All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] [RFC] Do the PIN check in SIMManager
Date: Wed, 23 Sep 2009 15:02:50 -0500	[thread overview]
Message-ID: <200909231502.51564.denkenz@gmail.com> (raw)
In-Reply-To: <fb249edb0909231347ha981387ge221b34f1e2e4839@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

Hi Andrew,

> Should we have a read-only property so clients know what the current
> state is?  Unfortunately this would be some 6 properties and 6 more

Actually more like 7.  However, right now we only really care about pin lock.  
We can theoretically optimize the query somewhat by looking at whether the 
CPIN is being asked for at startup.  If it is, the PIN is locked, and unlocked 
otherwise.  Then the LockPin / UnlockPin callbacks can update the state 
appropriately.

So the thought right now is to add LockedPins property, which will be a list 
of pins that are currently locked.  If nothing is locked, an empty list is 
returned.

For now I'm planning to implement LockedPins support for pin only, but the 
others will have to be queried eventually as well.

> commands on startup, for little gain.  I attached a diff to add plugin
> interface for this without dbus interface.  The other two changes are
> just clean-up.

Patches have been applied, thanks.

Regards,
-Denis

      reply	other threads:[~2009-09-23 20:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-05  7:25 [PATCH] [RFC] Do the PIN check in SIMManager Andrzej Zaborowski
2009-09-07  9:53 ` Santtu Lakkala
2009-09-08  2:41   ` Andrzej Zaborowski
2009-09-17 18:57     ` Andrzej Zaborowski
2009-09-22  5:12       ` Denis Kenzior
2009-09-23 20:47         ` andrzej zaborowski
2009-09-23 20:02           ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909231502.51564.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.