* [PATCH -next] netxen: build fix for INET=n
@ 2009-09-11 22:41 Randy Dunlap
2009-09-11 22:46 ` Dhananjay Phadke
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2009-09-11 22:41 UTC (permalink / raw)
To: netdev; +Cc: davem, Dhananjay Phadke
From: Randy Dunlap <randy.dunlap@oracle.com>
When CONFIG_INET is disabled, netxen has a build failure:
netxen_nic_main.c:(.text+0x118fd1): undefined reference to `netxen_config_indev_addr'
so make that function just an empty stub when CONFIG_INET=n.
(not "inline" since that conflicts with other declarations of it)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/net/netxen/netxen_nic_main.c | 4 ++++
1 file changed, 4 insertions(+)
--- linux-next-20090911.orig/drivers/net/netxen/netxen_nic_main.c
+++ linux-next-20090911/drivers/net/netxen/netxen_nic_main.c
@@ -2450,6 +2450,10 @@ static struct notifier_block netxen_netd
static struct notifier_block netxen_inetaddr_cb = {
.notifier_call = netxen_inetaddr_event,
};
+#else
+static void
+netxen_config_indev_addr(struct net_device *dev, unsigned long event)
+{ }
#endif
static struct pci_driver netxen_driver = {
---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] netxen: build fix for INET=n
2009-09-11 22:41 [PATCH -next] netxen: build fix for INET=n Randy Dunlap
@ 2009-09-11 22:46 ` Dhananjay Phadke
2009-09-11 22:52 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Dhananjay Phadke @ 2009-09-11 22:46 UTC (permalink / raw)
To: Randy Dunlap; +Cc: netdev, davem
grr .. I broke it again!
Thanks Randy for fixing.
Acked-by: Dhananjay Phadke <dhananjay@netxen.com>
Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> When CONFIG_INET is disabled, netxen has a build failure:
>
> netxen_nic_main.c:(.text+0x118fd1): undefined reference to `netxen_config_indev_addr'
>
> so make that function just an empty stub when CONFIG_INET=n.
> (not "inline" since that conflicts with other declarations of it)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/net/netxen/netxen_nic_main.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> --- linux-next-20090911.orig/drivers/net/netxen/netxen_nic_main.c
> +++ linux-next-20090911/drivers/net/netxen/netxen_nic_main.c
> @@ -2450,6 +2450,10 @@ static struct notifier_block netxen_netd
> static struct notifier_block netxen_inetaddr_cb = {
> .notifier_call = netxen_inetaddr_event,
> };
> +#else
> +static void
> +netxen_config_indev_addr(struct net_device *dev, unsigned long event)
> +{ }
> #endif
>
> static struct pci_driver netxen_driver = {
>
>
>
>
> ---
> ~Randy
> LPC 2009, Sept. 23-25, Portland, Oregon
> http://linuxplumbersconf.org/2009/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] netxen: build fix for INET=n
2009-09-11 22:46 ` Dhananjay Phadke
@ 2009-09-11 22:52 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-09-11 22:52 UTC (permalink / raw)
To: dhananjay.phadke; +Cc: randy.dunlap, netdev
From: Dhananjay Phadke <dhananjay.phadke@qlogic.com>
Date: Fri, 11 Sep 2009 15:46:29 -0700
> grr .. I broke it again!
>
> Thanks Randy for fixing.
Please don't top post, put your replies underneath the quoted
content so people read the context of what you're replying
to and then see your reply, not the other way around.
Thanks.
> Acked-by: Dhananjay Phadke <dhananjay@netxen.com>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-11 22:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-11 22:41 [PATCH -next] netxen: build fix for INET=n Randy Dunlap
2009-09-11 22:46 ` Dhananjay Phadke
2009-09-11 22:52 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.