Re: python-wpactrl

Re: python-wpactrl

[Howard Chu]

openembedded-devel-request@lists.openembedded.org wrote:

> Date: Tue, 15 Sep 2009 09:13:22 +0100
> From: Phil Blundell<philb@gnu.org>

> On Sun, 2009-09-13 at 18:59 -0700, Howard Chu wrote:
>> Here's a recipe file for the python-wpactrl module, which connects to
>> wpa_supplicant's control interface. It works for me...
>
> Thanks for the patch.
>
> Your bb file is named "python-wpactrl_1.0", which would suggest that
> this is for version 1.0 of the package.  But the SRC_URI seems to point
> to some random-looking svn revision.  Can you clarify what the
> versioning situation is with that?

I'll use the svn revision number. I used 1.0 because that's the version number 
present in the various files of the repository. It may take a while before I 
get to reposting this, have a lot of other things on my plate.

> The patch looks fine to me otherwise.

Thanks for the review.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Re: python-wpactrl

[Howard Chu]

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

> Date: Mon, 14 Sep 2009 13:46:35 +0200
> From: Koen Kooi<k.kooi@student.utwente.nl>

> Please use SRCREV to point to the revision and put it in PV as well so
> people can see which version they are installing.
>
> And please send it as a git-am'able patch so we can track author metadata.

I think this addresses your comments.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

[-- Attachment #2: 0001-Add-wpactrl-module.patch --]
[-- Type: text/x-diff, Size: 1014 bytes --]

From 89b27aff8cb95def72927604492bbf77990da403 Mon Sep 17 00:00:00 2001
From: Howard Chu <hyc@symas.com>
Date: Sun, 27 Sep 2009 12:43:40 -0700
Subject: [PATCH] Add wpactrl module


Signed-off-by: Howard Chu <hyc@symas.com>
---
 recipes/python/python-wpactrl_svn.bb |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
 create mode 100644 recipes/python/python-wpactrl_svn.bb

diff --git a/recipes/python/python-wpactrl_svn.bb b/recipes/python/python-wpactrl_svn.bb
new file mode 100644
index 0000000..e0e8a05
--- /dev/null
+++ b/recipes/python/python-wpactrl_svn.bb
@@ -0,0 +1,12 @@
+DESCRIPTION = "A Python extension for wpa_supplicant/hostapd control interface access"
+SECTION = "devel/python"
+LICENSE = "GPLv2"
+HOMEPAGE = "http://projects.otaku42.de/wiki/PythonWpaCtrl"
+
+inherit distutils
+
+SRCREV = "383"
+SRC_URI = "svn://svn.otaku42.de;module=python-wpactrl;proto=http"
+S = "${WORKDIR}/python-wpactrl/trunk"
+PV = "1.0.1+svnr${SRCREV}"
+
-- 
1.6.0.4

Re: python-wpactrl

[Phil Blundell]

On Sun, 2009-09-13 at 18:59 -0700, Howard Chu wrote:
> Here's a recipe file for the python-wpactrl module, which connects to 
> wpa_supplicant's control interface. It works for me...

Thanks for the patch.

Your bb file is named "python-wpactrl_1.0", which would suggest that
this is for version 1.0 of the package.  But the SRC_URI seems to point
to some random-looking svn revision.  Can you clarify what the
versioning situation is with that?

The patch looks fine to me otherwise.

p.

Re: python-wpactrl

[Koen Kooi]

On 14-09-09 03:59, Howard Chu wrote:
> Here's a recipe file for the python-wpactrl module, which connects to
> wpa_supplicant's control interface. It works for me...

A few comments:


> DESCRIPTION = "A Python extension for wpa_supplicant/hostapd control interface access"
> HOMEPAGE ="http://projects.otaku42.de/wiki/PythonWpaCtrl"
> SECTION = "devel/python"
> LICENSE = "GPLv2"
> PR = "r0"

That sets PR to its default value, so leave that out please.

> SRC_URI = "svn://svn.otaku42.de;module=python-wpactrl;proto=http;rev=383"

Please use SRCREV to point to the revision and put it in PV as well so 
people can see which version they are installing.

And please send it as a git-am'able patch so we can track author metadata.

regards,

Koen

python-wpactrl

[Howard Chu]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

Here's a recipe file for the python-wpactrl module, which connects to 
wpa_supplicant's control interface. It works for me...

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

[-- Attachment #2: python-wpactrl_1.0.bb --]
[-- Type: text/plain, Size: 343 bytes --]

DESCRIPTION = "A Python extension for wpa_supplicant/hostapd control interface access"
HOMEPAGE = "http://projects.otaku42.de/wiki/PythonWpaCtrl"
SECTION = "devel/python"
LICENSE = "GPLv2"
PR = "r0"

SRC_URI = "svn://svn.otaku42.de;module=python-wpactrl;proto=http;rev=383"

S = "${WORKDIR}/python-wpactrl/trunk"

inherit distutils