* [PATCH] swap : remove unused field of swapper_space
@ 2009-09-25 9:12 Huang Shijie
2009-09-25 11:11 ` Hugh Dickins
0 siblings, 1 reply; 3+ messages in thread
From: Huang Shijie @ 2009-09-25 9:12 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, Huang Shijie
There is no place to use the i_mmap_nonlinear of swapper_space, so
remove it.
Signed-off-by: Huang Shijie <shijie8@gmail.com>
---
mm/swap_state.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/mm/swap_state.c b/mm/swap_state.c
index 6d1daeb..be16a6b 100644
--- a/mm/swap_state.c
+++ b/mm/swap_state.c
@@ -43,7 +43,6 @@ struct address_space swapper_space = {
.page_tree = RADIX_TREE_INIT(GFP_ATOMIC|__GFP_NOWARN),
.tree_lock = __SPIN_LOCK_UNLOCKED(swapper_space.tree_lock),
.a_ops = &swap_aops,
- .i_mmap_nonlinear = LIST_HEAD_INIT(swapper_space.i_mmap_nonlinear),
.backing_dev_info = &swap_backing_dev_info,
};
--
1.6.0.6
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] swap : remove unused field of swapper_space
2009-09-25 9:12 [PATCH] swap : remove unused field of swapper_space Huang Shijie
@ 2009-09-25 11:11 ` Hugh Dickins
2009-09-27 1:36 ` Huang Shijie
0 siblings, 1 reply; 3+ messages in thread
From: Hugh Dickins @ 2009-09-25 11:11 UTC (permalink / raw)
To: Huang Shijie; +Cc: akpm, linux-mm
On Fri, 25 Sep 2009, Huang Shijie wrote:
> There is no place to use the i_mmap_nonlinear of swapper_space, so
> remove it.
>
> Signed-off-by: Huang Shijie <shijie8@gmail.com>
I say NAK, unless you're very sure:
see commit comment below when I added that line.
Hugh
> ---
> mm/swap_state.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/mm/swap_state.c b/mm/swap_state.c
> index 6d1daeb..be16a6b 100644
> --- a/mm/swap_state.c
> +++ b/mm/swap_state.c
> @@ -43,7 +43,6 @@ struct address_space swapper_space = {
> .page_tree = RADIX_TREE_INIT(GFP_ATOMIC|__GFP_NOWARN),
> .tree_lock = __SPIN_LOCK_UNLOCKED(swapper_space.tree_lock),
> .a_ops = &swap_aops,
> - .i_mmap_nonlinear = LIST_HEAD_INIT(swapper_space.i_mmap_nonlinear),
> .backing_dev_info = &swap_backing_dev_info,
> };
>
commit e11f2cc49856eabafed09cf30e190646f78b7207
Author: Hugh Dickins <hugh@veritas.com>
Date: Fri Jun 4 20:51:55 2004 -0700
[PATCH] mm: swapper_space.i_mmap_nonlinear
Initialize swapper_space.i_mmap_nonlinear, so mapping_mapped reports false on
it (as it used to do). Update comment on swapper_space, now more fields are
used than those initialized explicitly.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] swap : remove unused field of swapper_space
2009-09-25 11:11 ` Hugh Dickins
@ 2009-09-27 1:36 ` Huang Shijie
0 siblings, 0 replies; 3+ messages in thread
From: Huang Shijie @ 2009-09-27 1:36 UTC (permalink / raw)
To: Hugh Dickins; +Cc: akpm, linux-mm
Hugh Dickins a??e??:
> On Fri, 25 Sep 2009, Huang Shijie wrote:
>
>
>> There is no place to use the i_mmap_nonlinear of swapper_space, so
>> remove it.
>>
>> Signed-off-by: Huang Shijie <shijie8@gmail.com>
>>
>
> I say NAK, unless you're very sure:
> see commit comment below when I added that line.
>
> Hugh
>
>
>> ---
>> mm/swap_state.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/mm/swap_state.c b/mm/swap_state.c
>> index 6d1daeb..be16a6b 100644
>> --- a/mm/swap_state.c
>> +++ b/mm/swap_state.c
>> @@ -43,7 +43,6 @@ struct address_space swapper_space = {
>> .page_tree = RADIX_TREE_INIT(GFP_ATOMIC|__GFP_NOWARN),
>> .tree_lock = __SPIN_LOCK_UNLOCKED(swapper_space.tree_lock),
>> .a_ops = &swap_aops,
>> - .i_mmap_nonlinear = LIST_HEAD_INIT(swapper_space.i_mmap_nonlinear),
>> .backing_dev_info = &swap_backing_dev_info,
>> };
>>
>>
>
> commit e11f2cc49856eabafed09cf30e190646f78b7207
> Author: Hugh Dickins <hugh@veritas.com>
> Date: Fri Jun 4 20:51:55 2004 -0700
>
> [PATCH] mm: swapper_space.i_mmap_nonlinear
>
> Initialize swapper_space.i_mmap_nonlinear, so mapping_mapped reports false on
> it (as it used to do). Update comment on swapper_space, now more fields are
> used than those initialized explicitly.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
>
>
Yes ,you are right.
I didn't notice that there were other places calling mapping_mapped() in
non-x86 archs.
The result generated by the default "make cscope" fooled me.
thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-27 1:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-25 9:12 [PATCH] swap : remove unused field of swapper_space Huang Shijie
2009-09-25 11:11 ` Hugh Dickins
2009-09-27 1:36 ` Huang Shijie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.