Re: [PATCH] hw/remote: Add missing include

From: Jag Raman <jag.raman@oracle.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
	John Johnson <john.g.johnson@oracle.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Elena Ufimtseva <elena.ufimtseva@oracle.com>
Subject: Re: [PATCH] hw/remote: Add missing include
Date: Sat, 22 Jan 2022 02:52:49 +0000	[thread overview]
Message-ID: <4AC03C2C-FC1E-4FD1-84F1-EF6C56CCD1D2@oracle.com> (raw)
In-Reply-To: <20220122003345.84522-1-f4bug@amsat.org>


> On Jan 21, 2022, at 7:33 PM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> 
> Currently "qemu/error-report.h" is implicitly included, however
> if headers in include/ get refactored, we get:
> 
>  hw/remote/proxy-memory-listener.c: In function ‘proxy_memory_listener_commit’:
>  hw/remote/proxy-memory-listener.c:183:9: error: implicit declaration of function ‘error_report’; did you mean ‘error_report_err’? [-Werror=implicit-function-declaration]
>    183 |         error_report("Number of fds is more than %d", REMOTE_MAX_FDS);
>        |         ^~~~~~~~~~~~
>        |         error_report_err
> 
> Add the missing "qemu/error-report.h" header to avoid that.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Jagannathan Raman <jag.raman@oracle.com>

> ---
> hw/remote/proxy-memory-listener.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/hw/remote/proxy-memory-listener.c b/hw/remote/proxy-memory-listener.c
> index 882c9b4854..0e893f3189 100644
> --- a/hw/remote/proxy-memory-listener.c
> +++ b/hw/remote/proxy-memory-listener.c
> @@ -16,6 +16,7 @@
> #include "exec/cpu-common.h"
> #include "exec/ram_addr.h"
> #include "qapi/error.h"
> +#include "qemu/error-report.h"
> #include "hw/remote/mpqemu-link.h"
> #include "hw/remote/proxy-memory-listener.h"
> 
> -- 
> 2.34.1
>