* [PATCH] hw/remote: Add missing include
@ 2022-01-22 0:33 Philippe Mathieu-Daudé via
2022-01-22 2:52 ` Jag Raman
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-01-22 0:33 UTC (permalink / raw)
To: qemu-devel
Cc: John G Johnson, qemu-trivial, Elena Ufimtseva, Jagannathan Raman,
Philippe Mathieu-Daudé
Currently "qemu/error-report.h" is implicitly included, however
if headers in include/ get refactored, we get:
hw/remote/proxy-memory-listener.c: In function ‘proxy_memory_listener_commit’:
hw/remote/proxy-memory-listener.c:183:9: error: implicit declaration of function ‘error_report’; did you mean ‘error_report_err’? [-Werror=implicit-function-declaration]
183 | error_report("Number of fds is more than %d", REMOTE_MAX_FDS);
| ^~~~~~~~~~~~
| error_report_err
Add the missing "qemu/error-report.h" header to avoid that.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/remote/proxy-memory-listener.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/remote/proxy-memory-listener.c b/hw/remote/proxy-memory-listener.c
index 882c9b4854..0e893f3189 100644
--- a/hw/remote/proxy-memory-listener.c
+++ b/hw/remote/proxy-memory-listener.c
@@ -16,6 +16,7 @@
#include "exec/cpu-common.h"
#include "exec/ram_addr.h"
#include "qapi/error.h"
+#include "qemu/error-report.h"
#include "hw/remote/mpqemu-link.h"
#include "hw/remote/proxy-memory-listener.h"
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hw/remote: Add missing include
2022-01-22 0:33 [PATCH] hw/remote: Add missing include Philippe Mathieu-Daudé via
@ 2022-01-22 2:52 ` Jag Raman
0 siblings, 0 replies; 2+ messages in thread
From: Jag Raman @ 2022-01-22 2:52 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-trivial, John Johnson, qemu-devel, Elena Ufimtseva
> On Jan 21, 2022, at 7:33 PM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Currently "qemu/error-report.h" is implicitly included, however
> if headers in include/ get refactored, we get:
>
> hw/remote/proxy-memory-listener.c: In function ‘proxy_memory_listener_commit’:
> hw/remote/proxy-memory-listener.c:183:9: error: implicit declaration of function ‘error_report’; did you mean ‘error_report_err’? [-Werror=implicit-function-declaration]
> 183 | error_report("Number of fds is more than %d", REMOTE_MAX_FDS);
> | ^~~~~~~~~~~~
> | error_report_err
>
> Add the missing "qemu/error-report.h" header to avoid that.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Jagannathan Raman <jag.raman@oracle.com>
> ---
> hw/remote/proxy-memory-listener.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/remote/proxy-memory-listener.c b/hw/remote/proxy-memory-listener.c
> index 882c9b4854..0e893f3189 100644
> --- a/hw/remote/proxy-memory-listener.c
> +++ b/hw/remote/proxy-memory-listener.c
> @@ -16,6 +16,7 @@
> #include "exec/cpu-common.h"
> #include "exec/ram_addr.h"
> #include "qapi/error.h"
> +#include "qemu/error-report.h"
> #include "hw/remote/mpqemu-link.h"
> #include "hw/remote/proxy-memory-listener.h"
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-22 2:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-22 0:33 [PATCH] hw/remote: Add missing include Philippe Mathieu-Daudé via
2022-01-22 2:52 ` Jag Raman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.