* [PATCH] Bluetooth: hidp: Initialize list header of hidp sesson user
@ 2015-06-26 6:27 Tedd Ho-Jeong An
2015-06-26 7:06 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Tedd Ho-Jeong An @ 2015-06-26 6:27 UTC (permalink / raw)
To: BlueZ development; +Cc: Marcel Holtmann, Johan Hedberg, An, Tedd
From: Tedd Ho-Jeong An <tedd.an@intel.com>
When new hidp session is created, list header in l2cap_user is
not initialized and this causes list_empty() to fail in
l2cap_register_user() even if l2cap_user list is empty.
Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
---
net/bluetooth/hidp/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index 9070dfd..f1a117f 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -915,6 +915,7 @@ static int hidp_session_new(struct hidp_session **out, const bdaddr_t *bdaddr,
session->conn = l2cap_conn_get(conn);
session->user.probe = hidp_session_probe;
session->user.remove = hidp_session_remove;
+ INIT_LIST_HEAD(&session->user.list);
session->ctrl_sock = ctrl_sock;
session->intr_sock = intr_sock;
skb_queue_head_init(&session->ctrl_transmit);
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: hidp: Initialize list header of hidp sesson user
2015-06-26 6:27 [PATCH] Bluetooth: hidp: Initialize list header of hidp sesson user Tedd Ho-Jeong An
@ 2015-06-26 7:06 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2015-06-26 7:06 UTC (permalink / raw)
To: Tedd Ho-Jeong An; +Cc: BlueZ development, Johan Hedberg
Hi Tedd,
> When new hidp session is created, list header in l2cap_user is
> not initialized and this causes list_empty() to fail in
> l2cap_register_user() even if l2cap_user list is empty.
>
> Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
> ---
> net/bluetooth/hidp/core.c | 1 +
> 1 file changed, 1 insertion(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-26 7:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-26 6:27 [PATCH] Bluetooth: hidp: Initialize list header of hidp sesson user Tedd Ho-Jeong An
2015-06-26 7:06 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.