All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Xue, Ken" <Ken.Xue@amd.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "lenb@kernel.org" <lenb@kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Wu, Jeff" <Jeff.Wu@amd.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Andriy Shevchenko <andriy.shevchenko@intel.com>
Subject: RE: [PATCH] acpi:apd:add AMD ACPI2Platform device support for x86 system.
Date: Mon, 24 Nov 2014 01:02:30 +0000	[thread overview]
Message-ID: <4AC89B18A26BAB43B540DB1C94E2802C05A48D06@scybexdag03.amd.com> (raw)
In-Reply-To: <20864469.6Ozf1NSibZ@vostro.rjw.lan>


On Tuesday, November 18, 2014 01:58:11 PM Ken Xue wrote:
> This new feature is to interpret AMD specific ACPI device to platform 
> device such as I2C, UART found on AMD CZ and later chipsets. It is 
> based on example INTEL LPSS. Now, it can support AMD I2C & UART.
> 
> Signed-off-by: Ken Xue <Ken.Xue@amd.com>
> Signed-off-by: Jeff Wu <Jeff.Wu@amd.com>

Generally speaking, this seems to duplicate much code from acpi_lpss which should be re-used instead.  What about moving the code that will be common between acpi_lpss and the new driver into a new file (say acpi_soc.c)?

Also, you need to avoid automatic creation of platform devices when !X86_AMD_PLATFORM_DEVICE in analogy with what acpi_lpss does, or bad things will happen.

[ken] sounds fair enough.  Let me take action to merge drivers to acpi_soc.c ? or you have other plan?

[...]

WARNING: multiple messages have this Message-ID (diff)
From: "Xue, Ken" <Ken.Xue@amd.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "lenb@kernel.org" <lenb@kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Wu, Jeff" <Jeff.Wu@amd.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Andriy Shevchenko <andriy.shevchenko@intel.com>
Subject: RE: [PATCH] acpi:apd:add AMD ACPI2Platform device support for x86 system.
Date: Mon, 24 Nov 2014 01:02:30 +0000	[thread overview]
Message-ID: <4AC89B18A26BAB43B540DB1C94E2802C05A48D06@scybexdag03.amd.com> (raw)
In-Reply-To: <20864469.6Ozf1NSibZ@vostro.rjw.lan>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1008 bytes --]


On Tuesday, November 18, 2014 01:58:11 PM Ken Xue wrote:
> This new feature is to interpret AMD specific ACPI device to platform 
> device such as I2C, UART found on AMD CZ and later chipsets. It is 
> based on example INTEL LPSS. Now, it can support AMD I2C & UART.
> 
> Signed-off-by: Ken Xue <Ken.Xue@amd.com>
> Signed-off-by: Jeff Wu <Jeff.Wu@amd.com>

Generally speaking, this seems to duplicate much code from acpi_lpss which should be re-used instead.  What about moving the code that will be common between acpi_lpss and the new driver into a new file (say acpi_soc.c)?

Also, you need to avoid automatic creation of platform devices when !X86_AMD_PLATFORM_DEVICE in analogy with what acpi_lpss does, or bad things will happen.

[ken] sounds fair enough.  Let me take action to merge drivers to acpi_soc.c ? or you have other plan?

[...]
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2014-11-24  1:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18  5:58 [PATCH] acpi:apd:add AMD ACPI2Platform device support for x86 system Ken Xue
2014-11-18  5:58 ` Ken Xue
2014-11-21  5:15 ` Xue, Ken
2014-11-21 14:58   ` Rafael J. Wysocki
2014-11-24  1:15 ` Rafael J. Wysocki
2014-11-24  1:02   ` Xue, Ken [this message]
2014-11-24  1:02     ` Xue, Ken
2014-11-24  1:47     ` Rafael J. Wysocki
2014-11-26 10:31       ` Ken Xue
2014-11-26 10:31         ` Ken Xue
2014-11-27 11:46         ` Mika Westerberg
2014-11-27 11:46           ` Mika Westerberg
2014-11-27 17:06           ` Rafael J. Wysocki
2014-11-27 16:48             ` Mika Westerberg
2014-11-28  1:33           ` Ken Xue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC89B18A26BAB43B540DB1C94E2802C05A48D06@scybexdag03.amd.com \
    --to=ken.xue@amd.com \
    --cc=Jeff.Wu@amd.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.