[lm-sensors] [PATCH] coretemp: Add Lynnfield CPU

[lm-sensors] [PATCH] coretemp: Add Lynnfield CPU

[Huaxu Wan]

Add Lynnfield processor support. Lynnfield is a quad-core Nehalem based microprocessor for Desktop market, which is introduced in September 2009.

Signed-off-by: Huaxu Wan <huaxu.wan@linux.intel.com>
Signed-off-by: Kent Liu <kent.liu@linux.intel.com>
---
 drivers/hwmon/coretemp.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index 93c1722..a9a21dc 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -413,11 +413,11 @@ static int __init coretemp_init(void)
        for_each_online_cpu(i) {
                struct cpuinfo_x86 *c = &cpu_data(i);

-               /* check if family 6, models 0xe, 0xf, 0x16, 0x17, 0x1A */
+               /* check if family 6, models 0xe, 0xf, 0x16, 0x17, 0x1A, 0x1E */
                if ((c->cpuid_level < 0) || (c->x86 != 0x6) ||
                    !((c->x86_model = 0xe) || (c->x86_model = 0xf) ||
                        (c->x86_model = 0x16) || (c->x86_model = 0x17) ||
-                       (c->x86_model = 0x1A))) {
+                       (c->x86_model = 0x1A) || (c->x86_model = 0x1E))) {

                        /* supported CPU not found, but report the unknown
                           family 6 CPU */
--

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] coretemp: Add Lynnfield CPU

[Rudolf Marek]

Hi,

Looks good. However I would like to see the Documentation/hwmon/coretemp updated 
too.

Maybe Intel can overtake the driver maintainership because I'm quite struggling 
to get any info from Intel. Second reason is lack of free time.

Thank you,

Rudolf

Huaxu Wan napsal(a):
> Add Lynnfield processor support. Lynnfield is a quad-core Nehalem based microprocessor for Desktop market, which is introduced in September 2009.
> 
> Signed-off-by: Huaxu Wan <huaxu.wan@linux.intel.com>
> Signed-off-by: Kent Liu <kent.liu@linux.intel.com>
> ---
>  drivers/hwmon/coretemp.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index 93c1722..a9a21dc 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -413,11 +413,11 @@ static int __init coretemp_init(void)
>         for_each_online_cpu(i) {
>                 struct cpuinfo_x86 *c = &cpu_data(i);
> 
> -               /* check if family 6, models 0xe, 0xf, 0x16, 0x17, 0x1A */
> +               /* check if family 6, models 0xe, 0xf, 0x16, 0x17, 0x1A, 0x1E */
>                 if ((c->cpuid_level < 0) || (c->x86 != 0x6) ||
>                     !((c->x86_model = 0xe) || (c->x86_model = 0xf) ||
>                         (c->x86_model = 0x16) || (c->x86_model = 0x17) ||
> -                       (c->x86_model = 0x1A))) {
> +                       (c->x86_model = 0x1A) || (c->x86_model = 0x1E))) {
> 
>                         /* supported CPU not found, but report the unknown
>                            family 6 CPU */
> --

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] coretemp: Add Lynnfield CPU

[Kent Liu]

On Wed, Sep 23, 2009 at 12:00:08PM +0200, Jean Delvare wrote:
> On Wed, 16 Sep 2009 23:24:51 +0200, Rudolf Marek wrote:
> > Looks good. However I would like to see the Documentation/hwmon/coretemp updated 
> > too.
> 
> I'll take care of that.
Thanks Jean.
> 
> > Maybe Intel can overtake the driver maintainership because I'm quite struggling 
> > to get any info from Intel. Second reason is lack of free time.
> 
> Huaxu, Kent, can you please comment on this?
Hmmm... I am looking for an Intel internal support for this maintainership, since I 
usually not receive such documents either. I would like to take once this can be 
resolved.
> 
> > Huaxu Wan napsal(a):
> > > Add Lynnfield processor support. Lynnfield is a quad-core Nehalem based microprocessor for Desktop market, which is introduced in September 2009.
> 
> What are the TjMax and TTarget temperatures for these CPUs?
So far I do not find them in datasheet. Let me check what I can find more.

Thanks,
Kent

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] coretemp: Add Lynnfield CPU

[Kent Liu]

Hello Rudolf

Yes. I think Huaxu and I can take this, even though I am still on the way 
to acquire enough documents from hardware team. As I have a lot of processors
on hand to test, maybe it's better to gain more coverage in coretemp driver.

Please let me know what I need to do regarding to take the maintainership. 
We are not experienced in doing so.

Thanks,
Kent
On Wed, Sep 16, 2009 at 11:24:51PM +0200, Rudolf Marek wrote:
> Hi,
>
> Looks good. However I would like to see the Documentation/hwmon/coretemp 
> updated too.
>
> Maybe Intel can overtake the driver maintainership because I'm quite 
> struggling to get any info from Intel. Second reason is lack of free 
> time.
>
> Thank you,
>
> Rudolf
>
> Huaxu Wan napsal(a):
>> Add Lynnfield processor support. Lynnfield is a quad-core Nehalem based microprocessor for Desktop market, which is introduced in September 2009.
>>
>> Signed-off-by: Huaxu Wan <huaxu.wan@linux.intel.com>
>> Signed-off-by: Kent Liu <kent.liu@linux.intel.com>
>> ---
>>  drivers/hwmon/coretemp.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
>> index 93c1722..a9a21dc 100644
>> --- a/drivers/hwmon/coretemp.c
>> +++ b/drivers/hwmon/coretemp.c
>> @@ -413,11 +413,11 @@ static int __init coretemp_init(void)
>>         for_each_online_cpu(i) {
>>                 struct cpuinfo_x86 *c = &cpu_data(i);
>>
>> -               /* check if family 6, models 0xe, 0xf, 0x16, 0x17, 0x1A */
>> +               /* check if family 6, models 0xe, 0xf, 0x16, 0x17, 0x1A, 0x1E */
>>                 if ((c->cpuid_level < 0) || (c->x86 != 0x6) ||
>>                     !((c->x86_model = 0xe) || (c->x86_model = 0xf) ||
>>                         (c->x86_model = 0x16) || (c->x86_model = 0x17) ||
>> -                       (c->x86_model = 0x1A))) {
>> +                       (c->x86_model = 0x1A) || (c->x86_model = 0x1E))) {
>>
>>                         /* supported CPU not found, but report the unknown
>>                            family 6 CPU */
>> --
>

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] coretemp: Add Lynnfield CPU

[Jean Delvare]

Hi Kent,

On Sat, 10 Oct 2009 14:01:18 +0800, Kent Liu wrote:
> Yes. I think Huaxu and I can take this, even though I am still on the way 
> to acquire enough documents from hardware team. As I have a lot of processors
> on hand to test, maybe it's better to gain more coverage in coretemp driver.
> 
> Please let me know what I need to do regarding to take the maintainership.
> We are not experienced in doing so.

Simply send us a patch updating the "CORETEMP HARDWARE MONITORING
DRIVER" entry in file MAINTAINERS. Set the M: field to the new
maintainer (format is "name <address>"). You can have several M: fields
if there will be several maintainers. And that's all :)

Once we receive the patch, I'll pick it and push it upstream in a
timely manner.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] coretemp: Add Lynnfield CPU

[Rudolf Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Kent,

> Please let me know what I need to do regarding to take the maintainership. 
> We are not experienced in doing so.

Yes thats it what Jean said to you. Many thanks for this!

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrTl88ACgkQ3J9wPJqZRNV2hwCgopnemKT4J5dBmiir3Q8qjGhu
vP0AniGrMsD+aZRAzcubADm4wINHLT23
=Vukl
-----END PGP SIGNATURE-----

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors