Re: [SPDK] nasm on test machines

* Re: [SPDK] nasm on test machines
@ 2018-08-20 15:08 Harris, James R
  0 siblings, 0 replies; 13+ messages in thread
From: Harris, James R @ 2018-08-20 15:08 UTC (permalink / raw)
  To: spdk

[-- Attachment #1: Type: text/plain, Size: 6034 bytes --]

Thanks Paul.  I’d still like a config-time check to make sure the installed version meets the ipsec library’s needs.

-Jim

On 8/20/18, 6:44 AM, "SPDK on behalf of Luse, Paul E" <spdk-bounces(a)lists.01.org on behalf of paul.e.luse(a)intel.com> wrote:

    Yup, just confirmed he added it Jun 13, thanks Daniel if you're still out there!

    :)
    Paul

    -----Original Message-----
    From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of Luse, Paul E
    Sent: Monday, August 20, 2018 6:43 AM
    To: Storage Performance Development Kit <spdk(a)lists.01.org>
    Subject: Re: [SPDK] nasm on test machines

    Smart ass :) I thought the package installers could specify min version- must be thinking of another dist.  Actually I just looked and nasm is already in pkgdep.sh but I didn't add it.  Maybe Daniel did before he left?

    -Paul

    -----Original Message-----
    From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of Harris, James R
    Sent: Monday, August 20, 2018 6:33 AM
    To: Storage Performance Development Kit <spdk(a)lists.01.org>
    Subject: Re: [SPDK] nasm on test machines

    But users won't have your email. :-)

    Putting it into pkgdep.sh doesn't help if it installs a version that's too old.  I think docs need to spell this out and provide options for the user to get the version of nasm needed for their distro/version. We also talked about adding a config-time check to see if the install nasm supports the instructions needed for the IPSec lib.

    Jim

    Sent from my iPhone

    > On Aug 20, 2018, at 6:15 AM, Luse, Paul E <paul.e.luse(a)intel.com> wrote:
    > 
    > I supplied the version requirement in this email (below)
    > 
    > -from my iPhone 
    > 
    >> On Aug 20, 2018, at 6:10 AM, Harris, James R <james.r.harris(a)intel.com> wrote:
    >> 
    >> Adding nasm to pkgdep.sh may not be sufficient.  It needs to be a new enough version which supports instructions used by IPSec library.
    >> 
    >> Jim
    >> 
    >> Sent from my iPhone
    >> 
    >>> On Aug 20, 2018, at 5:50 AM, Luse, Paul E <paul.e.luse(a)intel.com> wrote:
    >>> 
    >>> Yeah, probably so..  Will see what others think.  I have another patch out that also updated pkgdep to install the ipsec lib since it takes root (ugh).  https://review.gerrithub.io/c/spdk/intel-ipsec-mb/+/422747  Once that lands it will need to be run on the test machines also.  See what Jim, Ben & the others say about adding name to the script.
    >>> 
    >>> Thanks Karol!
    >>> 
    >>> -Paul
    >>> 
    >>> -----Original Message-----
    >>> From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of Latecki, Karol
    >>> Sent: Monday, August 20, 2018 4:05 AM
    >>> To: Storage Performance Development Kit <spdk(a)lists.01.org>
    >>> Subject: Re: [SPDK] nasm on test machines
    >>> 
    >>> Hi Paul!
    >>> Installed on machines on my side.
    >>> I think you should add it to pkgdep.sh if it's needed for any of ./configure options.
    >>> 
    >>> Karol
    >>> 
    >>> -----Original Message-----
    >>> From: SPDK [mailto:spdk-bounces(a)lists.01.org] On Behalf Of Luse, Paul E
    >>> Sent: Saturday, August 18, 2018 6:37 PM
    >>> To: Storage Performance Development Kit <spdk(a)lists.01.org>
    >>> Subject: [SPDK] nasm on test machines
    >>> 
    >>> Seth/Karol,
    >>> 
    >>> Can we get nasm (see below) installed on all the test machines (& VMs)?  Right now it's not in pkgdep.sh but I'm wondering if it should be now... see https://review.gerrithub.io/c/spdk/spdk/+/422746
    >>> 
    >>> FYI this if for crypto (well for ipsesc lib which is needed for crypto)
    >>> 
    >>> Thx
    >>> Paul
    >>> 
    >>> NASM version 2.12.02 or newer
    >>> 
    >>> _______________________________________________
    >>> SPDK mailing list
    >>> SPDK(a)lists.01.org
    >>> https://lists.01.org/mailman/listinfo/spdk
    >>> --------------------------------------------------------------------
    >>> 
    >>> Intel Technology Poland sp. z o.o.
    >>> ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
    >>> 
    >>> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
    >>> This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
    >>> 
    >>> _______________________________________________
    >>> SPDK mailing list
    >>> SPDK(a)lists.01.org
    >>> https://lists.01.org/mailman/listinfo/spdk
    >>> _______________________________________________
    >>> SPDK mailing list
    >>> SPDK(a)lists.01.org
    >>> https://lists.01.org/mailman/listinfo/spdk
    >> _______________________________________________
    >> SPDK mailing list
    >> SPDK(a)lists.01.org
    >> https://lists.01.org/mailman/listinfo/spdk
    > _______________________________________________
    > SPDK mailing list
    > SPDK(a)lists.01.org
    > https://lists.01.org/mailman/listinfo/spdk
    _______________________________________________
    SPDK mailing list
    SPDK(a)lists.01.org
    https://lists.01.org/mailman/listinfo/spdk
    _______________________________________________
    SPDK mailing list
    SPDK(a)lists.01.org
    https://lists.01.org/mailman/listinfo/spdk
    _______________________________________________
    SPDK mailing list
    SPDK(a)lists.01.org
    https://lists.01.org/mailman/listinfo/spdk

^ permalink raw reply	[flat|nested] 13+ messages in thread