From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 02/10] USB add macros for debugging usb device setup.
Date: Sat, 31 Oct 2009 21:00:09 -0500 [thread overview]
Message-ID: <4AECEBA9.2000903@windriver.com> (raw)
In-Reply-To: <200910311746.44937.vapier@gentoo.org>
Mike Frysinger wrote:
> On Saturday 31 October 2009 13:37:39 Tom Rix wrote:
>> +#ifdef DEBUG
>> +static inline void print_device_descriptor(struct usb_device_descriptor
>> *d) +{
>> + serial_printf("usb device descriptor \n");
>
> do you really need serial_printf() ? what's wrong with debug() ? then you
> dont even really need "#ifdef DEBUG" around all the functions ...
> -mike
The explicit serial_printf is done because this patch set changes the
stdin and stdout for serial to usbtty.
When you use printf to debug printf, you regress into a bad state.
Tom
next prev parent reply other threads:[~2009-11-01 2:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 17:37 [U-Boot] v3 OMAP USB Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 01/10] USB Consolidate descriptor definitions Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 02/10] USB add macros for debugging usb device setup Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 03/10] TWL4030 Add usb PHY support Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 04/10] OMAP3 Add usb device support Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 05/10] OMAP3 zoom1 Add usbtty configuration Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 06/10] OMAP3 beagle " Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 07/10] USBTTY make some function declarations easier to use Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 08/10] OMAP3 zoom2 Use usbtty if the debug board is not connected Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 09/10] OMAP3 USB Initialize twl4030 only if required Tom Rix
2009-10-31 17:37 ` [U-Boot] [PATCH 10/10] omap3evm: musb: add USB config Tom Rix
2009-10-31 21:49 ` [U-Boot] [PATCH 09/10] OMAP3 USB Initialize twl4030 only if required Mike Frysinger
2009-11-01 2:09 ` Tom
2009-11-01 13:35 ` Mike Frysinger
2009-10-31 21:47 ` [U-Boot] [PATCH 08/10] OMAP3 zoom2 Use usbtty if the debug board is not connected Mike Frysinger
2009-11-01 2:03 ` Tom
2009-11-01 13:33 ` Mike Frysinger
2009-11-01 14:14 ` Tom
2009-11-01 14:55 ` Mike Frysinger
2009-10-31 21:46 ` [U-Boot] [PATCH 02/10] USB add macros for debugging usb device setup Mike Frysinger
2009-11-01 2:00 ` Tom [this message]
2009-11-01 13:32 ` Mike Frysinger
2009-11-01 14:02 ` Tom
2009-11-01 14:09 ` Mike Frysinger
2009-11-01 14:29 ` Tom
2009-11-04 15:06 ` [U-Boot] v3 OMAP USB Tom
2009-11-04 15:28 ` Mike Frysinger
2009-11-04 20:21 ` Remy Bohmer
2009-11-05 3:38 ` Gupta, Ajay Kumar
2009-11-05 9:42 ` Remy Bohmer
2009-11-05 13:44 ` Tom
2009-11-05 15:42 ` Remy Bohmer
2009-11-06 18:01 ` [U-Boot] AT91 runnable out of RAM ? Tom Rix
2009-11-07 7:50 ` Remy Bohmer
2009-11-07 12:13 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AECEBA9.2000903@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.