* [PATCH] ioemu: fix drive name parsing
@ 2009-11-04 7:52 Yang, Xiaowei
2009-11-04 17:12 ` Ian Jackson
0 siblings, 1 reply; 4+ messages in thread
From: Yang, Xiaowei @ 2009-11-04 7:52 UTC (permalink / raw)
To: xen-devel
In xenstore_parse_domain_config(), 'any_hdN' is overridden by local version
accidentally.
diff --git a/xenstore.c b/xenstore.c
index b5a791e..8ac478b 100644
--- a/xenstore.c
+++ b/xenstore.c
@@ -357,7 +357,7 @@ void xenstore_parse_domain_config(int hvm_domid)
char *buf = NULL;
char *fpath = NULL, *bpath = NULL,
*dev = NULL, *params = NULL, *drv = NULL;
- int i, any_hdN = 0, ret;
+ int i, ret;
unsigned int len, num, hd_index, pci_devid = 0;
BlockDriverState *bs;
BlockDriver *format;
Signed-off-by: Yang Xiaowei <xiaowei.yang@intel.com>
Thanks,
Xiaowei
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ioemu: fix drive name parsing
2009-11-04 7:52 [PATCH] ioemu: fix drive name parsing Yang, Xiaowei
@ 2009-11-04 17:12 ` Ian Jackson
0 siblings, 0 replies; 4+ messages in thread
From: Ian Jackson @ 2009-11-04 17:12 UTC (permalink / raw)
To: xen-devel
Yang, Xiaowei writes ("[Xen-devel] [PATCH] ioemu: fix drive name parsing"):
> In xenstore_parse_domain_config(), 'any_hdN' is overridden by local version
> accidentally.
Thanks for spotting this. You're right that it's a bug. I've applied
your patch (although really I think this whole area is pretty grotty
and could do with substantial rework).
Two comments though about the formatting of your patch:
* It didn't apply cleanly because it had different whitespace to
that in the actual code. Your mailer must have done something to
it I think. Best practice seems to be (if you can't make your
mailer reliably not mangle the body of the message) to provide each
patch _both_ as an attachment (for application) _and_ by including
it in the body (for readable review).
* You forgot the Signed-off-By line, by which you would certify that
the code copyright and so forth status was appropriate (according
to the Developer's Certificate of Origin). I applied your patch
anyway because it's a one-line change (which most authorities think
makes it too small for copyright to apply) but you should make sure
to appropriately certify your code in future.
Thanks,
Ian.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] ioemu: fix drive name parsing
2009-11-05 10:08 ` Yang, Xiaowei
@ 2009-11-05 11:51 ` Ian Jackson
0 siblings, 0 replies; 4+ messages in thread
From: Ian Jackson @ 2009-11-05 11:51 UTC (permalink / raw)
To: Yang, Xiaowei; +Cc: xen-devel, Ian Jackson
Yang, Xiaowei writes ("RE: [Xen-devel][PATCH] ioemu: fix drive name parsing"):
> I added the signed-off-by line at the bottom!:)
So you did, sorry!
Ian.
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] ioemu: fix drive name parsing
[not found] <4AF27686.4020100@intel.com>
@ 2009-11-05 10:08 ` Yang, Xiaowei
2009-11-05 11:51 ` Ian Jackson
0 siblings, 1 reply; 4+ messages in thread
From: Yang, Xiaowei @ 2009-11-05 10:08 UTC (permalink / raw)
To: Ian Jackson, xen-devel
> Yang, Xiaowei writes ("[Xen-devel] [PATCH] ioemu: fix drive name parsing"):
> > In xenstore_parse_domain_config(), 'any_hdN' is overridden by local version
> > accidentally.
>
> Thanks for spotting this. You're right that it's a bug. I've applied
> your patch (although really I think this whole area is pretty grotty
> and could do with substantial rework).
>
> Two comments though about the formatting of your patch:
>
> * It didn't apply cleanly because it had different whitespace to
> that in the actual code. Your mailer must have done something to
There must be something wrong when I did the paste.
> it I think. Best practice seems to be (if you can't make your
> mailer reliably not mangle the body of the message) to provide each
> patch _both_ as an attachment (for application) _and_ by including
> it in the body (for readable review).
Thanks for the advice. I'll attach the patch also next time.
>
> * You forgot the Signed-off-By line, by which you would certify that
I added the signed-off-by line at the bottom!:)
Thanks,
xiaowei
> the code copyright and so forth status was appropriate (according
> to the Developer's Certificate of Origin). I applied your patch
> anyway because it's a one-line change (which most authorities think
> makes it too small for copyright to apply) but you should make sure
> to appropriately certify your code in future.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-11-05 11:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-04 7:52 [PATCH] ioemu: fix drive name parsing Yang, Xiaowei
2009-11-04 17:12 ` Ian Jackson
[not found] <4AF27686.4020100@intel.com>
2009-11-05 10:08 ` Yang, Xiaowei
2009-11-05 11:51 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.