* [LTP] [PATCH] Fix build failure in cgroup_fj testcase
@ 2009-11-06 1:35 Shi Weihua
2009-11-09 17:39 ` Subrata Modak
0 siblings, 1 reply; 2+ messages in thread
From: Shi Weihua @ 2009-11-06 1:35 UTC (permalink / raw)
To: ltp-list
The following build failure occured on my x86 box.
-------------------------------------------------------
# uname -a
Linux F8-i386 2.6.32-rc5-tipshiwh+ #3 SMP Wed Oct 21 15:14:54 EDT 2009 i686 i686 i386 GNU/Linux
# cat /etc/issue
Fedora release 8 (Werewolf)
Kernel \r on an \m
gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -I/home/shiwh/ltp-full-20091031/testcases/kernel/include -I/home/shiwh/ltp-full-20091031/testcases/kernel/controllers/cgroup_fj/../libcontrollers -Wall -O2 -Wextra -I../../../../include -I../../../../include -L/home/shiwh/ltp-full-20091031/testcases/kernel/controllers/cgroup_fj/../libcontrollers -L../../../../lib cgroup_fj_proc.c -lltp -lcontrollers -o cgroup_fj_proc
/usr/bin/ld: cannot find -lcontrollers
collect2: ld returned 1 exit status
make[4]: *** [cgroup_fj_proc] Error 1
make[4]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases/kernel/controllers/cgroup_fj'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases/kernel/controllers'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases/kernel'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases'
make: *** [testcases-all] Error 2
-------------------------------------------------------
But the case "cgroup_fj" does not need "-lcontrollers" when building.
So in my patch, i deleted "-lcontrollers" in testcases/kernel/controllers/Makefile.inc
and added it to testcases/kernel/controllers/memctl/Makefile because the case "memctl"
need it.
All other cases in testcases/kernel/controllers/ build well too when my patch merged.
Signed-off-by: Shi Weihua <shiwh@cn.fujitsu.com>
---
diff -urpN ltp-full-20091031.orig/testcases/kernel/controllers/Makefile.inc ltp-full-20091031/testcases/kernel/controllers/Makefile.inc
--- ltp-full-20091031.orig/testcases/kernel/controllers/Makefile.inc 2009-11-02 04:07:13.000000000 -0500
+++ ltp-full-20091031/testcases/kernel/controllers/Makefile.inc 2009-11-05 08:54:06.000000000 -0500
@@ -39,8 +39,6 @@ CPPFLAGS += -I$(abs_srcdir)/../$(LIBDIR
LDFLAGS += -L$(abs_builddir)/../$(LIBDIR)
-LDLIBS += -lcontrollers
-
INSTALL_TARGETS ?= *.sh
# vim: syntax=make
diff -urpN ltp-full-20091031.orig/testcases/kernel/controllers/memctl/Makefile ltp-full-20091031/testcases/kernel/controllers/memctl/Makefile
--- ltp-full-20091031.orig/testcases/kernel/controllers/memctl/Makefile 2009-11-02 04:07:14.000000000 -0500
+++ ltp-full-20091031/testcases/kernel/controllers/memctl/Makefile 2009-11-06 04:13:49.000000000 -0500
@@ -27,4 +27,6 @@ include $(abs_srcdir)/../Makefile.inc
INSTALL_TARGETS := *.sh
+LDLIBS += -lcontrollers
+
include $(top_srcdir)/include/mk/generic_leaf_target.mk
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [LTP] [PATCH] Fix build failure in cgroup_fj testcase
2009-11-06 1:35 [LTP] [PATCH] Fix build failure in cgroup_fj testcase Shi Weihua
@ 2009-11-09 17:39 ` Subrata Modak
0 siblings, 0 replies; 2+ messages in thread
From: Subrata Modak @ 2009-11-09 17:39 UTC (permalink / raw)
To: Shi Weihua; +Cc: ltp-list
On Fri, 2009-11-06 at 09:35 +0800, Shi Weihua wrote:
> The following build failure occured on my x86 box.
> -------------------------------------------------------
> # uname -a
> Linux F8-i386 2.6.32-rc5-tipshiwh+ #3 SMP Wed Oct 21 15:14:54 EDT 2009 i686 i686 i386 GNU/Linux
> # cat /etc/issue
> Fedora release 8 (Werewolf)
> Kernel \r on an \m
>
> gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -I/home/shiwh/ltp-full-20091031/testcases/kernel/include -I/home/shiwh/ltp-full-20091031/testcases/kernel/controllers/cgroup_fj/../libcontrollers -Wall -O2 -Wextra -I../../../../include -I../../../../include -L/home/shiwh/ltp-full-20091031/testcases/kernel/controllers/cgroup_fj/../libcontrollers -L../../../../lib cgroup_fj_proc.c -lltp -lcontrollers -o cgroup_fj_proc
> /usr/bin/ld: cannot find -lcontrollers
> collect2: ld returned 1 exit status
> make[4]: *** [cgroup_fj_proc] Error 1
> make[4]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases/kernel/controllers/cgroup_fj'
> make[3]: *** [all] Error 2
> make[3]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases/kernel/controllers'
> make[2]: *** [all] Error 2
> make[2]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases/kernel'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases'
> make: *** [testcases-all] Error 2
> -------------------------------------------------------
>
> But the case "cgroup_fj" does not need "-lcontrollers" when building.
> So in my patch, i deleted "-lcontrollers" in testcases/kernel/controllers/Makefile.inc
> and added it to testcases/kernel/controllers/memctl/Makefile because the case "memctl"
> need it.
> All other cases in testcases/kernel/controllers/ build well too when my patch merged.
>
> Signed-off-by: Shi Weihua <shiwh@cn.fujitsu.com>
Thanks.
Regards--
Subrata
> ---
> diff -urpN ltp-full-20091031.orig/testcases/kernel/controllers/Makefile.inc ltp-full-20091031/testcases/kernel/controllers/Makefile.inc
> --- ltp-full-20091031.orig/testcases/kernel/controllers/Makefile.inc 2009-11-02 04:07:13.000000000 -0500
> +++ ltp-full-20091031/testcases/kernel/controllers/Makefile.inc 2009-11-05 08:54:06.000000000 -0500
> @@ -39,8 +39,6 @@ CPPFLAGS += -I$(abs_srcdir)/../$(LIBDIR
>
> LDFLAGS += -L$(abs_builddir)/../$(LIBDIR)
>
> -LDLIBS += -lcontrollers
> -
> INSTALL_TARGETS ?= *.sh
>
> # vim: syntax=make
> diff -urpN ltp-full-20091031.orig/testcases/kernel/controllers/memctl/Makefile ltp-full-20091031/testcases/kernel/controllers/memctl/Makefile
> --- ltp-full-20091031.orig/testcases/kernel/controllers/memctl/Makefile 2009-11-02 04:07:14.000000000 -0500
> +++ ltp-full-20091031/testcases/kernel/controllers/memctl/Makefile 2009-11-06 04:13:49.000000000 -0500
> @@ -27,4 +27,6 @@ include $(abs_srcdir)/../Makefile.inc
>
> INSTALL_TARGETS := *.sh
>
> +LDLIBS += -lcontrollers
> +
> include $(top_srcdir)/include/mk/generic_leaf_target.mk
>
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> trial. Simplify your report design, integration and deployment - and focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now. http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-09 17:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-06 1:35 [LTP] [PATCH] Fix build failure in cgroup_fj testcase Shi Weihua
2009-11-09 17:39 ` Subrata Modak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.