sparse noise due to patch "net: fix kmemcheck annotations"

sparse noise due to patch "net: fix kmemcheck annotations"

[Stefan Richter]

Hi Eric,

with above mentioned patch, committed as
14d18a81b5171d4433e41129619c75748b4f4d26, you changed

struct sk_buff {
	...
	__be16 protocol;
	...
}
to
	__be16 protocol:16;

This introduces the following warning from sparse:

include/linux/skbuff.h:357:41: error: invalid bitfield specifier for
type restricted __be16.

So, one checker satisfied, another disturbed?  Any idea how to get this
sparse-clean again?
-- 
Stefan Richter
-=====-==--= =-== -=-==
http://arcgraph.de/sr/

Re: sparse noise due to patch "net: fix kmemcheck annotations"

[Eric Dumazet]

Stefan Richter a écrit :
> Hi Eric,
> 
> with above mentioned patch, committed as
> 14d18a81b5171d4433e41129619c75748b4f4d26, you changed
> 
> struct sk_buff {
> 	...
> 	__be16 protocol;
> 	...
> }
> to
> 	__be16 protocol:16;
> 
> This introduces the following warning from sparse:
> 
> include/linux/skbuff.h:357:41: error: invalid bitfield specifier for
> type restricted __be16.
> 
> So, one checker satisfied, another disturbed?  Any idea how to get this
> sparse-clean again?

No problem here... how do you get this error, and what is your sparse version ?

Re: sparse noise due to patch "net: fix kmemcheck annotations"

[Stefan Richter]

Eric Dumazet wrote:
> Stefan Richter a écrit :
>> include/linux/skbuff.h:357:41: error: invalid bitfield specifier for
>> type restricted __be16.
...
> No problem here... how do you get this error, and what is your sparse version ?

It's sparse 0.4.2.
The note is only logged with 'make ... CF="-D__CHECK_ENDIAN__"'.

I guess sparse could be taught to ignore :_ suffixes if the suffix
covers the whole width of the type...  unless there is something that
could be improved in kmemcheck.
-- 
Stefan Richter
-=====-==--= =-== -=-==
http://arcgraph.de/sr/