app launchers should NOT modify /proc/sys/vm

app launchers should NOT modify /proc/sys/vm

[Sebastian Spaeth]

[-- Attachment #1.1: Type: text/plain, Size: 943 bytes --]

Currently, the navit (routing app) launcher script modifies
/proc/sys/vm/overcommit_memory without ever setting it back. This change
should -if at all- should only be done with serious evaluation on the
respective devices IMHO. I don't want to introduce random OOM process
killings because apps start using the RAM the kernel has promised to them.

Do I get the OK to remove the relevant lines? I will follow up on this
mail with a patch that you can ACK.

spaetz

Commit introducing this:
http://cgit.openembedded.net/cgit.cgi/openembedded/commit/?id=742fb4ae71e6a7e655385086ba9edebbf00b6ebd

author	Matthias Hentges <oe@hentges.net>
committer	Matthias Hentges <oe@hentges.net>	2008-01-05
commit	742fb4ae71e6a7e655385086ba9edebbf00b6ebd
--- a/dev/null
+++ b/packages/navit/files/navit.launcher
...
+ if test "$USER" = "root"
+ then
+ echo "Enabling low-mem workaround..."
+ echo 1 > /proc/sys/vm/overcommit_memory



[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 261 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 268 bytes --]

app launchers should NOT modify /proc/sys/vm

[Sebastian Spaeth]

P.S. Sorry if this comes through twice. Dreamhost mail server was having
issues...

Currently, the navit (routing app) launcher script modifies
/proc/sys/vm/overcommit_memory without ever setting it back. This change
should -if at all- should only be done with serious evaluation on the
respective devices IMHO. I don't want to introduce random OOM process
killings for everyone because apps start using the RAM the kernel has
promised to them.

Do I get the OK to remove the launcher which is only doing this hackery?
I will follow up on this mail with a patch that you can ACK.

spaetz

Commit introducing this:
http://cgit.openembedded.net/cgit.cgi/openembedded/commit/?id=742fb4ae71e6a7e655385086ba9edebbf00b6ebd

author	Matthias Hentges <oe@hentges.net>
committer	Matthias Hentges <oe@hentges.net>	2008-01-05
commit	742fb4ae71e6a7e655385086ba9edebbf00b6ebd
--- a/dev/null
+++ b/packages/navit/files/navit.launcher
...
+ if test "$USER" = "root"
+ then
+ echo "Enabling low-mem workaround..."
+ echo 1 > /proc/sys/vm/overcommit_memory