* [PATCH 13 of 13] LVM: 2 mirrored log monitor fixes
@ 2010-02-17 17:57 Jonathan Brassow
2010-02-17 23:20 ` Takahiro Yasui
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Brassow @ 2010-02-17 17:57 UTC (permalink / raw)
To: lvm-devel
Patch name: lvm2-mirrored-log-monitor-fixes.patch
If an event is received on a mirrored LV which also happens to
be the log of a mirror, strip off the '_mlog' component extension
of the name and pass the encapsulating LV to 'lvconvert --repair'.
Index: LVM2/daemons/dmeventd/plugins/mirror/dmeventd_mirror.c
===================================================================
--- LVM2.orig/daemons/dmeventd/plugins/mirror/dmeventd_mirror.c
+++ LVM2/daemons/dmeventd/plugins/mirror/dmeventd_mirror.c
@@ -148,6 +148,11 @@ static int _remove_failed_devices(const
return -ENOMEM; /* FIXME Replace with generic error return - reason for failure has already got logged */
}
+ /* strip off the mirror component designations */
+ layer = strstr(lv, "_mlog");
+ if (layer)
+ layer = '\0';
+
/* FIXME Is any sanity-checking required on %s? */
if (CMD_SIZE <= snprintf(cmd_str, CMD_SIZE, "lvconvert --config devices{ignore_suspended_devices=1} --repair --use-policies %s/%s", vg, lv)) {
/* this error should be caught above, but doesn't hurt to check again */
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 13 of 13] LVM: 2 mirrored log monitor fixes
2010-02-17 17:57 [PATCH 13 of 13] LVM: 2 mirrored log monitor fixes Jonathan Brassow
@ 2010-02-17 23:20 ` Takahiro Yasui
2010-02-18 15:26 ` Jonathan Brassow
0 siblings, 1 reply; 3+ messages in thread
From: Takahiro Yasui @ 2010-02-17 23:20 UTC (permalink / raw)
To: lvm-devel
Jonathan Brassow wrote:
> Patch name: lvm2-mirrored-log-monitor-fixes.patch
>
> If an event is received on a mirrored LV which also happens to
> be the log of a mirror, strip off the '_mlog' component extension
> of the name and pass the encapsulating LV to 'lvconvert --repair'.
>
>
> Index: LVM2/daemons/dmeventd/plugins/mirror/dmeventd_mirror.c
> ===================================================================
> --- LVM2.orig/daemons/dmeventd/plugins/mirror/dmeventd_mirror.c
> +++ LVM2/daemons/dmeventd/plugins/mirror/dmeventd_mirror.c
> @@ -148,6 +148,11 @@ static int _remove_failed_devices(const
> return -ENOMEM; /* FIXME Replace with generic error return - reason for failure has already got logged */
> }
>
> + /* strip off the mirror component designations */
> + layer = strstr(lv, "_mlog");
> + if (layer)
> + layer = '\0';
Typo? :)
*layer = '\0';
Thanks,
Taka
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 13 of 13] LVM: 2 mirrored log monitor fixes
2010-02-17 23:20 ` Takahiro Yasui
@ 2010-02-18 15:26 ` Jonathan Brassow
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Brassow @ 2010-02-18 15:26 UTC (permalink / raw)
To: lvm-devel
On Feb 17, 2010, at 5:20 PM, Takahiro Yasui wrote:
> Jonathan Brassow wrote:
>> Patch name: lvm2-mirrored-log-monitor-fixes.patch
>>
>> If an event is received on a mirrored LV which also happens to
>> be the log of a mirror, strip off the '_mlog' component extension
>> of the name and pass the encapsulating LV to 'lvconvert --repair'.
>>
>>
>> Index: LVM2/daemons/dmeventd/plugins/mirror/dmeventd_mirror.c
>> ===================================================================
>> --- LVM2.orig/daemons/dmeventd/plugins/mirror/dmeventd_mirror.c
>> +++ LVM2/daemons/dmeventd/plugins/mirror/dmeventd_mirror.c
>> @@ -148,6 +148,11 @@ static int _remove_failed_devices(const
>> return -ENOMEM; /* FIXME Replace with generic error return -
>> reason for failure has already got logged */
>> }
>>
>> + /* strip off the mirror component designations */
>> + layer = strstr(lv, "_mlog");
>> + if (layer)
>> + layer = '\0';
>
> Typo? :)
> *layer = '\0';
>
> Thanks,
Good catch, thank-you.
brassow
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-18 15:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-17 17:57 [PATCH 13 of 13] LVM: 2 mirrored log monitor fixes Jonathan Brassow
2010-02-17 23:20 ` Takahiro Yasui
2010-02-18 15:26 ` Jonathan Brassow
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.