* [Qemu-devel] [PATCH] arm host: Fix linker warning (m68k targets)
@ 2010-01-22 21:04 Stefan Weil
2010-02-12 9:57 ` [Qemu-devel] " Stefan Weil
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Weil @ 2010-01-22 21:04 UTC (permalink / raw)
To: qemu-devel
Compilation of m68k-softmmu or m68k-linux-user on arm host
(or cross compilation for arm) results in a linker warning:
LINK m68k-softmmu/qemu-system-m68k
m68k-dis.o: warning: definition of `floatformat_ieee_single_little' overriding common
arm-dis.o: warning: common is here
/usr/lib/gcc/arm-linux-gnueabi/4.3.2/../../../../arm-linux-gnueabi/bin/ld: Warning: size of symbol `floatformat_ieee_single_little' changed from 4 in arm-dis.o to 48 in m68k-dis.o
floatformat_ieee_single_little is declared in arm-dis.c and m68k-dis.c,
and both declarations don't match, so this is an error.
The symbol is not needed in arm-dis.c, so I removed it there.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
arm-dis.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/arm-dis.c b/arm-dis.c
index 2c67d8f..4fb899e 100644
--- a/arm-dis.c
+++ b/arm-dis.c
@@ -60,10 +60,8 @@
#define FPU_VFP_EXT_V3 0
#define FPU_NEON_EXT_V1 0
-int floatformat_ieee_single_little;
/* Assume host uses ieee float. */
-static void floatformat_to_double (int *ignored, unsigned char *data,
- double *dest)
+static void floatformat_to_double (unsigned char *data, double *dest)
{
union {
uint32_t i;
@@ -2543,9 +2541,7 @@ print_insn_neon (struct disassemble_info *info, long given, bfd_boolean thumb)
valbytes[2] = (value >> 16) & 0xff;
valbytes[3] = (value >> 24) & 0xff;
- floatformat_to_double
- (&floatformat_ieee_single_little, valbytes,
- &fvalue);
+ floatformat_to_double (valbytes, &fvalue);
func (stream, "#%.7g\t; 0x%.8lx", fvalue,
value);
--
1.6.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] Re: [PATCH] arm host: Fix linker warning (m68k targets)
2010-01-22 21:04 [Qemu-devel] [PATCH] arm host: Fix linker warning (m68k targets) Stefan Weil
@ 2010-02-12 9:57 ` Stefan Weil
2010-02-23 18:42 ` [Qemu-devel] " Stefan Weil
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Weil @ 2010-02-12 9:57 UTC (permalink / raw)
To: Paul Brook; +Cc: qemu-devel
Stefan Weil schrieb:
> Compilation of m68k-softmmu or m68k-linux-user on arm host
> (or cross compilation for arm) results in a linker warning:
>
> LINK m68k-softmmu/qemu-system-m68k
> m68k-dis.o: warning: definition of `floatformat_ieee_single_little'
> overriding common
> arm-dis.o: warning: common is here
> /usr/lib/gcc/arm-linux-gnueabi/4.3.2/../../../../arm-linux-gnueabi/bin/ld:
> Warning: size of symbol `floatformat_ieee_single_little' changed from
> 4 in arm-dis.o to 48 in m68k-dis.o
>
> floatformat_ieee_single_little is declared in arm-dis.c and m68k-dis.c,
> and both declarations don't match, so this is an error.
>
> The symbol is not needed in arm-dis.c, so I removed it there.
>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> arm-dis.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arm-dis.c b/arm-dis.c
> index 2c67d8f..4fb899e 100644
> --- a/arm-dis.c
> +++ b/arm-dis.c
> @@ -60,10 +60,8 @@
> #define FPU_VFP_EXT_V3 0
> #define FPU_NEON_EXT_V1 0
>
> -int floatformat_ieee_single_little;
> /* Assume host uses ieee float. */
> -static void floatformat_to_double (int *ignored, unsigned char *data,
> - double *dest)
> +static void floatformat_to_double (unsigned char *data, double *dest)
> {
> union {
> uint32_t i;
> @@ -2543,9 +2541,7 @@ print_insn_neon (struct disassemble_info *info,
> long given, bfd_boolean thumb)
> valbytes[2] = (value >> 16) & 0xff;
> valbytes[3] = (value >> 24) & 0xff;
>
> - floatformat_to_double
> - (&floatformat_ieee_single_little, valbytes,
> - &fvalue);
> + floatformat_to_double (valbytes, &fvalue);
>
> func (stream, "#%.7g\t; 0x%.8lx", fvalue,
> value);
The patch is still missing in git. Maybe it got lost?
A linker warning about symbols which change from 4 to 48 byte
should be regarded as error.
Regards,
Stefan Weil
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] arm host: Fix linker warning (m68k targets)
2010-02-12 9:57 ` [Qemu-devel] " Stefan Weil
@ 2010-02-23 18:42 ` Stefan Weil
2010-02-23 21:13 ` Anthony Liguori
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Weil @ 2010-02-23 18:42 UTC (permalink / raw)
To: QEMU Developers; +Cc: Anthony Liguori, Paul Brook
Stefan Weil schrieb:
> Stefan Weil schrieb:
>
>> Compilation of m68k-softmmu or m68k-linux-user on arm host
>> (or cross compilation for arm) results in a linker warning:
>>
>> LINK m68k-softmmu/qemu-system-m68k
>> m68k-dis.o: warning: definition of `floatformat_ieee_single_little'
>> overriding common
>> arm-dis.o: warning: common is here
>> /usr/lib/gcc/arm-linux-gnueabi/4.3.2/../../../../arm-linux-gnueabi/bin/ld:
>> Warning: size of symbol `floatformat_ieee_single_little' changed from
>> 4 in arm-dis.o to 48 in m68k-dis.o
>>
>> floatformat_ieee_single_little is declared in arm-dis.c and m68k-dis.c,
>> and both declarations don't match, so this is an error.
>>
>> The symbol is not needed in arm-dis.c, so I removed it there.
>>
>> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
>> ---
>> arm-dis.c | 8 ++------
>> 1 files changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/arm-dis.c b/arm-dis.c
>> index 2c67d8f..4fb899e 100644
>> --- a/arm-dis.c
>> +++ b/arm-dis.c
>> @@ -60,10 +60,8 @@
>> #define FPU_VFP_EXT_V3 0
>> #define FPU_NEON_EXT_V1 0
>>
>> -int floatformat_ieee_single_little;
>> /* Assume host uses ieee float. */
>> -static void floatformat_to_double (int *ignored, unsigned char *data,
>> - double *dest)
>> +static void floatformat_to_double (unsigned char *data, double *dest)
>> {
>> union {
>> uint32_t i;
>> @@ -2543,9 +2541,7 @@ print_insn_neon (struct disassemble_info *info,
>> long given, bfd_boolean thumb)
>> valbytes[2] = (value >> 16) & 0xff;
>> valbytes[3] = (value >> 24) & 0xff;
>>
>> - floatformat_to_double
>> - (&floatformat_ieee_single_little, valbytes,
>> - &fvalue);
>> + floatformat_to_double (valbytes, &fvalue);
>>
>> func (stream, "#%.7g\t; 0x%.8lx", fvalue,
>> value);
>>
>
> The patch is still missing in git. Maybe it got lost?
>
> A linker warning about symbols which change from 4 to 48 byte
> should be regarded as error.
>
> Regards,
> Stefan Weil
>
I'd commit it myself if I had the rights, but I haven't.
So the only think I can do is remind those who have...
Regards,
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] arm host: Fix linker warning (m68k targets)
2010-02-23 18:42 ` [Qemu-devel] " Stefan Weil
@ 2010-02-23 21:13 ` Anthony Liguori
2010-02-23 21:32 ` Stefan Weil
0 siblings, 1 reply; 6+ messages in thread
From: Anthony Liguori @ 2010-02-23 21:13 UTC (permalink / raw)
To: Stefan Weil; +Cc: QEMU Developers, Paul Brook
On 02/23/2010 12:42 PM, Stefan Weil wrote:
>
> I'd commit it myself if I had the rights, but I haven't.
> So the only think I can do is remind those who have...
>
Please resubmit. I would expect an ARM host patch to be applied by Paul
but if he's not available to, I'll keep it my queue to be applied.
Regards,
Anthony Liguori
> Regards,
> Stefan
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH] arm host: Fix linker warning (m68k targets)
2010-02-23 21:13 ` Anthony Liguori
@ 2010-02-23 21:32 ` Stefan Weil
2010-02-27 15:25 ` Aurelien Jarno
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Weil @ 2010-02-23 21:32 UTC (permalink / raw)
To: QEMU Developers; +Cc: aliguori
Compilation of m68k-softmmu or m68k-linux-user on arm host
(or cross compilation for arm) results in a linker warning:
LINK m68k-softmmu/qemu-system-m68k
m68k-dis.o: warning: definition of `floatformat_ieee_single_little' overriding common
arm-dis.o: warning: common is here
/usr/lib/gcc/arm-linux-gnueabi/4.3.2/../../../../arm-linux-gnueabi/bin/ld: Warning: size of symbol `floatformat_ieee_single_little' changed from 4 in arm-dis.o to 48 in m68k-dis.o
floatformat_ieee_single_little is declared in arm-dis.c and m68k-dis.c,
and both declarations don't match, so this is an error.
The symbol is not needed in arm-dis.c, so I removed it there.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
arm-dis.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/arm-dis.c b/arm-dis.c
index 2c67d8f..4fb899e 100644
--- a/arm-dis.c
+++ b/arm-dis.c
@@ -60,10 +60,8 @@
#define FPU_VFP_EXT_V3 0
#define FPU_NEON_EXT_V1 0
-int floatformat_ieee_single_little;
/* Assume host uses ieee float. */
-static void floatformat_to_double (int *ignored, unsigned char *data,
- double *dest)
+static void floatformat_to_double (unsigned char *data, double *dest)
{
union {
uint32_t i;
@@ -2543,9 +2541,7 @@ print_insn_neon (struct disassemble_info *info, long given, bfd_boolean thumb)
valbytes[2] = (value >> 16) & 0xff;
valbytes[3] = (value >> 24) & 0xff;
- floatformat_to_double
- (&floatformat_ieee_single_little, valbytes,
- &fvalue);
+ floatformat_to_double (valbytes, &fvalue);
func (stream, "#%.7g\t; 0x%.8lx", fvalue,
value);
--
1.6.6.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] arm host: Fix linker warning (m68k targets)
2010-02-23 21:32 ` Stefan Weil
@ 2010-02-27 15:25 ` Aurelien Jarno
0 siblings, 0 replies; 6+ messages in thread
From: Aurelien Jarno @ 2010-02-27 15:25 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-devel
On Tue, Feb 23, 2010 at 10:32:23PM +0100, Stefan Weil wrote:
> Compilation of m68k-softmmu or m68k-linux-user on arm host
> (or cross compilation for arm) results in a linker warning:
>
> LINK m68k-softmmu/qemu-system-m68k
> m68k-dis.o: warning: definition of `floatformat_ieee_single_little' overriding common
> arm-dis.o: warning: common is here
> /usr/lib/gcc/arm-linux-gnueabi/4.3.2/../../../../arm-linux-gnueabi/bin/ld: Warning: size of symbol `floatformat_ieee_single_little' changed from 4 in arm-dis.o to 48 in m68k-dis.o
>
> floatformat_ieee_single_little is declared in arm-dis.c and m68k-dis.c,
> and both declarations don't match, so this is an error.
>
> The symbol is not needed in arm-dis.c, so I removed it there.
Thanks, applied.
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> arm-dis.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/arm-dis.c b/arm-dis.c
> index 2c67d8f..4fb899e 100644
> --- a/arm-dis.c
> +++ b/arm-dis.c
> @@ -60,10 +60,8 @@
> #define FPU_VFP_EXT_V3 0
> #define FPU_NEON_EXT_V1 0
>
> -int floatformat_ieee_single_little;
> /* Assume host uses ieee float. */
> -static void floatformat_to_double (int *ignored, unsigned char *data,
> - double *dest)
> +static void floatformat_to_double (unsigned char *data, double *dest)
> {
> union {
> uint32_t i;
> @@ -2543,9 +2541,7 @@ print_insn_neon (struct disassemble_info *info, long given, bfd_boolean thumb)
> valbytes[2] = (value >> 16) & 0xff;
> valbytes[3] = (value >> 24) & 0xff;
>
> - floatformat_to_double
> - (&floatformat_ieee_single_little, valbytes,
> - &fvalue);
> + floatformat_to_double (valbytes, &fvalue);
>
> func (stream, "#%.7g\t; 0x%.8lx", fvalue,
> value);
> --
> 1.6.6.1
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-02-27 15:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-22 21:04 [Qemu-devel] [PATCH] arm host: Fix linker warning (m68k targets) Stefan Weil
2010-02-12 9:57 ` [Qemu-devel] " Stefan Weil
2010-02-23 18:42 ` [Qemu-devel] " Stefan Weil
2010-02-23 21:13 ` Anthony Liguori
2010-02-23 21:32 ` Stefan Weil
2010-02-27 15:25 ` Aurelien Jarno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.