Re: LP-PHY Fatal DMA error 0x00000800 on non-ULV Core 2 Duo?!?!!??!

* Re: LP-PHY Fatal DMA error 0x00000800 on non-ULV Core 2 Duo?!?!!??!
       [not found]                 ` <4B8AAF42.8000602@polymtl.ca>
@ 2010-02-28 18:42                   ` Gábor Stefanik
  2010-02-28 18:47                     ` Rafał Miłecki
  2010-02-28 19:44                     ` William Bourque
  0 siblings, 2 replies; 22+ messages in thread
From: Gábor Stefanik @ 2010-02-28 18:42 UTC (permalink / raw)
  To: William Bourque; +Cc: bcm43xx-dev, linux-wireless

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

On Sun, Feb 28, 2010 at 7:00 PM, William Bourque
<william.bourque@polymtl.ca> wrote:
> I confirm, it still crashes on my notebook as well. However the new
> "fallback to PIO" behavior introduced earlier do a fine job getting it back
> on track.
>
> Btw, you are often refering to some documentation that document the register
> for this device, where could I find it? I probably won't be able to do much,
> but I'm curious to see...
>
> - William

Thanks!

New test patch attached.

Please CC linux-wireless@vger.kernel.org on further e-mails,
bcm43xx-dev appears to be having problems.

-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

[-- Attachment #2: lpphy-test.patch --]
[-- Type: application/octet-stream, Size: 2992 bytes --]

diff --git a/drivers/ssb/driver_chipcommon.c b/drivers/ssb/driver_chipcommon.c
index 9681536..a3ab04a 100644
--- a/drivers/ssb/driver_chipcommon.c
+++ b/drivers/ssb/driver_chipcommon.c
@@ -233,6 +233,12 @@ void ssb_chipcommon_init(struct ssb_chipcommon *cc)
 {
 	if (!cc->dev)
 		return; /* We don't have a ChipCommon */
+
+	if (cc->dev->id.revision >= 20) {
+		chipco_write32(cc, SSB_CHIPCO_GPIO_PULLUP, 0);
+		chipco_write32(cc, SSB_CHIPCO_GPIO_PULLDN, 0);
+	}
+
 	ssb_pmu_init(cc);
 	chipco_powercontrol_init(cc);
 	ssb_chipco_set_clockmode(cc, SSB_CLKMODE_FAST);
diff --git a/drivers/ssb/driver_chipcommon_pmu.c b/drivers/ssb/driver_chipcommon_pmu.c
index 3d55124..1fa1648 100644
--- a/drivers/ssb/driver_chipcommon_pmu.c
+++ b/drivers/ssb/driver_chipcommon_pmu.c
@@ -427,7 +427,9 @@ static void ssb_pmu_resources_init(struct ssb_chipcommon *cc)
 		/* We keep the default settings:
 		 * min_msk = 0xCBB
 		 * max_msk = 0x7FFFF
+		 * However, we need to actually write min_msk to the device.
 		 */
+		min_msk = 0xCBB;
 		break;
 	case 0x4325:
 		/* Power OTP down later. */
@@ -516,15 +518,14 @@ void ssb_pmu_init(struct ssb_chipcommon *cc)
 	ssb_dprintk(KERN_DEBUG PFX "Found rev %u PMU (capabilities 0x%08X)\n",
 		    cc->pmu.rev, pmucap);
 
-	if (cc->pmu.rev >= 1) {
-		if ((bus->chip_id == 0x4325) && (bus->chip_rev < 2)) {
-			chipco_mask32(cc, SSB_CHIPCO_PMU_CTL,
-				      ~SSB_CHIPCO_PMU_CTL_NOILPONW);
-		} else {
-			chipco_set32(cc, SSB_CHIPCO_PMU_CTL,
-				     SSB_CHIPCO_PMU_CTL_NOILPONW);
-		}
+	if (cc->pmu.rev == 1) {
+		chipco_mask32(cc, SSB_CHIPCO_PMU_CTL,
+			      ~SSB_CHIPCO_PMU_CTL_NOILPONW);
+	} else {
+		chipco_set32(cc, SSB_CHIPCO_PMU_CTL,
+			     SSB_CHIPCO_PMU_CTL_NOILPONW);
 	}
+
 	ssb_pmu_pll_init(cc);
 	ssb_pmu_resources_init(cc);
 }
diff --git a/drivers/ssb/driver_pcicore.c b/drivers/ssb/driver_pcicore.c
index f1dcd79..65923d8 100644
--- a/drivers/ssb/driver_pcicore.c
+++ b/drivers/ssb/driver_pcicore.c
@@ -441,6 +441,12 @@ static void ssb_pcicore_init_clientmode(struct ssb_pcicore *pc)
 {
 	/* Disable PCI interrupts. */
 	ssb_write32(pc->dev, SSB_INTVEC, 0);
+
+	/* PCI-E misc configuration */
+	/* HACK This looks wrong, but this is what the vendor driver does... */
+	ssb_write32(pc->dev, 0x280a, ssb_read32(pc->dev, 0x280a) | 0x8000);
+	/* And now as the specs say: */
+	ssb_write32(pc->dev, 0x80a, ssb_read32(pc->dev, 0x80a) | 0x8000);
 }
 
 void ssb_pcicore_init(struct ssb_pcicore *pc)
diff --git a/include/linux/ssb/ssb_driver_chipcommon.h b/include/linux/ssb/ssb_driver_chipcommon.h
index 4e27acf..dc46c1b 100644
--- a/include/linux/ssb/ssb_driver_chipcommon.h
+++ b/include/linux/ssb/ssb_driver_chipcommon.h
@@ -122,6 +122,8 @@
 #define SSB_CHIPCO_FLASHDATA		0x0048
 #define SSB_CHIPCO_BCAST_ADDR		0x0050
 #define SSB_CHIPCO_BCAST_DATA		0x0054
+#define SSB_CHIPCO_GPIO_PULLUP		0x0058
+#define SSB_CHIPCO_GPIO_PULLDN		0x005C
 #define SSB_CHIPCO_GPIOIN		0x0060
 #define SSB_CHIPCO_GPIOOUT		0x0064
 #define SSB_CHIPCO_GPIOOUTEN		0x0068

^ permalink raw reply related	[flat|nested] 22+ messages in thread