* [U-Boot] [PATCH] nios2: Add missing Ethernet initialization to board_init().
@ 2010-03-21 17:37 Scott McNutt
2010-03-21 17:44 ` Mike Frysinger
0 siblings, 1 reply; 3+ messages in thread
From: Scott McNutt @ 2010-03-21 17:37 UTC (permalink / raw)
To: u-boot
Signed-off-by: Scott McNutt <smcnutt@psyent.com>
---
lib_nios2/board.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/lib_nios2/board.c b/lib_nios2/board.c
index 41d3297..311d66c 100644
--- a/lib_nios2/board.c
+++ b/lib_nios2/board.c
@@ -139,6 +139,14 @@ void board_init (void)
board_late_init ();
#endif
+#if defined(CONFIG_CMD_NET)
+#if defined(CONFIG_NET_MULTI)
+ WATCHDOG_RESET ();
+ puts ("Net: ");
+#endif
+ eth_initialize (bd);
+#endif
+
/* main_loop */
for (;;) {
WATCHDOG_RESET ();
--
1.6.0.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] nios2: Add missing Ethernet initialization to board_init().
2010-03-21 17:37 [U-Boot] [PATCH] nios2: Add missing Ethernet initialization to board_init() Scott McNutt
@ 2010-03-21 17:44 ` Mike Frysinger
2010-03-21 19:25 ` Scott McNutt
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2010-03-21 17:44 UTC (permalink / raw)
To: u-boot
On Sunday 21 March 2010 13:37:53 Scott McNutt wrote:
> + WATCHDOG_RESET ();
> + puts ("Net: ");
considering serial drivers' putc() should be calling watchdog reset, does this
really make sense here ? looks like a wart in a few arches you shouldnt be
copying over ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100321/00e8fa8c/attachment.pgp
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] nios2: Add missing Ethernet initialization to board_init().
2010-03-21 17:44 ` Mike Frysinger
@ 2010-03-21 19:25 ` Scott McNutt
0 siblings, 0 replies; 3+ messages in thread
From: Scott McNutt @ 2010-03-21 19:25 UTC (permalink / raw)
To: u-boot
Mike Frysinger wrote:
> On Sunday 21 March 2010 13:37:53 Scott McNutt wrote:
>> + WATCHDOG_RESET ();
>> + puts ("Net: ");
>
> considering serial drivers' putc() should be calling watchdog reset, does this
> really make sense here ?
No.
> looks like a wart in a few arches you shouldnt be
> copying over ...
Agreed. Warts can become difficult to remove. ;-)
Regards,
--Scott
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-21 19:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-21 17:37 [U-Boot] [PATCH] nios2: Add missing Ethernet initialization to board_init() Scott McNutt
2010-03-21 17:44 ` Mike Frysinger
2010-03-21 19:25 ` Scott McNutt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.