* [LTP] [BUG?] proc01: read /proc/acpi/event failed if acpi daemon stopped
@ 2010-03-13 3:49 Shi Weihua
2010-03-13 6:27 ` Garrett Cooper
0 siblings, 1 reply; 7+ messages in thread
From: Shi Weihua @ 2010-03-13 3:49 UTC (permalink / raw)
To: Garrett Cooper, Rishikesh; +Cc: ltp-list
An error message occured when i tested proc01.
---------
proc01 1 TFAIL : read failed: /proc/acpi/event: errno=EAGAIN(11): Resource temporarily unavailable
---------
If "service acpid start", this message will be turned to:
---------
proc01 0 TINFO : /proc/acpi/event: known issue: errno=EBUSY(16): Device or resource busy
---------
I think we should to add a check of acpi daemon's status in testcases/kernel/fs/proc/proc01.c.
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [BUG?] proc01: read /proc/acpi/event failed if acpi daemon stopped
2010-03-13 3:49 [LTP] [BUG?] proc01: read /proc/acpi/event failed if acpi daemon stopped Shi Weihua
@ 2010-03-13 6:27 ` Garrett Cooper
2010-03-13 7:13 ` Garrett Cooper
0 siblings, 1 reply; 7+ messages in thread
From: Garrett Cooper @ 2010-03-13 6:27 UTC (permalink / raw)
To: Shi Weihua; +Cc: ltp-list
On Fri, Mar 12, 2010 at 7:49 PM, Shi Weihua <shiwh@cn.fujitsu.com> wrote:
> An error message occured when i tested proc01.
> ---------
> proc01 1 TFAIL : read failed: /proc/acpi/event: errno=EAGAIN(11): Resource temporarily unavailable
> ---------
>
> If "service acpid start", this message will be turned to:
> ---------
> proc01 0 TINFO : /proc/acpi/event: known issue: errno=EBUSY(16): Device or resource busy
> ---------
>
> I think we should to add a check of acpi daemon's status in testcases/kernel/fs/proc/proc01.c.
No, that's making things too complicated and won't scale as every
distro has developed a different means for specifying the status for a
service. Why not just add EAGAIN for that /proc node?
Thanks,
-Garrett
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [BUG?] proc01: read /proc/acpi/event failed if acpi daemon stopped
2010-03-13 6:27 ` Garrett Cooper
@ 2010-03-13 7:13 ` Garrett Cooper
2010-03-22 10:06 ` Shi Weihua
0 siblings, 1 reply; 7+ messages in thread
From: Garrett Cooper @ 2010-03-13 7:13 UTC (permalink / raw)
To: Shi Weihua; +Cc: ltp-list
On Fri, Mar 12, 2010 at 10:27 PM, Garrett Cooper <yanegomi@gmail.com> wrote:
> On Fri, Mar 12, 2010 at 7:49 PM, Shi Weihua <shiwh@cn.fujitsu.com> wrote:
>> An error message occured when i tested proc01.
>> ---------
>> proc01 1 TFAIL : read failed: /proc/acpi/event: errno=EAGAIN(11): Resource temporarily unavailable
>> ---------
>>
>> If "service acpid start", this message will be turned to:
>> ---------
>> proc01 0 TINFO : /proc/acpi/event: known issue: errno=EBUSY(16): Device or resource busy
>> ---------
>>
>> I think we should to add a check of acpi daemon's status in testcases/kernel/fs/proc/proc01.c.
>
> No, that's making things too complicated and won't scale as every
> distro has developed a different means for specifying the status for a
> service. Why not just add EAGAIN for that /proc node?
And FWIW the error condition is correct in my opinion if kernel
acpi hasn't been enabled, which was the case here.
Thanks,
-Garrett
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [BUG?] proc01: read /proc/acpi/event failed if acpi daemon stopped
2010-03-13 7:13 ` Garrett Cooper
@ 2010-03-22 10:06 ` Shi Weihua
2010-03-23 3:57 ` Garrett Cooper
0 siblings, 1 reply; 7+ messages in thread
From: Shi Weihua @ 2010-03-22 10:06 UTC (permalink / raw)
To: Garrett Cooper; +Cc: ltp-list
Hi Garrett
at 2010-3-13 15:13, Garrett Cooper wrote:
> On Fri, Mar 12, 2010 at 10:27 PM, Garrett Cooper <yanegomi@gmail.com> wrote:
>> On Fri, Mar 12, 2010 at 7:49 PM, Shi Weihua <shiwh@cn.fujitsu.com> wrote:
>>> An error message occured when i tested proc01.
>>> ---------
>>> proc01 1 TFAIL : read failed: /proc/acpi/event: errno=EAGAIN(11): Resource temporarily unavailable
>>> ---------
>>>
>>> If "service acpid start", this message will be turned to:
>>> ---------
>>> proc01 0 TINFO : /proc/acpi/event: known issue: errno=EBUSY(16): Device or resource busy
>>> ---------
>>>
>>> I think we should to add a check of acpi daemon's status in testcases/kernel/fs/proc/proc01.c.
>>
>> No, that's making things too complicated and won't scale as every
>> distro has developed a different means for specifying the status for a
>> service. Why not just add EAGAIN for that /proc node?
>
> And FWIW the error condition is correct in my opinion if kernel
> acpi hasn't been enabled, which was the case here.
I think we should to give a warning message to LTP users.
How do you think the following patch?
diff --git a/testcases/kernel/fs/proc/proc01.c b/testcases/kernel/fs/proc/proc01.c
index 2d4a5fd..62d44b1 100644
--- a/testcases/kernel/fs/proc/proc01.c
+++ b/testcases/kernel/fs/proc/proc01.c
@@ -101,6 +101,7 @@ const Mapping known_issues[] = {
{"read", "/proc/fs/nfsd/filehandle", EINVAL},
{"read", "/proc/fs/nfsd/.getfs", EINVAL},
{"read", "/proc/fs/nfsd/.getfd", EINVAL},
+ {"read", "/proc/acpi/event", EAGAIN}, //EAGAIN will be returned if acpi daemon disabled
{"", "", 0}
};
> Thanks,
> -Garrett
>
>
--
Shi Weihua
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [LTP] [BUG?] proc01: read /proc/acpi/event failed if acpi daemon stopped
2010-03-22 10:06 ` Shi Weihua
@ 2010-03-23 3:57 ` Garrett Cooper
2010-03-23 5:22 ` Shi Weihua
0 siblings, 1 reply; 7+ messages in thread
From: Garrett Cooper @ 2010-03-23 3:57 UTC (permalink / raw)
To: Shi Weihua; +Cc: ltp-list
On Mon, Mar 22, 2010 at 3:06 AM, Shi Weihua <shiwh@cn.fujitsu.com> wrote:
> Hi Garrett
>
> at 2010-3-13 15:13, Garrett Cooper wrote:
>> On Fri, Mar 12, 2010 at 10:27 PM, Garrett Cooper <yanegomi@gmail.com> wrote:
>>> On Fri, Mar 12, 2010 at 7:49 PM, Shi Weihua <shiwh@cn.fujitsu.com> wrote:
>>>> An error message occured when i tested proc01.
>>>> ---------
>>>> proc01 1 TFAIL : read failed: /proc/acpi/event: errno=EAGAIN(11): Resource temporarily unavailable
>>>> ---------
>>>>
>>>> If "service acpid start", this message will be turned to:
>>>> ---------
>>>> proc01 0 TINFO : /proc/acpi/event: known issue: errno=EBUSY(16): Device or resource busy
>>>> ---------
>>>>
>>>> I think we should to add a check of acpi daemon's status in testcases/kernel/fs/proc/proc01.c.
>>>
>>> No, that's making things too complicated and won't scale as every
>>> distro has developed a different means for specifying the status for a
>>> service. Why not just add EAGAIN for that /proc node?
>>
>> And FWIW the error condition is correct in my opinion if kernel
>> acpi hasn't been enabled, which was the case here.
>
> I think we should to give a warning message to LTP users.
> How do you think the following patch?
>
> diff --git a/testcases/kernel/fs/proc/proc01.c b/testcases/kernel/fs/proc/proc01.c
> index 2d4a5fd..62d44b1 100644
> --- a/testcases/kernel/fs/proc/proc01.c
> +++ b/testcases/kernel/fs/proc/proc01.c
> @@ -101,6 +101,7 @@ const Mapping known_issues[] = {
> {"read", "/proc/fs/nfsd/filehandle", EINVAL},
> {"read", "/proc/fs/nfsd/.getfs", EINVAL},
> {"read", "/proc/fs/nfsd/.getfd", EINVAL},
> + {"read", "/proc/acpi/event", EAGAIN}, //EAGAIN will be returned if acpi daemon disabled
> {"", "", 0}
> };
Looks good minus the C++ style comment ;).
Thanks again!
-Garrett
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [BUG?] proc01: read /proc/acpi/event failed if acpi daemon stopped
2010-03-23 3:57 ` Garrett Cooper
@ 2010-03-23 5:22 ` Shi Weihua
2010-03-23 16:44 ` Garrett Cooper
0 siblings, 1 reply; 7+ messages in thread
From: Shi Weihua @ 2010-03-23 5:22 UTC (permalink / raw)
To: Garrett Cooper; +Cc: ltp-list
at 2010-3-23 11:57, Garrett Cooper wrote:
> On Mon, Mar 22, 2010 at 3:06 AM, Shi Weihua <shiwh@cn.fujitsu.com> wrote:
>> Hi Garrett
>>
>> at 2010-3-13 15:13, Garrett Cooper wrote:
>>> On Fri, Mar 12, 2010 at 10:27 PM, Garrett Cooper <yanegomi@gmail.com> wrote:
>>>> On Fri, Mar 12, 2010 at 7:49 PM, Shi Weihua <shiwh@cn.fujitsu.com> wrote:
>>>>> An error message occured when i tested proc01.
>>>>> ---------
>>>>> proc01 1 TFAIL : read failed: /proc/acpi/event: errno=EAGAIN(11): Resource temporarily unavailable
>>>>> ---------
>>>>>
>>>>> If "service acpid start", this message will be turned to:
>>>>> ---------
>>>>> proc01 0 TINFO : /proc/acpi/event: known issue: errno=EBUSY(16): Device or resource busy
>>>>> ---------
>>>>>
>>>>> I think we should to add a check of acpi daemon's status in testcases/kernel/fs/proc/proc01.c.
>>>>
>>>> No, that's making things too complicated and won't scale as every
>>>> distro has developed a different means for specifying the status for a
>>>> service. Why not just add EAGAIN for that /proc node?
>>>
>>> And FWIW the error condition is correct in my opinion if kernel
>>> acpi hasn't been enabled, which was the case here.
>>
>> I think we should to give a warning message to LTP users.
>> How do you think the following patch?
>>
>> diff --git a/testcases/kernel/fs/proc/proc01.c b/testcases/kernel/fs/proc/proc01.c
>> index 2d4a5fd..62d44b1 100644
>> --- a/testcases/kernel/fs/proc/proc01.c
>> +++ b/testcases/kernel/fs/proc/proc01.c
>> @@ -101,6 +101,7 @@ const Mapping known_issues[] = {
>> {"read", "/proc/fs/nfsd/filehandle", EINVAL},
>> {"read", "/proc/fs/nfsd/.getfs", EINVAL},
>> {"read", "/proc/fs/nfsd/.getfd", EINVAL},
>> + {"read", "/proc/acpi/event", EAGAIN}, //EAGAIN will be returned if acpi daemon disabled
>> {"", "", 0}
>> };
>
> Looks good minus the C++ style comment ;).
ok, let's use C style comment.
diff --git a/testcases/kernel/fs/proc/proc01.c b/testcases/kernel/fs/proc/proc01.c
index 2d4a5fd..355b7dd 100644
--- a/testcases/kernel/fs/proc/proc01.c
+++ b/testcases/kernel/fs/proc/proc01.c
@@ -101,6 +101,7 @@ const Mapping known_issues[] = {
{"read", "/proc/fs/nfsd/filehandle", EINVAL},
{"read", "/proc/fs/nfsd/.getfs", EINVAL},
{"read", "/proc/fs/nfsd/.getfd", EINVAL},
+ {"read", "/proc/acpi/event", EAGAIN}, /* EAGAIN will be returned if acpi daemon disabled */
{"", "", 0}
};
> Thanks again!
> -Garrett
>
>
--
Shi Weihua
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [LTP] [BUG?] proc01: read /proc/acpi/event failed if acpi daemon stopped
2010-03-23 5:22 ` Shi Weihua
@ 2010-03-23 16:44 ` Garrett Cooper
0 siblings, 0 replies; 7+ messages in thread
From: Garrett Cooper @ 2010-03-23 16:44 UTC (permalink / raw)
To: Shi Weihua; +Cc: ltp-list
On Mon, Mar 22, 2010 at 10:22 PM, Shi Weihua <shiwh@cn.fujitsu.com> wrote:
> at 2010-3-23 11:57, Garrett Cooper wrote:
>> On Mon, Mar 22, 2010 at 3:06 AM, Shi Weihua <shiwh@cn.fujitsu.com> wrote:
>>> Hi Garrett
>>>
>>> at 2010-3-13 15:13, Garrett Cooper wrote:
>>>> On Fri, Mar 12, 2010 at 10:27 PM, Garrett Cooper <yanegomi@gmail.com> wrote:
>>>>> On Fri, Mar 12, 2010 at 7:49 PM, Shi Weihua <shiwh@cn.fujitsu.com> wrote:
>>>>>> An error message occured when i tested proc01.
>>>>>> ---------
>>>>>> proc01 1 TFAIL : read failed: /proc/acpi/event: errno=EAGAIN(11): Resource temporarily unavailable
>>>>>> ---------
>>>>>>
>>>>>> If "service acpid start", this message will be turned to:
>>>>>> ---------
>>>>>> proc01 0 TINFO : /proc/acpi/event: known issue: errno=EBUSY(16): Device or resource busy
>>>>>> ---------
>>>>>>
>>>>>> I think we should to add a check of acpi daemon's status in testcases/kernel/fs/proc/proc01.c.
>>>>>
>>>>> No, that's making things too complicated and won't scale as every
>>>>> distro has developed a different means for specifying the status for a
>>>>> service. Why not just add EAGAIN for that /proc node?
>>>>
>>>> And FWIW the error condition is correct in my opinion if kernel
>>>> acpi hasn't been enabled, which was the case here.
>>>
>>> I think we should to give a warning message to LTP users.
>>> How do you think the following patch?
>>>
>>> diff --git a/testcases/kernel/fs/proc/proc01.c b/testcases/kernel/fs/proc/proc01.c
>>> index 2d4a5fd..62d44b1 100644
>>> --- a/testcases/kernel/fs/proc/proc01.c
>>> +++ b/testcases/kernel/fs/proc/proc01.c
>>> @@ -101,6 +101,7 @@ const Mapping known_issues[] = {
>>> {"read", "/proc/fs/nfsd/filehandle", EINVAL},
>>> {"read", "/proc/fs/nfsd/.getfs", EINVAL},
>>> {"read", "/proc/fs/nfsd/.getfd", EINVAL},
>>> + {"read", "/proc/acpi/event", EAGAIN}, //EAGAIN will be returned if acpi daemon disabled
>>> {"", "", 0}
>>> };
>>
>> Looks good minus the C++ style comment ;).
>
> ok, let's use C style comment.
>
> diff --git a/testcases/kernel/fs/proc/proc01.c b/testcases/kernel/fs/proc/proc01.c
> index 2d4a5fd..355b7dd 100644
> --- a/testcases/kernel/fs/proc/proc01.c
> +++ b/testcases/kernel/fs/proc/proc01.c
> @@ -101,6 +101,7 @@ const Mapping known_issues[] = {
> {"read", "/proc/fs/nfsd/filehandle", EINVAL},
> {"read", "/proc/fs/nfsd/.getfs", EINVAL},
> {"read", "/proc/fs/nfsd/.getfd", EINVAL},
> + {"read", "/proc/acpi/event", EAGAIN}, /* EAGAIN will be returned if acpi daemon disabled */
> {"", "", 0}
> };
Acked-by: Garrett Cooper <yanegomi@gmail.com>
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-03-23 16:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-13 3:49 [LTP] [BUG?] proc01: read /proc/acpi/event failed if acpi daemon stopped Shi Weihua
2010-03-13 6:27 ` Garrett Cooper
2010-03-13 7:13 ` Garrett Cooper
2010-03-22 10:06 ` Shi Weihua
2010-03-23 3:57 ` Garrett Cooper
2010-03-23 5:22 ` Shi Weihua
2010-03-23 16:44 ` Garrett Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.