* [PATCH 1/1] lockd: crashes in svcxdr_encode_owner
@ 2021-09-15 21:33 Dai Ngo
2021-09-15 21:44 ` Chuck Lever III
0 siblings, 1 reply; 2+ messages in thread
From: Dai Ngo @ 2021-09-15 21:33 UTC (permalink / raw)
To: linux-nfs
svcxdr_encode_owner needs to handle case where no lock owner
info to pass back, obj->len == 0.
Fixes: a6a63ca5652e ("lockd: Common NLM XDR helpers")
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
---
fs/lockd/svcxdr.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/lockd/svcxdr.h b/fs/lockd/svcxdr.h
index c69a0bb76c94..04fde20ea8c1 100644
--- a/fs/lockd/svcxdr.h
+++ b/fs/lockd/svcxdr.h
@@ -139,6 +139,8 @@ svcxdr_encode_owner(struct xdr_stream *xdr, const struct xdr_netobj *obj)
if (xdr_stream_encode_u32(xdr, obj->len) < 0)
return false;
+ if (obj->len == 0)
+ return true;
p = xdr_reserve_space(xdr, obj->len);
if (!p)
return false;
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] lockd: crashes in svcxdr_encode_owner
2021-09-15 21:33 [PATCH 1/1] lockd: crashes in svcxdr_encode_owner Dai Ngo
@ 2021-09-15 21:44 ` Chuck Lever III
0 siblings, 0 replies; 2+ messages in thread
From: Chuck Lever III @ 2021-09-15 21:44 UTC (permalink / raw)
To: Dai Ngo; +Cc: Linux NFS Mailing List
Hi Dai-
> On Sep 15, 2021, at 5:33 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>
> svcxdr_encode_owner needs to handle case where no lock owner
> info to pass back, obj->len == 0.
>
> Fixes: a6a63ca5652e ("lockd: Common NLM XDR helpers")
> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
This seems like 5.15-rc material, so I will apply it to my -rc branch
once review is complete.
> ---
> fs/lockd/svcxdr.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/lockd/svcxdr.h b/fs/lockd/svcxdr.h
> index c69a0bb76c94..04fde20ea8c1 100644
> --- a/fs/lockd/svcxdr.h
> +++ b/fs/lockd/svcxdr.h
> @@ -139,6 +139,8 @@ svcxdr_encode_owner(struct xdr_stream *xdr, const struct xdr_netobj *obj)
>
> if (xdr_stream_encode_u32(xdr, obj->len) < 0)
> return false;
> + if (obj->len == 0)
> + return true;
> p = xdr_reserve_space(xdr, obj->len);
> if (!p)
> return false;
> --
> 2.9.5
>
--
Chuck Lever
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-15 21:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15 21:33 [PATCH 1/1] lockd: crashes in svcxdr_encode_owner Dai Ngo
2021-09-15 21:44 ` Chuck Lever III
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.