All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: "David Härdeman" <david@hardeman.nu>
Cc: linux-input@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [RFC3] Teach drivers/media/IR/ir-raw-event.c to use durations
Date: Thu, 08 Apr 2010 09:21:17 -0300	[thread overview]
Message-ID: <4BBDCA3D.3000106@infradead.org> (raw)
In-Reply-To: <20100408113910.GA17104@hardeman.nu>

David Härdeman wrote:
> drivers/media/IR/ir-raw-event.c is currently written with the assumption 
> that all "raw" hardware will generate events only on state change (i.e.  
> when a pulse or space starts).
> 
> However, some hardware (like mceusb, probably the most popular IR receiver
> out there) only generates duration data (and that data is buffered so using
> any kind of timing on the data is futile).
> 
> Furthermore, using signed int's to represent pulse/space durations in ms
> is a well-known approach to anyone with experience in writing ir decoders.
> 
> This patch (which has been tested this time) is still a RFC on my proposed
> interface changes.
> 
> Changes since last version:
> 
> o s64's are used to represent pulse/space durations in ns.
> 
> o Lots of #defines are used in the decoders
> 
> o Refreshed to apply cleanly on top of Mauro's current git tree
> 
> o Jon's comments wrt. interrupt-context safe functions have been added
> 

Ok, tested it with a variety of NEC/NEC extended/RC-5 IR's I have, with the
saa7134 hardware. All worked.

There's just a few checkpatch.pl complains, and the most important thing:

It lacks your SOB ;)

Please fix the checkpatch.pl errors, add a kfifo size comment and your SOB
and resend it to me (or, if you prefer, just send your SOB. I can take care
of the rest, as they're just trivial things).

-- 

Cheers,
Mauro

WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: "David Härdeman" <david@hardeman.nu>
Cc: linux-input@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [RFC3] Teach drivers/media/IR/ir-raw-event.c to use durations
Date: Thu, 08 Apr 2010 09:21:17 -0300	[thread overview]
Message-ID: <4BBDCA3D.3000106@infradead.org> (raw)
In-Reply-To: <20100408113910.GA17104@hardeman.nu>

David Härdeman wrote:
> drivers/media/IR/ir-raw-event.c is currently written with the assumption 
> that all "raw" hardware will generate events only on state change (i.e.  
> when a pulse or space starts).
> 
> However, some hardware (like mceusb, probably the most popular IR receiver
> out there) only generates duration data (and that data is buffered so using
> any kind of timing on the data is futile).
> 
> Furthermore, using signed int's to represent pulse/space durations in ms
> is a well-known approach to anyone with experience in writing ir decoders.
> 
> This patch (which has been tested this time) is still a RFC on my proposed
> interface changes.
> 
> Changes since last version:
> 
> o s64's are used to represent pulse/space durations in ns.
> 
> o Lots of #defines are used in the decoders
> 
> o Refreshed to apply cleanly on top of Mauro's current git tree
> 
> o Jon's comments wrt. interrupt-context safe functions have been added
> 

Ok, tested it with a variety of NEC/NEC extended/RC-5 IR's I have, with the
saa7134 hardware. All worked.

There's just a few checkpatch.pl complains, and the most important thing:

It lacks your SOB ;)

Please fix the checkpatch.pl errors, add a kfifo size comment and your SOB
and resend it to me (or, if you prefer, just send your SOB. I can take care
of the rest, as they're just trivial things).

-- 

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-04-08 12:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08 11:39 [RFC3] Teach drivers/media/IR/ir-raw-event.c to use durations David Härdeman
2010-04-08 12:01 ` Mauro Carvalho Chehab
2010-04-08 12:21 ` Mauro Carvalho Chehab [this message]
2010-04-08 12:21   ` Mauro Carvalho Chehab
2010-04-09 11:25 ` Andy Walls
2010-04-09 12:31   ` Jon Smirl
2010-04-09 14:00     ` Mauro Carvalho Chehab
2010-04-09 15:14       ` Jon Smirl
2010-04-09 15:14         ` Jon Smirl
2010-04-09 20:44       ` Found NEC IR specification in NEC uPD6122 datasheet (Re: [RFC3] Teach drivers/media/IR/ir-raw-event.c to use durations) Andy Walls
2010-04-10  6:48       ` [RFC3] Teach drivers/media/IR/ir-raw-event.c to use durations David Härdeman
2010-04-10  6:48         ` David Härdeman
2010-04-10 11:56         ` Andy Walls
2010-04-10 12:10           ` Mauro Carvalho Chehab
2010-04-10 12:34             ` Andy Walls
2010-04-10 12:16         ` Jon Smirl
2010-04-10  0:35   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BBDCA3D.3000106@infradead.org \
    --to=mchehab@infradead.org \
    --cc=david@hardeman.nu \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.