All of lore.kernel.org
 help / color / mirror / Atom feed
* PATCH: ni_labpc_cs.c
@ 2010-03-03  5:41 Jakob Penzien
  2010-03-03  7:21 ` PATCH: ni_labpc_cs.c 2 Jakob Penzien
  2010-04-09 20:22 ` Jakob Penzien
  0 siblings, 2 replies; 5+ messages in thread
From: Jakob Penzien @ 2010-03-03  5:41 UTC (permalink / raw)
  To: gregkh, wfp5p, bart, linux, keil, devel, linux-kernel

>From b8eff3ab872920c733981fa475220c0b6169d058 Mon Sep 17 00:00:00 2001
From: Jakob Penzien <jakob@bloodmoon.(none)>
Date: Wed, 3 Mar 2010 00:31:24 -0500
Subject: [PATCH 2/2] Staging: Comedi: fix 80 character and KERN
coding style issue in ni_labpc_cs.c
 This is a patch to the ni_labpc_cs.c file that fixes up the 80
character and KERN
 warning found by the checkpoint.pl tool
 Signed-off-by: Jakob Penzien <Supermine290@gmail.com>

---
 drivers/staging/comedi/drivers/ni_labpc_cs.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_labpc_cs.c
b/drivers/staging/comedi/drivers/ni_labpc_cs.c
index 0b963bb..07d7bf9 100644
--- a/drivers/staging/comedi/drivers/ni_labpc_cs.c
+++ b/drivers/staging/comedi/drivers/ni_labpc_cs.c
@@ -1,7 +1,8 @@
 /*
     comedi/drivers/ni_labpc_cs.c
     Driver for National Instruments daqcard-1200 boards
-    Copyright (C) 2001, 2002, 2003 Frank Mori Hess
<fmhess@users.sourceforge.net>
+    Copyright (C) 2001, 2002, 2003 Frank Mori Hess
+    <fmhess@users.sourceforge.net>

     PCMCIA crap is adapted from dummy_cs.c 1.31 2001/08/24 12:13:13
     from the pcmcia package.
@@ -146,7 +147,7 @@ static int labpc_attach(struct comedi_device
*dev, struct comedi_devconfig *it)
 		irq = link->irq.AssignedIRQ;
 		break;
 	default:
-		printk("bug! couldn't determine board type\n");
+		printk(KERN_ERR"bug! couldn't determine board type\n");
 		return -EINVAL;
 		break;
 	}
-- 
1.6.3.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: PATCH: ni_labpc_cs.c 2
  2010-03-03  5:41 PATCH: ni_labpc_cs.c Jakob Penzien
@ 2010-03-03  7:21 ` Jakob Penzien
  2010-04-08 19:16   ` Greg KH
  2010-04-09 20:22 ` Jakob Penzien
  1 sibling, 1 reply; 5+ messages in thread
From: Jakob Penzien @ 2010-03-03  7:21 UTC (permalink / raw)
  To: gregkh, wfp5p, bart, linux, keil, devel, linux-kernel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

- From b8eff3ab872920c733981fa475220c0b6169d058 Mon Sep 17 00:00:00 2001
From: Jakob Penzien <jakob@bloodmoon.(none)>
Date: Wed, 3 Mar 2010 00:31:24 -0500
Subject: [PATCH 2/2] Staging: Comedi: fix 80 character and KERN
coding style issue in ni_labpc_cs.c
 This is a patch to the ni_labpc_cs.c file that fixes up the 80
character and KERN
 warning found by the checkpoint.pl tool. Changed the spaceing
between KERN and ".
 Signed-off-by: Jakob Penzien <Supermine290@gmail.com>

- ---
 drivers/staging/comedi/drivers/ni_labpc_cs.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_labpc_cs.c
b/drivers/staging/comedi/drivers/ni_labpc_cs.c
index 0b963bb..07d7bf9 100644
- --- a/drivers/staging/comedi/drivers/ni_labpc_cs.c
+++ b/drivers/staging/comedi/drivers/ni_labpc_cs.c
@@ -1,7 +1,8 @@
 /*
     comedi/drivers/ni_labpc_cs.c
     Driver for National Instruments daqcard-1200 boards
- -    Copyright (C) 2001, 2002, 2003 Frank Mori Hess
<fmhess@users.sourceforge.net>
+    Copyright (C) 2001, 2002, 2003 Frank Mori Hess
+    <fmhess@users.sourceforge.net>

     PCMCIA crap is adapted from dummy_cs.c 1.31 2001/08/24 12:13:13
     from the pcmcia package.
@@ -146,7 +147,7 @@ static int labpc_attach(struct comedi_device
*dev, struct comedi_devconfig *it)
 		irq = link->irq.AssignedIRQ;
 		break;
 	default:
- -		printk("bug! couldn't determine board type\n");
+		printk(KERN_ERR "bug! couldn't determine board type\n");
 		return -EINVAL;
 		break;
 	}
- --
1.6.3.3
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkuODfoACgkQRHWk8kRA7BAM1QCeKMICZDu19e8DQfyS4UsSRn62
+jUAoIJ91y4SRk+S7+eXALvP/2hB1Vm0
=OYrU
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: PATCH: ni_labpc_cs.c 2
  2010-03-03  7:21 ` PATCH: ni_labpc_cs.c 2 Jakob Penzien
@ 2010-04-08 19:16   ` Greg KH
  0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2010-04-08 19:16 UTC (permalink / raw)
  To: Jakob Penzien; +Cc: gregkh, wfp5p, bart, linux, keil, devel, linux-kernel

On Wed, Mar 03, 2010 at 02:21:34AM -0500, Jakob Penzien wrote:
> From b8eff3ab872920c733981fa475220c0b6169d058 Mon Sep 17 00:00:00 2001
> From: Jakob Penzien <jakob@bloodmoon.(none)>

I don't think that's your email address :)

And it's signed, and can't be applied :(

Care to try again?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: PATCH: ni_labpc_cs.c 2
  2010-03-03  5:41 PATCH: ni_labpc_cs.c Jakob Penzien
  2010-03-03  7:21 ` PATCH: ni_labpc_cs.c 2 Jakob Penzien
@ 2010-04-09 20:22 ` Jakob Penzien
  2010-04-27 22:21   ` Greg KH
  1 sibling, 1 reply; 5+ messages in thread
From: Jakob Penzien @ 2010-04-09 20:22 UTC (permalink / raw)
  To: gregkh, wfp5p, bart, linux, keil, devel, linux-kernel

From: Jakob Penzien <jwpenzie@mtu.edu>
Date: Wed, 3 Mar 2010 00:31:24 -0500
Subject: [PATCH 2/2] Staging: Comedi: fix 80 character and KERN
coding style issue in ni_labpc_cs.c
 This is a patch to the ni_labpc_cs.c file that fixes up the 80
character and KERN
 warning found by the checkpoint.pl tool. Changed the spaceing
between KERN and ".
 Signed-off-by: Jakob Penzien <Supermine290@gmail.com>

---
 drivers/staging/comedi/drivers/ni_labpc_cs.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_labpc_cs.c
b/drivers/staging/comedi/drivers/ni_labpc_cs.c
index 0b963bb..07d7bf9 100644
--- a/drivers/staging/comedi/drivers/ni_labpc_cs.c
+++ b/drivers/staging/comedi/drivers/ni_labpc_cs.c
@@ -1,7 +1,8 @@
 /*
     comedi/drivers/ni_labpc_cs.c
     Driver for National Instruments daqcard-1200 boards
-    Copyright (C) 2001, 2002, 2003 Frank Mori Hess
<fmhess@users.sourceforge.net>
+    Copyright (C) 2001, 2002, 2003 Frank Mori Hess
+    <fmhess@users.sourceforge.net>

     PCMCIA crap is adapted from dummy_cs.c 1.31 2001/08/24 12:13:13
     from the pcmcia package.
@@ -146,7 +147,7 @@ static int labpc_attach(struct comedi_device
*dev, struct comedi_devconfig *it)
 		irq = link->irq.AssignedIRQ;
 		break;
 	default:
-		printk("bug! couldn't determine board type\n");
+		printk(KERN_ERR "bug! couldn't determine board type\n");
 		return -EINVAL;
 		break;
 	}


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: PATCH: ni_labpc_cs.c 2
  2010-04-09 20:22 ` Jakob Penzien
@ 2010-04-27 22:21   ` Greg KH
  0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2010-04-27 22:21 UTC (permalink / raw)
  To: Jakob Penzien; +Cc: gregkh, wfp5p, bart, linux, keil, devel, linux-kernel

On Fri, Apr 09, 2010 at 04:22:14PM -0400, Jakob Penzien wrote:
> From: Jakob Penzien <jwpenzie@mtu.edu>
> Date: Wed, 3 Mar 2010 00:31:24 -0500
> Subject: [PATCH 2/2] Staging: Comedi: fix 80 character and KERN
> coding style issue in ni_labpc_cs.c
>  This is a patch to the ni_labpc_cs.c file that fixes up the 80
> character and KERN
>  warning found by the checkpoint.pl tool. Changed the spaceing
> between KERN and ".
>  Signed-off-by: Jakob Penzien <Supermine290@gmail.com>

This patch was line-wrapped :(

Also, it was already fixed up by someone else before you :(

sorry,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-04-27 22:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-03  5:41 PATCH: ni_labpc_cs.c Jakob Penzien
2010-03-03  7:21 ` PATCH: ni_labpc_cs.c 2 Jakob Penzien
2010-04-08 19:16   ` Greg KH
2010-04-09 20:22 ` Jakob Penzien
2010-04-27 22:21   ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.