[Patch 1/8] CLD: cleanup: add cld_msg_rpc.x

[Patch 1/8] CLD: cleanup: add cld_msg_rpc.x

[Pete Zaitcev]

You know what's weird... Without this, I cannot build an RPM at all,
the rpmbuild complains about unpackaged files and aborts. But
everyone else seems to have no problem? Strange. BTW, I am on
Fedora 14.

Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>

---
 lib/Makefile.am |    1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/Makefile.am b/lib/Makefile.am
index ea72426..012d558 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -27,6 +27,7 @@ libcldc_la_SOURCES	=	\
 	common.c		\
 	libtimer.c		\
 	pkt.c			\
+	cld_msg_rpc.x		\
 	cld_msg_rpc_xdr.c
 
 libcldc_la_LDFLAGS = \

Re: [Patch 1/8] CLD: cleanup: add cld_msg_rpc.x

[Jeff Garzik]

On 04/14/2010 02:33 PM, Pete Zaitcev wrote:
> You know what's weird... Without this, I cannot build an RPM at all,
> the rpmbuild complains about unpackaged files and aborts. But
> everyone else seems to have no problem? Strange. BTW, I am on
> Fedora 14.
>
> Signed-off-by: Pete Zaitcev<zaitcev@redhat.com>
>
> ---
>   lib/Makefile.am |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/lib/Makefile.am b/lib/Makefile.am
> index ea72426..012d558 100644
> --- a/lib/Makefile.am
> +++ b/lib/Makefile.am
> @@ -27,6 +27,7 @@ libcldc_la_SOURCES	=	\
>   	common.c		\
>   	libtimer.c		\
>   	pkt.c			\
> +	cld_msg_rpc.x		\
>   	cld_msg_rpc_xdr.c

that's quite strange, because I built an official rawhide copy just fine 
without this...

Maybe you can try the SRPM from the koji build?

	http://koji.fedoraproject.org/koji/taskinfo?taskID=2114193

May I presume you are using "make distcheck" to generate the tarball for 
your custom RPMs?

	Jeff

Re: [Patch 1/8] CLD: cleanup: add cld_msg_rpc.x

[Pete Zaitcev]

On Wed, 14 Apr 2010 15:55:01 -0400
Jeff Garzik <jeff@garzik.org> wrote:

> > +++ b/lib/Makefile.am
> > @@ -27,6 +27,7 @@ libcldc_la_SOURCES	=	\
> >   	common.c		\
> >   	libtimer.c		\
> >   	pkt.c			\
> > +	cld_msg_rpc.x		\
> >   	cld_msg_rpc_xdr.c
> 
> that's quite strange, because I built an official rawhide copy just fine 
> without this...

Strange indeed, I re-checked and it went away now. Oh well.

> May I presume you are using "make distcheck" to generate the tarball for 
> your custom RPMs?

Of course.

-- Pete

Re: [Patch 1/8] CLD: cleanup: add cld_msg_rpc.x

[Jeff Garzik]

On 04/16/2010 10:18 PM, Pete Zaitcev wrote:
> On Wed, 14 Apr 2010 15:55:01 -0400
> Jeff Garzik<jeff@garzik.org>  wrote:
>
>>> +++ b/lib/Makefile.am
>>> @@ -27,6 +27,7 @@ libcldc_la_SOURCES	=	\
>>>    	common.c		\
>>>    	libtimer.c		\
>>>    	pkt.c			\
>>> +	cld_msg_rpc.x		\
>>>    	cld_msg_rpc_xdr.c
>>
>> that's quite strange, because I built an official rawhide copy just fine
>> without this...
>
> Strange indeed, I re-checked and it went away now. Oh well.

I wonder if it's a problem with the 'clean' functionality.  The 
EXTRA_DIST line contains a list of things forced to be included in the 
tarball, typically used for things not contained in *_SOURCES.  AFAICT 
from the autoconf/automake docs, that is where sources for generated 
sources[1] should reside.  So I still wonder how it disappeared for you...

	Jeff




[1] Brought to you by the Department of Redundant Redundancies