* Using xen-netfront in dom0
@ 2010-04-19 8:26 Rafal Wojtczuk
2010-04-19 17:15 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 2+ messages in thread
From: Rafal Wojtczuk @ 2010-04-19 8:26 UTC (permalink / raw)
To: xen-devel; +Cc: qubes-devel
Hello,
In xen-netfront.c, there is an explicit check if we are running in dom0, and
if so, skip initialization:
http://git.kernel.org/?p=linux/kernel/git/jeremy/xen.git;a=blob;f=drivers/net/xen-netfront.c;h=ee7465a7a2a9fa563f44a470bdad1911e175d1ad;hb=xen/stable-2.6.32.x#l1807
But if using a driver domain (with a NIC assigned), then definitely there is
a need to run xen-netfront in dom0. In fact, commenting out the
xen_initial_domain() check makes it work fine with a driver domain.
Is there any reason for this check, besides obviously false assumption
"nobody needs it in dom0" ? On a related note, there seems to be no such
check in xen-blkfront.c.
If there are no disadvantages, I would vote for removal of the
xen_initial_domain() check; otherwise, can we have a module parameter
"allow_dom0" ?
Regards,
Rafal Wojtczuk
The Qubes OS Project
http://qubes-os.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Using xen-netfront in dom0
2010-04-19 8:26 Using xen-netfront in dom0 Rafal Wojtczuk
@ 2010-04-19 17:15 ` Jeremy Fitzhardinge
0 siblings, 0 replies; 2+ messages in thread
From: Jeremy Fitzhardinge @ 2010-04-19 17:15 UTC (permalink / raw)
To: Rafal Wojtczuk; +Cc: xen-devel, qubes-devel
On 04/19/2010 01:26 AM, Rafal Wojtczuk wrote:
> Is there any reason for this check, besides obviously false assumption
> "nobody needs it in dom0" ? On a related note, there seems to be no such
> check in xen-blkfront.c.
>
> If there are no disadvantages, I would vote for removal of the
> xen_initial_domain() check; otherwise, can we have a module parameter
> "allow_dom0" ?
>
No, I think its probably fine to remove the check. Presumably if the
driver is modular it would never get loaded in a normal dom0 case
anyway? And in the non-modular case, an initialized but unused driver
shouldn't take much memory (and if it does, that should be fixed).
J
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-19 17:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-19 8:26 Using xen-netfront in dom0 Rafal Wojtczuk
2010-04-19 17:15 ` Jeremy Fitzhardinge
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.