* [PATCH] tm6000: bugfix image position
@ 2010-05-07 15:29 stefan.ringel
2010-05-07 15:46 ` Stefan Ringel
0 siblings, 1 reply; 4+ messages in thread
From: stefan.ringel @ 2010-05-07 15:29 UTC (permalink / raw)
To: linux-media; +Cc: mchehab, Stefan Ringel
From: Stefan Ringel <stefan.ringel@arcor.de>
bugfix incorrect image and line position in videobuffer
Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
---
drivers/staging/tm6000/tm6000-video.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/tm6000/tm6000-video.c b/drivers/staging/tm6000/tm6000-video.c
index 9554472..f7248f0 100644
--- a/drivers/staging/tm6000/tm6000-video.c
+++ b/drivers/staging/tm6000/tm6000-video.c
@@ -223,8 +223,8 @@ static int copy_packet(struct urb *urb, u32 header, u8 **ptr, u8 *endp,
* It should, instead, check if the user selected
* entrelaced or non-entrelaced mode
*/
- pos= ((line<<1)+field)*linewidth +
- block*TM6000_URB_MSG_LEN;
+ pos = ((line << 1) - field - 1) * linewidth +
+ block * TM6000_URB_MSG_LEN;
/* Don't allow to write out of the buffer */
if (pos+TM6000_URB_MSG_LEN > (*buf)->vb.size) {
--
1.7.0.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tm6000: bugfix image position
2010-05-07 15:29 [PATCH] tm6000: bugfix image position stefan.ringel
@ 2010-05-07 15:46 ` Stefan Ringel
2010-05-07 18:17 ` Bee Hock Goh
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Ringel @ 2010-05-07 15:46 UTC (permalink / raw)
To: stefan.ringel; +Cc: linux-media, mchehab
Am 07.05.2010 17:29, schrieb stefan.ringel@arcor.de:
> From: Stefan Ringel <stefan.ringel@arcor.de>
>
> bugfix incorrect image and line position in videobuffer
>
>
> Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
> ---
> drivers/staging/tm6000/tm6000-video.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/tm6000/tm6000-video.c b/drivers/staging/tm6000/tm6000-video.c
> index 9554472..f7248f0 100644
> --- a/drivers/staging/tm6000/tm6000-video.c
> +++ b/drivers/staging/tm6000/tm6000-video.c
> @@ -223,8 +223,8 @@ static int copy_packet(struct urb *urb, u32 header, u8 **ptr, u8 *endp,
> * It should, instead, check if the user selected
> * entrelaced or non-entrelaced mode
> */
> - pos= ((line<<1)+field)*linewidth +
> - block*TM6000_URB_MSG_LEN;
> + pos = ((line << 1) - field - 1) * linewidth +
> + block * TM6000_URB_MSG_LEN;
>
> /* Don't allow to write out of the buffer */
> if (pos+TM6000_URB_MSG_LEN > (*buf)->vb.size) {
>
http://www.stefanringel.de/pub/tm6000_image_07_05_2010.jpg
--
Stefan Ringel <stefan.ringel@arcor.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tm6000: bugfix image position
2010-05-07 15:46 ` Stefan Ringel
@ 2010-05-07 18:17 ` Bee Hock Goh
2010-05-07 18:37 ` Stefan Ringel
0 siblings, 1 reply; 4+ messages in thread
From: Bee Hock Goh @ 2010-05-07 18:17 UTC (permalink / raw)
To: Stefan Ringel; +Cc: linux-media, mchehab
Stefan,
This fix the ugly green line on the top.
btw, do you notice that there seem to be black gap on the left and
right of the screen?
On Fri, May 7, 2010 at 11:46 PM, Stefan Ringel <stefan.ringel@arcor.de> wrote:
> Am 07.05.2010 17:29, schrieb stefan.ringel@arcor.de:
>> From: Stefan Ringel <stefan.ringel@arcor.de>
>>
>> bugfix incorrect image and line position in videobuffer
>>
>>
>> Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
>> ---
>> drivers/staging/tm6000/tm6000-video.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/tm6000/tm6000-video.c b/drivers/staging/tm6000/tm6000-video.c
>> index 9554472..f7248f0 100644
>> --- a/drivers/staging/tm6000/tm6000-video.c
>> +++ b/drivers/staging/tm6000/tm6000-video.c
>> @@ -223,8 +223,8 @@ static int copy_packet(struct urb *urb, u32 header, u8 **ptr, u8 *endp,
>> * It should, instead, check if the user selected
>> * entrelaced or non-entrelaced mode
>> */
>> - pos= ((line<<1)+field)*linewidth +
>> - block*TM6000_URB_MSG_LEN;
>> + pos = ((line << 1) - field - 1) * linewidth +
>> + block * TM6000_URB_MSG_LEN;
>>
>> /* Don't allow to write out of the buffer */
>> if (pos+TM6000_URB_MSG_LEN > (*buf)->vb.size) {
>>
>
>
> http://www.stefanringel.de/pub/tm6000_image_07_05_2010.jpg
>
> --
> Stefan Ringel <stefan.ringel@arcor.de>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tm6000: bugfix image position
2010-05-07 18:17 ` Bee Hock Goh
@ 2010-05-07 18:37 ` Stefan Ringel
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Ringel @ 2010-05-07 18:37 UTC (permalink / raw)
To: Bee Hock Goh; +Cc: linux-media, mchehab
Am 07.05.2010 20:17, schrieb Bee Hock Goh:
> Stefan,
>
> This fix the ugly green line on the top.
>
> btw, do you notice that there seem to be black gap on the left and
> right of the screen?
>
Have you seen my picture? I corrected that field inverted is, ergo line
1 field 1 is line 0, line 1 field 0 is line 1, line 2 field 1 is line 2,
line 2 field 0 is line 3 ... . I have not wrote from the black gap -
that is video calibration! And what for ugly green line, what I have is
a green code and that is normal!
> On Fri, May 7, 2010 at 11:46 PM, Stefan Ringel <stefan.ringel@arcor.de> wrote:
>
>> Am 07.05.2010 17:29, schrieb stefan.ringel@arcor.de:
>>
>>> From: Stefan Ringel <stefan.ringel@arcor.de>
>>>
>>> bugfix incorrect image and line position in videobuffer
>>>
>>>
>>> Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
>>> ---
>>> drivers/staging/tm6000/tm6000-video.c | 4 ++--
>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/staging/tm6000/tm6000-video.c b/drivers/staging/tm6000/tm6000-video.c
>>> index 9554472..f7248f0 100644
>>> --- a/drivers/staging/tm6000/tm6000-video.c
>>> +++ b/drivers/staging/tm6000/tm6000-video.c
>>> @@ -223,8 +223,8 @@ static int copy_packet(struct urb *urb, u32 header, u8 **ptr, u8 *endp,
>>> * It should, instead, check if the user selected
>>> * entrelaced or non-entrelaced mode
>>> */
>>> - pos= ((line<<1)+field)*linewidth +
>>> - block*TM6000_URB_MSG_LEN;
>>> + pos = ((line << 1) - field - 1) * linewidth +
>>> + block * TM6000_URB_MSG_LEN;
>>>
>>> /* Don't allow to write out of the buffer */
>>> if (pos+TM6000_URB_MSG_LEN > (*buf)->vb.size) {
>>>
>>>
>>
>> http://www.stefanringel.de/pub/tm6000_image_07_05_2010.jpg
>>
>> --
>> Stefan Ringel <stefan.ringel@arcor.de>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Stefan Ringel <stefan.ringel@arcor.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-05-07 18:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-05-07 15:29 [PATCH] tm6000: bugfix image position stefan.ringel
2010-05-07 15:46 ` Stefan Ringel
2010-05-07 18:17 ` Bee Hock Goh
2010-05-07 18:37 ` Stefan Ringel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.