All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute LED
@ 2010-05-29  1:23 Joey Lee
  2010-05-29 19:47 ` [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute LED support on HP mini Takashi Iwai
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Joey Lee @ 2010-05-29  1:23 UTC (permalink / raw)
  To: linux-sound

[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]

Hi Takashi, 

The attached is my patch to 

Add 92HD81B1X5 subsystem id 0x103c1584 to stac92hd83xxx_cfg_tbl[] for
mute LED support on HP mini.

Please kindly help review it.


Thank's a lot!
Joey Lee


Add 92HD81B1X5 subsystem id 0x103c1584 to stac92hd83xxx_cfg_tbl[] for
mute LED support on HP mini.

Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
---
 sound/pci/hda/patch_sigmatel.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/sound/pci/hda/patch_sigmatel.c
b/sound/pci/hda/patch_sigmatel.c
index f1e7bab..18b75bd 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -1655,6 +1655,8 @@ static struct snd_pci_quirk
stac92hd83xxx_cfg_tbl[] = {
                      "unknown Dell", STAC_DELL_S14),
        SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
                      "HP", STAC_92HD83XXX_HP),
+       SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x1500,
+                       "HP", STAC_92HD83XXX_HP),
        {} /* terminator */
 };

-- 
1.6.0.2


[-- Attachment #2: Add-92HD81B1X5-to-stac92hd83xxx_cfg_tbl-for-mute-L.patch --]
[-- Type: text/plain, Size: 1026 bytes --]

From e32ef26f88d2a2217ce70e5a04bf5c1d9973649e Mon Sep 17 00:00:00 2001
From: Lee, Chun-Yi <jlee@novell.com>
Date: Thu, 27 May 2010 19:52:47 +0800
Subject: [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute LED support on HP mini

Add 92HD81B1X5 subsystem id 0x103c1584 to stac92hd83xxx_cfg_tbl[] for
mute LED support on HP mini.

Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
---
 sound/pci/hda/patch_sigmatel.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index f1e7bab..18b75bd 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -1655,6 +1655,8 @@ static struct snd_pci_quirk stac92hd83xxx_cfg_tbl[] = {
 		      "unknown Dell", STAC_DELL_S14),
 	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
 		      "HP", STAC_92HD83XXX_HP),
+	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x1500,
+			"HP", STAC_92HD83XXX_HP),
 	{} /* terminator */
 };
 
-- 
1.6.0.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute LED  support on HP mini
  2010-05-29  1:23 [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute LED Joey Lee
@ 2010-05-29 19:47 ` Takashi Iwai
  2010-05-30  0:52 ` [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute Joey Lee
  2010-05-31  4:34 ` Joey Lee
  2 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2010-05-29 19:47 UTC (permalink / raw)
  To: linux-sound

At Sat, 29 May 2010 03:23:50 +0200,
Joey Lee wrote:
> 
> Hi Takashi, 
> 
> The attached is my patch to 
> 
> Add 92HD81B1X5 subsystem id 0x103c1584 to stac92hd83xxx_cfg_tbl[] for
> mute LED support on HP mini.
> 
> Please kindly help review it.
> 
> 
> Thank's a lot!
> Joey Lee
> 
> 
> Add 92HD81B1X5 subsystem id 0x103c1584 to stac92hd83xxx_cfg_tbl[] for
> mute LED support on HP mini.
> 
> Signed-off-by: Lee, Chun-Yi <jlee@novell.com>

2.6.34 driver should work without this quirk.  Could you check?


thanks,

Takashi

> ---
>  sound/pci/hda/patch_sigmatel.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_sigmatel.c
> b/sound/pci/hda/patch_sigmatel.c
> index f1e7bab..18b75bd 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -1655,6 +1655,8 @@ static struct snd_pci_quirk
> stac92hd83xxx_cfg_tbl[] = {
>                       "unknown Dell", STAC_DELL_S14),
>         SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
>                       "HP", STAC_92HD83XXX_HP),
> +       SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x1500,
> +                       "HP", STAC_92HD83XXX_HP),
>         {} /* terminator */
>  };
> 
> -- 
> 1.6.0.2
> 
> [2 Add-92HD81B1X5-to-stac92hd83xxx_cfg_tbl-for-mute-L.patch <text/plain (quoted-printable)>]
> >From e32ef26f88d2a2217ce70e5a04bf5c1d9973649e Mon Sep 17 00:00:00 2001
> From: Lee, Chun-Yi <jlee@novell.com>
> Date: Thu, 27 May 2010 19:52:47 +0800
> Subject: [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute LED support on HP mini
> 
> Add 92HD81B1X5 subsystem id 0x103c1584 to stac92hd83xxx_cfg_tbl[] for
> mute LED support on HP mini.
> 
> Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
> ---
>  sound/pci/hda/patch_sigmatel.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index f1e7bab..18b75bd 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -1655,6 +1655,8 @@ static struct snd_pci_quirk stac92hd83xxx_cfg_tbl[] = {
>  		      "unknown Dell", STAC_DELL_S14),
>  	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
>  		      "HP", STAC_92HD83XXX_HP),
> +	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x1500,
> +			"HP", STAC_92HD83XXX_HP),
>  	{} /* terminator */
>  };
>  
> -- 
> 1.6.0.2
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute
  2010-05-29  1:23 [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute LED Joey Lee
  2010-05-29 19:47 ` [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute LED support on HP mini Takashi Iwai
@ 2010-05-30  0:52 ` Joey Lee
  2010-05-31  4:34 ` Joey Lee
  2 siblings, 0 replies; 4+ messages in thread
From: Joey Lee @ 2010-05-30  0:52 UTC (permalink / raw)
  To: linux-sound

Hi Takashi, 

於 六,2010-05-29 於 21:47 +0200,Takashi Iwai 提到:
> At Sat, 29 May 2010 03:23:50 +0200,
> Joey Lee wrote:
> > 
> > Hi Takashi, 
> > 
> > The attached is my patch to 
> > 
> > Add 92HD81B1X5 subsystem id 0x103c1584 to stac92hd83xxx_cfg_tbl[] for
> > mute LED support on HP mini.
> > 
> > Please kindly help review it.
> > 
> > 
> > Thank's a lot!
> > Joey Lee
> > 
> > 
> > Add 92HD81B1X5 subsystem id 0x103c1584 to stac92hd83xxx_cfg_tbl[] for
> > mute LED support on HP mini.
> > 
> > Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
> 
> 2.6.34 driver should work without this quirk.  Could you check?
> 

Yes, I didn't check the 2.6.34, I will do that.



Thank's a lot!
Joey Lee

> 
> > ---
> >  sound/pci/hda/patch_sigmatel.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/sound/pci/hda/patch_sigmatel.c
> > b/sound/pci/hda/patch_sigmatel.c
> > index f1e7bab..18b75bd 100644
> > --- a/sound/pci/hda/patch_sigmatel.c
> > +++ b/sound/pci/hda/patch_sigmatel.c
> > @@ -1655,6 +1655,8 @@ static struct snd_pci_quirk
> > stac92hd83xxx_cfg_tbl[] = {
> >                       "unknown Dell", STAC_DELL_S14),
> >         SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
> >                       "HP", STAC_92HD83XXX_HP),
> > +       SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x1500,
> > +                       "HP", STAC_92HD83XXX_HP),
> >         {} /* terminator */
> >  };
> > 
> > -- 
> > 1.6.0.2
> > 
> > [2 Add-92HD81B1X5-to-stac92hd83xxx_cfg_tbl-for-mute-L.patch <text/plain (quoted-printable)>]
> > >From e32ef26f88d2a2217ce70e5a04bf5c1d9973649e Mon Sep 17 00:00:00 2001
> > From: Lee, Chun-Yi <jlee@novell.com>
> > Date: Thu, 27 May 2010 19:52:47 +0800
> > Subject: [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute LED support on HP mini
> > 
> > Add 92HD81B1X5 subsystem id 0x103c1584 to stac92hd83xxx_cfg_tbl[] for
> > mute LED support on HP mini.
> > 
> > Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
> > ---
> >  sound/pci/hda/patch_sigmatel.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> > index f1e7bab..18b75bd 100644
> > --- a/sound/pci/hda/patch_sigmatel.c
> > +++ b/sound/pci/hda/patch_sigmatel.c
> > @@ -1655,6 +1655,8 @@ static struct snd_pci_quirk stac92hd83xxx_cfg_tbl[] = {
> >  		      "unknown Dell", STAC_DELL_S14),
> >  	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
> >  		      "HP", STAC_92HD83XXX_HP),
> > +	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x1500,
> > +			"HP", STAC_92HD83XXX_HP),
> >  	{} /* terminator */
> >  };
> >  
> > -- 
> > 1.6.0.2
> > 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute
  2010-05-29  1:23 [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute LED Joey Lee
  2010-05-29 19:47 ` [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute LED support on HP mini Takashi Iwai
  2010-05-30  0:52 ` [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute Joey Lee
@ 2010-05-31  4:34 ` Joey Lee
  2 siblings, 0 replies; 4+ messages in thread
From: Joey Lee @ 2010-05-31  4:34 UTC (permalink / raw)
  To: linux-sound

Hi Takashi, 

Yes, you are right! 
I just check the newest 2.6.34 drvier, it works fine and don't need this
quirk.


Thank's a lot!
Joey Lee

於 六,2010-05-29 於 21:47 +0200,Takashi Iwai 提到:
> At Sat, 29 May 2010 03:23:50 +0200,
> Joey Lee wrote:
> > 
> > Hi Takashi, 
> > 
> > The attached is my patch to 
> > 
> > Add 92HD81B1X5 subsystem id 0x103c1584 to stac92hd83xxx_cfg_tbl[] for
> > mute LED support on HP mini.
> > 
> > Please kindly help review it.
> > 
> > 
> > Thank's a lot!
> > Joey Lee
> > 
> > 
> > Add 92HD81B1X5 subsystem id 0x103c1584 to stac92hd83xxx_cfg_tbl[] for
> > mute LED support on HP mini.
> > 
> > Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
> 
> 2.6.34 driver should work without this quirk.  Could you check?
> 
> 
> thanks,
> 
> Takashi
> 
> > ---
> >  sound/pci/hda/patch_sigmatel.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/sound/pci/hda/patch_sigmatel.c
> > b/sound/pci/hda/patch_sigmatel.c
> > index f1e7bab..18b75bd 100644
> > --- a/sound/pci/hda/patch_sigmatel.c
> > +++ b/sound/pci/hda/patch_sigmatel.c
> > @@ -1655,6 +1655,8 @@ static struct snd_pci_quirk
> > stac92hd83xxx_cfg_tbl[] = {
> >                       "unknown Dell", STAC_DELL_S14),
> >         SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
> >                       "HP", STAC_92HD83XXX_HP),
> > +       SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x1500,
> > +                       "HP", STAC_92HD83XXX_HP),
> >         {} /* terminator */
> >  };
> > 
> > -- 
> > 1.6.0.2
> > 
> > [2 Add-92HD81B1X5-to-stac92hd83xxx_cfg_tbl-for-mute-L.patch <text/plain (quoted-printable)>]
> > >From e32ef26f88d2a2217ce70e5a04bf5c1d9973649e Mon Sep 17 00:00:00 2001
> > From: Lee, Chun-Yi <jlee@novell.com>
> > Date: Thu, 27 May 2010 19:52:47 +0800
> > Subject: [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute LED support on HP mini
> > 
> > Add 92HD81B1X5 subsystem id 0x103c1584 to stac92hd83xxx_cfg_tbl[] for
> > mute LED support on HP mini.
> > 
> > Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
> > ---
> >  sound/pci/hda/patch_sigmatel.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> > index f1e7bab..18b75bd 100644
> > --- a/sound/pci/hda/patch_sigmatel.c
> > +++ b/sound/pci/hda/patch_sigmatel.c
> > @@ -1655,6 +1655,8 @@ static struct snd_pci_quirk stac92hd83xxx_cfg_tbl[] = {
> >  		      "unknown Dell", STAC_DELL_S14),
> >  	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x3600,
> >  		      "HP", STAC_92HD83XXX_HP),
> > +	SND_PCI_QUIRK_MASK(PCI_VENDOR_ID_HP, 0xff00, 0x1500,
> > +			"HP", STAC_92HD83XXX_HP),
> >  	{} /* terminator */
> >  };
> >  
> > -- 
> > 1.6.0.2
> > 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-05-31  4:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-05-29  1:23 [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute LED Joey Lee
2010-05-29 19:47 ` [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute LED support on HP mini Takashi Iwai
2010-05-30  0:52 ` [PATCH] Add 92HD81B1X5 to stac92hd83xxx_cfg_tbl[] for mute Joey Lee
2010-05-31  4:34 ` Joey Lee

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.