All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] KVM VMX: Make sure single type invvpid is supported before issuing this instruction
@ 2010-06-03  8:44 Gui Jianfeng
  2010-06-03  8:57 ` Sheng Yang
  0 siblings, 1 reply; 8+ messages in thread
From: Gui Jianfeng @ 2010-06-03  8:44 UTC (permalink / raw)
  To: Avi Kivity; +Cc: Sheng Yang, kvm

According to SDM, we need check whether single-context INVVPID type is supported
before issuing invvpid instruction.

Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
 arch/x86/include/asm/vmx.h |    2 ++
 arch/x86/kvm/vmx.c         |    8 +++++++-
 2 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
index 104cf86..6fa40d0 100644
--- a/arch/x86/include/asm/vmx.h
+++ b/arch/x86/include/asm/vmx.h
@@ -376,6 +376,8 @@ enum vmcs_field {
 #define VMX_EPT_EXTENT_CONTEXT_BIT		(1ull << 25)
 #define VMX_EPT_EXTENT_GLOBAL_BIT		(1ull << 26)
 
+#define VMX_EPT_INVVPID_SINGLE_CONTEXT_BIT      (1ull << (41 - 32))
+
 #define VMX_EPT_DEFAULT_GAW			3
 #define VMX_EPT_MAX_GAW				0x4
 #define VMX_EPT_MT_EPTE_SHIFT			3
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 0e561a5..e2d12bf 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -355,6 +355,11 @@ static inline bool cpu_has_vmx_invept_global(void)
 	return vmx_capability.ept & VMX_EPT_EXTENT_GLOBAL_BIT;
 }
 
+static inline bool cpu_has_vmx_invvpid_single(void)
+{
+	return vmx_capability.vpid & VMX_EPT_INVVPID_SINGLE_CONTEXT_BIT;
+}
+
 static inline bool cpu_has_vmx_ept(void)
 {
 	return vmcs_config.cpu_based_2nd_exec_ctrl &
@@ -499,7 +504,8 @@ static inline void vpid_sync_vcpu_all(struct vcpu_vmx *vmx)
 	if (vmx->vpid == 0)
 		return;
 
-	__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
+	if (cpu_has_vmx_invvpid_single())
+		__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
 }
 
 static inline void ept_sync_global(void)
-- 
1.6.5.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] KVM VMX: Make sure single type invvpid is supported before issuing this instruction
  2010-06-03  8:44 [PATCH] KVM VMX: Make sure single type invvpid is supported before issuing this instruction Gui Jianfeng
@ 2010-06-03  8:57 ` Sheng Yang
  2010-06-03  9:07   ` Gui Jianfeng
  2010-06-03  9:45   ` [PATCH v2] KVM VMX: Make sure single type invvpid is supported before issuing invvpid instruction Gui Jianfeng
  0 siblings, 2 replies; 8+ messages in thread
From: Sheng Yang @ 2010-06-03  8:57 UTC (permalink / raw)
  To: Gui Jianfeng; +Cc: Avi Kivity, kvm

On Thursday 03 June 2010 16:44:34 Gui Jianfeng wrote:
> According to SDM, we need check whether single-context INVVPID type is
> supported before issuing invvpid instruction.
> 
> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
> ---
>  arch/x86/include/asm/vmx.h |    2 ++
>  arch/x86/kvm/vmx.c         |    8 +++++++-
>  2 files changed, 9 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
> index 104cf86..6fa40d0 100644
> --- a/arch/x86/include/asm/vmx.h
> +++ b/arch/x86/include/asm/vmx.h
> @@ -376,6 +376,8 @@ enum vmcs_field {
>  #define VMX_EPT_EXTENT_CONTEXT_BIT		(1ull << 25)
>  #define VMX_EPT_EXTENT_GLOBAL_BIT		(1ull << 26)

Hi Jianfeng
> 
> +#define VMX_EPT_INVVPID_SINGLE_CONTEXT_BIT      (1ull << (41 - 32))
> +

VPID is not a part of EPT. And you can keep consistent with the names above, like: 
VMX_VPID_EXTENT_SINGLE_CONTEXT_BIT

And comments it later maybe better than indirectly (41 - 32)?

Others looks fine to me.

--
regards
Yang, Sheng

>  #define VMX_EPT_DEFAULT_GAW			3
>  #define VMX_EPT_MAX_GAW				0x4
>  #define VMX_EPT_MT_EPTE_SHIFT			3
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 0e561a5..e2d12bf 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -355,6 +355,11 @@ static inline bool cpu_has_vmx_invept_global(void)
>  	return vmx_capability.ept & VMX_EPT_EXTENT_GLOBAL_BIT;
>  }
> 
> +static inline bool cpu_has_vmx_invvpid_single(void)
> +{
> +	return vmx_capability.vpid & VMX_EPT_INVVPID_SINGLE_CONTEXT_BIT;
> +}
> +
>  static inline bool cpu_has_vmx_ept(void)
>  {
>  	return vmcs_config.cpu_based_2nd_exec_ctrl &
> @@ -499,7 +504,8 @@ static inline void vpid_sync_vcpu_all(struct vcpu_vmx
> *vmx) if (vmx->vpid == 0)
>  		return;
> 
> -	__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
> +	if (cpu_has_vmx_invvpid_single())
> +		__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
>  }
> 
>  static inline void ept_sync_global(void)

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] KVM VMX: Make sure single type invvpid is supported before issuing this instruction
  2010-06-03  8:57 ` Sheng Yang
@ 2010-06-03  9:07   ` Gui Jianfeng
  2010-06-03  9:45   ` [PATCH v2] KVM VMX: Make sure single type invvpid is supported before issuing invvpid instruction Gui Jianfeng
  1 sibling, 0 replies; 8+ messages in thread
From: Gui Jianfeng @ 2010-06-03  9:07 UTC (permalink / raw)
  To: Sheng Yang; +Cc: Avi Kivity, kvm

Sheng Yang wrote:
> On Thursday 03 June 2010 16:44:34 Gui Jianfeng wrote:
>> According to SDM, we need check whether single-context INVVPID type is
>> supported before issuing invvpid instruction.
>>
>> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
>> ---
>>  arch/x86/include/asm/vmx.h |    2 ++
>>  arch/x86/kvm/vmx.c         |    8 +++++++-
>>  2 files changed, 9 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
>> index 104cf86..6fa40d0 100644
>> --- a/arch/x86/include/asm/vmx.h
>> +++ b/arch/x86/include/asm/vmx.h
>> @@ -376,6 +376,8 @@ enum vmcs_field {
>>  #define VMX_EPT_EXTENT_CONTEXT_BIT		(1ull << 25)
>>  #define VMX_EPT_EXTENT_GLOBAL_BIT		(1ull << 26)
> 
> Hi Jianfeng
>> +#define VMX_EPT_INVVPID_SINGLE_CONTEXT_BIT      (1ull << (41 - 32))
>> +
> 
> VPID is not a part of EPT. And you can keep consistent with the names above, like: 
> VMX_VPID_EXTENT_SINGLE_CONTEXT_BIT
> 
> And comments it later maybe better than indirectly (41 - 32)?
> 

Ok, will post an updated version.

Thanks,
Gui

> Others looks fine to me.
> 
> --
> regards
> Yang, Sheng
> 
>>  #define VMX_EPT_DEFAULT_GAW			3
>>  #define VMX_EPT_MAX_GAW				0x4
>>  #define VMX_EPT_MT_EPTE_SHIFT			3
>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>> index 0e561a5..e2d12bf 100644
>> --- a/arch/x86/kvm/vmx.c
>> +++ b/arch/x86/kvm/vmx.c
>> @@ -355,6 +355,11 @@ static inline bool cpu_has_vmx_invept_global(void)
>>  	return vmx_capability.ept & VMX_EPT_EXTENT_GLOBAL_BIT;
>>  }
>>
>> +static inline bool cpu_has_vmx_invvpid_single(void)
>> +{
>> +	return vmx_capability.vpid & VMX_EPT_INVVPID_SINGLE_CONTEXT_BIT;
>> +}
>> +
>>  static inline bool cpu_has_vmx_ept(void)
>>  {
>>  	return vmcs_config.cpu_based_2nd_exec_ctrl &
>> @@ -499,7 +504,8 @@ static inline void vpid_sync_vcpu_all(struct vcpu_vmx
>> *vmx) if (vmx->vpid == 0)
>>  		return;
>>
>> -	__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
>> +	if (cpu_has_vmx_invvpid_single())
>> +		__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
>>  }
>>
>>  static inline void ept_sync_global(void)
> 
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2] KVM VMX: Make sure single type invvpid is supported before issuing invvpid instruction
  2010-06-03  8:57 ` Sheng Yang
  2010-06-03  9:07   ` Gui Jianfeng
@ 2010-06-03  9:45   ` Gui Jianfeng
  2010-06-03  9:58     ` Sheng Yang
  1 sibling, 1 reply; 8+ messages in thread
From: Gui Jianfeng @ 2010-06-03  9:45 UTC (permalink / raw)
  To: Sheng Yang, Avi Kivity; +Cc: kvm

According to SDM, we need check whether single-context INVVPID type is supported
before issuing invvpid instruction.

Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
 arch/x86/include/asm/vmx.h |    2 ++
 arch/x86/kvm/vmx.c         |   14 +++++++++++++-
 2 files changed, 15 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
index 104cf86..4e78b25 100644
--- a/arch/x86/include/asm/vmx.h
+++ b/arch/x86/include/asm/vmx.h
@@ -376,6 +376,8 @@ enum vmcs_field {
 #define VMX_EPT_EXTENT_CONTEXT_BIT		(1ull << 25)
 #define VMX_EPT_EXTENT_GLOBAL_BIT		(1ull << 26)
 
+#define VMX_VPID_EXTENT_SINGLE_CONTEXT_BIT      (1ull << 9)
+
 #define VMX_EPT_DEFAULT_GAW			3
 #define VMX_EPT_MAX_GAW				0x4
 #define VMX_EPT_MT_EPTE_SHIFT			3
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 0e561a5..f363fe3 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -355,6 +355,17 @@ static inline bool cpu_has_vmx_invept_global(void)
 	return vmx_capability.ept & VMX_EPT_EXTENT_GLOBAL_BIT;
 }
 
+static inline bool cpu_has_vmx_invvpid_single(void)
+{
+	/* 
+	 *  bit 41 of IA32_VMX_EPT_VPID_CAP MSR indicates whehter the 
+	 *  single-context INVVPID type is supported. vmx_capability.vpid 
+	 *  represents the higher 32 bits of IA32_VMX_EPT_VPID_CAP MSR, so
+	 *  VMX_VPID_EXTENT_SINGLE_CONTEXT_BIT(bit 9) is used here.
+	 */
+	return vmx_capability.vpid & VMX_VPID_EXTENT_SINGLE_CONTEXT_BIT;
+}
+
 static inline bool cpu_has_vmx_ept(void)
 {
 	return vmcs_config.cpu_based_2nd_exec_ctrl &
@@ -499,7 +510,8 @@ static inline void vpid_sync_vcpu_all(struct vcpu_vmx *vmx)
 	if (vmx->vpid == 0)
 		return;
 
-	__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
+	if (cpu_has_vmx_invvpid_single())
+		__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
 }
 
 static inline void ept_sync_global(void)
-- 
1.6.5.2



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] KVM VMX: Make sure single type invvpid is supported before issuing invvpid instruction
  2010-06-03  9:45   ` [PATCH v2] KVM VMX: Make sure single type invvpid is supported before issuing invvpid instruction Gui Jianfeng
@ 2010-06-03  9:58     ` Sheng Yang
  2010-06-04  0:51       ` [PATCH v3] " Gui Jianfeng
  0 siblings, 1 reply; 8+ messages in thread
From: Sheng Yang @ 2010-06-03  9:58 UTC (permalink / raw)
  To: Gui Jianfeng; +Cc: Avi Kivity, kvm

On Thursday 03 June 2010 17:45:22 Gui Jianfeng wrote:
> According to SDM, we need check whether single-context INVVPID type is
> supported before issuing invvpid instruction.
> 
> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
> ---
>  arch/x86/include/asm/vmx.h |    2 ++
>  arch/x86/kvm/vmx.c         |   14 +++++++++++++-
>  2 files changed, 15 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
> index 104cf86..4e78b25 100644
> --- a/arch/x86/include/asm/vmx.h
> +++ b/arch/x86/include/asm/vmx.h
> @@ -376,6 +376,8 @@ enum vmcs_field {
>  #define VMX_EPT_EXTENT_CONTEXT_BIT		(1ull << 25)
>  #define VMX_EPT_EXTENT_GLOBAL_BIT		(1ull << 26)
> 
> +#define VMX_VPID_EXTENT_SINGLE_CONTEXT_BIT      (1ull << 9)
> +
>  #define VMX_EPT_DEFAULT_GAW			3
>  #define VMX_EPT_MAX_GAW				0x4
>  #define VMX_EPT_MT_EPTE_SHIFT			3
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 0e561a5..f363fe3 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -355,6 +355,17 @@ static inline bool cpu_has_vmx_invept_global(void)
>  	return vmx_capability.ept & VMX_EPT_EXTENT_GLOBAL_BIT;
>  }
> 
> +static inline bool cpu_has_vmx_invvpid_single(void)
> +{
> +	/*
> +	 *  bit 41 of IA32_VMX_EPT_VPID_CAP MSR indicates whehter the
> +	 *  single-context INVVPID type is supported. vmx_capability.vpid
> +	 *  represents the higher 32 bits of IA32_VMX_EPT_VPID_CAP MSR, so
> +	 *  VMX_VPID_EXTENT_SINGLE_CONTEXT_BIT(bit 9) is used here.
> +	 */

The comment is better with the VMX_VPID_EXTENT_SINGLE_CONTEXT_BIT marco, since it 
would also applied to other similar ones. 

And I have checked my sent mail, found the word "later" maybe the reason you put 
the comment here... In fact I meant something like

#define VMX_EPT_INVVPID_SINGLE_CONTEXT_BIT (1 << 9) /* (41 - 32) */

Sorry if the word caused confusing...

--
regards
Yang, Sheng

> +	return vmx_capability.vpid & VMX_VPID_EXTENT_SINGLE_CONTEXT_BIT;
> +}
> +
>  static inline bool cpu_has_vmx_ept(void)
>  {
>  	return vmcs_config.cpu_based_2nd_exec_ctrl &
> @@ -499,7 +510,8 @@ static inline void vpid_sync_vcpu_all(struct vcpu_vmx
> *vmx) if (vmx->vpid == 0)
>  		return;
> 
> -	__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
> +	if (cpu_has_vmx_invvpid_single())
> +		__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
>  }
> 
>  static inline void ept_sync_global(void)

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v3] KVM VMX: Make sure single type invvpid is supported before issuing invvpid instruction
  2010-06-03  9:58     ` Sheng Yang
@ 2010-06-04  0:51       ` Gui Jianfeng
  2010-06-04  5:40         ` Sheng Yang
  2010-06-04 17:51         ` Marcelo Tosatti
  0 siblings, 2 replies; 8+ messages in thread
From: Gui Jianfeng @ 2010-06-04  0:51 UTC (permalink / raw)
  To: Sheng Yang; +Cc: Avi Kivity, kvm

According to SDM, we need check whether single-context INVVPID type is supported
before issuing invvpid instruction.

Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
 arch/x86/include/asm/vmx.h |    2 ++
 arch/x86/kvm/vmx.c         |    8 +++++++-
 2 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
index 104cf86..b4e2840 100644
--- a/arch/x86/include/asm/vmx.h
+++ b/arch/x86/include/asm/vmx.h
@@ -376,6 +376,8 @@ enum vmcs_field {
 #define VMX_EPT_EXTENT_CONTEXT_BIT		(1ull << 25)
 #define VMX_EPT_EXTENT_GLOBAL_BIT		(1ull << 26)
 
+#define VMX_VPID_EXTENT_SINGLE_CONTEXT_BIT      (1ull << 9) /* (41 - 32) */
+
 #define VMX_EPT_DEFAULT_GAW			3
 #define VMX_EPT_MAX_GAW				0x4
 #define VMX_EPT_MT_EPTE_SHIFT			3
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 0e561a5..240a407 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -355,6 +355,11 @@ static inline bool cpu_has_vmx_invept_global(void)
 	return vmx_capability.ept & VMX_EPT_EXTENT_GLOBAL_BIT;
 }
 
+static inline bool cpu_has_vmx_invvpid_single(void)
+{
+	return vmx_capability.vpid & VMX_VPID_EXTENT_SINGLE_CONTEXT_BIT;
+}
+
 static inline bool cpu_has_vmx_ept(void)
 {
 	return vmcs_config.cpu_based_2nd_exec_ctrl &
@@ -499,7 +504,8 @@ static inline void vpid_sync_vcpu_all(struct vcpu_vmx *vmx)
 	if (vmx->vpid == 0)
 		return;
 
-	__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
+	if (cpu_has_vmx_invvpid_single())
+		__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
 }
 
 static inline void ept_sync_global(void)
-- 
1.6.5.2



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v3] KVM VMX: Make sure single type invvpid is supported before issuing invvpid instruction
  2010-06-04  0:51       ` [PATCH v3] " Gui Jianfeng
@ 2010-06-04  5:40         ` Sheng Yang
  2010-06-04 17:51         ` Marcelo Tosatti
  1 sibling, 0 replies; 8+ messages in thread
From: Sheng Yang @ 2010-06-04  5:40 UTC (permalink / raw)
  To: Gui Jianfeng; +Cc: Avi Kivity, kvm, Marcelo Tosatti

On Friday 04 June 2010 08:51:39 Gui Jianfeng wrote:
> According to SDM, we need check whether single-context INVVPID type is
> supported before issuing invvpid instruction.
> 
> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>

Reviewed-by: Sheng Yang <sheng@linux.intel.com>

--
regards
Yang, Sheng

> ---
>  arch/x86/include/asm/vmx.h |    2 ++
>  arch/x86/kvm/vmx.c         |    8 +++++++-
>  2 files changed, 9 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
> index 104cf86..b4e2840 100644
> --- a/arch/x86/include/asm/vmx.h
> +++ b/arch/x86/include/asm/vmx.h
> @@ -376,6 +376,8 @@ enum vmcs_field {
>  #define VMX_EPT_EXTENT_CONTEXT_BIT		(1ull << 25)
>  #define VMX_EPT_EXTENT_GLOBAL_BIT		(1ull << 26)
> 
> +#define VMX_VPID_EXTENT_SINGLE_CONTEXT_BIT      (1ull << 9) /* (41 - 32)
> */ +
>  #define VMX_EPT_DEFAULT_GAW			3
>  #define VMX_EPT_MAX_GAW				0x4
>  #define VMX_EPT_MT_EPTE_SHIFT			3
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 0e561a5..240a407 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -355,6 +355,11 @@ static inline bool cpu_has_vmx_invept_global(void)
>  	return vmx_capability.ept & VMX_EPT_EXTENT_GLOBAL_BIT;
>  }
> 
> +static inline bool cpu_has_vmx_invvpid_single(void)
> +{
> +	return vmx_capability.vpid & VMX_VPID_EXTENT_SINGLE_CONTEXT_BIT;
> +}
> +
>  static inline bool cpu_has_vmx_ept(void)
>  {
>  	return vmcs_config.cpu_based_2nd_exec_ctrl &
> @@ -499,7 +504,8 @@ static inline void vpid_sync_vcpu_all(struct vcpu_vmx
> *vmx) if (vmx->vpid == 0)
>  		return;
> 
> -	__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
> +	if (cpu_has_vmx_invvpid_single())
> +		__invvpid(VMX_VPID_EXTENT_SINGLE_CONTEXT, vmx->vpid, 0);
>  }
> 
>  static inline void ept_sync_global(void)

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v3] KVM VMX: Make sure single type invvpid is supported before issuing invvpid instruction
  2010-06-04  0:51       ` [PATCH v3] " Gui Jianfeng
  2010-06-04  5:40         ` Sheng Yang
@ 2010-06-04 17:51         ` Marcelo Tosatti
  1 sibling, 0 replies; 8+ messages in thread
From: Marcelo Tosatti @ 2010-06-04 17:51 UTC (permalink / raw)
  To: Gui Jianfeng; +Cc: Sheng Yang, Avi Kivity, kvm

On Fri, Jun 04, 2010 at 08:51:39AM +0800, Gui Jianfeng wrote:
> According to SDM, we need check whether single-context INVVPID type is supported
> before issuing invvpid instruction.
> 
> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
> ---
>  arch/x86/include/asm/vmx.h |    2 ++
>  arch/x86/kvm/vmx.c         |    8 +++++++-
>  2 files changed, 9 insertions(+), 1 deletions(-)

Applied, thanks.


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2010-06-04 18:20 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-03  8:44 [PATCH] KVM VMX: Make sure single type invvpid is supported before issuing this instruction Gui Jianfeng
2010-06-03  8:57 ` Sheng Yang
2010-06-03  9:07   ` Gui Jianfeng
2010-06-03  9:45   ` [PATCH v2] KVM VMX: Make sure single type invvpid is supported before issuing invvpid instruction Gui Jianfeng
2010-06-03  9:58     ` Sheng Yang
2010-06-04  0:51       ` [PATCH v3] " Gui Jianfeng
2010-06-04  5:40         ` Sheng Yang
2010-06-04 17:51         ` Marcelo Tosatti

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.