* Re: [lm-sensors] fintek f71869 driver - found a working
@ 2010-06-09 16:44 Roman Evstifeev
2010-06-10 8:29 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Roman Evstifeev @ 2010-06-09 16:44 UTC (permalink / raw)
To: lm-sensors
2010/6/9 Michael Gerst <michaelpgerst@gmail.com>
>
> So, not sure who to submit this to, but I have the fintek f71869fg chipset working. After going over the specs, it's nearly identical to f1882fg
> patched drivers/hwmon/f71882fg.c and set up sensors3.conf with the following:
> ## BEGIN SENSORS3.CONF
> chip "f71869fg-*"
> # Voltages
> label in0 "+3.3V"
> label in1 "core"
> label in2 "NB"
> label in3 "SB +5V"
> label in4 "Dimm"
> label in5 "+5V"
> label in6 "+12V"
> label in7 "SB +3V"
> label in8 "BAT"
> ignore in9
> compute in0 @*2, @/2
> compute in3 (@ * 3.7), ( @ / 3.7)
> compute in4 (@ * 1.5), ( @ / 1.5)
> compute in5 (@ * 3.7), ( @ / 3.7)
> compute in6 (@ * 11), ( @ / 11)
> compute in7 @*2, @/2
> compute in8 @*2, @/2
> # Temperature
> label temp1 "CPU"
> label temp2 "System"
> label temp3 "System"
> # Fans
> label fan1 "CPU Fan"
> label fan2 "Sys Fan 1"
> label fan3 "Sys Fan 2"
> ## END SENSORS3.CONF
>
> ## BEGIN PATCH
> *** /root/f71882fg.c 2010-05-27 19:21:26.000000000 -0500
> --- f71882fg.c 2010-02-06 16:17:12.000000000 -0600
> ***************
> *** 48,54 ****
> #define SIO_F71858_ID 0x0507 /* Chipset ID */
> #define SIO_F71862_ID 0x0601 /* Chipset ID */
> #define SIO_F71882_ID 0x0541 /* Chipset ID */
> - #define SIO_F71869_ID 0x0814 /* Chipset ID */
> #define SIO_F71889_ID 0x0723 /* Chipset ID */
> #define SIO_F8000_ID 0x0581 /* Chipset ID */
> --- 48,53 ----
> ***************
> *** 97,103 ****
> module_param(force_id, ushort, 0);
> MODULE_PARM_DESC(force_id, "Override the detected device ID");
> ! enum chips { f71858fg, f71862fg, f71882fg, f71889fg, f8000, f71869fg };
> static const char *f71882fg_names[] = {
> "f71858fg",
> --- 96,102 ----
> module_param(force_id, ushort, 0);
> MODULE_PARM_DESC(force_id, "Override the detected device ID");
> ! enum chips { f71858fg, f71862fg, f71882fg, f71889fg, f8000 };
> static const char *f71882fg_names[] = {
> "f71858fg",
> ***************
> *** 105,111 ****
> "f71882fg",
> "f71889fg",
> "f8000",
> - "f71869fg"
> };
> static struct platform_device *f71882fg_pdev;
> --- 104,109 ----
> ***************
> *** 1898,1904 ****
> ARRAY_SIZE(f71858fg_in_temp_attr));
> break;
> case f71882fg:
> - case f71869fg:
> case f71889fg:
> err = f71882fg_create_sysfs_files(pdev,
> fxxxx_in1_alarm_attr,
> --- 1896,1901 ----
> ***************
> *** 1937,1943 ****
> err = (data->pwm_enable & 0x15) != 0x15;
> break;
> case f71882fg:
> - case f71869fg:
> case f71889fg:
> err = 0;
> break;
> --- 1934,1939 ----
> ***************
> *** 1959,1965 ****
> goto exit_unregister_sysfs;
> if (data->type = f71862fg || data->type = f71882fg ||
> ! data->type = f71889fg || data->type = f71869fg ) {
> err = f71882fg_create_sysfs_files(pdev,
> fxxxx_fan_beep_attr, nr_fans);
> if (err)
> --- 1955,1961 ----
> goto exit_unregister_sysfs;
> if (data->type = f71862fg || data->type = f71882fg ||
> ! data->type = f71889fg) {
> err = f71882fg_create_sysfs_files(pdev,
> fxxxx_fan_beep_attr, nr_fans);
> if (err)
> ***************
> *** 2054,2060 ****
> ARRAY_SIZE(f71858fg_in_temp_attr));
> break;
> case f71882fg:
> - case f71869fg:
> case f71889fg:
> f71882fg_remove_sysfs_files(pdev,
> fxxxx_in1_alarm_attr,
> --- 2050,2055 ----
> ***************
> *** 2078,2084 ****
> ARRAY_SIZE(fxxxx_fan_attr[0]) * nr_fans);
> if (data->type = f71862fg || data->type = f71882fg ||
> ! data->type = f71889fg || data->type = f71869fg )
> f71882fg_remove_sysfs_files(pdev,
> fxxxx_fan_beep_attr, nr_fans);
> --- 2073,2079 ----
> ARRAY_SIZE(fxxxx_fan_attr[0]) * nr_fans);
> if (data->type = f71862fg || data->type = f71882fg ||
> ! data->type = f71889fg)
> f71882fg_remove_sysfs_files(pdev,
> fxxxx_fan_beep_attr, nr_fans);
> ***************
> *** 2133,2141 ****
> case SIO_F71882_ID:
> sio_data->type = f71882fg;
> break;
> - case SIO_F71869_ID:
> - sio_data->type = f71869fg;
> - break;
> case SIO_F71889_ID:
> sio_data->type = f71889fg;
> break;
> --- 2128,2133 ----
> ## END PATCH
> Again, sorry if I'm blasting this to the wrong contact.
>
1) Strange patch... it just removes all the f71869fg stuff from
driver, and does not touch f71889fg.
Are you sure, that you created diff right?
2) Can you please confirm, that you are able to control fan speed
(writing to pwm sysfs files really changes voltage) ? With current
version from 2.6.34 i am not able to do that (seee
http://lists.lm-sensors.org/pipermail/lm-sensors/2010-June/028676.html
)
>
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [lm-sensors] fintek f71869 driver - found a working
2010-06-09 16:44 [lm-sensors] fintek f71869 driver - found a working Roman Evstifeev
@ 2010-06-10 8:29 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2010-06-10 8:29 UTC (permalink / raw)
To: lm-sensors
Hi,
Can you please supply your patch in unified diff format (diff -u) then
I'll take a closer look at it. Most likely some more changes will be
needed but it is a start (all fintek devices tend to be nearly identical,
yet not identical at all).
Regards,
Hans
On 06/09/2010 03:27 PM, Michael Gerst wrote:
> So, not sure who to submit this to, but I have the fintek f71869fg
> chipset working. After going over the specs, it's nearly identical to
> f1882fg
>
> patched drivers/hwmon/f71882fg.c and set up sensors3.conf with the
> following:
>
> ## BEGIN SENSORS3.CONF
>
> chip "f71869fg-*"
>
> # Voltages
>
> label in0 "+3.3V"
> label in1 "core"
> label in2 "NB"
> label in3 "SB +5V"
> label in4 "Dimm"
> label in5 "+5V"
> label in6 "+12V"
> label in7 "SB +3V"
> label in8 "BAT"
> ignore in9
>
> compute in0 @*2, @/2
> compute in3 (@ * 3.7), ( @ / 3.7)
> compute in4 (@ * 1.5), ( @ / 1.5)
> compute in5 (@ * 3.7), ( @ / 3.7)
> compute in6 (@ * 11), ( @ / 11)
> compute in7 @*2, @/2
> compute in8 @*2, @/2
>
> # Temperature
>
> label temp1 "CPU"
> label temp2 "System"
> label temp3 "System"
>
> # Fans
>
> label fan1 "CPU Fan"
> label fan2 "Sys Fan 1"
> label fan3 "Sys Fan 2"
>
> ## END SENSORS3.CONF
>
>
> ## BEGIN PATCH
>
> *** /root/f71882fg.c 2010-05-27 19:21:26.000000000 -0500
> --- f71882fg.c 2010-02-06 16:17:12.000000000 -0600
> ***************
> *** 48,54 ****
> #define SIO_F71858_ID 0x0507 /* Chipset ID */
> #define SIO_F71862_ID 0x0601 /* Chipset ID */
> #define SIO_F71882_ID 0x0541 /* Chipset ID */
> - #define SIO_F71869_ID 0x0814 /* Chipset ID */
> #define SIO_F71889_ID 0x0723 /* Chipset ID */
> #define SIO_F8000_ID 0x0581 /* Chipset ID */
>
> --- 48,53 ----
> ***************
> *** 97,103 ****
> module_param(force_id, ushort, 0);
> MODULE_PARM_DESC(force_id, "Override the detected device ID");
>
> ! enum chips { f71858fg, f71862fg, f71882fg, f71889fg, f8000, f71869fg };
>
> static const char *f71882fg_names[] = {
> "f71858fg",
> --- 96,102 ----
> module_param(force_id, ushort, 0);
> MODULE_PARM_DESC(force_id, "Override the detected device ID");
>
> ! enum chips { f71858fg, f71862fg, f71882fg, f71889fg, f8000 };
>
> static const char *f71882fg_names[] = {
> "f71858fg",
> ***************
> *** 105,111 ****
> "f71882fg",
> "f71889fg",
> "f8000",
> - "f71869fg"
> };
>
> static struct platform_device *f71882fg_pdev;
> --- 104,109 ----
> ***************
> *** 1898,1904 ****
> ARRAY_SIZE(f71858fg_in_temp_attr));
> break;
> case f71882fg:
> - case f71869fg:
> case f71889fg:
> err = f71882fg_create_sysfs_files(pdev,
> fxxxx_in1_alarm_attr,
> --- 1896,1901 ----
> ***************
> *** 1937,1943 ****
> err = (data->pwm_enable & 0x15) != 0x15;
> break;
> case f71882fg:
> - case f71869fg:
> case f71889fg:
> err = 0;
> break;
> --- 1934,1939 ----
> ***************
> *** 1959,1965 ****
> goto exit_unregister_sysfs;
>
> if (data->type = f71862fg || data->type = f71882fg ||
> ! data->type = f71889fg || data->type = f71869fg ) {
> err = f71882fg_create_sysfs_files(pdev,
> fxxxx_fan_beep_attr, nr_fans);
> if (err)
> --- 1955,1961 ----
> goto exit_unregister_sysfs;
>
> if (data->type = f71862fg || data->type = f71882fg ||
> ! data->type = f71889fg) {
> err = f71882fg_create_sysfs_files(pdev,
> fxxxx_fan_beep_attr, nr_fans);
> if (err)
> ***************
> *** 2054,2060 ****
> ARRAY_SIZE(f71858fg_in_temp_attr));
> break;
> case f71882fg:
> - case f71869fg:
> case f71889fg:
> f71882fg_remove_sysfs_files(pdev,
> fxxxx_in1_alarm_attr,
> --- 2050,2055 ----
> ***************
> *** 2078,2084 ****
> ARRAY_SIZE(fxxxx_fan_attr[0]) * nr_fans);
>
> if (data->type = f71862fg || data->type = f71882fg ||
> ! data->type = f71889fg || data->type = f71869fg )
> f71882fg_remove_sysfs_files(pdev,
> fxxxx_fan_beep_attr, nr_fans);
>
> --- 2073,2079 ----
> ARRAY_SIZE(fxxxx_fan_attr[0]) * nr_fans);
>
> if (data->type = f71862fg || data->type = f71882fg ||
> ! data->type = f71889fg)
> f71882fg_remove_sysfs_files(pdev,
> fxxxx_fan_beep_attr, nr_fans);
>
> ***************
> *** 2133,2141 ****
> case SIO_F71882_ID:
> sio_data->type = f71882fg;
> break;
> - case SIO_F71869_ID:
> - sio_data->type = f71869fg;
> - break;
> case SIO_F71889_ID:
> sio_data->type = f71889fg;
> break;
> --- 2128,2133 ----
>
> ## END PATCH
>
> Again, sorry if I'm blasting this to the wrong contact.
>
>
>
>
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-10 8:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-09 16:44 [lm-sensors] fintek f71869 driver - found a working Roman Evstifeev
2010-06-10 8:29 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.