All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ipr: add support for new Obsidian-E embedded adapter
       [not found] <20100624203107.468479055@linux.vnet.ibm.com>
@ 2010-06-24 20:34 ` Wayne Boyer
  2010-06-24 20:34 ` [PATCH 2/2] ipr: change endian swap key to match hardware spec change Wayne Boyer
  1 sibling, 0 replies; 3+ messages in thread
From: Wayne Boyer @ 2010-06-24 20:34 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-scsi, Brian King

This patch allows the driver to recognize a new Obsidian-E based adapter that
uses a new subsystem ID.

This patch also fixes a few tab/space problems.

Signed-off-by: Wayne Boyer <wayneb@linux.vnet.ibm.com>

---
 drivers/scsi/ipr.c |    2 ++
 drivers/scsi/ipr.h |    9 +++++----
 2 files changed, 7 insertions(+), 4 deletions(-)

Index: b/drivers/scsi/ipr.c
===================================================================
--- a/drivers/scsi/ipr.c	2010-06-21 16:06:37.000000000 -0700
+++ b/drivers/scsi/ipr.c	2010-06-21 16:13:47.000000000 -0700
@@ -8889,6 +8889,8 @@ static struct pci_device_id ipr_pci_tabl
 	{ PCI_VENDOR_ID_IBM, PCI_DEVICE_ID_IBM_OBSIDIAN_E,
 	      PCI_VENDOR_ID_IBM, IPR_SUBS_DEV_ID_57B3, 0, 0, 0 },
 	{ PCI_VENDOR_ID_IBM, PCI_DEVICE_ID_IBM_OBSIDIAN_E,
+	      PCI_VENDOR_ID_IBM, IPR_SUBS_DEV_ID_57CC, 0, 0, 0 },
+	{ PCI_VENDOR_ID_IBM, PCI_DEVICE_ID_IBM_OBSIDIAN_E,
 	      PCI_VENDOR_ID_IBM, IPR_SUBS_DEV_ID_57B7, 0, 0,
 	      IPR_USE_LONG_TRANSOP_TIMEOUT | IPR_USE_PCI_WARM_RESET },
 	{ PCI_VENDOR_ID_IBM, PCI_DEVICE_ID_IBM_SNIPE,
Index: b/drivers/scsi/ipr.h
===================================================================
--- a/drivers/scsi/ipr.h	2010-06-21 16:06:38.000000000 -0700
+++ b/drivers/scsi/ipr.h	2010-06-21 16:13:44.000000000 -0700
@@ -62,12 +62,12 @@
 #define IPR_SUBS_DEV_ID_2780	0x0264
 #define IPR_SUBS_DEV_ID_5702	0x0266
 #define IPR_SUBS_DEV_ID_5703	0x0278
-#define IPR_SUBS_DEV_ID_572E  0x028D
-#define IPR_SUBS_DEV_ID_573E  0x02D3
-#define IPR_SUBS_DEV_ID_573D  0x02D4
+#define IPR_SUBS_DEV_ID_572E	0x028D
+#define IPR_SUBS_DEV_ID_573E	0x02D3
+#define IPR_SUBS_DEV_ID_573D	0x02D4
 #define IPR_SUBS_DEV_ID_571A	0x02C0
 #define IPR_SUBS_DEV_ID_571B	0x02BE
-#define IPR_SUBS_DEV_ID_571E  0x02BF
+#define IPR_SUBS_DEV_ID_571E	0x02BF
 #define IPR_SUBS_DEV_ID_571F	0x02D5
 #define IPR_SUBS_DEV_ID_572A	0x02C1
 #define IPR_SUBS_DEV_ID_572B	0x02C2
@@ -82,6 +82,7 @@
 #define IPR_SUBS_DEV_ID_57B4    0x033B
 #define IPR_SUBS_DEV_ID_57B2    0x035F
 #define IPR_SUBS_DEV_ID_57C6    0x0357
+#define IPR_SUBS_DEV_ID_57CC    0x035C

 #define IPR_SUBS_DEV_ID_57B5    0x033C
 #define IPR_SUBS_DEV_ID_57CE    0x035E


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ipr: change endian swap key to match hardware spec change
       [not found] <20100624203107.468479055@linux.vnet.ibm.com>
  2010-06-24 20:34 ` [PATCH 1/2] ipr: add support for new Obsidian-E embedded adapter Wayne Boyer
@ 2010-06-24 20:34 ` Wayne Boyer
  2010-06-25  0:00   ` Wayne Boyer
  1 sibling, 1 reply; 3+ messages in thread
From: Wayne Boyer @ 2010-06-24 20:34 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-scsi, Brian King

The value used to change the endian representation on the new adapters has
changed.  This patch updates that value.

Signed-off-by: Wayne Boyer <wayneb@linux.vnet.ibm.com>
---

 drivers/scsi/ipr.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/scsi/ipr.h
===================================================================
--- a/drivers/scsi/ipr.h	2010-06-23 11:21:57.000000000 -0700
+++ b/drivers/scsi/ipr.h	2010-06-23 11:22:08.000000000 -0700
@@ -1257,7 +1257,7 @@ struct ipr_interrupt_offsets {
 	unsigned long dump_addr_reg;
 	unsigned long dump_data_reg;

-#define IPR_ENDIAN_SWAP_KEY		0x000C0C00
+#define IPR_ENDIAN_SWAP_KEY		0x000B0B00
 	unsigned long endian_swap_reg;
 };



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] ipr: change endian swap key to match hardware spec change
  2010-06-24 20:34 ` [PATCH 2/2] ipr: change endian swap key to match hardware spec change Wayne Boyer
@ 2010-06-25  0:00   ` Wayne Boyer
  0 siblings, 0 replies; 3+ messages in thread
From: Wayne Boyer @ 2010-06-25  0:00 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-scsi, Brian King



On 06/24/2010 01:34 PM, Wayne Boyer wrote:
> The value used to change the endian representation on the new adapters has
> changed.  This patch updates that value.
> 
> Signed-off-by: Wayne Boyer <wayneb@linux.vnet.ibm.com>
> ---
> 
>  drivers/scsi/ipr.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: b/drivers/scsi/ipr.h
> ===================================================================
> --- a/drivers/scsi/ipr.h	2010-06-23 11:21:57.000000000 -0700
> +++ b/drivers/scsi/ipr.h	2010-06-23 11:22:08.000000000 -0700
> @@ -1257,7 +1257,7 @@ struct ipr_interrupt_offsets {
>  	unsigned long dump_addr_reg;
>  	unsigned long dump_data_reg;
> 
> -#define IPR_ENDIAN_SWAP_KEY		0x000C0C00
> +#define IPR_ENDIAN_SWAP_KEY		0x000B0B00

The original patch has the wrong value.  I mistook "8" for "B" in the
spec.  The corrected patch is below.

---

The value used to change the endian representation on the new adapters has
changed.  This patch updates that value.

Signed-off-by: Wayne Boyer <wayneb@linux.vnet.ibm.com>
---

 drivers/scsi/ipr.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/scsi/ipr.h
===================================================================
--- a/drivers/scsi/ipr.h	2010-06-23 11:21:57.000000000 -0700
+++ b/drivers/scsi/ipr.h	2010-06-24 16:45:34.000000000 -0700
@@ -1257,7 +1257,7 @@ struct ipr_interrupt_offsets {
 	unsigned long dump_addr_reg;
 	unsigned long dump_data_reg;

-#define IPR_ENDIAN_SWAP_KEY		0x000C0C00
+#define IPR_ENDIAN_SWAP_KEY		0x00080800
 	unsigned long endian_swap_reg;
 };

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-06-25  0:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20100624203107.468479055@linux.vnet.ibm.com>
2010-06-24 20:34 ` [PATCH 1/2] ipr: add support for new Obsidian-E embedded adapter Wayne Boyer
2010-06-24 20:34 ` [PATCH 2/2] ipr: change endian swap key to match hardware spec change Wayne Boyer
2010-06-25  0:00   ` Wayne Boyer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.