From: Roger Quadros <roger.quadros@nokia.com> To: ext Ohad Ben-Cohen <ohad@wizery.com> Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>, Chikkature Rajashekar Madhusudhan <madhu.cr@ti.com>, "Coelho Luciano (Nokia-MS/Helsinki)" <Luciano.Coelho@nokia.com>, "akpm@linux-foundation.org" <akpm@linux-foundation.org>, San Mehat <san@google.com>, Ohad Ben-Cohen <ohadb@ti.com> Subject: Re: [PATCH 11/15] wireless: wl1271: introduce platform device support Date: Tue, 06 Jul 2010 13:35:32 +0300 [thread overview] Message-ID: <4C3306F4.8060907@nokia.com> (raw) In-Reply-To: <AANLkTintIz-N7MwwtqhVq2LR3Ln5JTNYSbJUBSSClcA-@mail.gmail.com> Hi Ohad, On 07/06/2010 12:30 PM, ext Ohad Ben-Cohen wrote: > Hi Roger, > > On Tue, Jul 6, 2010 at 11:53 AM, Roger Quadros<roger.quadros@nokia.com> wrote: >> Could you please explain why you need to do this? > > To minimize power consumption when the wlan device is not in use, we > would like to keep the device powered off as long as the interface is > down, and only power it on when the user brings up the interface. > Agreed. > Whenever the chip is powered on, it must be initialized and > reconfigured by mmc_attach_sdio, and the wl1271 driver have to wait > for that phase to successfully complete (essentially waiting for the > sdio_driver's probe function to be called). > > To make sure this SDIO init step occurs correctly every time we toggle > the device's power back on, and to prevent potential races, we also > have to make sure that the sdio function is removed every time we > power off the chip (the driver waits for the sdio_driver's remove > function to be called). > > That's why we let the mmc layer think that the card is removed: > physically it is still there, but for all practical purposes it is > really removed, because once you power off the chip, you must > reinitialize it again next time you power it on, as if the card was > really removed and re-inserted. > My point is that shouldn't this be handled by SDIO core? If there are no users for the SDIO function and the card, doesn't the SDIO core power down the slot, and take care of re-initialization when it is powered up?
WARNING: multiple messages have this Message-ID (diff)
From: roger.quadros@nokia.com (Roger Quadros) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 11/15] wireless: wl1271: introduce platform device support Date: Tue, 06 Jul 2010 13:35:32 +0300 [thread overview] Message-ID: <4C3306F4.8060907@nokia.com> (raw) In-Reply-To: <AANLkTintIz-N7MwwtqhVq2LR3Ln5JTNYSbJUBSSClcA-@mail.gmail.com> Hi Ohad, On 07/06/2010 12:30 PM, ext Ohad Ben-Cohen wrote: > Hi Roger, > > On Tue, Jul 6, 2010 at 11:53 AM, Roger Quadros<roger.quadros@nokia.com> wrote: >> Could you please explain why you need to do this? > > To minimize power consumption when the wlan device is not in use, we > would like to keep the device powered off as long as the interface is > down, and only power it on when the user brings up the interface. > Agreed. > Whenever the chip is powered on, it must be initialized and > reconfigured by mmc_attach_sdio, and the wl1271 driver have to wait > for that phase to successfully complete (essentially waiting for the > sdio_driver's probe function to be called). > > To make sure this SDIO init step occurs correctly every time we toggle > the device's power back on, and to prevent potential races, we also > have to make sure that the sdio function is removed every time we > power off the chip (the driver waits for the sdio_driver's remove > function to be called). > > That's why we let the mmc layer think that the card is removed: > physically it is still there, but for all practical purposes it is > really removed, because once you power off the chip, you must > reinitialize it again next time you power it on, as if the card was > really removed and re-inserted. > My point is that shouldn't this be handled by SDIO core? If there are no users for the SDIO function and the card, doesn't the SDIO core power down the slot, and take care of re-initialization when it is powered up?
next prev parent reply other threads:[~2010-07-06 10:35 UTC|newest] Thread overview: 161+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-07-06 0:37 [PATCH 00/15] wlan+omap+mmc: out-of-the-box WLAN support for ZOOM2/3 Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` [PATCH 01/15] sdio: add TI + wl1271 ids Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` [PATCH 02/15] wireless: wl1271: remove SDIO IDs from driver Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 7:04 ` Luciano Coelho 2010-07-06 7:04 ` Luciano Coelho 2010-07-06 0:37 ` [PATCH 03/15] omap: mmc: prepare for software card detect support Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` [PATCH 04/15] mmc: support embedded data field in mmc_host Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 15:49 ` Grazvydas Ignotas 2010-07-06 15:49 ` Grazvydas Ignotas 2010-07-06 15:49 ` Grazvydas Ignotas 2010-07-06 15:54 ` Ohad Ben-Cohen 2010-07-06 15:54 ` Ohad Ben-Cohen 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-06 0:37 ` [PATCH 05/15] omap: hsmmc: add virtual card detect support Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 1:45 ` Nicolas Pitre 2010-07-06 1:45 ` Nicolas Pitre 2010-07-06 10:22 ` Ohad Ben-Cohen 2010-07-06 10:22 ` Ohad Ben-Cohen 2010-07-06 10:22 ` Ohad Ben-Cohen 2010-07-06 11:02 ` Roger Quadros 2010-07-06 11:02 ` Roger Quadros 2010-07-06 12:02 ` Ohad Ben-Cohen 2010-07-06 12:02 ` Ohad Ben-Cohen 2010-07-06 11:48 ` Ohad Ben-Cohen 2010-07-06 11:48 ` Ohad Ben-Cohen 2010-07-06 12:39 ` Roger Quadros 2010-07-06 12:39 ` Roger Quadros 2010-07-06 13:44 ` Ohad Ben-Cohen 2010-07-06 13:44 ` Ohad Ben-Cohen 2010-07-06 15:34 ` Madhusudhan 2010-07-06 15:34 ` Madhusudhan 2010-07-06 15:34 ` Madhusudhan 2010-07-06 17:00 ` Nicolas Pitre 2010-07-06 17:00 ` Nicolas Pitre 2010-07-06 0:37 ` [PATCH 06/15] omap zoom2: wlan board muxing Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 11:43 ` Tony Lindgren 2010-07-06 11:43 ` Tony Lindgren 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-08 9:45 ` Tony Lindgren 2010-07-08 9:45 ` Tony Lindgren 2010-07-08 20:12 ` Ohad Ben-Cohen 2010-07-08 20:12 ` Ohad Ben-Cohen 2010-07-08 20:12 ` Ohad Ben-Cohen 2010-07-06 0:37 ` [PATCH 07/15] omap zoom3: " Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` [PATCH 08/15] wireless: wl1271: make wl12xx.h common to both spi and sdio Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 7:08 ` Luciano Coelho 2010-07-06 7:08 ` Luciano Coelho 2010-07-06 7:08 ` Luciano Coelho 2010-07-06 0:37 ` [PATCH 09/15] wireless: wl12xx: support pdata SDIO handlers Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` [PATCH 10/15] wireless: wl1271: support return value for the set power func Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 7:11 ` Luciano Coelho 2010-07-06 7:11 ` Luciano Coelho 2010-07-06 0:37 ` [PATCH 11/15] wireless: wl1271: introduce platform device support Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 8:53 ` Roger Quadros 2010-07-06 8:53 ` Roger Quadros 2010-07-06 8:53 ` Roger Quadros 2010-07-06 9:30 ` Ohad Ben-Cohen 2010-07-06 9:30 ` Ohad Ben-Cohen 2010-07-06 9:30 ` Ohad Ben-Cohen 2010-07-06 10:35 ` Roger Quadros [this message] 2010-07-06 10:35 ` Roger Quadros 2010-07-06 12:53 ` Ohad Ben-Cohen 2010-07-06 12:53 ` Ohad Ben-Cohen 2010-07-06 14:30 ` Roger Quadros 2010-07-06 14:30 ` Roger Quadros 2010-07-06 17:42 ` Nicolas Pitre 2010-07-06 17:42 ` Nicolas Pitre 2010-07-06 17:42 ` Nicolas Pitre 2010-07-06 19:51 ` Adrian Hunter 2010-07-06 19:51 ` Adrian Hunter 2010-07-07 8:02 ` Roger Quadros 2010-07-07 8:02 ` Roger Quadros 2010-07-07 8:02 ` Roger Quadros 2010-07-07 14:02 ` Nicolas Pitre 2010-07-07 14:02 ` Nicolas Pitre 2010-07-07 14:54 ` Madhusudhan 2010-07-07 14:54 ` Madhusudhan 2010-07-07 14:54 ` Madhusudhan 2010-07-07 15:46 ` Nicolas Pitre 2010-07-07 15:46 ` Nicolas Pitre 2010-07-07 19:59 ` Adrian Hunter 2010-07-07 19:59 ` Adrian Hunter 2010-07-08 4:34 ` Nicolas Pitre 2010-07-08 4:34 ` Nicolas Pitre 2010-07-08 4:34 ` Nicolas Pitre 2010-07-07 7:48 ` Roger Quadros 2010-07-07 7:48 ` Roger Quadros 2010-07-07 13:52 ` Nicolas Pitre 2010-07-07 13:52 ` Nicolas Pitre 2010-07-08 8:54 ` Roger Quadros 2010-07-08 8:54 ` Roger Quadros 2010-07-08 20:10 ` Ohad Ben-Cohen 2010-07-08 20:10 ` Ohad Ben-Cohen 2010-07-09 8:12 ` Roger Quadros 2010-07-09 8:12 ` Roger Quadros 2010-07-09 8:32 ` Ohad Ben-Cohen 2010-07-09 8:32 ` Ohad Ben-Cohen 2010-07-09 9:24 ` Grazvydas Ignotas 2010-07-09 9:24 ` Grazvydas Ignotas 2010-08-10 21:21 ` Ohad Ben-Cohen 2010-08-10 21:21 ` Ohad Ben-Cohen 2010-07-06 0:37 ` [PATCH 12/15] wireless: wl1271: take irq info from platform data Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` [PATCH 13/15] wireless: wl1271: make ref_clock configurable by board Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` [PATCH 14/15] omap: zoom: add WLAN device Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 12:33 ` Roger Quadros 2010-07-06 12:33 ` Roger Quadros 2010-07-06 13:47 ` Ohad Ben-Cohen 2010-07-06 13:47 ` Ohad Ben-Cohen 2010-07-06 13:47 ` Ohad Ben-Cohen 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-06 0:37 ` [PATCH 15/15] omap: zoom: enable " Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-06 0:37 ` Ohad Ben-Cohen 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-08 20:13 ` Ohad Ben-Cohen 2010-07-08 20:13 ` Ohad Ben-Cohen 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-08 3:39 ` [PATCH 00/15] wlan+omap+mmc: out-of-the-box WLAN support for ZOOM2/3 Ghorai, Sukumar 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-08 3:39 ` Ghorai, Sukumar 2010-07-08 3:39 ` Ghorai, Sukumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4C3306F4.8060907@nokia.com \ --to=roger.quadros@nokia.com \ --cc=Luciano.Coelho@nokia.com \ --cc=akpm@linux-foundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=madhu.cr@ti.com \ --cc=ohad@wizery.com \ --cc=ohadb@ti.com \ --cc=san@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.