All of lore.kernel.org
 help / color / mirror / Atom feed
From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Greg KH <greg@kroah.com>, Ohad Ben-Cohen <ohad@wizery.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Hebbar, Shivananda" <x0hebbar@ti.com>,
	"Ramos Falcon, Ernesto" <ernesto@ti.com>,
	"Anna, Suman" <s-anna@ti.com>,
	"Kanigeri, Hari" <h-kanigeri2@ti.com>,
	Felipe Balbi <felipe.balbi@nokia.com>,
	Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
	"Gupta, Ramesh" <grgupta@ti.com>,
	"Guzman Lugo, Fernando" <fernando.lugo@ti.com>,
	Tony Lindgren <tony@atomide.com>,
	Ameya Palande <ameya.palande@nokia.com>,
	"Gomez Castellanos, Ivan" <ivan.gomez@ti.com>,
	Andy Shevchenko <ext-andriy.shevchenko@nokia.com>,
	"Uribe de Leon, Armando" <x0095078@ti.com>,
	"Chitriki Rudramuni, Deepak" <deepak.chitriki@ti.com>,
	"Menon, Nishanth" <nm@ti.com>,
	Phil Carmody <ext-phil.2.carmody@nokia.com>,
	"Pitney, Gilbert" <gpitney@ti.com>, "Shah, Bhavin" <bshah@ti.com>
Subject: Re: [PATCH 11/11] staging: ti dspbridge: enable driver building
Date: Tue, 6 Jul 2010 10:52:28 -0500	[thread overview]
Message-ID: <4C33513C.4090704@ti.com> (raw)
In-Reply-To: <AANLkTik0rm12w4jplD1vSTZnPbwguDU6xtOdAfs9C-3r@mail.gmail.com>

On 7/4/2010 5:53 AM, Felipe Contreras wrote:
> On Thu, Jun 24, 2010 at 1:41 AM, Greg KH<greg@kroah.com>  wrote:
>> The default is always 'n' so you don't need this.
>>
>> Also, this enables the driver to be built on x86, which fails horribly,
>> and I don't think is what you really want to have happen :)
>>
>> So I need some more Kconfig changes here, care to redo just this one
>> patch?  I've applied all the others and they will show up in linux-next
>> tomorrow.
>
> I fixed all that stuff some time ago:
> http://article.gmane.org/gmane.linux.ports.arm.omap/36065
>
> But the patches were ignored.

Patches were not ignored, discussion was held privately (you and me), 
patch 13 was not accepted because changing indentation doesn't deserve a 
copyright assignment (IMHO), at that point *you* wanted your patches not 
to be included if the last one wasn't merged in.

- omar


WARNING: multiple messages have this Message-ID (diff)
From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Greg KH <greg@kroah.com>, Ohad Ben-Cohen <ohad@wizery.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Hebbar, Shivananda" <x0hebbar@ti.com>,
	"Ramos Falcon, Ernesto" <ernesto@ti.com>,
	"Anna, Suman" <s-anna@ti.com>,
	"Kanigeri, Hari" <h-kanigeri2@ti.com>,
	Felipe Balbi <felipe.balbi@nokia.com>,
	Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
	"Gupta, Ramesh" <grgupta@ti.com>,
	"Guzman Lugo, Fernando" <fernando.lugo@ti.com>,
	Tony Lindgren <tony@atomide.com>,
	Ameya Palande <ameya.palande@nokia.com>,
	"Gomez Castellanos, Ivan" <ivan.gomez@ti.com>,
	Andy Shevchenko <ext-andriy.shevchenko@nokia.com>,
	"Uribe de Leon, Armando" <x0095078@ti.com>,
	"Chitriki Rudramuni, Deepak" <deepak.chitriki@ti.com>,
	"Menon, Nishanth" <nm@ti.com>,
	Phil Carmody <ext-phil.2.carmody@nokia.com>,
	"Pitney, Gilbert" <gpitney@ti.com>
Subject: Re: [PATCH 11/11] staging: ti dspbridge: enable driver building
Date: Tue, 6 Jul 2010 10:52:28 -0500	[thread overview]
Message-ID: <4C33513C.4090704@ti.com> (raw)
In-Reply-To: <AANLkTik0rm12w4jplD1vSTZnPbwguDU6xtOdAfs9C-3r@mail.gmail.com>

On 7/4/2010 5:53 AM, Felipe Contreras wrote:
> On Thu, Jun 24, 2010 at 1:41 AM, Greg KH<greg@kroah.com>  wrote:
>> The default is always 'n' so you don't need this.
>>
>> Also, this enables the driver to be built on x86, which fails horribly,
>> and I don't think is what you really want to have happen :)
>>
>> So I need some more Kconfig changes here, care to redo just this one
>> patch?  I've applied all the others and they will show up in linux-next
>> tomorrow.
>
> I fixed all that stuff some time ago:
> http://article.gmane.org/gmane.linux.ports.arm.omap/36065
>
> But the patches were ignored.

Patches were not ignored, discussion was held privately (you and me), 
patch 13 was not accepted because changing indentation doesn't deserve a 
copyright assignment (IMHO), at that point *you* wanted your patches not 
to be included if the last one wasn't merged in.

- omar

  reply	other threads:[~2010-07-06 15:52 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-23 13:01 [PATCH 00/11] staging: add ti dspbridge driver Ohad Ben-Cohen
2010-06-23 13:01 ` Ohad Ben-Cohen
2010-06-23 13:01 ` [PATCH 01/11] staging: ti dspbridge: add driver documentation Ohad Ben-Cohen
2010-06-23 13:01   ` Ohad Ben-Cohen
2010-06-23 13:01 ` [PATCH 02/11] staging: ti dspbridge: add core driver sources Ohad Ben-Cohen
2010-06-23 13:01   ` Ohad Ben-Cohen
2010-06-23 13:01 ` [PATCH 03/11] staging: ti dspbridge: add platform manager code Ohad Ben-Cohen
2010-06-23 13:01   ` Ohad Ben-Cohen
2010-06-23 13:01 ` [PATCH 04/11] staging: ti dspbridge: add resource manager Ohad Ben-Cohen
2010-06-23 13:01   ` Ohad Ben-Cohen
2010-06-23 13:01 ` [PATCH 05/11] staging: ti dspbridge: add MMU support Ohad Ben-Cohen
2010-06-23 13:01   ` Ohad Ben-Cohen
2010-06-23 13:02 ` [PATCH 06/11] staging: ti dspbridge: add generic utilities Ohad Ben-Cohen
2010-06-23 13:02   ` Ohad Ben-Cohen
2010-06-23 15:43   ` Andy Shevchenko
2010-06-24  7:09     ` Ohad Ben-Cohen
2010-07-06 15:08       ` [PATCH] staging: tidspbridge: gen: simplify and clean up Andy Shevchenko
2010-06-23 13:02 ` [PATCH 07/11] staging: ti dspbridge: add services Ohad Ben-Cohen
2010-06-23 13:02   ` Ohad Ben-Cohen
2010-06-23 13:02 ` [PATCH 08/11] staging: ti dspbridge: add DOFF binaries loader Ohad Ben-Cohen
2010-06-23 13:02   ` Ohad Ben-Cohen
2010-06-23 13:12 ` [PATCH 09/11] staging: ti dspbridge: add header files Ohad Ben-Cohen
2010-06-23 13:12   ` Ohad Ben-Cohen
2010-06-23 13:13 ` [PATCH 10/11] staging: ti dspbridge: add TODO file Ohad Ben-Cohen
2010-06-23 13:13   ` Ohad Ben-Cohen
2010-06-23 13:14 ` [PATCH 11/11] staging: ti dspbridge: enable driver building Ohad Ben-Cohen
2010-06-23 13:14   ` Ohad Ben-Cohen
2010-06-23 22:41   ` Greg KH
2010-06-24 13:40     ` Ohad Ben-Cohen
2010-06-24 13:40       ` Ohad Ben-Cohen
2010-07-04 10:53     ` Felipe Contreras
2010-07-04 10:53       ` Felipe Contreras
2010-07-06 15:52       ` Omar Ramirez Luna [this message]
2010-07-06 15:52         ` Omar Ramirez Luna
2010-07-07  9:31         ` Felipe Contreras
2010-07-07 10:18           ` Ohad Ben-Cohen
2010-07-07 20:43           ` Ramirez Luna, Omar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C33513C.4090704@ti.com \
    --to=omar.ramirez@ti.com \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=ameya.palande@nokia.com \
    --cc=bshah@ti.com \
    --cc=deepak.chitriki@ti.com \
    --cc=ernesto@ti.com \
    --cc=ext-andriy.shevchenko@nokia.com \
    --cc=ext-phil.2.carmody@nokia.com \
    --cc=felipe.balbi@nokia.com \
    --cc=felipe.contreras@gmail.com \
    --cc=fernando.lugo@ti.com \
    --cc=gpitney@ti.com \
    --cc=greg@kroah.com \
    --cc=grgupta@ti.com \
    --cc=h-kanigeri2@ti.com \
    --cc=ivan.gomez@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=ohad@wizery.com \
    --cc=s-anna@ti.com \
    --cc=tony@atomide.com \
    --cc=x0095078@ti.com \
    --cc=x0hebbar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.