* [PATCH] i2c-pxa: fix compiler warning, due to missing const @ 2010-06-15 8:56 Marc Kleine-Budde [not found] ` <1276592205-26284-1-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Marc Kleine-Budde @ 2010-06-15 8:56 UTC (permalink / raw) To: linux-i2c-u79uwXL29TY76Z2rM5mHXA Cc: Marc Kleine-Budde, Eric Miao, Roel Kluin, Pavel Machek This patch adds the missing const to "struct platform_device_id" to fix this warning: /home/frogger/pengutronix/linux/linux-2.6/drivers/i2c/busses/i2c-pxa.c: In function 'i2c_pxa_probe': /home/frogger/pengutronix/linux/linux-2.6/drivers/i2c/busses/i2c-pxa.c:1004: warning: initialization discards qualifiers from pointer target type Signed-off-by: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Cc: Eric Miao <eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Roel Kluin <roel.kluin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org> --- drivers/i2c/busses/i2c-pxa.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index 020ff23..c94e51b 100644 --- a/drivers/i2c/busses/i2c-pxa.c +++ b/drivers/i2c/busses/i2c-pxa.c @@ -1001,7 +1001,7 @@ static int i2c_pxa_probe(struct platform_device *dev) struct pxa_i2c *i2c; struct resource *res; struct i2c_pxa_platform_data *plat = dev->dev.platform_data; - struct platform_device_id *id = platform_get_device_id(dev); + const struct platform_device_id *id = platform_get_device_id(dev); int ret; int irq; -- 1.7.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <1276592205-26284-1-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]
* Re: [PATCH] i2c-pxa: fix compiler warning, due to missing const [not found] ` <1276592205-26284-1-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> @ 2010-06-15 9:52 ` Eric Miao [not found] ` <AANLkTiksiKUecR8tVYDEsKVYE7BxF5WAu9KdJISFRBFB-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Eric Miao @ 2010-06-15 9:52 UTC (permalink / raw) To: Marc Kleine-Budde Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Roel Kluin, Pavel Machek On Tue, Jun 15, 2010 at 4:56 PM, Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote: > This patch adds the missing const to "struct platform_device_id" to fix > this warning: > > /home/frogger/pengutronix/linux/linux-2.6/drivers/i2c/busses/i2c-pxa.c: > In function 'i2c_pxa_probe': > /home/frogger/pengutronix/linux/linux-2.6/drivers/i2c/busses/i2c-pxa.c:1004: > warning: initialization discards qualifiers from pointer target type > > Signed-off-by: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> > Cc: Eric Miao <eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Ack > Cc: Roel Kluin <roel.kluin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > Cc: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org> > --- > drivers/i2c/busses/i2c-pxa.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c > index 020ff23..c94e51b 100644 > --- a/drivers/i2c/busses/i2c-pxa.c > +++ b/drivers/i2c/busses/i2c-pxa.c > @@ -1001,7 +1001,7 @@ static int i2c_pxa_probe(struct platform_device *dev) > struct pxa_i2c *i2c; > struct resource *res; > struct i2c_pxa_platform_data *plat = dev->dev.platform_data; > - struct platform_device_id *id = platform_get_device_id(dev); > + const struct platform_device_id *id = platform_get_device_id(dev); > int ret; > int irq; > > -- > 1.7.1 > > ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <AANLkTiksiKUecR8tVYDEsKVYE7BxF5WAu9KdJISFRBFB-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] i2c-pxa: fix compiler warning, due to missing const [not found] ` <AANLkTiksiKUecR8tVYDEsKVYE7BxF5WAu9KdJISFRBFB-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2010-06-20 22:34 ` Ben Dooks [not found] ` <20100620223400.GB12387-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Ben Dooks @ 2010-06-20 22:34 UTC (permalink / raw) To: Eric Miao Cc: Marc Kleine-Budde, linux-i2c-u79uwXL29TY76Z2rM5mHXA, Roel Kluin, Pavel Machek On Tue, Jun 15, 2010 at 05:52:09PM +0800, Eric Miao wrote: > On Tue, Jun 15, 2010 at 4:56 PM, Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote: > > This patch adds the missing const to "struct platform_device_id" to fix > > this warning: > > > > /home/frogger/pengutronix/linux/linux-2.6/drivers/i2c/busses/i2c-pxa.c: > > In function 'i2c_pxa_probe': > > /home/frogger/pengutronix/linux/linux-2.6/drivers/i2c/busses/i2c-pxa.c:1004: > > warning: initialization discards qualifiers from pointer target type > > > > Signed-off-by: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> > > Cc: Eric Miao <eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > Ack ok, will apply. -- Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20100620223400.GB12387-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>]
* Re: [PATCH] i2c-pxa: fix compiler warning, due to missing const [not found] ` <20100620223400.GB12387-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org> @ 2010-06-21 6:56 ` Marc Kleine-Budde [not found] ` <4C1F0D19.7030901-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Marc Kleine-Budde @ 2010-06-21 6:56 UTC (permalink / raw) To: Ben Dooks; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 1041 bytes --] Ben Dooks wrote: > On Tue, Jun 15, 2010 at 05:52:09PM +0800, Eric Miao wrote: >> On Tue, Jun 15, 2010 at 4:56 PM, Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> wrote: >>> This patch adds the missing const to "struct platform_device_id" to fix >>> this warning: >>> >>> /home/frogger/pengutronix/linux/linux-2.6/drivers/i2c/busses/i2c-pxa.c: >>> In function 'i2c_pxa_probe': >>> /home/frogger/pengutronix/linux/linux-2.6/drivers/i2c/busses/i2c-pxa.c:1004: >>> warning: initialization discards qualifiers from pointer target type >>> >>> Signed-off-by: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> >>> Cc: Eric Miao <eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> Ack > > ok, will apply. tnx Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 260 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <4C1F0D19.7030901-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]
* Re: [PATCH] i2c-pxa: fix compiler warning, due to missing const [not found] ` <4C1F0D19.7030901-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> @ 2010-07-15 7:43 ` Marc Kleine-Budde 2010-07-19 8:13 ` Marc Kleine-Budde 1 sibling, 0 replies; 6+ messages in thread From: Marc Kleine-Budde @ 2010-07-15 7:43 UTC (permalink / raw) To: Ben Dooks; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 1126 bytes --] Hey Ben, Marc Kleine-Budde wrote: > Ben Dooks wrote: >> On Tue, Jun 15, 2010 at 05:52:09PM +0800, Eric Miao wrote: >>> On Tue, Jun 15, 2010 at 4:56 PM, Marc Kleine-Budde <mkl@pengutronix.de> wrote: >>>> This patch adds the missing const to "struct platform_device_id" to fix >>>> this warning: >>>> >>>> /home/frogger/pengutronix/linux/linux-2.6/drivers/i2c/busses/i2c-pxa.c: >>>> In function 'i2c_pxa_probe': >>>> /home/frogger/pengutronix/linux/linux-2.6/drivers/i2c/busses/i2c-pxa.c:1004: >>>> warning: initialization discards qualifiers from pointer target type >>>> >>>> Signed-off-by: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> >>>> Cc: Eric Miao <eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >>> Ack >> ok, will apply. ping, is there a change to get this patch into 2.6.35? cheers, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 260 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c-pxa: fix compiler warning, due to missing const [not found] ` <4C1F0D19.7030901-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2010-07-15 7:43 ` Marc Kleine-Budde @ 2010-07-19 8:13 ` Marc Kleine-Budde 1 sibling, 0 replies; 6+ messages in thread From: Marc Kleine-Budde @ 2010-07-19 8:13 UTC (permalink / raw) To: Ben Dooks; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 1194 bytes --] Hey Ben, Marc Kleine-Budde wrote: > Ben Dooks wrote: >> On Tue, Jun 15, 2010 at 05:52:09PM +0800, Eric Miao wrote: >>> On Tue, Jun 15, 2010 at 4:56 PM, Marc Kleine-Budde <mkl@pengutronix.de> wrote: >>>> This patch adds the missing const to "struct platform_device_id" to fix >>>> this warning: >>>> >>>> /home/frogger/pengutronix/linux/linux-2.6/drivers/i2c/busses/i2c-pxa.c: >>>> In function 'i2c_pxa_probe': >>>> /home/frogger/pengutronix/linux/linux-2.6/drivers/i2c/busses/i2c-pxa.c:1004: >>>> warning: initialization discards qualifiers from pointer target type >>>> >>>> Signed-off-by: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> >>>> Cc: Eric Miao <eric.y.miao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >>> Ack >> ok, will apply. ping, is there a change to get this patch into 2.6.35? I think compiler warnings in a kernel release don't look good. cheers, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 260 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-07-19 8:13 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2010-06-15 8:56 [PATCH] i2c-pxa: fix compiler warning, due to missing const Marc Kleine-Budde [not found] ` <1276592205-26284-1-git-send-email-mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2010-06-15 9:52 ` Eric Miao [not found] ` <AANLkTiksiKUecR8tVYDEsKVYE7BxF5WAu9KdJISFRBFB-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2010-06-20 22:34 ` Ben Dooks [not found] ` <20100620223400.GB12387-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org> 2010-06-21 6:56 ` Marc Kleine-Budde [not found] ` <4C1F0D19.7030901-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2010-07-15 7:43 ` Marc Kleine-Budde 2010-07-19 8:13 ` Marc Kleine-Budde
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.