All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI
@ 2010-07-22  5:14 Chanwoo Choi
  2010-07-22  7:35 ` Seungwhan Youn
  2010-07-22 10:56 ` Mark Brown
  0 siblings, 2 replies; 10+ messages in thread
From: Chanwoo Choi @ 2010-07-22  5:14 UTC (permalink / raw)
  To: alsa-devel; +Cc: Kyungmin Park, Mark Brown, Joonyoung Shim, Liam Girdwood

This patch modify some code which register a DAI with ASoC core
according to modified registration API of DAI.

Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 sound/soc/s3c24xx/aquila_wm8994.c |    3 +--
 sound/soc/s3c24xx/s3c-i2s-v2.c    |    2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/soc/s3c24xx/aquila_wm8994.c b/sound/soc/s3c24xx/aquila_wm8994.c
index 69c41eb..007ed3a 100644
--- a/sound/soc/s3c24xx/aquila_wm8994.c
+++ b/sound/soc/s3c24xx/aquila_wm8994.c
@@ -268,8 +268,7 @@ static int __init aquila_init(void)
 		return -ENOMEM;
 
 	/* register voice DAI here */
-	ret = snd_soc_register_dai(&aquila_snd_device->dev,
-			0, &voice_dai);
+	ret = snd_soc_register_dai(&aquila_snd_device->dev, &voice_dai);
 	if (ret)
 		return ret;
 
diff --git a/sound/soc/s3c24xx/s3c-i2s-v2.c b/sound/soc/s3c24xx/s3c-i2s-v2.c
index f4fbc0e..b3866d5 100644
--- a/sound/soc/s3c24xx/s3c-i2s-v2.c
+++ b/sound/soc/s3c24xx/s3c-i2s-v2.c
@@ -750,7 +750,7 @@ int s3c_i2sv2_register_dai(struct device *dev, int id,
 	drv->suspend = s3c2412_i2s_suspend;
 	drv->resume = s3c2412_i2s_resume;
 
-	return snd_soc_register_dai(dev, id, drv);
+	return snd_soc_register_dai(dev, drv);
 }
 EXPORT_SYMBOL_GPL(s3c_i2sv2_register_dai);
 
-- 
1.6.3.3

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI
  2010-07-22  5:14 [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI Chanwoo Choi
@ 2010-07-22  7:35 ` Seungwhan Youn
  2010-07-22  7:45   ` Chanwoo Choi
  2010-07-22 10:56 ` Mark Brown
  1 sibling, 1 reply; 10+ messages in thread
From: Seungwhan Youn @ 2010-07-22  7:35 UTC (permalink / raw)
  To: Chanwoo Choi
  Cc: alsa-devel, Mark Brown, Liam Girdwood, Kyungmin Park, Joonyoung Shim

Hi,

On Thu, Jul 22, 2010 at 2:14 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> This patch modify some code which register a DAI with ASoC core
> according to modified registration API of DAI.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  sound/soc/s3c24xx/aquila_wm8994.c |    3 +--
>  sound/soc/s3c24xx/s3c-i2s-v2.c    |    2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/s3c24xx/aquila_wm8994.c b/sound/soc/s3c24xx/aquila_wm8994.c
> index 69c41eb..007ed3a 100644
> --- a/sound/soc/s3c24xx/aquila_wm8994.c
> +++ b/sound/soc/s3c24xx/aquila_wm8994.c
> @@ -268,8 +268,7 @@ static int __init aquila_init(void)
>                return -ENOMEM;
>
>        /* register voice DAI here */
> -       ret = snd_soc_register_dai(&aquila_snd_device->dev,
> -                       0, &voice_dai);
> +       ret = snd_soc_register_dai(&aquila_snd_device->dev, &voice_dai);
>        if (ret)
>                return ret;
>
> diff --git a/sound/soc/s3c24xx/s3c-i2s-v2.c b/sound/soc/s3c24xx/s3c-i2s-v2.c
> index f4fbc0e..b3866d5 100644
> --- a/sound/soc/s3c24xx/s3c-i2s-v2.c
> +++ b/sound/soc/s3c24xx/s3c-i2s-v2.c
> @@ -750,7 +750,7 @@ int s3c_i2sv2_register_dai(struct device *dev, int id,
>        drv->suspend = s3c2412_i2s_suspend;
>        drv->resume = s3c2412_i2s_resume;
>
> -       return snd_soc_register_dai(dev, id, drv);
> +       return snd_soc_register_dai(dev, drv);

How about s3c64xx-i2s? I think, if this patch fixes all errors in
'sound/soc/s3c24xx',
It'll be more nice than this.

>  }
>  EXPORT_SYMBOL_GPL(s3c_i2sv2_register_dai);
>
> --
> 1.6.3.3
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI
  2010-07-22  7:35 ` Seungwhan Youn
@ 2010-07-22  7:45   ` Chanwoo Choi
  2010-07-22  7:55     ` Seungwhan Youn
  0 siblings, 1 reply; 10+ messages in thread
From: Chanwoo Choi @ 2010-07-22  7:45 UTC (permalink / raw)
  To: Seungwhan Youn
  Cc: alsa-devel, Joonyoung Shim, Mark Brown, Chanwoo Choi,
	Kyungmin Park, Liam Girdwood

Seungwhan Youn wrote:
> Hi,
> 
> On Thu, Jul 22, 2010 at 2:14 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> This patch modify some code which register a DAI with ASoC core
>> according to modified registration API of DAI.
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>>  sound/soc/s3c24xx/aquila_wm8994.c |    3 +--
>>  sound/soc/s3c24xx/s3c-i2s-v2.c    |    2 +-
>>  2 files changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/sound/soc/s3c24xx/aquila_wm8994.c b/sound/soc/s3c24xx/aquila_wm8994.c
>> index 69c41eb..007ed3a 100644
>> --- a/sound/soc/s3c24xx/aquila_wm8994.c
>> +++ b/sound/soc/s3c24xx/aquila_wm8994.c
>> @@ -268,8 +268,7 @@ static int __init aquila_init(void)
>>                return -ENOMEM;
>>
>>        /* register voice DAI here */
>> -       ret = snd_soc_register_dai(&aquila_snd_device->dev,
>> -                       0, &voice_dai);
>> +       ret = snd_soc_register_dai(&aquila_snd_device->dev, &voice_dai);
>>        if (ret)
>>                return ret;
>>
>> diff --git a/sound/soc/s3c24xx/s3c-i2s-v2.c b/sound/soc/s3c24xx/s3c-i2s-v2.c
>> index f4fbc0e..b3866d5 100644
>> --- a/sound/soc/s3c24xx/s3c-i2s-v2.c
>> +++ b/sound/soc/s3c24xx/s3c-i2s-v2.c
>> @@ -750,7 +750,7 @@ int s3c_i2sv2_register_dai(struct device *dev, int id,
>>        drv->suspend = s3c2412_i2s_suspend;
>>        drv->resume = s3c2412_i2s_resume;
>>
>> -       return snd_soc_register_dai(dev, id, drv);
>> +       return snd_soc_register_dai(dev, drv);
> 
> How about s3c64xx-i2s? I think, if this patch fixes all errors in
Sorry, I confused your comment.
What do you mean "How about s3c64xx-i2s" ?

> 'sound/soc/s3c24xx',
> It'll be more nice than this.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI
  2010-07-22  7:45   ` Chanwoo Choi
@ 2010-07-22  7:55     ` Seungwhan Youn
  2010-07-22  8:05       ` Chanwoo Choi
  0 siblings, 1 reply; 10+ messages in thread
From: Seungwhan Youn @ 2010-07-22  7:55 UTC (permalink / raw)
  To: Chanwoo Choi
  Cc: Joonyoung Shim, alsa-devel, Mark Brown, Kyungmin Park, Liam Girdwood

On Thu, Jul 22, 2010 at 4:45 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Seungwhan Youn wrote:
>> Hi,
>>
>> On Thu, Jul 22, 2010 at 2:14 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>>> This patch modify some code which register a DAI with ASoC core
>>> according to modified registration API of DAI.
>>>
>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>>> ---
>>>  sound/soc/s3c24xx/aquila_wm8994.c |    3 +--
>>>  sound/soc/s3c24xx/s3c-i2s-v2.c    |    2 +-
>>>  2 files changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/sound/soc/s3c24xx/aquila_wm8994.c b/sound/soc/s3c24xx/aquila_wm8994.c
>>> index 69c41eb..007ed3a 100644
>>> --- a/sound/soc/s3c24xx/aquila_wm8994.c
>>> +++ b/sound/soc/s3c24xx/aquila_wm8994.c
>>> @@ -268,8 +268,7 @@ static int __init aquila_init(void)
>>>                return -ENOMEM;
>>>
>>>        /* register voice DAI here */
>>> -       ret = snd_soc_register_dai(&aquila_snd_device->dev,
>>> -                       0, &voice_dai);
>>> +       ret = snd_soc_register_dai(&aquila_snd_device->dev, &voice_dai);
>>>        if (ret)
>>>                return ret;
>>>
>>> diff --git a/sound/soc/s3c24xx/s3c-i2s-v2.c b/sound/soc/s3c24xx/s3c-i2s-v2.c
>>> index f4fbc0e..b3866d5 100644
>>> --- a/sound/soc/s3c24xx/s3c-i2s-v2.c
>>> +++ b/sound/soc/s3c24xx/s3c-i2s-v2.c
>>> @@ -750,7 +750,7 @@ int s3c_i2sv2_register_dai(struct device *dev, int id,
>>>        drv->suspend = s3c2412_i2s_suspend;
>>>        drv->resume = s3c2412_i2s_resume;
>>>
>>> -       return snd_soc_register_dai(dev, id, drv);
>>> +       return snd_soc_register_dai(dev, drv);
>>
>> How about s3c64xx-i2s? I think, if this patch fixes all errors in
> Sorry, I confused your comment.
> What do you mean "How about s3c64xx-i2s" ?

Actually 'sound/soc/s3c24xx/s3c64xx-i2s.c' has same error.

So, If this patch's purpose is to fix compile error, my opinion is
that this patch fix all the same errors in 'sound/soc/s3c24xx/'.

>
>> 'sound/soc/s3c24xx',
>> It'll be more nice than this.
>
>
>
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI
  2010-07-22  7:55     ` Seungwhan Youn
@ 2010-07-22  8:05       ` Chanwoo Choi
  2010-07-22  8:26         ` Seungwhan Youn
  0 siblings, 1 reply; 10+ messages in thread
From: Chanwoo Choi @ 2010-07-22  8:05 UTC (permalink / raw)
  To: Seungwhan Youn
  Cc: Joonyoung Shim, alsa-devel, Mark Brown, Kyungmin Park, Liam Girdwood

Seungwhan Youn wrote:
> On Thu, Jul 22, 2010 at 4:45 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> Seungwhan Youn wrote:
>>> Hi,
>>>
>>> On Thu, Jul 22, 2010 at 2:14 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>>>> This patch modify some code which register a DAI with ASoC core
>>>> according to modified registration API of DAI.
>>>>
>>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>>>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>>>> ---
>>>>  sound/soc/s3c24xx/aquila_wm8994.c |    3 +--
>>>>  sound/soc/s3c24xx/s3c-i2s-v2.c    |    2 +-
>>>>  2 files changed, 2 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/sound/soc/s3c24xx/aquila_wm8994.c b/sound/soc/s3c24xx/aquila_wm8994.c
>>>> index 69c41eb..007ed3a 100644
>>>> --- a/sound/soc/s3c24xx/aquila_wm8994.c
>>>> +++ b/sound/soc/s3c24xx/aquila_wm8994.c
>>>> @@ -268,8 +268,7 @@ static int __init aquila_init(void)
>>>>                return -ENOMEM;
>>>>
>>>>        /* register voice DAI here */
>>>> -       ret = snd_soc_register_dai(&aquila_snd_device->dev,
>>>> -                       0, &voice_dai);
>>>> +       ret = snd_soc_register_dai(&aquila_snd_device->dev, &voice_dai);
>>>>        if (ret)
>>>>                return ret;
>>>>
>>>> diff --git a/sound/soc/s3c24xx/s3c-i2s-v2.c b/sound/soc/s3c24xx/s3c-i2s-v2.c
>>>> index f4fbc0e..b3866d5 100644
>>>> --- a/sound/soc/s3c24xx/s3c-i2s-v2.c
>>>> +++ b/sound/soc/s3c24xx/s3c-i2s-v2.c
>>>> @@ -750,7 +750,7 @@ int s3c_i2sv2_register_dai(struct device *dev, int id,
>>>>        drv->suspend = s3c2412_i2s_suspend;
>>>>        drv->resume = s3c2412_i2s_resume;
>>>>
>>>> -       return snd_soc_register_dai(dev, id, drv);
>>>> +       return snd_soc_register_dai(dev, drv);
>>> How about s3c64xx-i2s? I think, if this patch fixes all errors in
>> Sorry, I confused your comment.
>> What do you mean "How about s3c64xx-i2s" ?
> 
> Actually 'sound/soc/s3c24xx/s3c64xx-i2s.c' has same error.
> 
> So, If this patch's purpose is to fix compile error, my opinion is
> that this patch fix all the same errors in 'sound/soc/s3c24xx/'.

The 'sound/soc/s3c24xx/s3c64xx-i2s.c' haven't directly called 
'snd_soc_register_dai()' function. 
It is call 's3c_i2sv2_register_dai()' in 'sound/soc/s3c24xx/s3c-i2s-v2.c' 
to register a DAI.

> 
>>> 'sound/soc/s3c24xx',
>>> It'll be more nice than this.
>>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI
  2010-07-22  8:05       ` Chanwoo Choi
@ 2010-07-22  8:26         ` Seungwhan Youn
  2010-07-22 10:15           ` Liam Girdwood
  0 siblings, 1 reply; 10+ messages in thread
From: Seungwhan Youn @ 2010-07-22  8:26 UTC (permalink / raw)
  To: Chanwoo Choi
  Cc: Joonyoung Shim, alsa-devel, Mark Brown, Kyungmin Park, Liam Girdwood

>>>>> +       return snd_soc_register_dai(dev, drv);
>>>> How about s3c64xx-i2s? I think, if this patch fixes all errors in
>>> Sorry, I confused your comment.
>>> What do you mean "How about s3c64xx-i2s" ?
>>
>> Actually 'sound/soc/s3c24xx/s3c64xx-i2s.c' has same error.
>>
>> So, If this patch's purpose is to fix compile error, my opinion is
>> that this patch fix all the same errors in 'sound/soc/s3c24xx/'.
>
> The 'sound/soc/s3c24xx/s3c64xx-i2s.c' haven't directly called
> 'snd_soc_register_dai()' function.
> It is call 's3c_i2sv2_register_dai()' in 'sound/soc/s3c24xx/s3c-i2s-v2.c'
> to register a DAI.
>

Oh, I was confused about this even I modify this few days ago.
I'm sorry that I make you to be confused.

>>
>>>> 'sound/soc/s3c24xx',
>>>> It'll be more nice than this.
>>>
>
>

Thanks,
claude
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI
  2010-07-22  8:26         ` Seungwhan Youn
@ 2010-07-22 10:15           ` Liam Girdwood
  2010-07-22 10:43             ` Seungwhan Youn
  0 siblings, 1 reply; 10+ messages in thread
From: Liam Girdwood @ 2010-07-22 10:15 UTC (permalink / raw)
  To: Seungwhan Youn
  Cc: Kyungmin Park, Chanwoo Choi, alsa-devel, Mark Brown, Joonyoung Shim

On Thu, 2010-07-22 at 17:26 +0900, Seungwhan Youn wrote:
> >>>>> +       return snd_soc_register_dai(dev, drv);
> >>>> How about s3c64xx-i2s? I think, if this patch fixes all errors in
> >>> Sorry, I confused your comment.
> >>> What do you mean "How about s3c64xx-i2s" ?
> >>
> >> Actually 'sound/soc/s3c24xx/s3c64xx-i2s.c' has same error.
> >>
> >> So, If this patch's purpose is to fix compile error, my opinion is
> >> that this patch fix all the same errors in 'sound/soc/s3c24xx/'.
> >
> > The 'sound/soc/s3c24xx/s3c64xx-i2s.c' haven't directly called
> > 'snd_soc_register_dai()' function.
> > It is call 's3c_i2sv2_register_dai()' in 'sound/soc/s3c24xx/s3c-i2s-v2.c'
> > to register a DAI.
> >
> 
> Oh, I was confused about this even I modify this few days ago.
> I'm sorry that I make you to be confused.
> 

I'm confused too ;)

Is this to be applied or not ?

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI
  2010-07-22 10:15           ` Liam Girdwood
@ 2010-07-22 10:43             ` Seungwhan Youn
  2010-07-22 11:42               ` Liam Girdwood
  0 siblings, 1 reply; 10+ messages in thread
From: Seungwhan Youn @ 2010-07-22 10:43 UTC (permalink / raw)
  To: Liam Girdwood
  Cc: Kyungmin Park, Chanwoo Choi, alsa-devel, Mark Brown, Joonyoung Shim

On Thu, Jul 22, 2010 at 7:15 PM, Liam Girdwood <lrg@slimlogic.co.uk> wrote:
> On Thu, 2010-07-22 at 17:26 +0900, Seungwhan Youn wrote:
>> >>>>> +       return snd_soc_register_dai(dev, drv);
>> >>>> How about s3c64xx-i2s? I think, if this patch fixes all errors in
>> >>> Sorry, I confused your comment.
>> >>> What do you mean "How about s3c64xx-i2s" ?
>> >>
>> >> Actually 'sound/soc/s3c24xx/s3c64xx-i2s.c' has same error.
>> >>
>> >> So, If this patch's purpose is to fix compile error, my opinion is
>> >> that this patch fix all the same errors in 'sound/soc/s3c24xx/'.
>> >
>> > The 'sound/soc/s3c24xx/s3c64xx-i2s.c' haven't directly called
>> > 'snd_soc_register_dai()' function.
>> > It is call 's3c_i2sv2_register_dai()' in 'sound/soc/s3c24xx/s3c-i2s-v2.c'
>> > to register a DAI.
>> >
>>
>> Oh, I was confused about this even I modify this few days ago.
>> I'm sorry that I make you to be confused.
>>
>
> I'm confused too ;)
>
> Is this to be applied or not ?

I think this okay. :)

>
> Liam
> --
> Freelance Developer, SlimLogic Ltd
> ASoC and Voltage Regulator Maintainer.
> http://www.slimlogic.co.uk
>
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI
  2010-07-22  5:14 [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI Chanwoo Choi
  2010-07-22  7:35 ` Seungwhan Youn
@ 2010-07-22 10:56 ` Mark Brown
  1 sibling, 0 replies; 10+ messages in thread
From: Mark Brown @ 2010-07-22 10:56 UTC (permalink / raw)
  To: Chanwoo Choi; +Cc: alsa-devel, Liam Girdwood, Kyungmin Park, Joonyoung Shim

On Thu, Jul 22, 2010 at 02:14:11PM +0900, Chanwoo Choi wrote:
> This patch modify some code which register a DAI with ASoC core
> according to modified registration API of DAI.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI
  2010-07-22 10:43             ` Seungwhan Youn
@ 2010-07-22 11:42               ` Liam Girdwood
  0 siblings, 0 replies; 10+ messages in thread
From: Liam Girdwood @ 2010-07-22 11:42 UTC (permalink / raw)
  To: Seungwhan Youn
  Cc: Chanwoo Choi, Kyungmin Park, Mark Brown, alsa-devel, Joonyoung Shim

On Thu, 2010-07-22 at 19:43 +0900, Seungwhan Youn wrote:
> On Thu, Jul 22, 2010 at 7:15 PM, Liam Girdwood <lrg@slimlogic.co.uk> wrote:
> > On Thu, 2010-07-22 at 17:26 +0900, Seungwhan Youn wrote:
> >> >>>>> +       return snd_soc_register_dai(dev, drv);
> >> >>>> How about s3c64xx-i2s? I think, if this patch fixes all errors in
> >> >>> Sorry, I confused your comment.
> >> >>> What do you mean "How about s3c64xx-i2s" ?
> >> >>
> >> >> Actually 'sound/soc/s3c24xx/s3c64xx-i2s.c' has same error.
> >> >>
> >> >> So, If this patch's purpose is to fix compile error, my opinion is
> >> >> that this patch fix all the same errors in 'sound/soc/s3c24xx/'.
> >> >
> >> > The 'sound/soc/s3c24xx/s3c64xx-i2s.c' haven't directly called
> >> > 'snd_soc_register_dai()' function.
> >> > It is call 's3c_i2sv2_register_dai()' in 'sound/soc/s3c24xx/s3c-i2s-v2.c'
> >> > to register a DAI.
> >> >
> >>
> >> Oh, I was confused about this even I modify this few days ago.
> >> I'm sorry that I make you to be confused.
> >>
> >
> > I'm confused too ;)
> >
> > Is this to be applied or not ?
> 
> I think this okay. :)
> 
All applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2010-07-22 11:42 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-22  5:14 [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI Chanwoo Choi
2010-07-22  7:35 ` Seungwhan Youn
2010-07-22  7:45   ` Chanwoo Choi
2010-07-22  7:55     ` Seungwhan Youn
2010-07-22  8:05       ` Chanwoo Choi
2010-07-22  8:26         ` Seungwhan Youn
2010-07-22 10:15           ` Liam Girdwood
2010-07-22 10:43             ` Seungwhan Youn
2010-07-22 11:42               ` Liam Girdwood
2010-07-22 10:56 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.