All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sctp: Process OOTB ASCONF Chunk at CLOSED state
@ 2010-07-23  8:50 Shan Wei
  2010-07-23 13:30 ` Vlad Yasevich
  0 siblings, 1 reply; 2+ messages in thread
From: Shan Wei @ 2010-07-23  8:50 UTC (permalink / raw)
  To: linux-sctp

RFC5061 said that If the received ASCONF Chunk is not associated with 
any association, the Chunk should be treated as OOTB. So, process
this OOTB chunk according to section 8.4 of RFC4960.

Quote from RFC5061:
5.2. Upon Reception of an ASCONF Chunk
   D3)  If neither D1, D2, nor D2-ext locates the association, treat the
        chunk as an Out Of The Blue packet as defined in [RFC4960].


Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
---
 net/sctp/sm_statetable.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sctp/sm_statetable.c b/net/sctp/sm_statetable.c
index 6d9b3aa..ca300db 100644
--- a/net/sctp/sm_statetable.c
+++ b/net/sctp/sm_statetable.c
@@ -449,7 +449,7 @@ static const sctp_sm_table_entry_t chunk_event_table[SCTP_NUM_BASE_CHUNK_TYPES][
 	/* SCTP_STATE_EMPTY */ \
 	TYPE_SCTP_FUNC(sctp_sf_ootb), \
 	/* SCTP_STATE_CLOSED */ \
-	TYPE_SCTP_FUNC(sctp_sf_discard_chunk), \
+	TYPE_SCTP_FUNC(sctp_sf_ootb), \
 	/* SCTP_STATE_COOKIE_WAIT */ \
 	TYPE_SCTP_FUNC(sctp_sf_discard_chunk), \
 	/* SCTP_STATE_COOKIE_ECHOED */ \
-- 
1.6.3.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] sctp: Process OOTB ASCONF Chunk at CLOSED state
  2010-07-23  8:50 [PATCH] sctp: Process OOTB ASCONF Chunk at CLOSED state Shan Wei
@ 2010-07-23 13:30 ` Vlad Yasevich
  0 siblings, 0 replies; 2+ messages in thread
From: Vlad Yasevich @ 2010-07-23 13:30 UTC (permalink / raw)
  To: linux-sctp

On 07/23/2010 04:50 AM, Shan Wei wrote:
> RFC5061 said that If the received ASCONF Chunk is not associated with 
> any association, the Chunk should be treated as OOTB. So, process
> this OOTB chunk according to section 8.4 of RFC4960.
> 
> Quote from RFC5061:
> 5.2. Upon Reception of an ASCONF Chunk
>    D3)  If neither D1, D2, nor D2-ext locates the association, treat the
>         chunk as an Out Of The Blue packet as defined in [RFC4960].
> 
> 
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
> ---
>  net/sctp/sm_statetable.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/sctp/sm_statetable.c b/net/sctp/sm_statetable.c
> index 6d9b3aa..ca300db 100644
> --- a/net/sctp/sm_statetable.c
> +++ b/net/sctp/sm_statetable.c
> @@ -449,7 +449,7 @@ static const sctp_sm_table_entry_t chunk_event_table[SCTP_NUM_BASE_CHUNK_TYPES][
>  	/* SCTP_STATE_EMPTY */ \
>  	TYPE_SCTP_FUNC(sctp_sf_ootb), \
>  	/* SCTP_STATE_CLOSED */ \
> -	TYPE_SCTP_FUNC(sctp_sf_discard_chunk), \
> +	TYPE_SCTP_FUNC(sctp_sf_ootb), \
>  	/* SCTP_STATE_COOKIE_WAIT */ \
>  	TYPE_SCTP_FUNC(sctp_sf_discard_chunk), \
>  	/* SCTP_STATE_COOKIE_ECHOED */ \

Same should probably be done for ASCONF_ACK as well....

-vlad

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-07-23 13:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-23  8:50 [PATCH] sctp: Process OOTB ASCONF Chunk at CLOSED state Shan Wei
2010-07-23 13:30 ` Vlad Yasevich

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.