[PATCH] post-receive-email: remove spurious commas in email subject.

[PATCH] post-receive-email: remove spurious commas in email subject.

[Matthieu Moy]

The previous form produced subjects like

  [SCM] project.git branch, foo, updated. ...

The new one will produce the lighter

  [SCM] project.git branch foo updated. ...

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
I am the only one bothered by these extra commas in email subject? If
so, I can live with it, but I thought I'd give it a try ;-).

 contrib/hooks/post-receive-email |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index 30ae63d..09c5241 100755
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -203,7 +203,7 @@ generate_email_header()
 	# Generate header
 	cat <<-EOF
 	To: $recipients
-	Subject: ${emailprefix}$projectdesc $refname_type, $short_refname, ${change_type}d. $describe
+	Subject: ${emailprefix}$projectdesc $refname_type $short_refname ${change_type}d. $describe
 	X-Git-Refname: $refname
 	X-Git-Reftype: $refname_type
 	X-Git-Oldrev: $oldrev
-- 
1.7.2.1.30.g18195

Re: [PATCH] post-receive-email: remove spurious commas in email subject.

[Kevin P. Fleming]

On 08/03/2010 08:10 AM, Matthieu Moy wrote:
> The previous form produced subjects like
> 
>   [SCM] project.git branch, foo, updated. ...
> 
> The new one will produce the lighter
> 
>   [SCM] project.git branch foo updated. ...
> 
> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
> ---
> I am the only one bothered by these extra commas in email subject? If
> so, I can live with it, but I thought I'd give it a try ;-).

No, I've removed them in our local copy as well, but never bothered to
send the changes to the list :-)

-- 
Kevin P. Fleming
Digium, Inc. | Director of Software Technologies
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
skype: kpfleming | jabber: kfleming@digium.com
Check us out at www.digium.com & www.asterisk.org

[PATCH (resend)] post-receive-email: remove spurious commas in email subject

[Matthieu Moy]

The previous form produced subjects like

  [SCM] project.git branch, foo, updated. ...

The new one will produce the lighter

  [SCM] project.git branch foo updated. ...

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
"Kevin P. Fleming" <kpfleming@digium.com> writes:

> On 08/03/2010 08:10 AM, Matthieu Moy wrote:
>
>> I am the only one bothered by these extra commas in email subject? If
>> so, I can live with it, but I thought I'd give it a try ;-).
>
> No, I've removed them in our local copy as well, but never bothered to
> send the changes to the list :-)

I guess it's time to get this into git.git then ...

 contrib/hooks/post-receive-email |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index 30ae63d..09c5241 100755
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -203,7 +203,7 @@ generate_email_header()
 	# Generate header
 	cat <<-EOF
 	To: $recipients
-	Subject: ${emailprefix}$projectdesc $refname_type, $short_refname, ${change_type}d. $describe
+	Subject: ${emailprefix}$projectdesc $refname_type $short_refname ${change_type}d. $describe
 	X-Git-Refname: $refname
 	X-Git-Reftype: $refname_type
 	X-Git-Oldrev: $oldrev
-- 
1.7.2.1.52.g95e25.dirty