* S5PC110 should be used the correct VIC number
@ 2010-07-27 10:54 Kyungmin Park
2010-07-28 6:00 ` Kukjin Kim
2010-08-04 15:16 ` Ben Dooks
0 siblings, 2 replies; 7+ messages in thread
From: Kyungmin Park @ 2010-07-27 10:54 UTC (permalink / raw)
To: linux-arm-kernel
Hi Ben,
Can you post the VIC patch from correct VIC number from vic code at
suspend & resume?
If not, it has to modify it after release. or can you fix it as below.
diff --git a/arch/arm/common/Kconfig b/arch/arm/common/Kconfig
index 0a34c81..0ac3d81 100644
--- a/arch/arm/common/Kconfig
+++ b/arch/arm/common/Kconfig
@@ -6,6 +6,7 @@ config ARM_VIC
config ARM_VIC_NR
int
+ default 4 if ARCH_S5PV210
default 2
depends on ARM_VIC
help
I hope anyone should be included at this rc window.
Thank you,
Kyungmin Park
^ permalink raw reply related [flat|nested] 7+ messages in thread
* S5PC110 should be used the correct VIC number
2010-07-27 10:54 S5PC110 should be used the correct VIC number Kyungmin Park
@ 2010-07-28 6:00 ` Kukjin Kim
2010-07-28 7:25 ` Kyungmin Park
2010-08-04 15:16 ` Ben Dooks
1 sibling, 1 reply; 7+ messages in thread
From: Kukjin Kim @ 2010-07-28 6:00 UTC (permalink / raw)
To: linux-arm-kernel
Kyungmin Park wrote:
>
> Hi Ben,
>
> Can you post the VIC patch from correct VIC number from vic code at
> suspend & resume?
> If not, it has to modify it after release. or can you fix it as below.
>
Yeah, you're right.
Already reported by Ben Dooks...but missed that.
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-June/016872.html
Anyway we need updated for ARCH_S5P6442 which has 3 VICs as well as
ARCH_S5PV210.
> diff --git a/arch/arm/common/Kconfig b/arch/arm/common/Kconfig
> index 0a34c81..0ac3d81 100644
> --- a/arch/arm/common/Kconfig
> +++ b/arch/arm/common/Kconfig
> @@ -6,6 +6,7 @@ config ARM_VIC
>
> config ARM_VIC_NR
> int
> + default 4 if ARCH_S5PV210
> default 2
> depends on ARM_VIC
> help
>
> I hope anyone should be included at this rc window.
>
Could you please submit for this?...so I think, Russell can send it to
upstream before 35 stable.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 7+ messages in thread
* S5PC110 should be used the correct VIC number
2010-07-28 6:00 ` Kukjin Kim
@ 2010-07-28 7:25 ` Kyungmin Park
2010-07-28 7:27 ` Russell King - ARM Linux
0 siblings, 1 reply; 7+ messages in thread
From: Kyungmin Park @ 2010-07-28 7:25 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jul 28, 2010 at 3:00 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Kyungmin Park wrote:
>>
>> Hi Ben,
>>
>> Can you post the VIC patch from correct VIC number from vic code at
>> suspend & resume?
>> If not, it has to modify it after release. or can you fix it as below.
>>
> Yeah, you're right.
>
> Already reported by Ben Dooks...but missed that.
> http://lists.infradead.org/pipermail/linux-arm-kernel/2010-June/016872.html
I think ben's patch solves all of problems.
Russell, can you pull it from ben's tree?
Thank you,
Kyungmin Park
>
> Anyway we need updated for ARCH_S5P6442 which has 3 VICs as well as
> ARCH_S5PV210.
>
>> diff --git a/arch/arm/common/Kconfig b/arch/arm/common/Kconfig
>> index 0a34c81..0ac3d81 100644
>> --- a/arch/arm/common/Kconfig
>> +++ b/arch/arm/common/Kconfig
>> @@ -6,6 +6,7 @@ config ARM_VIC
>>
>> ?config ARM_VIC_NR
>> ? ? ? ? int
>> + ? ? ? default 4 if ARCH_S5PV210
>> ? ? ? ? default 2
>> ? ? ? ? depends on ARM_VIC
>> ? ? ? ? help
>>
>> I hope anyone should be included at this rc window.
>>
> Could you please submit for this?...so I think, Russell can send it to
> upstream before 35 stable.
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* S5PC110 should be used the correct VIC number
2010-07-28 7:25 ` Kyungmin Park
@ 2010-07-28 7:27 ` Russell King - ARM Linux
2010-07-28 7:32 ` Kyungmin Park
0 siblings, 1 reply; 7+ messages in thread
From: Russell King - ARM Linux @ 2010-07-28 7:27 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jul 28, 2010 at 04:25:16PM +0900, Kyungmin Park wrote:
> On Wed, Jul 28, 2010 at 3:00 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > Kyungmin Park wrote:
> >>
> >> Hi Ben,
> >>
> >> Can you post the VIC patch from correct VIC number from vic code at
> >> suspend & resume?
> >> If not, it has to modify it after release. or can you fix it as below.
> >>
> > Yeah, you're right.
> >
> > Already reported by Ben Dooks...but missed that.
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2010-June/016872.html
>
> I think ben's patch solves all of problems.
>
> Russell, can you pull it from ben's tree?
When and only when Ben sends me a pull request.
^ permalink raw reply [flat|nested] 7+ messages in thread
* S5PC110 should be used the correct VIC number
2010-07-28 7:27 ` Russell King - ARM Linux
@ 2010-07-28 7:32 ` Kyungmin Park
0 siblings, 0 replies; 7+ messages in thread
From: Kyungmin Park @ 2010-07-28 7:32 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jul 28, 2010 at 4:27 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Wed, Jul 28, 2010 at 04:25:16PM +0900, Kyungmin Park wrote:
>> On Wed, Jul 28, 2010 at 3:00 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>> > Kyungmin Park wrote:
>> >>
>> >> Hi Ben,
>> >>
>> >> Can you post the VIC patch from correct VIC number from vic code at
>> >> suspend & resume?
>> >> If not, it has to modify it after release. or can you fix it as below.
>> >>
>> > Yeah, you're right.
>> >
>> > Already reported by Ben Dooks...but missed that.
>> > http://lists.infradead.org/pipermail/linux-arm-kernel/2010-June/016872.html
>>
>> I think ben's patch solves all of problems.
>>
>> Russell, can you pull it from ben's tree?
>
> When and only when Ben sends me a pull request.
>
In my memory, you mentioned it. there's some missing related it during
merge windows when I sent the above patches. So above patch doesn't
accepted.
Then If Ben don't request it. can you accept the each SoCs fixed patches?
Thank you,
Kyungmin Park
^ permalink raw reply [flat|nested] 7+ messages in thread
* S5PC110 should be used the correct VIC number
2010-07-27 10:54 S5PC110 should be used the correct VIC number Kyungmin Park
2010-07-28 6:00 ` Kukjin Kim
@ 2010-08-04 15:16 ` Ben Dooks
2010-08-04 23:50 ` Kyungmin Park
1 sibling, 1 reply; 7+ messages in thread
From: Ben Dooks @ 2010-08-04 15:16 UTC (permalink / raw)
To: linux-arm-kernel
On 27/07/10 11:54, Kyungmin Park wrote:
> Hi Ben,
>
> Can you post the VIC patch from correct VIC number from vic code at
> suspend & resume?
> If not, it has to modify it after release. or can you fix it as below.
I'll check to see if the patch I sent a while back to
dynamically allocate these and thus remove the need
to use the Kconfig to configure it.
--
Ben
^ permalink raw reply [flat|nested] 7+ messages in thread
* S5PC110 should be used the correct VIC number
2010-08-04 15:16 ` Ben Dooks
@ 2010-08-04 23:50 ` Kyungmin Park
0 siblings, 0 replies; 7+ messages in thread
From: Kyungmin Park @ 2010-08-04 23:50 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 5, 2010 at 12:16 AM, Ben Dooks <ben@simtec.co.uk> wrote:
> On 27/07/10 11:54, Kyungmin Park wrote:
>> Hi Ben,
>>
>> Can you post the VIC patch from correct VIC number from vic code at
>> suspend & resume?
>> If not, it has to modify it after release. or can you fix it as below.
>
> I'll check to see if the patch I sent a while back to
> dynamically allocate these and thus remove the need
> to use the Kconfig to configure it.
>
Right, So please send your patch again even though it's failed to merge 2.6.35.
Thank you,
Kyungmin Park
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-08-04 23:50 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-27 10:54 S5PC110 should be used the correct VIC number Kyungmin Park
2010-07-28 6:00 ` Kukjin Kim
2010-07-28 7:25 ` Kyungmin Park
2010-07-28 7:27 ` Russell King - ARM Linux
2010-07-28 7:32 ` Kyungmin Park
2010-08-04 15:16 ` Ben Dooks
2010-08-04 23:50 ` Kyungmin Park
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.