[PATCH 1/1] be2iscsi: Fix for Login failure

[PATCH 1/1] be2iscsi: Fix for Login failure

[Jayamohan Kallickal]

   The current code in tree has problems with Login.
This patch fixes the Login Failure .

 This patch has been made on the latest scsi-misc tree pulled today

Signed-off-by: Jayamohan Kallickal <jayamohank@serverengines.com>
---
 drivers/scsi/be2iscsi/be_iscsi.c |    5 ++---
 drivers/scsi/be2iscsi/be_mgmt.c  |    2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_iscsi.c
index 7d4d227..7f11f3e 100644
--- a/drivers/scsi/be2iscsi/be_iscsi.c
+++ b/drivers/scsi/be2iscsi/be_iscsi.c
@@ -300,8 +300,7 @@ int beiscsi_get_host_param(struct Scsi_Host *shost,
 			   enum iscsi_host_param param, char *buf)
 {
 	struct beiscsi_hba *phba = (struct beiscsi_hba *)iscsi_host_priv(shost);
-	int len = 0;
-	int status;
+	int status = 0;
 
 	SE_DEBUG(DBG_LVL_8, "In beiscsi_get_host_param, param= %d\n", param);
 	switch (param) {
@@ -315,7 +314,7 @@ int beiscsi_get_host_param(struct Scsi_Host *shost,
 	default:
 		return iscsi_host_get_param(shost, param, buf);
 	}
-	return len;
+	return status;
 }
 
 int beiscsi_get_macaddr(char *buf, struct beiscsi_hba *phba)
diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c
index 26350e4..877324f 100644
--- a/drivers/scsi/be2iscsi/be_mgmt.c
+++ b/drivers/scsi/be2iscsi/be_mgmt.c
@@ -368,7 +368,7 @@ int mgmt_open_connection(struct beiscsi_hba *phba,
 	memset(req, 0, sizeof(*req));
 	wrb->tag0 |= tag;
 
-	be_wrb_hdr_prepare(wrb, sizeof(*req), true, 1);
+	be_wrb_hdr_prepare(wrb, sizeof(*req), false, 1);
 	be_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_ISCSI,
 			   OPCODE_COMMON_ISCSI_TCP_CONNECT_AND_OFFLOAD,
 			   sizeof(*req));
-- 
1.6.4

Re: [PATCH 1/1] be2iscsi: Fix for Login failure

[Mike Christie]

On 08/12/2010 01:06 PM, Jayamohan Kallickal wrote:
>     The current code in tree has problems with Login.
> This patch fixes the Login Failure .
>
>   This patch has been made on the latest scsi-misc tree pulled today
>
> Signed-off-by: Jayamohan Kallickal<jayamohank@serverengines.com>
> ---
>   drivers/scsi/be2iscsi/be_iscsi.c |    5 ++---
>   drivers/scsi/be2iscsi/be_mgmt.c  |    2 +-
>   2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_iscsi.c
> index 7d4d227..7f11f3e 100644
> --- a/drivers/scsi/be2iscsi/be_iscsi.c
> +++ b/drivers/scsi/be2iscsi/be_iscsi.c
> @@ -300,8 +300,7 @@ int beiscsi_get_host_param(struct Scsi_Host *shost,
>   			   enum iscsi_host_param param, char *buf)
>   {
>   	struct beiscsi_hba *phba = (struct beiscsi_hba *)iscsi_host_priv(shost);
> -	int len = 0;
> -	int status;
> +	int status = 0;
>
>   	SE_DEBUG(DBG_LVL_8, "In beiscsi_get_host_param, param= %d\n", param);
>   	switch (param) {
> @@ -315,7 +314,7 @@ int beiscsi_get_host_param(struct Scsi_Host *shost,
>   	default:
>   		return iscsi_host_get_param(shost, param, buf);
>   	}
> -	return len;
> +	return status;

Can't believe I missed that.

Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>