Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	Miguel Di Ciurcio Filho <miguel.filho@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
Date: Tue, 17 Aug 2010 15:55:28 +0200	[thread overview]
Message-ID: <4C6A94D0.2090201@redhat.com> (raw)
In-Reply-To: <4C6A8CD8.2080701@codemonkey.ws>

On 08/17/10 15:21, Anthony Liguori wrote:
> On 08/17/2010 03:04 AM, Jes Sorensen wrote:
>> On 08/13/10 20:02, Blue Swirl wrote:      
>>> I fully agree on the need of change and support your excellent idea.
>>> There are other ways to solve the problem, but I believe we need more
>>> order than more chaos. Perhaps we the QEMU developers should appoint
>>> you the Guardian of the CODING_STYLE, and add a rule that no patch
>>> shall be committed without your CS-Acked-by line?
>>>      
>> I don't think this would ever work, it is begging for trouble relying on
>> one person to review all patches for this.
>>
>> While I agree coding style is good since it enforces consistency, there
>> are plenty problems with the old rules
> 
> To be perfectly honest, we have enough hard problems to solve in QEMU. 
> We're spending a lot more time on coding style than we probably need to :-)

I think we are in full agreement here, I am really just worried that we
add additional procedures here that will slow down the real development.

Cheers,
Jes