All of lore.kernel.org
 help / color / mirror / Atom feed
From: Blue Swirl <blauwirbel@gmail.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>,
	Miguel Di Ciurcio Filho <miguel.filho@gmail.com>,
	Markus Armbruster <armbru@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
Date: Sun, 22 Aug 2010 19:47:39 +0000	[thread overview]
Message-ID: <AANLkTi=kpbeUYLvnijOFn8dVQjFvLHLqPOHsc7Jjd1aH@mail.gmail.com> (raw)
In-Reply-To: <4C717A6C.9080805@codemonkey.ws>

On Sun, Aug 22, 2010 at 7:28 PM, Anthony Liguori <anthony@codemonkey.ws> wrote:
> On 08/22/2010 01:56 PM, Blue Swirl wrote:
>>>
>>> Why is this even still being discussed?  What problem are people actually
>>> trying to solve?
>>>
>>> Can someone point to a bug in QEMU that's been caused because of
>>> CODING_STYLE or the fact that some patches don't adhere to it?
>>>
>>
>> 7b1df88f284f462ecb236931ad863a815f243195
>>
>
> That's a hell of a bug :-)

Yeah. IIRC I almost dismissed the warning from clang as false positive
because I just couldn't see any bug.

>>> I don't see a problem with the way things are today.
>>>
>>
>> There is the problem that some patch submitters are reminded of
>> CODING_STYLE while others aren't.
>
> I still think we spend far too much time discussing this on list.  While I
> stand corrected that we've ever had a bug because of this, I have a hard
> time believing this is anywhere in the top 10 list of issues that we have.

When an outsider submits a patch which gets reviewed, CODING_STYLE
issues can almost certainly be expected. The other frequent issues
(for example memory management) should be addressed by HACKING.

  parent reply	other threads:[~2010-08-22 20:01 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-12 17:49 [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments Blue Swirl
2010-08-12 18:56 ` malc
2010-08-13 15:22   ` Miguel Di Ciurcio Filho
2010-08-13 18:02     ` Blue Swirl
2010-08-17  8:04       ` Jes Sorensen
2010-08-17 13:21         ` Anthony Liguori
2010-08-17 13:55           ` Jes Sorensen
2010-08-17 18:56             ` Blue Swirl
2010-08-19 13:32               ` Jes Sorensen
2010-08-19 18:29                 ` Blue Swirl
2010-08-22 20:15                   ` Avi Kivity
2010-08-22 20:20                     ` Jes Sorensen
2010-08-22 20:36                       ` Avi Kivity
2010-08-20 13:47           ` Markus Armbruster
2010-08-20 18:44             ` Blue Swirl
2010-08-20 20:24               ` Blue Swirl
2010-08-21  9:54                 ` Markus Armbruster
2010-08-21 10:47                   ` Blue Swirl
2010-08-21 12:24                     ` Markus Armbruster
2010-08-21 14:03                       ` Blue Swirl
2010-08-22 16:49                         ` Jes Sorensen
2010-08-22 17:00                           ` malc
2010-08-22 18:32                             ` Blue Swirl
2010-08-22 18:35                               ` malc
2010-08-23  8:02                                 ` Jes Sorensen
2010-08-23 14:07                                   ` john cooper
2010-08-22 18:18                           ` Blue Swirl
2010-08-22 18:36                             ` malc
2010-08-22 18:42                               ` Anthony Liguori
2010-08-22 20:03                                 ` Avi Kivity
2010-08-23  8:33                                 ` Kevin Wolf
2010-08-23 13:52                                 ` Jes Sorensen
2010-08-24 12:34                                 ` Markus Armbruster
2010-08-22 18:41                           ` Anthony Liguori
2010-08-22 18:56                             ` Blue Swirl
2010-08-22 19:28                               ` Anthony Liguori
2010-08-22 19:44                                 ` malc
2010-08-22 19:50                                   ` Blue Swirl
2010-08-22 20:28                                     ` malc
2010-08-22 20:39                                   ` Avi Kivity
2010-08-23 13:55                                     ` Jes Sorensen
2010-08-23 14:03                                       ` Avi Kivity
2010-08-23 14:07                                         ` Jes Sorensen
2010-08-23 14:15                                           ` Avi Kivity
2010-08-22 19:47                                 ` Blue Swirl [this message]
2010-08-22 20:09                               ` Avi Kivity
2010-08-22 20:15                                 ` Blue Swirl
2010-08-22 20:17                                 ` Anthony Liguori
2010-08-22 20:41                                   ` Avi Kivity
2010-08-23  7:17                               ` [Qemu-devel] " Paolo Bonzini
2010-08-22 16:40                     ` [Qemu-devel] " Jes Sorensen
2010-08-22 18:13                       ` Blue Swirl
2010-08-22 18:39                         ` malc
2010-08-23  8:14                           ` Jes Sorensen
2010-08-23 14:04                             ` john cooper
2010-08-23  8:09                         ` Jes Sorensen
2010-08-22 20:12                       ` Avi Kivity
2010-08-22 20:16                         ` Blue Swirl
2010-08-22 20:43                           ` Avi Kivity
2010-08-23 11:01                         ` Markus Armbruster
2010-08-23 11:07                           ` Avi Kivity
2010-08-17 18:51         ` Blue Swirl
2010-08-13 17:52   ` Blue Swirl
2010-08-13 20:54     ` malc
2010-08-15 14:04   ` [Qemu-devel] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=kpbeUYLvnijOFn8dVQjFvLHLqPOHsc7Jjd1aH@mail.gmail.com' \
    --to=blauwirbel@gmail.com \
    --cc=Jes.Sorensen@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=armbru@redhat.com \
    --cc=miguel.filho@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.