* [PATCH] enable getsockopt() for IP_NODEFRAG
@ 2010-09-11 6:26 Michael Kerrisk
[not found] ` <4C8B2130.7030605-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Michael Kerrisk @ 2010-09-11 6:26 UTC (permalink / raw)
To: Jiri Olsa
Cc: eric.dumazet, jengelh, kaber, netdev, netfilter-devel, linux-man,
David Miller
Hello Jiri
While integrating your man-pages patch for IP_NODEFRAG, I noticed
that this option is settable by setsockopt(), but not gettable by
getsockopt(). I suppose this is not intended. The (untested,
trivial) patch below adds getsockopt() support.
The patch is against 2.6.36-rc3.
Cheers,
Michael
PS I've just configured Thunderbird on this machine, hopefully the
patch is not mangled. Please let me know if there are problems.
Signed-off-by: Michael kerrisk <mtk.manpages@gmail.com>
--- net/ipv4/ip_sockglue.c.orig 2010-09-11 07:25:58.000000000 +0200
+++ net/ipv4/ip_sockglue.c 2010-09-11 07:43:43.000000000 +0200
@@ -1129,6 +1129,9 @@ static int do_ip_getsockopt(struct sock
case IP_HDRINCL:
val = inet->hdrincl;
break;
+ case IP_NODEFRAG:
+ val = inet->nodefrag;
+ break;
case IP_MTU_DISCOVER:
val = inet->pmtudisc;
break;
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Watch my Linux system programming book progress towards publication!
http://blog.man7.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] enable getsockopt() for IP_NODEFRAG
[not found] ` <4C8B2130.7030605-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2010-09-12 21:52 ` Jiri Olsa
[not found] ` <20100912215230.GA2091-Iosbtnj8/lepmqaOOeWOyQ@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Olsa @ 2010-09-12 21:52 UTC (permalink / raw)
To: Michael Kerrisk
Cc: eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w,
jengelh-nopoi9nDyk+ELgA04lAiVw, kaber-dcUjhNyLwpNeoWH0uzbU5w,
netdev-u79uwXL29TY76Z2rM5mHXA,
netfilter-devel-u79uwXL29TY76Z2rM5mHXA,
linux-man-u79uwXL29TY76Z2rM5mHXA, David Miller
On Sat, Sep 11, 2010 at 08:26:56AM +0200, Michael Kerrisk wrote:
> Hello Jiri
>
> While integrating your man-pages patch for IP_NODEFRAG, I noticed
> that this option is settable by setsockopt(), but not gettable by
> getsockopt(). I suppose this is not intended. The (untested,
> trivial) patch below adds getsockopt() support.
>
> The patch is against 2.6.36-rc3.
>
> Cheers,
>
> Michael
>
> PS I've just configured Thunderbird on this machine, hopefully the
> patch is not mangled. Please let me know if there are problems.
hi,
applied ok, compiled ok ;) thanks
Acked-by: Jiri Olsa <jolsa-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> Signed-off-by: Michael kerrisk <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> --- net/ipv4/ip_sockglue.c.orig 2010-09-11 07:25:58.000000000 +0200
> +++ net/ipv4/ip_sockglue.c 2010-09-11 07:43:43.000000000 +0200
> @@ -1129,6 +1129,9 @@ static int do_ip_getsockopt(struct sock
> case IP_HDRINCL:
> val = inet->hdrincl;
> break;
> + case IP_NODEFRAG:
> + val = inet->nodefrag;
> + break;
> case IP_MTU_DISCOVER:
> val = inet->pmtudisc;
> break;
> --
> Michael Kerrisk
> Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
> Watch my Linux system programming book progress towards publication!
> http://blog.man7.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] enable getsockopt() for IP_NODEFRAG
[not found] ` <20100912215230.GA2091-Iosbtnj8/lepmqaOOeWOyQ@public.gmane.org>
@ 2010-09-14 2:57 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-09-14 2:57 UTC (permalink / raw)
To: jolsa-H+wXaHxf7aLQT0dZR+AlfA
Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w,
eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w,
jengelh-nopoi9nDyk+ELgA04lAiVw, kaber-dcUjhNyLwpNeoWH0uzbU5w,
netdev-u79uwXL29TY76Z2rM5mHXA,
netfilter-devel-u79uwXL29TY76Z2rM5mHXA,
linux-man-u79uwXL29TY76Z2rM5mHXA
From: Jiri Olsa <jolsa-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Date: Sun, 12 Sep 2010 23:52:30 +0200
> On Sat, Sep 11, 2010 at 08:26:56AM +0200, Michael Kerrisk wrote:
>> Hello Jiri
>>
>> While integrating your man-pages patch for IP_NODEFRAG, I noticed
>> that this option is settable by setsockopt(), but not gettable by
>> getsockopt(). I suppose this is not intended. The (untested,
>> trivial) patch below adds getsockopt() support.
>>
>> The patch is against 2.6.36-rc3.
>>
>> Cheers,
>>
>> Michael
>>
>> PS I've just configured Thunderbird on this machine, hopefully the
>> patch is not mangled. Please let me know if there are problems.
> hi,
>
> applied ok, compiled ok ;) thanks
>
> Acked-by: Jiri Olsa <jolsa-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-14 2:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-11 6:26 [PATCH] enable getsockopt() for IP_NODEFRAG Michael Kerrisk
[not found] ` <4C8B2130.7030605-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-09-12 21:52 ` Jiri Olsa
[not found] ` <20100912215230.GA2091-Iosbtnj8/lepmqaOOeWOyQ@public.gmane.org>
2010-09-14 2:57 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.