* [PATCH] omniorb_4.1.4: merged native and non-native recipes
@ 2010-09-09 16:30 Fahad Usman
2010-09-09 16:57 ` Khem Raj
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Fahad Usman @ 2010-09-09 16:30 UTC (permalink / raw)
To: openembedded-devel
* removed the omniorb-native_4.1.4.bb file
* added DEPENDS_pn-omniorb = "omniorb-native" and DEPENDS_pn-omniorb-native += "python-native" to handle different dependencies for native and target recipes, thanks to Vitus Jensen for guidance
* added NATIVE_INSTALL_WORKS = "1"
* added BBCLASSEXTEND = "native"
* added do_install_virtclass-native and converted do_stage from native recipe to do_install_virtclass-native_append in the combined recipe
* bumped PR
Signed-off-by: Fahad Usman <fahad_usman@mentor.com>
---
recipes/omniorb/omniorb-native_4.1.4.bb | 23 ---------------------
recipes/omniorb/omniorb_4.1.4.bb | 33 +++++++++++++++++++++++++-----
2 files changed, 27 insertions(+), 29 deletions(-)
diff --git a/recipes/omniorb/omniorb-native_4.1.4.bb b/recipes/omniorb/omniorb-native_4.1.4.bb
deleted file mode 100644
index c5c550d..0000000
--- a/recipes/omniorb/omniorb-native_4.1.4.bb
+++ /dev/null
@@ -1,23 +0,0 @@
-SECTION = "devel"
-DEPENDS += "python-native"
-PR = "r0"
-
-SRC_URI = "http://downloads.sourceforge.net/omniorb/omniORB-4.1.4.tar.gz;name=omniORB414targz \
- file://omniorb_4.1.4.patch \
-"
-
-SRC_URI[omniORB414targz.md5sum] = "1f6070ff9b6339876976d61981eeaa6a"
-SRC_URI[omniORB414targz.sha256sum] = "84fb9790c25d6e46248c9773747e393b429573190da2150850d4a49debda4e8e"
-
-S = "${WORKDIR}/omniORB-${PV}"
-
-inherit native autotools
-
-do_compile () {
- oe_runmake
-}
-# Ugly hack so libtool does not find native libs when building cross packages
-# We really only build this package for omniidl anyway
-do_stage_append() {
- rm -f ${STAGING_LIBDIR_NATIVE}/libomni*
-}
diff --git a/recipes/omniorb/omniorb_4.1.4.bb b/recipes/omniorb/omniorb_4.1.4.bb
index a4c032c..03a1554 100644
--- a/recipes/omniorb/omniorb_4.1.4.bb
+++ b/recipes/omniorb/omniorb_4.1.4.bb
@@ -2,8 +2,9 @@ DESCRIPTION = "OmniORB High Performance ORB"
SECTION = "devel"
PRIORITY = "optional"
LICENSE = "LGPL"
-DEPENDS = "omniorb-native"
-PR = "r0"
+DEPENDS_pn-omniorb = "omniorb-native"
+DEPENDS_pn-omniorb-native += "python-native"
+PR = "r1"
SRC_URI = "http://downloads.sourceforge.net/omniorb/omniORB-4.1.4.tar.gz;name=omniORB414targz \
file://omniorb_4.1.4.patch \
@@ -12,6 +13,10 @@ file://omniORB-cross.patch \
file://omniORB_embedded_appl.patch \
file://rm_LongDouble.patch \
"
+SRC_URI_virtclass-native = "http://downloads.sourceforge.net/omniorb/omniORB-4.1.4.tar.gz;name=omniORB414targz \
+ file://omniorb_4.1.4.patch \
+"
+
SRC_URI[omniORB414targz.md5sum] = "1f6070ff9b6339876976d61981eeaa6a"
SRC_URI[omniORB414targz.sha256sum] = "84fb9790c25d6e46248c9773747e393b429573190da2150850d4a49debda4e8e"
@@ -29,9 +34,14 @@ do_compile () {
oe_runmake
}
+
+do_compile_virtclass-native() {
+ oe_runmake
+}
+
do_install () {
export EmbeddedSystem=1
- make DESTDIR=${D} install
+ autotools_do_install
install -d ${D}${sysconfdir}
install -m 0644 ${WORKDIR}/omniORB.cfg ${D}${sysconfdir}
install -d ${D}${localstatedir}/omninames
@@ -39,7 +49,18 @@ do_install () {
#only executable libraries are stripped by the stripper
chmod +x ${WORKDIR}/image/usr/lib/lib*
}
-do_stage () {
- export EmbeddedSystem=1
- autotools_stage_all
+
+do_install_virtclass-native() {
+ autotools_do_install
+}
+
+# The following comment is from the omniorb-native recipe which is now merged into this one...
+# Ugly hack so libtool does not find native libs when building cross packages
+# We really only build this package for omniidl anyway
+do_install_virtclass-native_append() {
+ rm -f ${D}${libdir}/libomni*
}
+
+BBCLASSEXTEND = "native"
+
+NATIVE_INSTALL_WORKS = "1"
--
1.6.3.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] omniorb_4.1.4: merged native and non-native recipes
2010-09-09 16:30 [PATCH] omniorb_4.1.4: merged native and non-native recipes Fahad Usman
@ 2010-09-09 16:57 ` Khem Raj
2010-09-09 17:20 ` Frans Meulenbroeks
2010-09-09 17:31 ` Philip Balister
2 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2010-09-09 16:57 UTC (permalink / raw)
To: openembedded-devel
On Thu, Sep 9, 2010 at 9:30 AM, Fahad Usman <fahad_usman@mentor.com> wrote:
> * removed the omniorb-native_4.1.4.bb file
> * added DEPENDS_pn-omniorb = "omniorb-native" and DEPENDS_pn-omniorb-native += "python-native" to handle different dependencies for native and target recipes, thanks to Vitus Jensen for guidance
> * added NATIVE_INSTALL_WORKS = "1"
> * added BBCLASSEXTEND = "native"
> * added do_install_virtclass-native and converted do_stage from native recipe to do_install_virtclass-native_append in the combined recipe
> * bumped PR
>
> Signed-off-by: Fahad Usman <fahad_usman@mentor.com>
> ---
> recipes/omniorb/omniorb-native_4.1.4.bb | 23 ---------------------
> recipes/omniorb/omniorb_4.1.4.bb | 33 +++++++++++++++++++++++++-----
> 2 files changed, 27 insertions(+), 29 deletions(-)
>
> diff --git a/recipes/omniorb/omniorb-native_4.1.4.bb b/recipes/omniorb/omniorb-native_4.1.4.bb
> deleted file mode 100644
> index c5c550d..0000000
> --- a/recipes/omniorb/omniorb-native_4.1.4.bb
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -SECTION = "devel"
> -DEPENDS += "python-native"
> -PR = "r0"
> -
> -SRC_URI = "http://downloads.sourceforge.net/omniorb/omniORB-4.1.4.tar.gz;name=omniORB414targz \
> - file://omniorb_4.1.4.patch \
> -"
> -
> -SRC_URI[omniORB414targz.md5sum] = "1f6070ff9b6339876976d61981eeaa6a"
> -SRC_URI[omniORB414targz.sha256sum] = "84fb9790c25d6e46248c9773747e393b429573190da2150850d4a49debda4e8e"
> -
> -S = "${WORKDIR}/omniORB-${PV}"
> -
> -inherit native autotools
> -
> -do_compile () {
> - oe_runmake
> -}
> -# Ugly hack so libtool does not find native libs when building cross packages
> -# We really only build this package for omniidl anyway
> -do_stage_append() {
> - rm -f ${STAGING_LIBDIR_NATIVE}/libomni*
> -}
> diff --git a/recipes/omniorb/omniorb_4.1.4.bb b/recipes/omniorb/omniorb_4.1.4.bb
> index a4c032c..03a1554 100644
> --- a/recipes/omniorb/omniorb_4.1.4.bb
> +++ b/recipes/omniorb/omniorb_4.1.4.bb
> @@ -2,8 +2,9 @@ DESCRIPTION = "OmniORB High Performance ORB"
> SECTION = "devel"
> PRIORITY = "optional"
> LICENSE = "LGPL"
> -DEPENDS = "omniorb-native"
> -PR = "r0"
> +DEPENDS_pn-omniorb = "omniorb-native"
> +DEPENDS_pn-omniorb-native += "python-native"
> +PR = "r1"
>
> SRC_URI = "http://downloads.sourceforge.net/omniorb/omniORB-4.1.4.tar.gz;name=omniORB414targz \
> file://omniorb_4.1.4.patch \
> @@ -12,6 +13,10 @@ file://omniORB-cross.patch \
> file://omniORB_embedded_appl.patch \
> file://rm_LongDouble.patch \
> "
> +SRC_URI_virtclass-native = "http://downloads.sourceforge.net/omniorb/omniORB-4.1.4.tar.gz;name=omniORB414targz \
> + file://omniorb_4.1.4.patch \
> +"
> +
>
> SRC_URI[omniORB414targz.md5sum] = "1f6070ff9b6339876976d61981eeaa6a"
> SRC_URI[omniORB414targz.sha256sum] = "84fb9790c25d6e46248c9773747e393b429573190da2150850d4a49debda4e8e"
> @@ -29,9 +34,14 @@ do_compile () {
> oe_runmake
>
> }
> +
> +do_compile_virtclass-native() {
> + oe_runmake
> +}
> +
> do_install () {
> export EmbeddedSystem=1
> - make DESTDIR=${D} install
> + autotools_do_install
> install -d ${D}${sysconfdir}
> install -m 0644 ${WORKDIR}/omniORB.cfg ${D}${sysconfdir}
> install -d ${D}${localstatedir}/omninames
can this be made do_install_append instead ?
> @@ -39,7 +49,18 @@ do_install () {
> #only executable libraries are stripped by the stripper
> chmod +x ${WORKDIR}/image/usr/lib/lib*
> }
> -do_stage () {
> - export EmbeddedSystem=1
> - autotools_stage_all
> +
> +do_install_virtclass-native() {
> + autotools_do_install
> +}
> +
> +# The following comment is from the omniorb-native recipe which is now merged into this one...
> +# Ugly hack so libtool does not find native libs when building cross packages
> +# We really only build this package for omniidl anyway
> +do_install_virtclass-native_append() {
> + rm -f ${D}${libdir}/libomni*
> }
> +
> +BBCLASSEXTEND = "native"
> +
> +NATIVE_INSTALL_WORKS = "1"
> --
> 1.6.3.3
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
--
-Khem
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] omniorb_4.1.4: merged native and non-native recipes
2010-09-09 16:30 [PATCH] omniorb_4.1.4: merged native and non-native recipes Fahad Usman
2010-09-09 16:57 ` Khem Raj
@ 2010-09-09 17:20 ` Frans Meulenbroeks
2010-09-14 12:49 ` Fahad
2010-09-09 17:31 ` Philip Balister
2 siblings, 1 reply; 6+ messages in thread
From: Frans Meulenbroeks @ 2010-09-09 17:20 UTC (permalink / raw)
To: openembedded-devel
2010/9/9 Fahad Usman <fahad_usman@mentor.com>:
> * removed the omniorb-native_4.1.4.bb file
> * added DEPENDS_pn-omniorb = "omniorb-native" and DEPENDS_pn-omniorb-native += "python-native" to handle different dependencies for native and target recipes, thanks to Vitus Jensen for guidance
> * added NATIVE_INSTALL_WORKS = "1"
> * added BBCLASSEXTEND = "native"
> * added do_install_virtclass-native and converted do_stage from native recipe to do_install_virtclass-native_append in the combined recipe
> * bumped PR
>
> Signed-off-by: Fahad Usman <fahad_usman@mentor.com>
> ---
> recipes/omniorb/omniorb-native_4.1.4.bb | 23 ---------------------
> recipes/omniorb/omniorb_4.1.4.bb | 33 +++++++++++++++++++++++++-----
> 2 files changed, 27 insertions(+), 29 deletions(-)
>
> diff --git a/recipes/omniorb/omniorb-native_4.1.4.bb b/recipes/omniorb/omniorb-native_4.1.4.bb
> deleted file mode 100644
> index c5c550d..0000000
> --- a/recipes/omniorb/omniorb-native_4.1.4.bb
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -SECTION = "devel"
> -DEPENDS += "python-native"
> -PR = "r0"
> -
> -SRC_URI = "http://downloads.sourceforge.net/omniorb/omniORB-4.1.4.tar.gz;name=omniORB414targz \
> - file://omniorb_4.1.4.patch \
> -"
> -
> -SRC_URI[omniORB414targz.md5sum] = "1f6070ff9b6339876976d61981eeaa6a"
> -SRC_URI[omniORB414targz.sha256sum] = "84fb9790c25d6e46248c9773747e393b429573190da2150850d4a49debda4e8e"
> -
> -S = "${WORKDIR}/omniORB-${PV}"
> -
> -inherit native autotools
> -
> -do_compile () {
> - oe_runmake
> -}
> -# Ugly hack so libtool does not find native libs when building cross packages
> -# We really only build this package for omniidl anyway
> -do_stage_append() {
> - rm -f ${STAGING_LIBDIR_NATIVE}/libomni*
> -}
> diff --git a/recipes/omniorb/omniorb_4.1.4.bb b/recipes/omniorb/omniorb_4.1.4.bb
> index a4c032c..03a1554 100644
> --- a/recipes/omniorb/omniorb_4.1.4.bb
> +++ b/recipes/omniorb/omniorb_4.1.4.bb
> @@ -2,8 +2,9 @@ DESCRIPTION = "OmniORB High Performance ORB"
> SECTION = "devel"
> PRIORITY = "optional"
> LICENSE = "LGPL"
> -DEPENDS = "omniorb-native"
> -PR = "r0"
> +DEPENDS_pn-omniorb = "omniorb-native"
> +DEPENDS_pn-omniorb-native += "python-native"
> +PR = "r1"
>
> SRC_URI = "http://downloads.sourceforge.net/omniorb/omniORB-4.1.4.tar.gz;name=omniORB414targz \
> file://omniorb_4.1.4.patch \
> @@ -12,6 +13,10 @@ file://omniORB-cross.patch \
> file://omniORB_embedded_appl.patch \
> file://rm_LongDouble.patch \
> "
> +SRC_URI_virtclass-native = "http://downloads.sourceforge.net/omniorb/omniORB-4.1.4.tar.gz;name=omniORB414targz \
> + file://omniorb_4.1.4.patch \
> +"
> +
>
> SRC_URI[omniORB414targz.md5sum] = "1f6070ff9b6339876976d61981eeaa6a"
> SRC_URI[omniORB414targz.sha256sum] = "84fb9790c25d6e46248c9773747e393b429573190da2150850d4a49debda4e8e"
> @@ -29,9 +34,14 @@ do_compile () {
> oe_runmake
>
> }
> +
> +do_compile_virtclass-native() {
> + oe_runmake
> +}
> +
> do_install () {
> export EmbeddedSystem=1
> - make DESTDIR=${D} install
> + autotools_do_install
> install -d ${D}${sysconfdir}
> install -m 0644 ${WORKDIR}/omniORB.cfg ${D}${sysconfdir}
> install -d ${D}${localstatedir}/omninames
> @@ -39,7 +49,18 @@ do_install () {
> #only executable libraries are stripped by the stripper
> chmod +x ${WORKDIR}/image/usr/lib/lib*
> }
> -do_stage () {
> - export EmbeddedSystem=1
> - autotools_stage_all
> +
> +do_install_virtclass-native() {
> + autotools_do_install
> +}
> +
> +# The following comment is from the omniorb-native recipe which is now merged into this one...
> +# Ugly hack so libtool does not find native libs when building cross packages
> +# We really only build this package for omniidl anyway
> +do_install_virtclass-native_append() {
> + rm -f ${D}${libdir}/libomni*
Can you verify if this is still needed ?
I suggest to do that by cleaning both recipes, then remove this hack,
then build omniidl-native followed by omniidl
If the last one builds fine, I'd say it is afe to leave tout this rm
Frans
> }
> +
> +BBCLASSEXTEND = "native"
> +
> +NATIVE_INSTALL_WORKS = "1"
> --
> 1.6.3.3
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] omniorb_4.1.4: merged native and non-native recipes
2010-09-09 16:30 [PATCH] omniorb_4.1.4: merged native and non-native recipes Fahad Usman
2010-09-09 16:57 ` Khem Raj
2010-09-09 17:20 ` Frans Meulenbroeks
@ 2010-09-09 17:31 ` Philip Balister
2 siblings, 0 replies; 6+ messages in thread
From: Philip Balister @ 2010-09-09 17:31 UTC (permalink / raw)
To: openembedded-devel
On 09/09/2010 12:30 PM, Fahad Usman wrote:
> * removed the omniorb-native_4.1.4.bb file
> * added DEPENDS_pn-omniorb = "omniorb-native" and DEPENDS_pn-omniorb-native += "python-native" to handle different dependencies for native and target recipes, thanks to Vitus Jensen for guidance
> * added NATIVE_INSTALL_WORKS = "1"
> * added BBCLASSEXTEND = "native"
> * added do_install_virtclass-native and converted do_stage from native recipe to do_install_virtclass-native_append in the combined recipe
> * bumped PR
Are you testing these changes? There are only a few users of omniorb I
know of, and I am not in a position to test these.
The native part of the build is only needed to make the omniidl tool, so
it is more of a cross thing than native.
Unless there is a compelling reason to do this work, I'd rather people
leave this recipe alone.
Philip
>
> Signed-off-by: Fahad Usman<fahad_usman@mentor.com>
> ---
> recipes/omniorb/omniorb-native_4.1.4.bb | 23 ---------------------
> recipes/omniorb/omniorb_4.1.4.bb | 33 +++++++++++++++++++++++++-----
> 2 files changed, 27 insertions(+), 29 deletions(-)
>
> diff --git a/recipes/omniorb/omniorb-native_4.1.4.bb b/recipes/omniorb/omniorb-native_4.1.4.bb
> deleted file mode 100644
> index c5c550d..0000000
> --- a/recipes/omniorb/omniorb-native_4.1.4.bb
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -SECTION = "devel"
> -DEPENDS += "python-native"
> -PR = "r0"
> -
> -SRC_URI = "http://downloads.sourceforge.net/omniorb/omniORB-4.1.4.tar.gz;name=omniORB414targz \
> - file://omniorb_4.1.4.patch \
> -"
> -
> -SRC_URI[omniORB414targz.md5sum] = "1f6070ff9b6339876976d61981eeaa6a"
> -SRC_URI[omniORB414targz.sha256sum] = "84fb9790c25d6e46248c9773747e393b429573190da2150850d4a49debda4e8e"
> -
> -S = "${WORKDIR}/omniORB-${PV}"
> -
> -inherit native autotools
> -
> -do_compile () {
> - oe_runmake
> -}
> -# Ugly hack so libtool does not find native libs when building cross packages
> -# We really only build this package for omniidl anyway
> -do_stage_append() {
> - rm -f ${STAGING_LIBDIR_NATIVE}/libomni*
> -}
> diff --git a/recipes/omniorb/omniorb_4.1.4.bb b/recipes/omniorb/omniorb_4.1.4.bb
> index a4c032c..03a1554 100644
> --- a/recipes/omniorb/omniorb_4.1.4.bb
> +++ b/recipes/omniorb/omniorb_4.1.4.bb
> @@ -2,8 +2,9 @@ DESCRIPTION = "OmniORB High Performance ORB"
> SECTION = "devel"
> PRIORITY = "optional"
> LICENSE = "LGPL"
> -DEPENDS = "omniorb-native"
> -PR = "r0"
> +DEPENDS_pn-omniorb = "omniorb-native"
> +DEPENDS_pn-omniorb-native += "python-native"
> +PR = "r1"
>
> SRC_URI = "http://downloads.sourceforge.net/omniorb/omniORB-4.1.4.tar.gz;name=omniORB414targz \
> file://omniorb_4.1.4.patch \
> @@ -12,6 +13,10 @@ file://omniORB-cross.patch \
> file://omniORB_embedded_appl.patch \
> file://rm_LongDouble.patch \
> "
> +SRC_URI_virtclass-native = "http://downloads.sourceforge.net/omniorb/omniORB-4.1.4.tar.gz;name=omniORB414targz \
> + file://omniorb_4.1.4.patch \
> +"
> +
>
> SRC_URI[omniORB414targz.md5sum] = "1f6070ff9b6339876976d61981eeaa6a"
> SRC_URI[omniORB414targz.sha256sum] = "84fb9790c25d6e46248c9773747e393b429573190da2150850d4a49debda4e8e"
> @@ -29,9 +34,14 @@ do_compile () {
> oe_runmake
>
> }
> +
> +do_compile_virtclass-native() {
> + oe_runmake
> +}
> +
> do_install () {
> export EmbeddedSystem=1
> - make DESTDIR=${D} install
> + autotools_do_install
> install -d ${D}${sysconfdir}
> install -m 0644 ${WORKDIR}/omniORB.cfg ${D}${sysconfdir}
> install -d ${D}${localstatedir}/omninames
> @@ -39,7 +49,18 @@ do_install () {
> #only executable libraries are stripped by the stripper
> chmod +x ${WORKDIR}/image/usr/lib/lib*
> }
> -do_stage () {
> - export EmbeddedSystem=1
> - autotools_stage_all
> +
> +do_install_virtclass-native() {
> + autotools_do_install
> +}
> +
> +# The following comment is from the omniorb-native recipe which is now merged into this one...
> +# Ugly hack so libtool does not find native libs when building cross packages
> +# We really only build this package for omniidl anyway
> +do_install_virtclass-native_append() {
> + rm -f ${D}${libdir}/libomni*
> }
> +
> +BBCLASSEXTEND = "native"
> +
> +NATIVE_INSTALL_WORKS = "1"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] omniorb_4.1.4: merged native and non-native recipes
2010-09-09 17:20 ` Frans Meulenbroeks
@ 2010-09-14 12:49 ` Fahad
2010-09-14 12:56 ` Philip Balister
0 siblings, 1 reply; 6+ messages in thread
From: Fahad @ 2010-09-14 12:49 UTC (permalink / raw)
To: openembedded-devel
On Thu, 2010-09-09 at 19:20 +0200, Frans Meulenbroeks wrote:
> 2010/9/9 Fahad Usman <fahad_usman@mentor.com>:
> > +# The following comment is from the omniorb-native recipe which is now merged into this one...
> > +# Ugly hack so libtool does not find native libs when building cross packages
> > +# We really only build this package for omniidl anyway
> > +do_install_virtclass-native_append() {
> > + rm -f ${D}${libdir}/libomni*
>
> Can you verify if this is still needed ?
> I suggest to do that by cleaning both recipes, then remove this hack,
> then build omniidl-native followed by omniidl
> If the last one builds fine, I'd say it is afe to leave tout this rm
>
Hi Frans,
looks like omniidl recipes are not in git any more and i couldn't find
any other package that depends on omniorb or omniorb-native. So, it is
probably not needed and it should be safe to remove this hack. I will
submit the updated patch for this.
Fahad.
> >
> >
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> >
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] omniorb_4.1.4: merged native and non-native recipes
2010-09-14 12:49 ` Fahad
@ 2010-09-14 12:56 ` Philip Balister
0 siblings, 0 replies; 6+ messages in thread
From: Philip Balister @ 2010-09-14 12:56 UTC (permalink / raw)
To: openembedded-devel
On 09/14/2010 08:49 AM, Fahad wrote:
> On Thu, 2010-09-09 at 19:20 +0200, Frans Meulenbroeks wrote:
>> 2010/9/9 Fahad Usman<fahad_usman@mentor.com>:
>>> +# The following comment is from the omniorb-native recipe which is now merged into this one...
>>> +# Ugly hack so libtool does not find native libs when building cross packages
>>> +# We really only build this package for omniidl anyway
>>> +do_install_virtclass-native_append() {
>>> + rm -f ${D}${libdir}/libomni*
>>
>> Can you verify if this is still needed ?
>> I suggest to do that by cleaning both recipes, then remove this hack,
>> then build omniidl-native followed by omniidl
>> If the last one builds fine, I'd say it is afe to leave tout this rm
>>
> Hi Frans,
> looks like omniidl recipes are not in git any more and i couldn't find
> any other package that depends on omniorb or omniorb-native. So, it is
> probably not needed and it should be safe to remove this hack. I will
> submit the updated patch for this.
Please do not push any changes to these recipes unless you have another
recipe that uses omniorb to test with. I can't test this until I am done
with my current project and that could be several weeks. There are
people doing out of tree work that uses this.
Please, please do not chance breaking recipes you do not fully understand!
Philip
>
> Fahad.
>>>
>>>
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-09-14 12:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-09 16:30 [PATCH] omniorb_4.1.4: merged native and non-native recipes Fahad Usman
2010-09-09 16:57 ` Khem Raj
2010-09-09 17:20 ` Frans Meulenbroeks
2010-09-14 12:49 ` Fahad
2010-09-14 12:56 ` Philip Balister
2010-09-09 17:31 ` Philip Balister
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.