From: Manuel Stahl <manuel.stahl@iis.fraunhofer.de> To: Greg KH <greg@kroah.com> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH] Add sc16is7x2 driver Date: Wed, 22 Sep 2010 10:01:39 +0200 [thread overview] Message-ID: <4C99B7E3.4070501@iis.fraunhofer.de> (raw) In-Reply-To: <20100921204238.GE25112@kroah.com> Am 21.09.2010 22:42, schrieb Greg KH: > On Tue, Sep 14, 2010 at 03:07:13PM +0200, Manuel Stahl wrote: >> --- a/include/linux/serial_core.h >> +++ b/include/linux/serial_core.h >> @@ -47,6 +47,9 @@ >> #define PORT_U6_16550A 19 /* ST-Ericsson U6xxx internal UART */ >> #define PORT_MAX_8250 19 /* max port ID */ >> >> +/* SC16IS7x2 SPI UART */ >> +#define PORT_SC16IS7X2 19 > > Hm, didn't you just duplicate the number here? Shouldn't that be "20" > and you bump the max up? Oh, that might be true. > In the end, we need to just drop those, I don't think we need defines > anymore, but I need to look at it some more to find out. Thank you for doing that, Greg. Regards, -- Dipl.-Inf. Manuel Stahl Fraunhofer-Institut für Integrierte Schaltungen IIS - Leistungsoptimierte Systeme - Nordostpark 93 Telefon +49 (0)911/58061-6419 90411 Nürnberg Fax +49 (0)911/58061-6398 http://www.iis.fraunhofer.de manuel.stahl@iis.fraunhofer.de
WARNING: multiple messages have this Message-ID (diff)
From: Manuel Stahl <manuel.stahl@iis.fraunhofer.de> To: Greg KH <greg@kroah.com> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH] Add sc16is7x2 driver Date: Wed, 22 Sep 2010 10:01:39 +0200 [thread overview] Message-ID: <4C99B7E3.4070501@iis.fraunhofer.de> (raw) In-Reply-To: <20100921204238.GE25112@kroah.com> Am 21.09.2010 22:42, schrieb Greg KH: > On Tue, Sep 14, 2010 at 03:07:13PM +0200, Manuel Stahl wrote: >> --- a/include/linux/serial_core.h >> +++ b/include/linux/serial_core.h >> @@ -47,6 +47,9 @@ >> #define PORT_U6_16550A 19 /* ST-Ericsson U6xxx internal UART */ >> #define PORT_MAX_8250 19 /* max port ID */ >> >> +/* SC16IS7x2 SPI UART */ >> +#define PORT_SC16IS7X2 19 > > Hm, didn't you just duplicate the number here? Shouldn't that be "20" > and you bump the max up? Oh, that might be true. > In the end, we need to just drop those, I don't think we need defines > anymore, but I need to look at it some more to find out. Thank you for doing that, Greg. Regards, -- Dipl.-Inf. Manuel Stahl Fraunhofer-Institut für Integrierte Schaltungen IIS - Leistungsoptimierte Systeme - Nordostpark 93 Telefon +49 (0)911/58061-6419 90411 Nürnberg Fax +49 (0)911/58061-6398 http://www.iis.fraunhofer.de manuel.stahl@iis.fraunhofer.de -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-09-22 8:01 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-09-03 13:11 [PATCH] Add sc16is7x2 driver Manuel Stahl 2010-09-14 0:25 ` Andrew Morton 2010-09-14 13:07 ` Manuel Stahl 2010-09-14 13:27 ` Jonathan Corbet 2010-09-15 13:42 ` Manuel Stahl 2010-09-15 19:17 ` Andrew Morton 2010-09-21 20:42 ` Greg KH 2010-09-22 8:01 ` Manuel Stahl [this message] 2010-09-22 8:01 ` Manuel Stahl -- strict thread matches above, loose matches on Subject: below -- 2012-02-05 6:55 Thomas Weber 2012-02-05 19:56 ` Alan Cox 2010-08-31 11:26 Manuel Stahl
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4C99B7E3.4070501@iis.fraunhofer.de \ --to=manuel.stahl@iis.fraunhofer.de \ --cc=akpm@linux-foundation.org \ --cc=greg@kroah.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.