Trouble building v4l-dvb

Trouble building v4l-dvb

[Ole W. Saastad]

Trouble building v4l-dvb
Asus eee netbook, running EasyPeasy.

ole@ole-eee:~$ cat /etc/issue
Ubuntu 9.04 \n \l
ole@ole-eee:~$ uname -a
Linux ole-eee 2.6.30.5-ep0 #10 SMP PREEMPT Thu Aug 27 19:45:06 CEST 2009
i686 GNU/Linux

Rationale for building from source: 
I have bought a USB TV with mpg4 support from Sandberg, Mini DVB-T
dongle. I also received an archive with driver routines for this from
Sandberg. These should be copied into the v4l-dvd three and just rebuild
with make. 

I have installed the kernel headers:
apt-get install mercurial linux-headers-$(uname -r) build-essential

Then I have downloaded the v4l-dvb source (assuming this is a stable
release): hg clone http://linuxtv.org/hg/v4l-dvb


I wanted to try to build before applying the patch from Sandberg. 
Issuing make yield the following :

LIRC: Requires at least kernel 2.6.36
IR_LIRC_CODEC: Requires at least kernel 2.6.36
IR_IMON: Requires at least kernel 2.6.36
IR_MCEUSB: Requires at least kernel 2.6.36
VIDEOBUF_DMA_CONTIG: Requires at least kernel 2.6.31
V4L2_MEM2MEM_DEV: Requires at least kernel 2.6.33
and a few more lines....

Ignoring these and just continuing :

  CC [M]  /home/ole/work/v4l-dvb/v4l/firedtv-dvb.o
  CC [M]  /home/ole/work/v4l-dvb/v4l/firedtv-fe.o
  CC [M]  /home/ole/work/v4l-dvb/v4l/firedtv-1394.o
/home/ole/work/v4l-dvb/v4l/firedtv-1394.c:22:17: error: dma.h: No such
file or directory
/home/ole/work/v4l-dvb/v4l/firedtv-1394.c:23:21: error: csr1212.h: No
such file or directory
/home/ole/work/v4l-dvb/v4l/firedtv-1394.c:24:23: error: highlevel.h: No
such file or directory
and many many more similar errors.

After some time the make bails out.


I assume this have some connection with the 9.04 being too old. 


Hints ?



Regards,
Ole W. Saastad

Re: Trouble building v4l-dvb

[Jan Hoogenraad]

Douglas;

Could you please check your last putback ?

the build is broken.

see:
http://www.xs4all.nl/~hverkuil/logs/Wednesday.log

and the mail
[cron job] v4l-dvb daily build 2.6.26 and up: ERRORS

Yours,
		Jan

Ole W. Saastad wrote:
> Trouble building v4l-dvb
> Asus eee netbook, running EasyPeasy.
> 
> ole@ole-eee:~$ cat /etc/issue
> Ubuntu 9.04 \n \l
> ole@ole-eee:~$ uname -a
> Linux ole-eee 2.6.30.5-ep0 #10 SMP PREEMPT Thu Aug 27 19:45:06 CEST 2009
> i686 GNU/Linux
> 
> Rationale for building from source: 
> I have bought a USB TV with mpg4 support from Sandberg, Mini DVB-T
> dongle. I also received an archive with driver routines for this from
> Sandberg. These should be copied into the v4l-dvd three and just rebuild
> with make. 
> 
> I have installed the kernel headers:
> apt-get install mercurial linux-headers-$(uname -r) build-essential
> 
> Then I have downloaded the v4l-dvb source (assuming this is a stable
> release): hg clone http://linuxtv.org/hg/v4l-dvb
> 
> 
> I wanted to try to build before applying the patch from Sandberg. 
> Issuing make yield the following :
> 
> LIRC: Requires at least kernel 2.6.36
> IR_LIRC_CODEC: Requires at least kernel 2.6.36
> IR_IMON: Requires at least kernel 2.6.36
> IR_MCEUSB: Requires at least kernel 2.6.36
> VIDEOBUF_DMA_CONTIG: Requires at least kernel 2.6.31
> V4L2_MEM2MEM_DEV: Requires at least kernel 2.6.33
> and a few more lines....
> 
> Ignoring these and just continuing :
> 
>   CC [M]  /home/ole/work/v4l-dvb/v4l/firedtv-dvb.o
>   CC [M]  /home/ole/work/v4l-dvb/v4l/firedtv-fe.o
>   CC [M]  /home/ole/work/v4l-dvb/v4l/firedtv-1394.o
> /home/ole/work/v4l-dvb/v4l/firedtv-1394.c:22:17: error: dma.h: No such
> file or directory
> /home/ole/work/v4l-dvb/v4l/firedtv-1394.c:23:21: error: csr1212.h: No
> such file or directory
> /home/ole/work/v4l-dvb/v4l/firedtv-1394.c:24:23: error: highlevel.h: No
> such file or directory
> and many many more similar errors.
> 
> After some time the make bails out.
> 
> 
> I assume this have some connection with the 9.04 being too old. 
> 
> 
> Hints ?
> 
> 
> 
> Regards,
> Ole W. Saastad
> 
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht

Re: Trouble building v4l-dvb

[Jan Hoogenraad]

I see that the build now succeeded.

Ole: this is something that should have been fixed a long time ago, but 
isn't.
make allyesmod
should set only those divers that do actually compile.
Unfortunately, the FIREDTV driver has bugs for as long as I remember.

In the 4vl directory, edit .config
and change the line
CONFIG_DVB_FIREDTV=m
into
CONFIG_DVB_FIREDTV=n

It should compile fine then.

Jan Hoogenraad wrote:
> Douglas;
> 
> Could you please check your last putback ?
> 
> the build is broken.
> 
> see:
> http://www.xs4all.nl/~hverkuil/logs/Wednesday.log
> 
> and the mail
> [cron job] v4l-dvb daily build 2.6.26 and up: ERRORS
> 
> Yours,
>         Jan
> 
> Ole W. Saastad wrote:
>> Trouble building v4l-dvb
>> Asus eee netbook, running EasyPeasy.
>>
>> ole@ole-eee:~$ cat /etc/issue
>> Ubuntu 9.04 \n \l
>> ole@ole-eee:~$ uname -a
>> Linux ole-eee 2.6.30.5-ep0 #10 SMP PREEMPT Thu Aug 27 19:45:06 CEST 2009
>> i686 GNU/Linux
>>
>> Rationale for building from source: I have bought a USB TV with mpg4 
>> support from Sandberg, Mini DVB-T
>> dongle. I also received an archive with driver routines for this from
>> Sandberg. These should be copied into the v4l-dvd three and just rebuild
>> with make.
>> I have installed the kernel headers:
>> apt-get install mercurial linux-headers-$(uname -r) build-essential
>>
>> Then I have downloaded the v4l-dvb source (assuming this is a stable
>> release): hg clone http://linuxtv.org/hg/v4l-dvb
>>
>>
>> I wanted to try to build before applying the patch from Sandberg. 
>> Issuing make yield the following :
>>
>> LIRC: Requires at least kernel 2.6.36
>> IR_LIRC_CODEC: Requires at least kernel 2.6.36
>> IR_IMON: Requires at least kernel 2.6.36
>> IR_MCEUSB: Requires at least kernel 2.6.36
>> VIDEOBUF_DMA_CONTIG: Requires at least kernel 2.6.31
>> V4L2_MEM2MEM_DEV: Requires at least kernel 2.6.33
>> and a few more lines....
>>
>> Ignoring these and just continuing :
>>
>>   CC [M]  /home/ole/work/v4l-dvb/v4l/firedtv-dvb.o
>>   CC [M]  /home/ole/work/v4l-dvb/v4l/firedtv-fe.o
>>   CC [M]  /home/ole/work/v4l-dvb/v4l/firedtv-1394.o
>> /home/ole/work/v4l-dvb/v4l/firedtv-1394.c:22:17: error: dma.h: No such
>> file or directory
>> /home/ole/work/v4l-dvb/v4l/firedtv-1394.c:23:21: error: csr1212.h: No
>> such file or directory
>> /home/ole/work/v4l-dvb/v4l/firedtv-1394.c:24:23: error: highlevel.h: No
>> such file or directory
>> and many many more similar errors.
>>
>> After some time the make bails out.
>>
>>
>> I assume this have some connection with the 9.04 being too old.
>>
>> Hints ?
>>
>>
>>
>> Regards,
>> Ole W. Saastad
>>
>>
>>
>>
>> -- 
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 
> 


-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht

Re: Trouble building v4l-dvb

[Mauro Carvalho Chehab]

Em 17-09-2010 06:35, Jan Hoogenraad escreveu:
> I see that the build now succeeded.
> 
> Ole: this is something that should have been fixed a long time ago, but isn't.
> make allyesmod
> should set only those divers that do actually compile.
> Unfortunately, the FIREDTV driver has bugs for as long as I remember.

The problem are not related to bugs at firedtv driver, but, instead, due to the fact
that the provided firewire drivers and fw-core don't match the drivers that are shipped
with the distro kernel. In order words, at Ubuntu (and some other deb-based distros),
they're shipping the wrong include files at /lib/modules/`uname -r`/build/. So, there's
no way to build and run any module based on that wrong broken headers.

Up to a certain amount, the same happens with -alsa files on Ubuntu: although they
will compile [1], as the provided headers at /lib/modules/`uname -r`/build/ are from a different
version than the alsa modules provided with Ubuntu, the drivers that depend on -alsa will 
generally compile, but they generally won't load (and, if they load, they'll can cause
an OOPS and some other random troubles), as the symbol dependency will not match.

While a hack might be added at v4l-dvb -hg tree to make firedtv to compile against a broken
header, the firedtv driver will not work anyway.

The only real solution for it is to fix this issue at the distro.

Cheers,
Mauro

[1] The v4l-dvb is smart enough to adapt to -alsa API changes that are backported into
an older kernel, since it checks for the API symbols that changed, instead of just looking
for the kernel version. This works fine with all distros (like Fedora, RHEL, SUSE, OpenSUSE,
Mandriva, ...) where the include files for alsa are at the right place:
/lib/modules/`uname -r`/build/).

Re: Trouble building v4l-dvb

[Jan Hoogenraad]

Thanks !

Indeed, the hack so that
make allyesmod
not select firedtv would be very helpful.

that way, it is also clear that firedtv will not work on debian-like 
distros.

Is there a way I cen help with that ?
I have no experience with Kconfig, so it would be a learning experience 
for me.


Mauro Carvalho Chehab wrote:
> Em 17-09-2010 06:35, Jan Hoogenraad escreveu:
>> I see that the build now succeeded.
>>
>> Ole: this is something that should have been fixed a long time ago, but isn't.
>> make allyesmod
>> should set only those divers that do actually compile.
>> Unfortunately, the FIREDTV driver has bugs for as long as I remember.
> 
> The problem are not related to bugs at firedtv driver, but, instead, due to the fact
> that the provided firewire drivers and fw-core don't match the drivers that are shipped
> with the distro kernel. In order words, at Ubuntu (and some other deb-based distros),
> they're shipping the wrong include files at /lib/modules/`uname -r`/build/. So, there's
> no way to build and run any module based on that wrong broken headers.
> 
> Up to a certain amount, the same happens with -alsa files on Ubuntu: although they
> will compile [1], as the provided headers at /lib/modules/`uname -r`/build/ are from a different
> version than the alsa modules provided with Ubuntu, the drivers that depend on -alsa will 
> generally compile, but they generally won't load (and, if they load, they'll can cause
> an OOPS and some other random troubles), as the symbol dependency will not match.
> 
> While a hack might be added at v4l-dvb -hg tree to make firedtv to compile against a broken
> header, the firedtv driver will not work anyway.
> 
> The only real solution for it is to fix this issue at the distro.
> 
> Cheers,
> Mauro
> 
> [1] The v4l-dvb is smart enough to adapt to -alsa API changes that are backported into
> an older kernel, since it checks for the API symbols that changed, instead of just looking
> for the kernel version. This works fine with all distros (like Fedora, RHEL, SUSE, OpenSUSE,
> Mandriva, ...) where the include files for alsa are at the right place:
> /lib/modules/`uname -r`/build/).
> 


-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht

Re: Trouble building v4l-dvb

[Mauro Carvalho Chehab]

Em 17-09-2010 08:08, Jan Hoogenraad escreveu:
> Thanks !
> 
> Indeed, the hack so that
> make allyesmod
> not select firedtv would be very helpful.
> 
> that way, it is also clear that firedtv will not work on debian-like distros.
> 
> Is there a way I cen help with that ?
> I have no experience with Kconfig, so it would be a learning experience for me.

You don't need to look at Kconfig. there are some scripts under v4l/scripts
that will deal with Kconfig dependencies. They are meant to identify kernel versions
and features. Those scripts are, mainly:

	v4l/scripts/make_config_compat.pl - Checks for "backported" features, enabling workarounds at v4l/compat.h
	v4l/scripts/make_kconfig.pl - Generates a .config file that will compile with an older kernel
	v4l/scripts/make_makefile.pl - Generates a Makefile that will build/install/remove the kernel modules

Basically, you need to add some intelligence to one of the above scripts (likely make_kconfig)
to identify that the kernel has broken firewire headers, and disable its compilation, printing
a warning message to the user.

You'll find a logic at make_makefile.pl to detect an Ubuntu broken kernel that stores the in-kernel
drivers at the wrong install place. I'm not sure if all Ubuntu kernels/versions do the same
thing, nor if this is broken for all distro-variants.

Perhaps you may use this logic at make_kconfig.pl. The logic assumes that broken distros
are the ones that store V4L/DVB files at /lib/modules/\$(KERNELRELEASE)/ubuntu/media. 
This is probably not true for all broken distros (as Ubuntu clones - and maybe Debian - could
have the same problem, but storing the media files on a different place), so you may
need to generalize that logic, in order to cover any other distros that don't compile
firewire.

While you're there, the better is to also disable CONFIG_ALSA on Ubuntu, as the drivers
won't work anyway.

As we don't want to have complains from users about "why driver foo is not compiling for me",
IMO, it should be printing a warning message saying that compilation of ALSA/FIREWIRE drivers with
that specific kernel version is not possible, due to the back packaging of kernel headers,
recommending to the user to get a vanilla upstream kernel, if he needs one of the disabled
drivers.

Cheers,
Mauro

Re: Trouble building v4l-dvb

[Devin Heitmueller]

On Fri, Sep 17, 2010 at 10:49 AM, Mauro Carvalho Chehab
<maurochehab@gmail.com> wrote:
> While you're there, the better is to also disable CONFIG_ALSA on Ubuntu, as the drivers
> won't work anyway.

Note: while building ALSA modules did fail in some versions for
Ubuntu, it has been over a years since I've seen that problem.
Blindly disabling ALSA for all Ubuntu users would be a huge regression
for users.

> As we don't want to have complains from users about "why driver foo is not compiling for me",
> IMO, it should be printing a warning message saying that compilation of ALSA/FIREWIRE drivers with
> that specific kernel version is not possible, due to the back packaging of kernel headers,
> recommending to the user to get a vanilla upstream kernel, if he needs one of the disabled
> drivers.

I agree with this premise for firedtv, but see my comment above about ALSA.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com

Re: Trouble building v4l-dvb

[Mauro Carvalho Chehab]

Em 17-09-2010 12:00, Devin Heitmueller escreveu:
> On Fri, Sep 17, 2010 at 10:49 AM, Mauro Carvalho Chehab
> <maurochehab@gmail.com> wrote:
>> While you're there, the better is to also disable CONFIG_ALSA on Ubuntu, as the drivers
>> won't work anyway.
> 
> Note: while building ALSA modules did fail in some versions for
> Ubuntu, it has been over a years since I've seen that problem.
> Blindly disabling ALSA for all Ubuntu users would be a huge regression
> for users.

Yeah, blindly disabling it, if some versions work is not the right thing to do.

I'm not an Ubuntu user, so, I'm not sure when it was fixed. Still, from time to time,
people complain to me about this problem with some Ubuntu versions. The last complains I
heard were with some netbook versions of Ubuntu-based distros.

If there's a way to check what versions have broken alsa headers, then the checker should
just disable to the broken ones. Otherwise, the better way seems to just print a warning
message that ALSA might not be working, but keep it enabled.

Cheers,
Mauro

Re: Trouble building v4l-dvb

[Jan Hoogenraad]

Really, the only thing I would do is disable the ones that break 
compilation. this is ONLY firedtv.

I doubt if anyone would read the messages during compilation.
I'll have a look at the logic.

Mauro Carvalho Chehab wrote:
> Em 17-09-2010 08:08, Jan Hoogenraad escreveu:
>> Thanks !
>>
>> Indeed, the hack so that
>> make allyesmod
>> not select firedtv would be very helpful.
>>
>> that way, it is also clear that firedtv will not work on debian-like distros.
>>
>> Is there a way I cen help with that ?
>> I have no experience with Kconfig, so it would be a learning experience for me.
> 
> You don't need to look at Kconfig. there are some scripts under v4l/scripts
> that will deal with Kconfig dependencies. They are meant to identify kernel versions
> and features. Those scripts are, mainly:
> 
> 	v4l/scripts/make_config_compat.pl - Checks for "backported" features, enabling workarounds at v4l/compat.h
> 	v4l/scripts/make_kconfig.pl - Generates a .config file that will compile with an older kernel
> 	v4l/scripts/make_makefile.pl - Generates a Makefile that will build/install/remove the kernel modules
> 
> Basically, you need to add some intelligence to one of the above scripts (likely make_kconfig)
> to identify that the kernel has broken firewire headers, and disable its compilation, printing
> a warning message to the user.
> 
> You'll find a logic at make_makefile.pl to detect an Ubuntu broken kernel that stores the in-kernel
> drivers at the wrong install place. I'm not sure if all Ubuntu kernels/versions do the same
> thing, nor if this is broken for all distro-variants.
> 
> Perhaps you may use this logic at make_kconfig.pl. The logic assumes that broken distros
> are the ones that store V4L/DVB files at /lib/modules/\$(KERNELRELEASE)/ubuntu/media. 
> This is probably not true for all broken distros (as Ubuntu clones - and maybe Debian - could
> have the same problem, but storing the media files on a different place), so you may
> need to generalize that logic, in order to cover any other distros that don't compile
> firewire.
> 
> While you're there, the better is to also disable CONFIG_ALSA on Ubuntu, as the drivers
> won't work anyway.
> 
> As we don't want to have complains from users about "why driver foo is not compiling for me",
> IMO, it should be printing a warning message saying that compilation of ALSA/FIREWIRE drivers with
> that specific kernel version is not possible, due to the back packaging of kernel headers,
> recommending to the user to get a vanilla upstream kernel, if he needs one of the disabled
> drivers.
> 
> Cheers,
> Mauro
> 


-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht

Re: Trouble building v4l-dvb

[Ole W. Saastad]

Thanks for all help so far.

I managed to figure out the firetv problem as soon as I discovered
the .myconfig file.

Including the drivers from Sandberg, for the rtl2832 chip and adding
some lines to Makefile, Kconfig and .myconfig it compiles and install.
Modules load and Me-TV starts, quality is poor with the small antenna.

However, there is no audio. Not even for the DAB radio channels.

Maybe this is Me-TV problem?

The version supplied with Easy Peasy Ubuntu 9.10 is old,  0.7.16.


Regards,
Ole W. Saastad






fr., 17.09.2010 kl. 11.35 +0200, skrev Jan Hoogenraad:
> I see that the build now succeeded.
> 
> Ole: this is something that should have been fixed a long time ago, but 
> isn't.
> make allyesmod
> should set only those divers that do actually compile.
> Unfortunately, the FIREDTV driver has bugs for as long as I remember.
> 
> In the 4vl directory, edit .config
> and change the line
> CONFIG_DVB_FIREDTV=m
> into
> CONFIG_DVB_FIREDTV=n
> 
> It should compile fine then.
> 
> Jan Hoogenraad wrote:
> > Douglas;
> > 
> > Could you please check your last putback ?
> > 
> > the build is broken.
> > 
> > see:
> > http://www.xs4all.nl/~hverkuil/logs/Wednesday.log
> > 
> > and the mail
> > [cron job] v4l-dvb daily build 2.6.26 and up: ERRORS
> > 
> > Yours,
> >         Jan
> > 
> > Ole W. Saastad wrote:
> >> Trouble building v4l-dvb
> >> Asus eee netbook, running EasyPeasy.
> >>
> >> ole@ole-eee:~$ cat /etc/issue
> >> Ubuntu 9.04 \n \l
> >> ole@ole-eee:~$ uname -a
> >> Linux ole-eee 2.6.30.5-ep0 #10 SMP PREEMPT Thu Aug 27 19:45:06 CEST 2009
> >> i686 GNU/Linux
> >>
> >> Rationale for building from source: I have bought a USB TV with mpg4 
> >> support from Sandberg, Mini DVB-T
> >> dongle. I also received an archive with driver routines for this from
> >> Sandberg. These should be copied into the v4l-dvd three and just rebuild
> >> with make.
> >> I have installed the kernel headers:
> >> apt-get install mercurial linux-headers-$(uname -r) build-essential
> >>
> >> Then I have downloaded the v4l-dvb source (assuming this is a stable
> >> release): hg clone http://linuxtv.org/hg/v4l-dvb
> >>
> >>
> >> I wanted to try to build before applying the patch from Sandberg. 
> >> Issuing make yield the following :
> >>
> >> LIRC: Requires at least kernel 2.6.36
> >> IR_LIRC_CODEC: Requires at least kernel 2.6.36
> >> IR_IMON: Requires at least kernel 2.6.36
> >> IR_MCEUSB: Requires at least kernel 2.6.36
> >> VIDEOBUF_DMA_CONTIG: Requires at least kernel 2.6.31
> >> V4L2_MEM2MEM_DEV: Requires at least kernel 2.6.33
> >> and a few more lines....
> >>
> >> Ignoring these and just continuing :
> >>
> >>   CC [M]  /home/ole/work/v4l-dvb/v4l/firedtv-dvb.o
> >>   CC [M]  /home/ole/work/v4l-dvb/v4l/firedtv-fe.o
> >>   CC [M]  /home/ole/work/v4l-dvb/v4l/firedtv-1394.o
> >> /home/ole/work/v4l-dvb/v4l/firedtv-1394.c:22:17: error: dma.h: No such
> >> file or directory
> >> /home/ole/work/v4l-dvb/v4l/firedtv-1394.c:23:21: error: csr1212.h: No
> >> such file or directory
> >> /home/ole/work/v4l-dvb/v4l/firedtv-1394.c:24:23: error: highlevel.h: No
> >> such file or directory
> >> and many many more similar errors.
> >>
> >> After some time the make bails out.
> >>
> >>
> >> I assume this have some connection with the 9.04 being too old.
> >>
> >> Hints ?
> >>
> >>
> >>
> >> Regards,
> >> Ole W. Saastad
> >>
> >>
> >>
> >>
> >> -- 
> >> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >>
> > 
> > 
> 
> 

rtl2832 chip driver

[Jan Hoogenraad]

Hi Ole:

Try vlc or keffeins, and see if they have the same audio problem.
Also: try playing a normal sound mp3 file with them.
me-tv and rtl2832 havce some problems:
https://bugs.launchpad.net/ubuntu/+source/me-tv/+bug/478379

Thanks for the Sandberg link.
At:
http://www.sandberg.it/support/product.aspx?id=133-59
I found Realtek stuff that looks very familiar to the RTL2831 stuff I 
put into another HG branch:
http://linuxtv.org/hg/~jhoogenraad/rtl2831-r2

This is again code where the frontend and backend have not been 
separated. Seems realtek has their branch kind of working, based on 
their windows approach.

Antti has set up a new version from scratch at:
http://linuxtv.org/hg/~anttip/rtl2831u/



Ole W. Saastad wrote:
> Thanks for all help so far.
> 
> I managed to figure out the firetv problem as soon as I discovered
> the .myconfig file.
> 
> Including the drivers from Sandberg, for the rtl2832 chip and adding
> some lines to Makefile, Kconfig and .myconfig it compiles and install.
> Modules load and Me-TV starts, quality is poor with the small antenna.
> 
> However, there is no audio. Not even for the DAB radio channels.
> 
> Maybe this is Me-TV problem?
> 
> The version supplied with Easy Peasy Ubuntu 9.10 is old,  0.7.16.
> 
> 
> Regards,
> Ole W. Saastad
> 


-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht

Re: Trouble building v4l-dvb

[Jan Hoogenraad]

On
Linux 2.6.28-19-generic
the problem is tackled already:
DVB_FIREDTV_IEEE1394: Requires at least kernel 2.6.30

On newer linux versions (I have tried Linux 2.6.32-24-generic) the 
problem is NOT that the modules dma is not present, it is just that the 
required header files are not present in
/usr/include

Another location mighte have been:
ls -l /usr/src/linux-headers-2.6.28-19-generic/include/config/ieee1394

but that only contains:
-rw-r--r-- 1 root root    0 2010-09-16 18:25 dv1394.h
drwxr-xr-x 3 root root 4096 2010-06-15 20:12 eth1394
-rw-r--r-- 1 root root    0 2010-09-16 18:25 eth1394.h
-rw-r--r-- 1 root root    0 2010-09-16 18:25 ohci1394.h
-rw-r--r-- 1 root root    0 2010-09-16 18:25 pcilynx.h
-rw-r--r-- 1 root root    0 2010-09-16 18:25 rawio.h
-rw-r--r-- 1 root root    0 2010-09-16 18:25 sbp2.h
-rw-r--r-- 1 root root    0 2010-09-16 18:25 video1394.h

Can you indicate where following files  should be located ?
dma.h
csr1212.h
highlevel.h

In that case checking if the dma.h file is present might be the best way 
forward.

I'll also file an ubuntu bug once I know what is missing where.
I could not find an entry in launchpad on this issue yet.

Mauro Carvalho Chehab wrote:
> Em 17-09-2010 08:08, Jan Hoogenraad escreveu:
>> Thanks !
>>
>> Indeed, the hack so that
>> make allyesmod
>> not select firedtv would be very helpful.
>>
>> that way, it is also clear that firedtv will not work on debian-like distros.
>>
>> Is there a way I cen help with that ?
>> I have no experience with Kconfig, so it would be a learning experience for me.
>
> You don't need to look at Kconfig. there are some scripts under v4l/scripts
> that will deal with Kconfig dependencies. They are meant to identify kernel versions
> and features. Those scripts are, mainly:
>
> 	v4l/scripts/make_config_compat.pl - Checks for "backported" features, enabling workarounds at v4l/compat.h
> 	v4l/scripts/make_kconfig.pl - Generates a .config file that will compile with an older kernel
> 	v4l/scripts/make_makefile.pl - Generates a Makefile that will build/install/remove the kernel modules
>
> Basically, you need to add some intelligence to one of the above scripts (likely make_kconfig)
> to identify that the kernel has broken firewire headers, and disable its compilation, printing
> a warning message to the user.
>
> You'll find a logic at make_makefile.pl to detect an Ubuntu broken kernel that stores the in-kernel
> drivers at the wrong install place. I'm not sure if all Ubuntu kernels/versions do the same
> thing, nor if this is broken for all distro-variants.
>
> Perhaps you may use this logic at make_kconfig.pl. The logic assumes that broken distros
> are the ones that store V4L/DVB files at /lib/modules/\$(KERNELRELEASE)/ubuntu/media.
> This is probably not true for all broken distros (as Ubuntu clones - and maybe Debian - could
> have the same problem, but storing the media files on a different place), so you may
> need to generalize that logic, in order to cover any other distros that don't compile
> firewire.
>
> While you're there, the better is to also disable CONFIG_ALSA on Ubuntu, as the drivers
> won't work anyway.
>
> As we don't want to have complains from users about "why driver foo is not compiling for me",
> IMO, it should be printing a warning message saying that compilation of ALSA/FIREWIRE drivers with
> that specific kernel version is not possible, due to the back packaging of kernel headers,
> recommending to the user to get a vanilla upstream kernel, if he needs one of the disabled
> drivers.
>
> Cheers,
> Mauro
>


-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht

Re: Trouble building v4l-dvb

[Mauro Carvalho Chehab]

Em 26-09-2010 13:18, Jan Hoogenraad escreveu:
> On
> Linux 2.6.28-19-generic
> the problem is tackled already:
> DVB_FIREDTV_IEEE1394: Requires at least kernel 2.6.30
> 
> On newer linux versions (I have tried Linux 2.6.32-24-generic) the problem is NOT that the modules dma is not present, it is just that the required header files are not present in
> /usr/include
> 
> Another location mighte have been:
> ls -l /usr/src/linux-headers-2.6.28-19-generic/include/config/ieee1394

This is the right place is whatever pointed on your kernel source alias, like:

$ ls -la /lib/modules/2.6.35+/source
lrwxrwxrwx. 1 root root 23 Set 26 21:51 /lib/modules/2.6.35+/source -> /home/v4l/v4l/patchwork


> 
> but that only contains:
> -rw-r--r-- 1 root root    0 2010-09-16 18:25 dv1394.h
> drwxr-xr-x 3 root root 4096 2010-06-15 20:12 eth1394
> -rw-r--r-- 1 root root    0 2010-09-16 18:25 eth1394.h
> -rw-r--r-- 1 root root    0 2010-09-16 18:25 ohci1394.h
> -rw-r--r-- 1 root root    0 2010-09-16 18:25 pcilynx.h
> -rw-r--r-- 1 root root    0 2010-09-16 18:25 rawio.h
> -rw-r--r-- 1 root root    0 2010-09-16 18:25 sbp2.h
> -rw-r--r-- 1 root root    0 2010-09-16 18:25 video1394.h
> 
> Can you indicate where following files  should be located ?
> dma.h
> csr1212.h
> highlevel.h

All of them are at the same place:

/lib/modules/2.6.35+/source/drivers/ieee1394/dma.h
/lib/modules/2.6.35+/source/drivers/ieee1394/csr1212.h
/lib/modules/2.6.35+/source/drivers/ieee1394/highlevel.h

> 
> In that case checking if the dma.h file is present might be the best way forward.
> 
> I'll also file an ubuntu bug once I know what is missing where.
> I could not find an entry in launchpad on this issue yet.

This is probably the best thing. A check for dma.h may also work. If you want,
do a patch for it and submit to Douglas.

Cheers,
Mauro

updated make_kconfig.pl for Ubuntu

[Jan Hoogenraad]

I have updated launchpad bug

https://bugs.launchpad.net/ubuntu/+source/linux-kernel-headers/+bug/134222

I also created an updated make_kconfig.pl

http://linuxtv.org/hg/~jhoogenraad/rtl2831-r2/file/cb34ee1c29fc/v4l/scripts/make_kconfig.pl

Unfortunately, I forgot to commit changes to the main archive the first 
time. I do not know how to make a patch file for this one file, without 
have all other changes in the two commits as well.
I cannot find a hg export command to make a patch for this one file 
between versions spanning two commits.

Douglas: can you help ?

Mauro Carvalho Chehab wrote:
> Em 26-09-2010 13:18, Jan Hoogenraad escreveu:
>> On
>> Linux 2.6.28-19-generic
>> the problem is tackled already:
>> DVB_FIREDTV_IEEE1394: Requires at least kernel 2.6.30
>>
>> On newer linux versions (I have tried Linux 2.6.32-24-generic) the problem is NOT that the modules dma is not present, it is just that the required header files are not present in
>> /usr/include
>>
>> Another location mighte have been:
>> ls -l /usr/src/linux-headers-2.6.28-19-generic/include/config/ieee1394
>
> This is the right place is whatever pointed on your kernel source alias, like:
>
> $ ls -la /lib/modules/2.6.35+/source
> lrwxrwxrwx. 1 root root 23 Set 26 21:51 /lib/modules/2.6.35+/source ->  /home/v4l/v4l/patchwork
>
>
>>
>> but that only contains:
>> -rw-r--r-- 1 root root    0 2010-09-16 18:25 dv1394.h
>> drwxr-xr-x 3 root root 4096 2010-06-15 20:12 eth1394
>> -rw-r--r-- 1 root root    0 2010-09-16 18:25 eth1394.h
>> -rw-r--r-- 1 root root    0 2010-09-16 18:25 ohci1394.h
>> -rw-r--r-- 1 root root    0 2010-09-16 18:25 pcilynx.h
>> -rw-r--r-- 1 root root    0 2010-09-16 18:25 rawio.h
>> -rw-r--r-- 1 root root    0 2010-09-16 18:25 sbp2.h
>> -rw-r--r-- 1 root root    0 2010-09-16 18:25 video1394.h
>>
>> Can you indicate where following files  should be located ?
>> dma.h
>> csr1212.h
>> highlevel.h
>
> All of them are at the same place:
>
> /lib/modules/2.6.35+/source/drivers/ieee1394/dma.h
> /lib/modules/2.6.35+/source/drivers/ieee1394/csr1212.h
> /lib/modules/2.6.35+/source/drivers/ieee1394/highlevel.h
>
>>
>> In that case checking if the dma.h file is present might be the best way forward.
>>
>> I'll also file an ubuntu bug once I know what is missing where.
>> I could not find an entry in launchpad on this issue yet.
>
> This is probably the best thing. A check for dma.h may also work. If you want,
> do a patch for it and submit to Douglas.
>
> Cheers,
> Mauro
>


-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht

Re: updated make_kconfig.pl for Ubuntu

[Mauro Carvalho Chehab]

Em 27-09-2010 15:41, Jan Hoogenraad escreveu:
> I have updated launchpad bug
> 
> https://bugs.launchpad.net/ubuntu/+source/linux-kernel-headers/+bug/134222
> 
> I also created an updated make_kconfig.pl
> 
> http://linuxtv.org/hg/~jhoogenraad/rtl2831-r2/file/cb34ee1c29fc/v4l/scripts/make_kconfig.pl
> 
> Unfortunately, I forgot to commit changes to the main archive the first time. I do not know how to make a patch file for this one file, without have all other changes in the two commits as well.
> I cannot find a hg export command to make a patch for this one file between versions spanning two commits.

You can just do a diff with upstream. Anyway, I'm enclosing the merged patch.

There's one problem on it:

$dmahplace="/usr/src/linux-headers-$dmahplace/include/config/ieee1394/dma.h";

Don't use absolute names here. -hg build system is smart enough to get the directory
where the kernel is installed, depending on what version you're compiling against
(you may change it with "make release").

Based on sub kernelcheck(), were we have:
	my $fullkernel="$kernsrc/fs/fcntl.c";

I suspect that using:
	$dmahplace="$kernelsrc/include/config/ieee1394/dma.h";

should work properly.

---

FYI, this is the diff from the master -hg:

diff -r 1da5fed5c8b2 v4l/scripts/make_kconfig.pl
--- a/v4l/scripts/make_kconfig.pl	Sun Sep 19 02:23:09 2010 -0300
+++ b/v4l/scripts/make_kconfig.pl	Mon Sep 27 16:04:50 2010 -0300
@@ -597,6 +597,9 @@
 disable_config('STAGING_BROKEN');
 $intopt { "DVB_MAX_ADAPTERS" } = 8;
 
+#check broken Ubuntu headers
+dmahcheck();
+
 # Check dependencies
 my %newconfig = checkdeps();
 
@@ -681,3 +684,27 @@
 EOF3
 	sleep 5;
 }
+
+# Check for full kernel sources and print a warning
+sub dmahcheck()
+{
+	my $dmahplace= "".$kernsrc;
+	$dmahplace =~ s-^/lib/modules/--g;
+	$dmahplace =~ s-/.*$--g;
+	$dmahplace="/usr/src/linux-headers-$dmahplace/include/config/ieee1394/dma.h";
+	if (! -e $dmahplace) {
+		print <<"EOF2";
+
+***WARNING:*** File $dmahplace not present.
+This problem is at least present on Ubuntu systems:
+https://bugs.launchpad.net/ubuntu/+source/linux-kernel-headers/+bug/134222
+
+Therefore disabling FIREDTV driver.
+
+EOF2
+
+	disable_config('DVB_FIREDTV');
+
+	}
+	sleep 5;
+}

Re: updated make_kconfig.pl for Ubuntu

[Jan Hoogenraad]

Mauro:

On my system, the call to make_kconfig reads:
./scripts/make_kconfig.pl /lib/modules/2.6.28-19-generic/build 
/lib/modules/2.6.28-19-generic/build 1

Using $kernelsrc yields the following error:
Global symbol "$kernelsrc" requires explicit package name at 
./scripts/make_kconfig.pl line 694.

Using
$dmahplace="$kernsrc/include/config/ieee1394/dma.h";
yields the following INCORRECT expansion:
/lib/modules/2.6.28-19-generic/build/include/config/ieee1394/dma.h
this is the place where I am building into, which is different from the 
place where Ubuntu places the include files from the package

Thus I built an expression to get:
/usr/src/linux-headers-2.6.28-19-generic/include/config/ieee1394/dma.h
as I described in the mail of yesterday.

Now, I realize that the header files could ALSO be present in the build 
directory, so there should be a check on that as well, as otherwise the 
FIREDTV is incorrectly disabled on other distros, or source builds.

Yes, and I know all of this is ugly ....

Mauro Carvalho Chehab wrote:
> Em 27-09-2010 15:41, Jan Hoogenraad escreveu:
>> I have updated launchpad bug
>>
>> https://bugs.launchpad.net/ubuntu/+source/linux-kernel-headers/+bug/134222
>>
>> I also created an updated make_kconfig.pl
>>
>> http://linuxtv.org/hg/~jhoogenraad/rtl2831-r2/file/cb34ee1c29fc/v4l/scripts/make_kconfig.pl
>>
>> Unfortunately, I forgot to commit changes to the main archive the first time. I do not know how to make a patch file for this one file, without have all other changes in the two commits as well.
>> I cannot find a hg export command to make a patch for this one file between versions spanning two commits.
>
> You can just do a diff with upstream. Anyway, I'm enclosing the merged patch.
>
> There's one problem on it:
>
> $dmahplace="/usr/src/linux-headers-$dmahplace/include/config/ieee1394/dma.h";
>
> Don't use absolute names here. -hg build system is smart enough to get the directory
> where the kernel is installed, depending on what version you're compiling against
> (you may change it with "make release").
>
> Based on sub kernelcheck(), were we have:
> 	my $fullkernel="$kernsrc/fs/fcntl.c";
>
> I suspect that using:
> 	$dmahplace="$kernelsrc/include/config/ieee1394/dma.h";
>
> should work properly.
>
> ---
>
> FYI, this is the diff from the master -hg:
>
> diff -r 1da5fed5c8b2 v4l/scripts/make_kconfig.pl
> --- a/v4l/scripts/make_kconfig.pl	Sun Sep 19 02:23:09 2010 -0300
> +++ b/v4l/scripts/make_kconfig.pl	Mon Sep 27 16:04:50 2010 -0300
> @@ -597,6 +597,9 @@
>   disable_config('STAGING_BROKEN');
>   $intopt { "DVB_MAX_ADAPTERS" } = 8;
>
> +#check broken Ubuntu headers
> +dmahcheck();
> +
>   # Check dependencies
>   my %newconfig = checkdeps();
>
> @@ -681,3 +684,27 @@
>   EOF3
>   	sleep 5;
>   }
> +
> +# Check for full kernel sources and print a warning
> +sub dmahcheck()
> +{
> +	my $dmahplace= "".$kernsrc;
> +	$dmahplace =~ s-^/lib/modules/--g;
> +	$dmahplace =~ s-/.*$--g;
> +	$dmahplace="/usr/src/linux-headers-$dmahplace/include/config/ieee1394/dma.h";
> +	if (! -e $dmahplace) {
> +		print<<"EOF2";
> +
> +***WARNING:*** File $dmahplace not present.
> +This problem is at least present on Ubuntu systems:
> +https://bugs.launchpad.net/ubuntu/+source/linux-kernel-headers/+bug/134222
> +
> +Therefore disabling FIREDTV driver.
> +
> +EOF2
> +
> +	disable_config('DVB_FIREDTV');
> +
> +	}
> +	sleep 5;
> +}
>


-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht

Re: updated make_kconfig.pl for Ubuntu

[Mauro Carvalho Chehab]

Em 27-09-2010 17:45, Jan Hoogenraad escreveu:
> Mauro:
> 
> On my system, the call to make_kconfig reads:
> ./scripts/make_kconfig.pl /lib/modules/2.6.28-19-generic/build /lib/modules/2.6.28-19-generic/build 1
> 
> Using $kernelsrc yields the following error:
> Global symbol "$kernelsrc" requires explicit package name at ./scripts/make_kconfig.pl line 694.
> 
> Using
> $dmahplace="$kernsrc/include/config/ieee1394/dma.h";
> yields the following INCORRECT expansion:
> /lib/modules/2.6.28-19-generic/build/include/config/ieee1394/dma.h
> this is the place where I am building into, which is different from the place where Ubuntu places the include files from the package
> 
> Thus I built an expression to get:
> /usr/src/linux-headers-2.6.28-19-generic/include/config/ieee1394/dma.h
> as I described in the mail of yesterday.


Huh? Are you sure that Ubuntu doesn't have a symbolic link at /lib/modules/2.6.28-19-generic/build pointing
to /usr/src/linux-headers-2.6.28-19-generic/?

If it doesn't have, then all compat checks done by make_config_compat.pl would fail.

> Now, I realize that the header files could ALSO be present in the build directory, so there should be a check on that as well, as otherwise the FIREDTV is incorrectly disabled on other distros, or source builds.
> 
> Yes, and I know all of this is ugly ....

It is not just ugly. It will break compilation on Ubuntu with:
	$ make release DIR=<some dir>

Cheers,
Mauro

Re: updated make_kconfig.pl for Ubuntu

[Jan Hoogenraad]

Douglas:

I have an updated make_kconfig.pl for Ububtu on:
http://linuxtv.org/hg/~jhoogenraad/rtl2831-r2/file/cb34ee1c29fc/v4l/scripts/make_kconfig.pl

Could you test if make allyesconfig actually keeps FIREDTV enabled on a 
non-Ubuntu system ?

If so, can you merge this version into the main stream ?


Mauro:

You are very right. I did not look far enough.

The expanded place where I expect the dma.h file would be (as I
/lib/modules/2.6.28-19-generic/build/include/config/ieee1394/dma.h

note that the letters "el" should be removed from your first expression
$dmahplace="$kernelsrc/include/config/ieee1394/dma.h";
needs to be:
$dmahplace="$kernsrc/include/config/ieee1394/dma.h";

Thanks a lot for helping !


As patch, relative to the diff you sent:

# HG changeset patch
# User Jan Hoogenraad <jan-conceptronic@h-i-s.nl>
# Date 1285695899 -7200
# Node ID 891128e7c3334e41f6c173ee5c01fddbce493b73
# Parent  cb34ee1c29fc8891ad3792b3df76031a72e39b9d
Location fix

From: Jan Hoogenraad <jan-conceptronic@h-i-s.nl>

Location fix

Priority: normal

Signed-off-by: Jan Hoogenraad <jan-conceptronic@h-i-s.nl>

diff -r cb34ee1c29fc -r 891128e7c333 v4l/scripts/make_kconfig.pl
--- a/v4l/scripts/make_kconfig.pl	Mon Sep 27 20:27:20 2010 +0200
+++ b/v4l/scripts/make_kconfig.pl	Tue Sep 28 19:44:59 2010 +0200
@@ -688,10 +688,7 @@
  # Check for full kernel sources and print a warning
  sub dmahcheck()
  {
-	my $dmahplace= "".$kernsrc;
-	$dmahplace =~ s-^/lib/modules/--g;
-	$dmahplace =~ s-/.*$--g;
- 
$dmahplace="/usr/src/linux-headers-$dmahplace/include/config/ieee1394/dma.h";
+	my $dmahplace="$kernsrc/include/config/ieee1394/dma.h";
  	if (! -e $dmahplace) {
  		print <<"EOF2";


Mauro Carvalho Chehab wrote:
> Em 27-09-2010 17:45, Jan Hoogenraad escreveu:
>> Mauro:
>>
>> On my system, the call to make_kconfig reads:
>> ./scripts/make_kconfig.pl /lib/modules/2.6.28-19-generic/build /lib/modules/2.6.28-19-generic/build 1
>>
>> Using $kernelsrc yields the following error:
>> Global symbol "$kernelsrc" requires explicit package name at ./scripts/make_kconfig.pl line 694.
>>
>> Using
>> $dmahplace="$kernsrc/include/config/ieee1394/dma.h";
>> yields the following INCORRECT expansion:
>> /lib/modules/2.6.28-19-generic/build/include/config/ieee1394/dma.h
>> this is the place where I am building into, which is different from the place where Ubuntu places the include files from the package
>>
>> Thus I built an expression to get:
>> /usr/src/linux-headers-2.6.28-19-generic/include/config/ieee1394/dma.h
>> as I described in the mail of yesterday.
>
>
> Huh? Are you sure that Ubuntu doesn't have a symbolic link at /lib/modules/2.6.28-19-generic/build pointing
> to /usr/src/linux-headers-2.6.28-19-generic/?
>
> If it doesn't have, then all compat checks done by make_config_compat.pl would fail.
>
>> Now, I realize that the header files could ALSO be present in the build directory, so there should be a check on that as well, as otherwise the FIREDTV is incorrectly disabled on other distros, or source builds.
>>
>> Yes, and I know all of this is ugly ....
>
> It is not just ugly. It will break compilation on Ubuntu with:
> 	$ make release DIR=<some dir>
>
> Cheers,
> Mauro
>


-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht

Re: updated make_kconfig.pl for Ubuntu

[Mauro Carvalho Chehab]

Em 28-09-2010 14:48, Jan Hoogenraad escreveu:
> Douglas:
> 
> I have an updated make_kconfig.pl for Ububtu on:
> http://linuxtv.org/hg/~jhoogenraad/rtl2831-r2/file/cb34ee1c29fc/v4l/scripts/make_kconfig.pl
> 
> Could you test if make allyesconfig actually keeps FIREDTV enabled on a non-Ubuntu system ?
> 
> If so, can you merge this version into the main stream ?
> 
> 
> Mauro:
> 
> You are very right. I did not look far enough.
> 
> The expanded place where I expect the dma.h file would be (as I
> /lib/modules/2.6.28-19-generic/build/include/config/ieee1394/dma.h
> 
> note that the letters "el" should be removed from your first expression
> $dmahplace="$kernelsrc/include/config/ieee1394/dma.h";
> needs to be:
> $dmahplace="$kernsrc/include/config/ieee1394/dma.h";
> 
> Thanks a lot for helping !
> 
> 
> As patch, relative to the diff you sent:
> 
> # HG changeset patch
> # User Jan Hoogenraad <jan-conceptronic@h-i-s.nl>
> # Date 1285695899 -7200
> # Node ID 891128e7c3334e41f6c173ee5c01fddbce493b73
> # Parent  cb34ee1c29fc8891ad3792b3df76031a72e39b9d
> Location fix
> 
> From: Jan Hoogenraad <jan-conceptronic@h-i-s.nl>
> 
> Location fix
> 
> Priority: normal
> 
> Signed-off-by: Jan Hoogenraad <jan-conceptronic@h-i-s.nl>
> 
> diff -r cb34ee1c29fc -r 891128e7c333 v4l/scripts/make_kconfig.pl
> --- a/v4l/scripts/make_kconfig.pl    Mon Sep 27 20:27:20 2010 +0200
> +++ b/v4l/scripts/make_kconfig.pl    Tue Sep 28 19:44:59 2010 +0200
> @@ -688,10 +688,7 @@
>  # Check for full kernel sources and print a warning
>  sub dmahcheck()
>  {
> -    my $dmahplace= "".$kernsrc;
> -    $dmahplace =~ s-^/lib/modules/--g;
> -    $dmahplace =~ s-/.*$--g;
> - $dmahplace="/usr/src/linux-headers-$dmahplace/include/config/ieee1394/dma.h";
> +    my $dmahplace="$kernsrc/include/config/ieee1394/dma.h";
>      if (! -e $dmahplace) {
>          print <<"EOF2";

Ok, now it looks correct on my eyes, and it should not hurt compilation
with make release and with distros that do a good job with their kernel
packages.

I'll let Douglas review and test, as he is the maintainer.

It would be better if you could send him a diff. you may use hg diff to generate
it against an older version, in order to merge all your make_kconfig.pl patches,
or just create a new clone from master and apply it there.

A side question: when do you intend to send us the patches for the Realtek
rtl2831?

Cheers,
Mauro.

Re: updated make_kconfig.pl for Ubuntu

[Jan Hoogenraad]

[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]

Douglas:

Can you push the updated make_kconfig.pl ?

It is in its own HG tree on:
http://linuxtv.org/hg/~jhoogenraad/ubuntu-firedtv/

Mauro Carvalho Chehab wrote:
> Em 28-09-2010 14:48, Jan Hoogenraad escreveu:
>> Douglas:
>>
>> I have an updated make_kconfig.pl for Ububtu on:
>> http://linuxtv.org/hg/~jhoogenraad/rtl2831-r2/file/cb34ee1c29fc/v4l/scripts/make_kconfig.pl
>>
>> Could you test if make allyesconfig actually keeps FIREDTV enabled on a non-Ubuntu system ?
>>
>> If so, can you merge this version into the main stream ?
>>
>
> Ok, now it looks correct on my eyes, and it should not hurt compilation
> with make release and with distros that do a good job with their kernel
> packages.
>
> I'll let Douglas review and test, as he is the maintainer.
>
> It would be better if you could send him a diff. you may use hg diff to generate
> it against an older version, in order to merge all your make_kconfig.pl patches,
> or just create a new clone from master and apply it there.
>
> A side question: when do you intend to send us the patches for the Realtek
> rtl2831?
>
> Cheers,
> Mauro.
>


-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht

[-- Attachment #2: ubuntu.patch --]
[-- Type: text/x-patch, Size: 1359 bytes --]

# HG changeset patch
# User Jan Hoogenraad <jan-conceptronic@h-i-s.nl>
# Date 1285703652 -7200
# Node ID c8e14191e48d98a19405c9f899abca30cd89bc18
# Parent  1da5fed5c8b2c626180b1a0983fe1c960b999525
Disable FIREDTV for debian/ubuntu distributions with bad header files

From: Jan Hoogenraad <jan-conceptronic@h-i-s.nl>

Disable FIREDTV for debian/ubuntu distributions with problems in header files

Priority: normal

Signed-off-by: Jan Hoogenraad <jan-conceptronic@h-i-s.nl>

diff -r 1da5fed5c8b2 -r c8e14191e48d v4l/scripts/make_kconfig.pl
--- a/v4l/scripts/make_kconfig.pl	Sun Sep 19 02:23:09 2010 -0300
+++ b/v4l/scripts/make_kconfig.pl	Tue Sep 28 21:54:12 2010 +0200
@@ -597,6 +597,9 @@
 disable_config('STAGING_BROKEN');
 $intopt { "DVB_MAX_ADAPTERS" } = 8;
 
+#check broken Ubuntu headers
+dmahcheck();
+
 # Check dependencies
 my %newconfig = checkdeps();
 
@@ -681,3 +684,24 @@
 EOF3
 	sleep 5;
 }
+
+# Check for full kernel sources and print a warning
+sub dmahcheck()
+{
+	my $dmahplace="$kernsrc/include/config/ieee1394/dma.h";
+	if (! -e $dmahplace) {
+		print <<"EOF2";
+
+***WARNING:*** File $dmahplace not present.
+This problem is at least present on Ubuntu systems:
+https://bugs.launchpad.net/ubuntu/+source/linux-kernel-headers/+bug/134222
+
+Therefore disabling FIREDTV driver.
+
+EOF2
+
+	disable_config('DVB_FIREDTV');
+
+	}
+	sleep 5;
+}

patches for the Realtek rtl2831

[Jan Hoogenraad]

Mauro Carvalho Chehab wrote:

>
> A side question: when do you intend to send us the patches for the Realtek
> rtl2831?
>

Basically, I'm waiting for somebody to take up the task to include IR 
support in Antti's branches. I don't have the knowledge to do so.
In the mean time, I just maintain the code from Realtek on a sync with 
mainline only base in hg, as the code is really sub-standard.

http://www.linuxtv.org/wiki/index.php/Realtek_RTL2831U

I have seen that Realtek keeps updating their Windows code, and the v4l 
port, at least for the RTL2832.
I see the "recipes" to use that on many forums.

> Cheers,
> Mauro.
>


-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht