[Buildroot] [PATCH 0/4] /etc/inittab stuff and device creation stuff

[Buildroot] [PATCH 0/4] /etc/inittab stuff and device creation stuff

[Yegor Yefremov]

Hi Peter and Thomas,

we've discussed mdev/udev handling and I've made some patches concerning this issue. The main idea is to provide 4 methods on how devices are created:

1. static - using the device_table.txt
2. dynamic - using devtmpfs only
3. dynamic - using devtmpfs and mdev
4. dynamic - using devtmpfs and udev

All methods are suitable for both read-only and full-featured file systems. The patches select appropriate options for kernel/BusyBox/packages, so it should be sufficient just to choose the proper method in "Target filesystem option".

Due to the fact, that device_table.txt not only creates devices, but also some folders in /etc/network. So I made a patch that creates this folders in default skeleton.

The second path of the patches enables custom console port configuration and also terminal type will be made configurable.

Please review the patches.

Best regards,
Yegor

[Buildroot] [PATCH 2/4] Enable terminal type configuration for /etc/inittab

[Yegor Yefremov]

---
 target/generic/Config.in   |    6 ++++++
 target/generic/Makefile.in |    3 ++-
 2 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/target/generic/Config.in b/target/generic/Config.in
index 286b0a3..e7b2c9f 100644
--- a/target/generic/Config.in
+++ b/target/generic/Config.in
@@ -164,6 +164,12 @@ config BR2_TARGET_GENERIC_GETTY_BAUDRATE_115200
 	bool "115200"
 endchoice
 
+config BR2_TARGET_GENERIC_GETTY_TERMINAL_TYPE
+	string "Terminal type"
+	default "vt100"
+	help
+		Specify a terminal type like vt100, linux etc.
+
 config BR2_TARGET_GENERIC_GETTY_BAUDRATE
 	string
 	default "0"		if BR2_TARGET_GENERIC_GETTY_BAUDRATE_KEEP
diff --git a/target/generic/Makefile.in b/target/generic/Makefile.in
index 1ef2a9d..dce23e6 100644
--- a/target/generic/Makefile.in
+++ b/target/generic/Makefile.in
@@ -2,6 +2,7 @@ TARGET_GENERIC_HOSTNAME:=$(call qstrip,$(BR2_TARGET_GENERIC_HOSTNAME))
 TARGET_GENERIC_ISSUE:=$(call qstrip,$(BR2_TARGET_GENERIC_ISSUE))
 TARGET_GENERIC_GETTY:=$(call qstrip,$(BR2_TARGET_GENERIC_GETTY_PORT))
 TARGET_GENERIC_GETTY_BAUDRATE:=$(call qstrip,$(BR2_TARGET_GENERIC_GETTY_BAUDRATE))
+TARGET_GENERIC_GETTY_TERMINAL_TYPE:=$(call qstrip,$(BR2_TARGET_GENERIC_GETTY_TERMINAL_TYPE))
 
 target-generic-hostname:
 	mkdir -p $(TARGET_DIR)/etc
@@ -12,7 +13,7 @@ target-generic-issue:
 	echo "$(TARGET_GENERIC_ISSUE)" > $(TARGET_DIR)/etc/issue
 
 target-generic-getty:
-	$(SED) '/# GENERIC_SERIAL$$/s~^.*#~$(TARGET_GENERIC_GETTY)::respawn:/sbin/getty -L $(TARGET_GENERIC_GETTY) $(TARGET_GENERIC_GETTY_BAUDRATE) vt100 #~' \
+	$(SED) '/# GENERIC_SERIAL$$/s~^.*#~$(TARGET_GENERIC_GETTY)::respawn:/sbin/getty -L $(TARGET_GENERIC_GETTY) $(TARGET_GENERIC_GETTY_BAUDRATE) $(TARGET_GENERIC_GETTY_TERMINAL_TYPE) #~' \
 		$(TARGET_DIR)/etc/inittab
 
 ifneq ($(TARGET_GENERIC_HOSTNAME),)

[Buildroot] [PATCH 3/4] Create menu entry to select device creation method

[Yegor Yefremov]

- static method uses device table as before
- devtmpfs method enables this feature in kernel
- mdev method adds mdev starting script to the file system
  and selects mdev itself for installation
- udev method selects udev for installation

All dynamic methods are base on devtmpfs, so one doesn't
need to care about /dev folder.
---
 fs/Config.in               |   32 ++++++++++++++++++++++++++------
 linux/linux.mk             |    4 ++++
 package/busybox/S10mdev    |   26 ++++++++++++++++++++++++++
 package/busybox/busybox.mk |   15 +++++++++++++++
 4 files changed, 71 insertions(+), 6 deletions(-)
 create mode 100644 package/busybox/S10mdev

diff --git a/fs/Config.in b/fs/Config.in
index 188e815..50d4382 100644
--- a/fs/Config.in
+++ b/fs/Config.in
@@ -15,13 +15,33 @@ config BR2_ROOTFS_POST_BUILD_SCRIPT
 	  only argument. Make sure the exit code of that script is 0,
 	  otherwise make will stop after calling it.
 
+choice
+	prompt "Device Creation"
+	default BR2_ROOTFS_DEVICE_CREATION_STATIC
+
+config BR2_ROOTFS_DEVICE_CREATION_STATIC
+	bool "Static using device table"
+
+config BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_DEVTMPFS
+	bool "Dynamic using devtmpfs only"
+
+config BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV
+	bool "Dynamic using mdev"
+
+config BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
+	bool "Dynamic using udev"
+	select BR2_PACKAGE_UDEV
+
+endchoice
+
 config BR2_ROOTFS_DEVICE_TABLE
-       string "Path to the device table"
-       default "target/generic/device_table.txt"
-       help
-         Specify the location of a device table, that will be passed
-         to the makedevs utility to create all the special device
-         files in the target filesystem.
+	string "Path to the device table"
+	depends on BR2_ROOTFS_DEVICE_CREATION_STATIC
+	default "target/generic/device_table.txt"
+	help
+	 Specify the location of a device table, that will be passed
+	 to the makedevs utility to create all the special device
+	 files in the target filesystem.
 
 choice
 	prompt "Root FS skeleton"
diff --git a/linux/linux.mk b/linux/linux.mk
index ea338fc..6ebbb4f 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -105,6 +105,10 @@ ifeq ($(BR2_TARGET_ROOTFS_INITRAMFS),y)
 	$(call KCONFIG_SET_OPT,CONFIG_INITRAMFS_SOURCE,\"$(BINARIES_DIR)/rootfs.initramfs\",$(@D)/.config)
 	$(call KCONFIG_ENABLE_OPT,CONFIG_INITRAMFS_COMPRESSION_GZIP,$(@D)/.config)
 endif
+ifneq ($(BR2_ROOTFS_DEVICE_CREATION_STATIC),y)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config)
+endif
 	$(TARGET_MAKE_ENV) $(MAKE) $(LINUX26_MAKE_FLAGS) -C $(@D) oldconfig
 	$(Q)touch $@
 
diff --git a/package/busybox/S10mdev b/package/busybox/S10mdev
new file mode 100644
index 0000000..943b73b
--- /dev/null
+++ b/package/busybox/S10mdev
@@ -0,0 +1,26 @@
+#!/bin/sh
+#
+# Start the mdev....
+#
+
+case "$1" in
+  start)
+ 	echo "Starting mdev..."
+	/sbin/mdev -s
+	;;
+  stop)
+	echo -n "Stopping mdev..."
+	killall mdev
+	;;
+  restart|reload)
+	"$0" stop
+	"$0" start
+	;;
+  *)
+	echo $"Usage: $0 {start|stop|restart}"
+	exit 1
+esac
+
+exit $?
+
+
diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk
index b7f4740..d4b04a9 100644
--- a/package/busybox/busybox.mk
+++ b/package/busybox/busybox.mk
@@ -20,6 +20,19 @@ ifndef BUSYBOX_CONFIG_FILE
 	BUSYBOX_CONFIG_FILE = $(call qstrip,$(BR2_PACKAGE_BUSYBOX_CONFIG))
 endif
 
+# If mdev will be used for device creation enable it and copy S10mdev to /etc/init.d
+ifeq ($(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV),y)
+define BUSYBOX_INSTALL_MDEV_SCRIPT
+	install -m 0755 package/busybox/S10mdev $(TARGET_DIR)/etc/init.d
+endef
+define BUSYBOX_SET_MDEV
+	$(call KCONFIG_ENABLE_OPT,CONFIG_MDEV,$(BUSYBOX_BUILD_CONFIG))
+	$(call KCONFIG_ENABLE_OPT,CONFIG_FEATURE_MDEV_CONF,$(BUSYBOX_BUILD_CONFIG))
+	$(call KCONFIG_ENABLE_OPT,CONFIG_FEATURE_MDEV_EXEC,$(BUSYBOX_BUILD_CONFIG))
+	$(call KCONFIG_ENABLE_OPT,CONFIG_FEATURE_MDEV_LOAD_FIRMWARE,$(BUSYBOX_BUILD_CONFIG))
+endef
+endif
+
 # If we have external syslogd, force busybox to use it
 ifeq ($(BR2_PACKAGE_SYSKLOGD),y)
 define BUSYBOX_SET_SYSKLOGD
@@ -114,6 +127,7 @@ define BUSYBOX_CONFIGURE_CMDS
 	$(BUSYBOX_SET_IPV6)
 	$(BUSYBOX_SET_RPC)
 	$(BUSYBOX_PREFER_STATIC)
+	$(BUSYBOX_SET_MDEV)
 	$(BUSYBOX_NETKITBASE)
 	$(BUSYBOX_NETKITTELNET)
 	@yes "" | $(MAKE) ARCH=$(KERNEL_ARCH) CROSS_COMPILE="$(TARGET_CROSS)" \
@@ -142,6 +156,7 @@ endif
 define BUSYBOX_INSTALL_TARGET_CMDS
 	$(BUSYBOX_INSTALL_BINARY)
 	-chmod a+rx $(TARGET_DIR)/usr/share/udhcpc/default.script
+	$(BUSYBOX_INSTALL_MDEV_SCRIPT)
 endef
 
 define BUSYBOX_UNINSTALL_TARGET_CMDS
-- 
1.7.1.1

[Buildroot] [PATCH 4/4] Add network scripting folders to fs/skeleton

[Yegor Yefremov]

Those folders by device_table.txt. If using the dynamic device creation method
these folders will be missing.
---
 0 files changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 fs/skeleton/etc/network/if-down.d/.empty
 create mode 100644 fs/skeleton/etc/network/if-post-down.d/.empty
 create mode 100644 fs/skeleton/etc/network/if-pre-up.d/.empty
 create mode 100644 fs/skeleton/etc/network/if-up.d/.empty

diff --git a/fs/skeleton/etc/network/if-down.d/.empty b/fs/skeleton/etc/network/if-down.d/.empty
new file mode 100644
index 0000000..e69de29
diff --git a/fs/skeleton/etc/network/if-post-down.d/.empty b/fs/skeleton/etc/network/if-post-down.d/.empty
new file mode 100644
index 0000000..e69de29
diff --git a/fs/skeleton/etc/network/if-pre-up.d/.empty b/fs/skeleton/etc/network/if-pre-up.d/.empty
new file mode 100644
index 0000000..e69de29
diff --git a/fs/skeleton/etc/network/if-up.d/.empty b/fs/skeleton/etc/network/if-up.d/.empty
new file mode 100644
index 0000000..e69de29
-- 
1.7.1.1

[Buildroot] [PATCH 1/4] Added new menu item to specify a custom port for /etc/inittab

[Yegor Yefremov]

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

---
 target/generic/Config.in |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/target/generic/Config.in b/target/generic/Config.in
index 54ff1d6..286b0a3 100644
--- a/target/generic/Config.in
+++ b/target/generic/Config.in
@@ -102,8 +102,16 @@ config BR2_TARGET_GENERIC_GETTY_TTYCPM2
 config BR2_TARGET_GENERIC_GETTY_TTYCPM3
 	bool "ttyCPM3"
 	depends on BR2_powerpc
+config BR2_TARGET_GENERIC_GETTY_CUSTOM
+	bool "Select custom port"
+
 endchoice
 
+config BR2_TARGET_GENERIC_GETTY_CUSTOM_PORT
+	string "Port"
+	depends on BR2_TARGET_GENERIC_GETTY_CUSTOM
+	default ""
+
 config BR2_TARGET_GENERIC_GETTY_PORT
 	string
 	default "#ttyS0"	if BR2_TARGET_GENERIC_GETTY_NONE
@@ -134,6 +142,7 @@ config BR2_TARGET_GENERIC_GETTY_PORT
 	default "ttyCPM1"	if BR2_TARGET_GENERIC_GETTY_TTYCPM1
 	default "ttyCPM2"	if BR2_TARGET_GENERIC_GETTY_TTYCPM2
 	default "ttyCPM3"	if BR2_TARGET_GENERIC_GETTY_TTYCPM3
+	default $(BR2_TARGET_GENERIC_GETTY_CUSTOM_PORT) if BR2_TARGET_GENERIC_GETTY_CUSTOM
 
 choice
 	prompt "Baudrate to use"

[Buildroot] [PATCH 1/4] Added new menu item to specify a custom port for /etc/inittab

[Thomas Petazzoni]

Hello,

Would people cry/complain if instead of the following patch we simply
replace the TARGET_GENERIC_GETTY_PORT parameter by a single free-form
text-field ?

Thomas

On Mon, 27 Sep 2010 10:53:36 +0200
Yegor Yefremov <yegor_sub1@visionsystems.de> wrote:

> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> 
> ---
>  target/generic/Config.in |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/target/generic/Config.in b/target/generic/Config.in
> index 54ff1d6..286b0a3 100644
> --- a/target/generic/Config.in
> +++ b/target/generic/Config.in
> @@ -102,8 +102,16 @@ config BR2_TARGET_GENERIC_GETTY_TTYCPM2
>  config BR2_TARGET_GENERIC_GETTY_TTYCPM3
>  	bool "ttyCPM3"
>  	depends on BR2_powerpc
> +config BR2_TARGET_GENERIC_GETTY_CUSTOM
> +	bool "Select custom port"
> +
>  endchoice
>  
> +config BR2_TARGET_GENERIC_GETTY_CUSTOM_PORT
> +	string "Port"
> +	depends on BR2_TARGET_GENERIC_GETTY_CUSTOM
> +	default ""
> +
>  config BR2_TARGET_GENERIC_GETTY_PORT
>  	string
>  	default "#ttyS0"	if BR2_TARGET_GENERIC_GETTY_NONE
> @@ -134,6 +142,7 @@ config BR2_TARGET_GENERIC_GETTY_PORT
>  	default "ttyCPM1"	if BR2_TARGET_GENERIC_GETTY_TTYCPM1
>  	default "ttyCPM2"	if BR2_TARGET_GENERIC_GETTY_TTYCPM2
>  	default "ttyCPM3"	if BR2_TARGET_GENERIC_GETTY_TTYCPM3
> +	default $(BR2_TARGET_GENERIC_GETTY_CUSTOM_PORT) if BR2_TARGET_GENERIC_GETTY_CUSTOM
>  
>  choice
>  	prompt "Baudrate to use"
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot


-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 2/4] Enable terminal type configuration for /etc/inittab

[Thomas Petazzoni]

On Fri, 24 Sep 2010 09:37:34 +0200
Yegor Yefremov <yegor_sub1@visionsystems.de> wrote:

> diff --git a/target/generic/Config.in b/target/generic/Config.in
> index 286b0a3..e7b2c9f 100644
> --- a/target/generic/Config.in
> +++ b/target/generic/Config.in
> @@ -164,6 +164,12 @@ config BR2_TARGET_GENERIC_GETTY_BAUDRATE_115200
>  	bool "115200"
>  endchoice
>  
> +config BR2_TARGET_GENERIC_GETTY_TERMINAL_TYPE
> +	string "Terminal type"
> +	default "vt100"
> +	help
> +		Specify a terminal type like vt100, linux etc.

Need only one tab + 2 spaces for the indentation of the help text.

Just out of curiosity, in what cases isn't vt100 an appropriate value ?

Once the minor tab+spaces issue is fixed:

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

I can merge this patch (and the other patches in this patch set into my
boards-cleanup work, as it is somewhat related to board-level
configuration options).

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 3/4] Create menu entry to select device creation method

[Thomas Petazzoni]

On Fri, 24 Sep 2010 09:38:50 +0200
Yegor Yefremov <yegor_sub1@visionsystems.de> wrote:

> +choice
> +	prompt "Device Creation"
> +	default BR2_ROOTFS_DEVICE_CREATION_STATIC

I would probably name this "/dev management" or something similar. In
my boards-cleanup work, I'm creating a new top-level "System
configuration" menu. Maybe this should belong to this place instead,
but this is something I can handle if I merge this patch into my
boards-cleanup branch.

> +config BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV
> +	bool "Dynamic using mdev"

Maybe this should "select BR2_PACKAGE_BUSYBOX" ?

>  config BR2_ROOTFS_DEVICE_TABLE
> -       string "Path to the device table"
> -       default "target/generic/device_table.txt"
> -       help
> -         Specify the location of a device table, that will be passed
> -         to the makedevs utility to create all the special device
> -         files in the target filesystem.
> +	string "Path to the device table"
> +	depends on BR2_ROOTFS_DEVICE_CREATION_STATIC
> +	default "target/generic/device_table.txt"
> +	help
> +	 Specify the location of a device table, that will be passed
> +	 to the makedevs utility to create all the special device
> +	 files in the target filesystem.

Something odd here with the indentation. We should only see the new
line "depends on BR2_ROOTFS_DEVICE_CREATION_STATIC" and no other change.

> +ifneq ($(BR2_ROOTFS_DEVICE_CREATION_STATIC),y)
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config)
> +endif

So devtmpfs is used even when mdev or udev are used ?

> index 0000000..943b73b
> --- /dev/null
> +++ b/package/busybox/S10mdev
> @@ -0,0 +1,26 @@
> +#!/bin/sh
> +#
> +# Start the mdev....

s/the//

> +#
> +
> +case "$1" in
> +  start)
> + 	echo "Starting mdev..."
> +	/sbin/mdev -s

This is not sufficient as far as I remember: this will only
populate /dev with the existing devices. mdev also needs to be
registered as a hotplug event handler by writing to some /proc/sys
file. See mdev documentation for details (docs/mdev.txt in Busybox
sources).

> +  stop)
> +	echo -n "Stopping mdev..."
> +	killall mdev

mdev is not a daemon, so there's no point in killing it.

> diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk
> index b7f4740..d4b04a9 100644
> --- a/package/busybox/busybox.mk
> +++ b/package/busybox/busybox.mk
> @@ -20,6 +20,19 @@ ifndef BUSYBOX_CONFIG_FILE
>  	BUSYBOX_CONFIG_FILE = $(call qstrip,$(BR2_PACKAGE_BUSYBOX_CONFIG))
>  endif
>  
> +# If mdev will be used for device creation enable it and copy S10mdev to /etc/init.d
> +ifeq ($(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV),y)
> +define BUSYBOX_INSTALL_MDEV_SCRIPT
> +	install -m 0755 package/busybox/S10mdev $(TARGET_DIR)/etc/init.d
> +endef
> +define BUSYBOX_SET_MDEV
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_MDEV,$(BUSYBOX_BUILD_CONFIG))
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_FEATURE_MDEV_CONF,$(BUSYBOX_BUILD_CONFIG))
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_FEATURE_MDEV_EXEC,$(BUSYBOX_BUILD_CONFIG))
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_FEATURE_MDEV_LOAD_FIRMWARE,$(BUSYBOX_BUILD_CONFIG))
> +endef
> +endif
> +
>  # If we have external syslogd, force busybox to use it
>  ifeq ($(BR2_PACKAGE_SYSKLOGD),y)
>  define BUSYBOX_SET_SYSKLOGD
> @@ -114,6 +127,7 @@ define BUSYBOX_CONFIGURE_CMDS
>  	$(BUSYBOX_SET_IPV6)
>  	$(BUSYBOX_SET_RPC)
>  	$(BUSYBOX_PREFER_STATIC)
> +	$(BUSYBOX_SET_MDEV)
>  	$(BUSYBOX_NETKITBASE)
>  	$(BUSYBOX_NETKITTELNET)
>  	@yes "" | $(MAKE) ARCH=$(KERNEL_ARCH) CROSS_COMPILE="$(TARGET_CROSS)" \
> @@ -142,6 +156,7 @@ endif
>  define BUSYBOX_INSTALL_TARGET_CMDS
>  	$(BUSYBOX_INSTALL_BINARY)
>  	-chmod a+rx $(TARGET_DIR)/usr/share/udhcpc/default.script
> +	$(BUSYBOX_INSTALL_MDEV_SCRIPT)
>  endef

This part sounds good to me.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 4/4] Add network scripting folders to fs/skeleton

[Thomas Petazzoni]

On Fri, 24 Sep 2010 09:39:49 +0200
Yegor Yefremov <yegor_sub1@visionsystems.de> wrote:

> Those folders by device_table.txt. If using the dynamic device creation method
> these folders will be missing.

"Those folders are currently created by device_table.txt"...

Ok on the principle, but if those directories are now part of the
skeleton, they should be removed from the device_table.txt file.

However, looking at device_table.txt, I also see that it does a few
things not related to device files :

/dev            d       755     0       0       -       -       -       -       -
/dev/pts        d       755     0       0       -       -       -       -       -
/dev/shm        d       755     0       0       -       -       -       -       -
/tmp            d       1777    0       0       -       -       -       -       -
/etc            d       755     0       0       -       -       -       -       -
/home/default   d       2755    1000    1000    -       -       -       -       -
#<name>                                 <type>  <mode>  <uid>   <gid>   <major> <minor> <start> <inc>   <count>
/bin/busybox                            f       4755    0       0       -       -       -       -       -
/etc/shadow                             f       600     0       0       -       -       -       -       -
/etc/passwd                             f       644     0       0       -       -       -       -       -
/etc/network/if-up.d                    d       755     0       0       -       -       -       -       -
/etc/network/if-pre-up.d                d       755     0       0       -       -       -       -       -
/etc/network/if-down.d                  d       755     0       0       -       -       -       -       -
/etc/network/if-post-down.d             d       755     0       0       -       -       -       -       -
/usr/share/udhcpc/default.script        f       755     0       0	-       -       -       -       -

For each of those lines, what will replace the usage of the device
table ? For things like proper access rights
for /etc/shadow, /etc/passwd, setuid for Busybox binary, proper flags
for /tmp, maybe we have no other choices than using a device table.

In that case, we could use a split device table :

 * One used in all cases

 * One used only in the static device case. Buildroot would concatenate
   this one to the previous one before doing the root filesystem generation.

Thoughts ?

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 2/4] Enable terminal type configuration for /etc/inittab

[Yegor Yefremov]

 Am 28.09.2010 19:28, schrieb Thomas Petazzoni:
> On Fri, 24 Sep 2010 09:37:34 +0200
> Yegor Yefremov <yegor_sub1@visionsystems.de> wrote:
>
>> diff --git a/target/generic/Config.in b/target/generic/Config.in
>> index 286b0a3..e7b2c9f 100644
>> --- a/target/generic/Config.in
>> +++ b/target/generic/Config.in
>> @@ -164,6 +164,12 @@ config BR2_TARGET_GENERIC_GETTY_BAUDRATE_115200
>>  	bool "115200"
>>  endchoice
>>  
>> +config BR2_TARGET_GENERIC_GETTY_TERMINAL_TYPE
>> +	string "Terminal type"
>> +	default "vt100"
>> +	help
>> +		Specify a terminal type like vt100, linux etc.
> Need only one tab + 2 spaces for the indentation of the help text.
>
> Just out of curiosity, in what cases isn't vt100 an appropriate value ?

Good question. We just use TERM=linux for our Debian installations, so I wanted to do it also for Buildroot. But you're right vt100 should be sufficient, that's why I made it default, so the old behavior is preserved.

Best regards,
Yegor

[Buildroot] [PATCH 1/4] Added new menu item to specify a custom port for /etc/inittab

[Yegor Yefremov]

> Would people cry/complain if instead of the following patch we simply
> replace the TARGET_GENERIC_GETTY_PORT parameter by a single free-form
> text-field ?

I wouldn't ;-) Let's make it this way.

Yegor

[Buildroot] [PATCH 3/4] Create menu entry to select device creation method

[Yegor Yefremov]

>> +choice
>> +	prompt "Device Creation"
>> +	default BR2_ROOTFS_DEVICE_CREATION_STATIC
> 
> I would probably name this "/dev management" or something similar. In
> my boards-cleanup work, I'm creating a new top-level "System
> configuration" menu. Maybe this should belong to this place instead,
> but this is something I can handle if I merge this patch into my
> boards-cleanup branch.

ACK
 
>> +config BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV
>> +	bool "Dynamic using mdev"
> 
> Maybe this should "select BR2_PACKAGE_BUSYBOX" ?

ACK

>>  config BR2_ROOTFS_DEVICE_TABLE
>> -       string "Path to the device table"
>> -       default "target/generic/device_table.txt"
>> -       help
>> -         Specify the location of a device table, that will be passed
>> -         to the makedevs utility to create all the special device
>> -         files in the target filesystem.
>> +	string "Path to the device table"
>> +	depends on BR2_ROOTFS_DEVICE_CREATION_STATIC
>> +	default "target/generic/device_table.txt"
>> +	help
>> +	 Specify the location of a device table, that will be passed
>> +	 to the makedevs utility to create all the special device
>> +	 files in the target filesystem.
> 
> Something odd here with the indentation. We should only see the new
> line "depends on BR2_ROOTFS_DEVICE_CREATION_STATIC" and no other change.

The indentation is already wrong in repository.
 
>> +ifneq ($(BR2_ROOTFS_DEVICE_CREATION_STATIC),y)
>> +	$(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
>> +	$(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config)
>> +endif
> 
> So devtmpfs is used even when mdev or udev are used ?

Why not? Otherwise you'll have to take care about /dev and fill it with devices.

>> index 0000000..943b73b
>> --- /dev/null
>> +++ b/package/busybox/S10mdev
>> @@ -0,0 +1,26 @@
>> +#!/bin/sh
>> +#
>> +# Start the mdev....
> 
> s/the//

ACK
 
>> +#
>> +
>> +case "$1" in
>> +  start)
>> + 	echo "Starting mdev..."
>> +	/sbin/mdev -s
> 
> This is not sufficient as far as I remember: this will only
> populate /dev with the existing devices. mdev also needs to be
> registered as a hotplug event handler by writing to some /proc/sys
> file. See mdev documentation for details (docs/mdev.txt in Busybox
> sources).

This can be done by filling the appropriate kernel option in .config UEVENT_HELPER_PATH.

>> +  stop)
>> +	echo -n "Stopping mdev..."
>> +	killall mdev
> 
> mdev is not a daemon, so there's no point in killing it.

ACK
 
>> diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk
>> index b7f4740..d4b04a9 100644
>> --- a/package/busybox/busybox.mk
>> +++ b/package/busybox/busybox.mk
>> @@ -20,6 +20,19 @@ ifndef BUSYBOX_CONFIG_FILE
>>  	BUSYBOX_CONFIG_FILE = $(call qstrip,$(BR2_PACKAGE_BUSYBOX_CONFIG))
>>  endif
>>  
>> +# If mdev will be used for device creation enable it and copy S10mdev to /etc/init.d
>> +ifeq ($(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV),y)
>> +define BUSYBOX_INSTALL_MDEV_SCRIPT
>> +	install -m 0755 package/busybox/S10mdev $(TARGET_DIR)/etc/init.d
>> +endef
>> +define BUSYBOX_SET_MDEV
>> +	$(call KCONFIG_ENABLE_OPT,CONFIG_MDEV,$(BUSYBOX_BUILD_CONFIG))
>> +	$(call KCONFIG_ENABLE_OPT,CONFIG_FEATURE_MDEV_CONF,$(BUSYBOX_BUILD_CONFIG))
>> +	$(call KCONFIG_ENABLE_OPT,CONFIG_FEATURE_MDEV_EXEC,$(BUSYBOX_BUILD_CONFIG))
>> +	$(call KCONFIG_ENABLE_OPT,CONFIG_FEATURE_MDEV_LOAD_FIRMWARE,$(BUSYBOX_BUILD_CONFIG))
>> +endef
>> +endif
>> +
>>  # If we have external syslogd, force busybox to use it
>>  ifeq ($(BR2_PACKAGE_SYSKLOGD),y)
>>  define BUSYBOX_SET_SYSKLOGD
>> @@ -114,6 +127,7 @@ define BUSYBOX_CONFIGURE_CMDS
>>  	$(BUSYBOX_SET_IPV6)
>>  	$(BUSYBOX_SET_RPC)
>>  	$(BUSYBOX_PREFER_STATIC)
>> +	$(BUSYBOX_SET_MDEV)
>>  	$(BUSYBOX_NETKITBASE)
>>  	$(BUSYBOX_NETKITTELNET)
>>  	@yes "" | $(MAKE) ARCH=$(KERNEL_ARCH) CROSS_COMPILE="$(TARGET_CROSS)" \
>> @@ -142,6 +156,7 @@ endif
>>  define BUSYBOX_INSTALL_TARGET_CMDS
>>  	$(BUSYBOX_INSTALL_BINARY)
>>  	-chmod a+rx $(TARGET_DIR)/usr/share/udhcpc/default.script
>> +	$(BUSYBOX_INSTALL_MDEV_SCRIPT)
>>  endef
> 
> This part sounds good to me.
> 
> Thomas

[Buildroot] [PATCH 3/4] Create menu entry to select device creation method

[Yegor Yefremov]

Create menu entry to select device creation method:

- static method uses device table as before
- devtmpfs method enables this feature in kernel
- mdev method adds mdev starting script to the file system
  and selects mdev itself for installation
- udev method selects udev for installation 

All dynamic methods are base on devtmpfs, so one doesn't
need to care about /dev folder.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Index: b/fs/Config.in
===================================================================
--- a/fs/Config.in	2010-09-30 14:52:42.000000000 +0200
+++ b/fs/Config.in	2010-09-30 14:54:12.000000000 +0200
@@ -15,13 +15,34 @@
 	  only argument. Make sure the exit code of that script is 0,
 	  otherwise make will stop after calling it.
 
+choice
+	prompt "/dev management"
+	default BR2_ROOTFS_DEVICE_CREATION_STATIC
+
+config BR2_ROOTFS_DEVICE_CREATION_STATIC
+	bool "Static using device table"
+
+config BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_DEVTMPFS
+	bool "Dynamic using devtmpfs only"
+
+config BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV
+	bool "Dynamic using mdev"
+	select BR2_PACKAGE_BUSYBOX
+
+config BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
+	bool "Dynamic using udev"
+	select BR2_PACKAGE_UDEV
+
+endchoice
+
 config BR2_ROOTFS_DEVICE_TABLE
-       string "Path to the device table"
-       default "target/generic/device_table.txt"
-       help
-         Specify the location of a device table, that will be passed
-         to the makedevs utility to create all the special device
-         files in the target filesystem.
+	string "Path to the device table"
+	depends on BR2_ROOTFS_DEVICE_CREATION_STATIC
+	default "target/generic/device_table.txt"
+	help
+	  Specify the location of a device table, that will be passed
+	  to the makedevs utility to create all the special device
+	  files in the target filesystem.
 
 choice
 	prompt "Root FS skeleton"
Index: b/package/busybox/S10mdev
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ b/package/busybox/S10mdev	2010-09-30 14:54:12.000000000 +0200
@@ -0,0 +1,22 @@
+#!/bin/sh
+#
+# Start mdev....
+#
+
+case "$1" in
+  start)
+ 	echo "Starting mdev..."
+	/sbin/mdev -s
+	;;
+  stop)
+	;;
+  restart|reload)
+	;;
+  *)
+	echo $"Usage: $0 {start|stop|restart}"
+	exit 1
+esac
+
+exit $?
+
+
Index: b/package/busybox/busybox.mk
===================================================================
--- a/package/busybox/busybox.mk	2010-09-30 14:52:43.000000000 +0200
+++ b/package/busybox/busybox.mk	2010-09-30 14:54:12.000000000 +0200
@@ -20,6 +20,19 @@
 	BUSYBOX_CONFIG_FILE = $(call qstrip,$(BR2_PACKAGE_BUSYBOX_CONFIG))
 endif
 
+# If mdev will be used for device creation enable it and copy S10mdev to /etc/init.d
+ifeq ($(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV),y)
+define BUSYBOX_INSTALL_MDEV_SCRIPT
+	install -m 0755 package/busybox/S10mdev $(TARGET_DIR)/etc/init.d
+endef
+define BUSYBOX_SET_MDEV
+	$(call KCONFIG_ENABLE_OPT,CONFIG_MDEV,$(BUSYBOX_BUILD_CONFIG))
+	$(call KCONFIG_ENABLE_OPT,CONFIG_FEATURE_MDEV_CONF,$(BUSYBOX_BUILD_CONFIG))
+	$(call KCONFIG_ENABLE_OPT,CONFIG_FEATURE_MDEV_EXEC,$(BUSYBOX_BUILD_CONFIG))
+	$(call KCONFIG_ENABLE_OPT,CONFIG_FEATURE_MDEV_LOAD_FIRMWARE,$(BUSYBOX_BUILD_CONFIG))
+endef
+endif
+
 # If we have external syslogd, force busybox to use it
 ifeq ($(BR2_PACKAGE_SYSKLOGD),y)
 define BUSYBOX_SET_SYSKLOGD
@@ -114,6 +127,7 @@
 	$(BUSYBOX_SET_IPV6)
 	$(BUSYBOX_SET_RPC)
 	$(BUSYBOX_PREFER_STATIC)
+	$(BUSYBOX_SET_MDEV)
 	$(BUSYBOX_NETKITBASE)
 	$(BUSYBOX_NETKITTELNET)
 	@yes "" | $(MAKE) ARCH=$(KERNEL_ARCH) CROSS_COMPILE="$(TARGET_CROSS)" \
@@ -142,6 +156,7 @@
 define BUSYBOX_INSTALL_TARGET_CMDS
 	$(BUSYBOX_INSTALL_BINARY)
 	-chmod a+rx $(TARGET_DIR)/usr/share/udhcpc/default.script
+	$(BUSYBOX_INSTALL_MDEV_SCRIPT)
 endef
 
 define BUSYBOX_UNINSTALL_TARGET_CMDS
Index: b/linux/linux.mk
===================================================================
--- a/linux/linux.mk	2010-09-30 14:52:54.000000000 +0200
+++ b/linux/linux.mk	2010-09-30 14:54:12.000000000 +0200
@@ -109,6 +109,13 @@
 	$(call KCONFIG_SET_OPT,CONFIG_INITRAMFS_SOURCE,\"$(BINARIES_DIR)/rootfs.initramfs\",$(@D)/.config)
 	$(call KCONFIG_ENABLE_OPT,CONFIG_INITRAMFS_COMPRESSION_GZIP,$(@D)/.config)
 endif
+ifneq ($(BR2_ROOTFS_DEVICE_CREATION_STATIC),y)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
+	$(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config)
+endif
+ifeq ($(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV),y)
+	$(call KCONFIG_SET_OPT,CONFIG_UEVENT_HELPER_PATH,\"/sbin/mdev\",$(@D)/.config)
+endif
 	$(TARGET_MAKE_ENV) $(MAKE) $(LINUX26_MAKE_FLAGS) -C $(@D) oldconfig
 	$(Q)touch $@
 

[Buildroot] [PATCH 4/4] Add network scripting folders to fs/skeleton

[Thomas Petazzoni]

On Fri, 24 Sep 2010 09:39:49 +0200
Yegor Yefremov <yegor_sub1@visionsystems.de> wrote:

> Those folders by device_table.txt. If using the dynamic device
> creation method these folders will be missing.

Thanks, merged into my for-2011.02/boards-cleanup branch.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 3/4] Create menu entry to select device creation method

[Thomas Petazzoni]

On Thu, 30 Sep 2010 14:57:53 +0200
Yegor Yefremov <yegor_sub1@visionsystems.de> wrote:

> Create menu entry to select device creation method:
> 
> - static method uses device table as before
> - devtmpfs method enables this feature in kernel
> - mdev method adds mdev starting script to the file system
>   and selects mdev itself for installation
> - udev method selects udev for installation 
> 
> All dynamic methods are base on devtmpfs, so one doesn't
> need to care about /dev folder.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Thanks, merged into my for-2011.02/boards-cleanup branch.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com