* KVM: VMX: Add AX to list of registers clobbered by guest switch
@ 2010-09-28 14:37 Jan Kiszka
2010-09-29 8:43 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2010-09-28 14:37 UTC (permalink / raw)
To: Avi Kivity, Marcelo Tosatti; +Cc: kvm
By chance this caused no harm so far. We overwrite AX during switch
to/from guest context, so we must declare this.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
arch/x86/kvm/vmx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 1a5ecfd..e315930 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -4013,7 +4013,7 @@ static void vmx_vcpu_run(struct kvm_vcpu *vcpu)
#endif
[cr2]"i"(offsetof(struct vcpu_vmx, vcpu.arch.cr2))
: "cc", "memory"
- , R"bx", R"di", R"si"
+ , R"ax", R"bx", R"di", R"si"
#ifdef CONFIG_X86_64
, "r8", "r9", "r10", "r11", "r12", "r13", "r14", "r15"
#endif
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: KVM: VMX: Add AX to list of registers clobbered by guest switch
2010-09-28 14:37 KVM: VMX: Add AX to list of registers clobbered by guest switch Jan Kiszka
@ 2010-09-29 8:43 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2010-09-29 8:43 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Marcelo Tosatti, kvm
On 09/28/2010 04:37 PM, Jan Kiszka wrote:
> By chance this caused no harm so far. We overwrite AX during switch
> to/from guest context, so we must declare this.
Applied, thanks.
I think we can remove the use of ax, which should reduce the chance of a
compile failure due to register pressure. But that can come later.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-29 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-28 14:37 KVM: VMX: Add AX to list of registers clobbered by guest switch Jan Kiszka
2010-09-29 8:43 ` Avi Kivity
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.