* [U-Boot] [PATCH] board_init_r: Removed unused cmdtp variable
@ 2010-10-01 14:57 Richard Retanubun
2010-10-02 8:55 ` Heiko Schocher
2010-10-06 20:55 ` Wolfgang Denk
0 siblings, 2 replies; 8+ messages in thread
From: Richard Retanubun @ 2010-10-01 14:57 UTC (permalink / raw)
To: u-boot
From 38c6ceb464f63d3705d30d6603624e7d0933f428 Mon Sep 17 00:00:00 2001
From: Richard Retanubun <RichardRetanubun@RuggedCom.com>
Date: Fri, 1 Oct 2010 10:17:26 -0400
Subject: [PATCH] board_init_r: Removed unused cmdtp variable
Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02
removed compiler warning for (now) unused cmd_tbl_t* cmdtp
---
Hi Heiko,
Not sure if you caught this one already, just a simple unused variable cleanup
- Richard
arch/avr32/lib/board.c | 1 -
arch/m68k/lib/board.c | 1 -
arch/mips/lib/board.c | 1 -
3 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/avr32/lib/board.c b/arch/avr32/lib/board.c
index e6b81cc..96ccc7f 100644
--- a/arch/avr32/lib/board.c
+++ b/arch/avr32/lib/board.c
@@ -257,7 +257,6 @@ void board_init_r(gd_t *new_gd, ulong dest_addr)
extern char * env_name_spec;
#endif
char *s;
- cmd_tbl_t *cmdtp;
bd_t *bd;
gd = new_gd;
diff --git a/arch/m68k/lib/board.c b/arch/m68k/lib/board.c
index acbdc58..3689ae3 100644
--- a/arch/m68k/lib/board.c
+++ b/arch/m68k/lib/board.c
@@ -405,7 +405,6 @@ board_init_f (ulong bootflag)
*/
void board_init_r (gd_t *id, ulong dest_addr)
{
- cmd_tbl_t *cmdtp;
char *s;
bd_t *bd;
extern void malloc_bin_reloc (void);
diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c
index 2f259cb..cdc7824 100644
--- a/arch/mips/lib/board.c
+++ b/arch/mips/lib/board.c
@@ -284,7 +284,6 @@ void board_init_f(ulong bootflag)
void board_init_r (gd_t *id, ulong dest_addr)
{
- cmd_tbl_t *cmdtp;
#ifndef CONFIG_SYS_NO_FLASH
ulong size;
#endif
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] board_init_r: Removed unused cmdtp variable
2010-10-01 14:57 [U-Boot] [PATCH] board_init_r: Removed unused cmdtp variable Richard Retanubun
@ 2010-10-02 8:55 ` Heiko Schocher
2010-10-04 12:54 ` Richard Retanubun
2010-10-06 20:55 ` Wolfgang Denk
1 sibling, 1 reply; 8+ messages in thread
From: Heiko Schocher @ 2010-10-02 8:55 UTC (permalink / raw)
To: u-boot
Hello Richard,
Richard Retanubun wrote:
> From 38c6ceb464f63d3705d30d6603624e7d0933f428 Mon Sep 17 00:00:00 2001
> From: Richard Retanubun <RichardRetanubun@RuggedCom.com>
> Date: Fri, 1 Oct 2010 10:17:26 -0400
> Subject: [PATCH] board_init_r: Removed unused cmdtp variable
>
> Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02
> removed compiler warning for (now) unused cmd_tbl_t* cmdtp
> ---
>
> Hi Heiko,
>
> Not sure if you caught this one already, just a simple unused variable
> cleanup
Thanks, but already fixed in arch/arm/lib/board.c
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] board_init_r: Removed unused cmdtp variable
2010-10-02 8:55 ` Heiko Schocher
@ 2010-10-04 12:54 ` Richard Retanubun
2010-10-04 13:00 ` Heiko Schocher
0 siblings, 1 reply; 8+ messages in thread
From: Richard Retanubun @ 2010-10-04 12:54 UTC (permalink / raw)
To: u-boot
>> Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02
>> removed compiler warning for (now) unused cmd_tbl_t* cmdtp
>> ---
>>
>> Hi Heiko,
>>
>> Not sure if you caught this one already, just a simple unused variable
>> cleanup
>
> Thanks, but already fixed in arch/arm/lib/board.c
>
> bye,
> Heiko
Hi Heiko,
Does this mean I should cc the respective maintainers for
avr32, m68k, and mips arch (the ones I found in my patch) to have them applied it?
or was that a typo and you mean the patch is already applied
on the ARM branch of the git repo?
Thanks,
- Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] board_init_r: Removed unused cmdtp variable
2010-10-04 12:54 ` Richard Retanubun
@ 2010-10-04 13:00 ` Heiko Schocher
0 siblings, 0 replies; 8+ messages in thread
From: Heiko Schocher @ 2010-10-04 13:00 UTC (permalink / raw)
To: u-boot
Hello Richard,
Richard Retanubun wrote:
>>> Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02
>>> removed compiler warning for (now) unused cmd_tbl_t* cmdtp
>>> ---
>>>
>>> Hi Heiko,
>>>
>>> Not sure if you caught this one already, just a simple unused variable
>>> cleanup
>> Thanks, but already fixed in arch/arm/lib/board.c
>>
>> bye,
>> Heiko
>
> Hi Heiko,
>
> Does this mean I should cc the respective maintainers for
> avr32, m68k, and mips arch (the ones I found in my patch) to have them applied it?
Yes.
> or was that a typo and you mean the patch is already applied
> on the ARM branch of the git repo?
I meant with "already fixed in arch/arm/lib/board.c", that in
arch/arm/lib/board.c there is no such unused variable in code,
so no need for fixing it there.
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] board_init_r: Removed unused cmdtp variable
2010-10-01 14:57 [U-Boot] [PATCH] board_init_r: Removed unused cmdtp variable Richard Retanubun
2010-10-02 8:55 ` Heiko Schocher
@ 2010-10-06 20:55 ` Wolfgang Denk
2010-10-19 14:29 ` [U-Boot] (no subject) Richard Retanubun
2010-10-19 14:29 ` [U-Boot] [PATCH 2/6] board_init_r: Removed unused cmdtp variable Richard Retanubun
1 sibling, 2 replies; 8+ messages in thread
From: Wolfgang Denk @ 2010-10-06 20:55 UTC (permalink / raw)
To: u-boot
Dear Richard Retanubun,
In message <4CA5F6DC.90005@RuggedCom.com> you wrote:
> From 38c6ceb464f63d3705d30d6603624e7d0933f428 Mon Sep 17 00:00:00 2001
> From: Richard Retanubun <RichardRetanubun@RuggedCom.com>
> Date: Fri, 1 Oct 2010 10:17:26 -0400
> Subject: [PATCH] board_init_r: Removed unused cmdtp variable
>
> Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02
> removed compiler warning for (now) unused cmd_tbl_t* cmdtp
> ---
>
> Hi Heiko,
>
> Not sure if you caught this one already, just a simple unused variable cleanup
>
> - Richard
>
> arch/avr32/lib/board.c | 1 -
> arch/m68k/lib/board.c | 1 -
> arch/mips/lib/board.c | 1 -
> 3 files changed, 0 insertions(+), 3 deletions(-)
This patch does not apply (I think it is white-space corrupted):
Applying: board_init_r: Removed unused cmdtp variable
Using index info to reconstruct a base tree...
error: patch failed: arch/avr32/lib/board.c:257
error: arch/avr32/lib/board.c: patch does not apply
error: patch failed: arch/m68k/lib/board.c:405
error: arch/m68k/lib/board.c: patch does not apply
error: patch failed: arch/mips/lib/board.c:284
error: arch/mips/lib/board.c: patch does not apply
Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Cannot fall back to three-way merge.
Patch failed at 0001 board_init_r: Removed unused cmdtp variable
Please fix and resubmit.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To understand a program you must become both the machine and the
program.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] (no subject)
2010-10-06 20:55 ` Wolfgang Denk
@ 2010-10-19 14:29 ` Richard Retanubun
2010-10-19 14:29 ` [U-Boot] [PATCH 2/6] board_init_r: Removed unused cmdtp variable Richard Retanubun
1 sibling, 0 replies; 8+ messages in thread
From: Richard Retanubun @ 2010-10-19 14:29 UTC (permalink / raw)
To: u-boot
Hi Wolfgang, sorry for the delay, here is the patch sent using git send-email.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 2/6] board_init_r: Removed unused cmdtp variable
2010-10-06 20:55 ` Wolfgang Denk
2010-10-19 14:29 ` [U-Boot] (no subject) Richard Retanubun
@ 2010-10-19 14:29 ` Richard Retanubun
2010-10-19 21:55 ` Wolfgang Denk
1 sibling, 1 reply; 8+ messages in thread
From: Richard Retanubun @ 2010-10-19 14:29 UTC (permalink / raw)
To: u-boot
From: Richard Retanubun <RichardRetanubun@RuggedCom.com>
Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02
removed compiler warning for (now) unused cmd_tbl_t* cmdtp
---
arch/avr32/lib/board.c | 1 -
arch/m68k/lib/board.c | 1 -
arch/mips/lib/board.c | 1 -
3 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/avr32/lib/board.c b/arch/avr32/lib/board.c
index e6b81cc..96ccc7f 100644
--- a/arch/avr32/lib/board.c
+++ b/arch/avr32/lib/board.c
@@ -257,7 +257,6 @@ void board_init_r(gd_t *new_gd, ulong dest_addr)
extern char * env_name_spec;
#endif
char *s;
- cmd_tbl_t *cmdtp;
bd_t *bd;
gd = new_gd;
diff --git a/arch/m68k/lib/board.c b/arch/m68k/lib/board.c
index ae9478a..a8cb205 100644
--- a/arch/m68k/lib/board.c
+++ b/arch/m68k/lib/board.c
@@ -397,7 +397,6 @@ board_init_f (ulong bootflag)
*/
void board_init_r (gd_t *id, ulong dest_addr)
{
- cmd_tbl_t *cmdtp;
char *s;
bd_t *bd;
extern void malloc_bin_reloc (void);
diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c
index 0044b19..4a22f7b 100644
--- a/arch/mips/lib/board.c
+++ b/arch/mips/lib/board.c
@@ -276,7 +276,6 @@ void board_init_f(ulong bootflag)
void board_init_r (gd_t *id, ulong dest_addr)
{
- cmd_tbl_t *cmdtp;
#ifndef CONFIG_SYS_NO_FLASH
ulong size;
#endif
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH 2/6] board_init_r: Removed unused cmdtp variable
2010-10-19 14:29 ` [U-Boot] [PATCH 2/6] board_init_r: Removed unused cmdtp variable Richard Retanubun
@ 2010-10-19 21:55 ` Wolfgang Denk
0 siblings, 0 replies; 8+ messages in thread
From: Wolfgang Denk @ 2010-10-19 21:55 UTC (permalink / raw)
To: u-boot
Dear Richard Retanubun,
In message <1287498595-23725-2-git-send-email-richardretanubun@ruggedcom.com> you wrote:
> From: Richard Retanubun <RichardRetanubun@RuggedCom.com>
>
> Follow up to commit 620f1f6a64095ed558e68d37f1965d015cd49b02
> removed compiler warning for (now) unused cmd_tbl_t* cmdtp
> ---
> arch/avr32/lib/board.c | 1 -
> arch/m68k/lib/board.c | 1 -
> arch/mips/lib/board.c | 1 -
> 3 files changed, 0 insertions(+), 3 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
After a heated argument on some trivial matter Nancy [Astor] . . .
shouted, ``If I were your wife I would put poison in your coffee!''
Whereupon Winston Churchill with equal heat and sincerity answered,
``And if I were your husband I would drink it.''
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-10-19 21:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-01 14:57 [U-Boot] [PATCH] board_init_r: Removed unused cmdtp variable Richard Retanubun
2010-10-02 8:55 ` Heiko Schocher
2010-10-04 12:54 ` Richard Retanubun
2010-10-04 13:00 ` Heiko Schocher
2010-10-06 20:55 ` Wolfgang Denk
2010-10-19 14:29 ` [U-Boot] (no subject) Richard Retanubun
2010-10-19 14:29 ` [U-Boot] [PATCH 2/6] board_init_r: Removed unused cmdtp variable Richard Retanubun
2010-10-19 21:55 ` Wolfgang Denk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.