* [PATCH] pata_bf54x: fix return type of bfin_set_devctl
@ 2010-10-21 8:00 Mike Frysinger
2010-10-21 17:45 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2010-10-21 8:00 UTC (permalink / raw)
To: linux-ide, Jeff Garzik; +Cc: uclinux-dist-devel
The new devctl func added for us to the driver has the wrong return
type. Which is to say there shouldn't be any. This fixes compile
time warnings as there shouldn't be any runtime difference.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
drivers/ata/pata_bf54x.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/pata_bf54x.c b/drivers/ata/pata_bf54x.c
index 9cae65d..5eeb922 100644
--- a/drivers/ata/pata_bf54x.c
+++ b/drivers/ata/pata_bf54x.c
@@ -826,7 +826,7 @@ static void bfin_dev_select(struct ata_port *ap, unsigned int device)
* @ctl: value to write
*/
-static u8 bfin_set_devctl(struct ata_port *ap, u8 ctl)
+static void bfin_set_devctl(struct ata_port *ap, u8 ctl)
{
void __iomem *base = (void __iomem *)ap->ioaddr.ctl_addr;
write_atapi_register(base, ATA_REG_CTRL, ctl);
--
1.7.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pata_bf54x: fix return type of bfin_set_devctl
2010-10-21 8:00 [PATCH] pata_bf54x: fix return type of bfin_set_devctl Mike Frysinger
@ 2010-10-21 17:45 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2010-10-21 17:45 UTC (permalink / raw)
To: Mike Frysinger; +Cc: linux-ide, Jeff Garzik, uclinux-dist-devel
Hello.
On 21-10-2010 12:00, Mike Frysinger wrote:
> The new devctl func added for us to the driver has the wrong return
> type. Which is to say there shouldn't be any. This fixes compile
> time warnings as there shouldn't be any runtime difference.
> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
[...]
> diff --git a/drivers/ata/pata_bf54x.c b/drivers/ata/pata_bf54x.c
> index 9cae65d..5eeb922 100644
> --- a/drivers/ata/pata_bf54x.c
> +++ b/drivers/ata/pata_bf54x.c
> @@ -826,7 +826,7 @@ static void bfin_dev_select(struct ata_port *ap, unsigned int device)
> * @ctl: value to write
> */
>
> -static u8 bfin_set_devctl(struct ata_port *ap, u8 ctl)
> +static void bfin_set_devctl(struct ata_port *ap, u8 ctl)
Sorry about that. Don't know how 'u8' crawled in...
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-21 19:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-21 8:00 [PATCH] pata_bf54x: fix return type of bfin_set_devctl Mike Frysinger
2010-10-21 17:45 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.