* Fix issue in sim_fs_op_error
@ 2010-10-24 12:04 Jeevaka Badrappan
2010-10-24 12:04 ` [PATCH] simfs: Fix issue with sim_fs_op_error Jeevaka Badrappan
0 siblings, 1 reply; 3+ messages in thread
From: Jeevaka Badrappan @ 2010-10-24 12:04 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 130 bytes --]
Hi,
Issue seen in error handling of read file information request.
This patch should fix that issue.
Regards,
jeevaka
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] simfs: Fix issue with sim_fs_op_error
2010-10-24 12:04 Fix issue in sim_fs_op_error Jeevaka Badrappan
@ 2010-10-24 12:04 ` Jeevaka Badrappan
2010-10-24 14:13 ` Denis Kenzior
0 siblings, 1 reply; 3+ messages in thread
From: Jeevaka Badrappan @ 2010-10-24 12:04 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
---
src/simfs.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/simfs.c b/src/simfs.c
index 4204aca..1e71f82 100644
--- a/src/simfs.c
+++ b/src/simfs.c
@@ -142,7 +142,10 @@ static void sim_fs_op_error(struct sim_fs *fs)
{
struct sim_fs_op *op = g_queue_peek_head(fs->op_q);
- if (op->is_read == TRUE)
+ if (op->info_only == TRUE)
+ ((sim_fs_read_info_cb_t) op->cb)
+ (0, 0, 0, 0, op->userdata);
+ else if (op->is_read == TRUE)
((ofono_sim_file_read_cb_t) op->cb)
(0, 0, 0, 0, 0, op->userdata);
else
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] simfs: Fix issue with sim_fs_op_error
2010-10-24 12:04 ` [PATCH] simfs: Fix issue with sim_fs_op_error Jeevaka Badrappan
@ 2010-10-24 14:13 ` Denis Kenzior
0 siblings, 0 replies; 3+ messages in thread
From: Denis Kenzior @ 2010-10-24 14:13 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
Hi Jeevaka,
On 10/24/2010 07:04 AM, Jeevaka Badrappan wrote:
> ---
> src/simfs.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/src/simfs.c b/src/simfs.c
> index 4204aca..1e71f82 100644
> --- a/src/simfs.c
> +++ b/src/simfs.c
> @@ -142,7 +142,10 @@ static void sim_fs_op_error(struct sim_fs *fs)
> {
> struct sim_fs_op *op = g_queue_peek_head(fs->op_q);
>
> - if (op->is_read == TRUE)
> + if (op->info_only == TRUE)
> + ((sim_fs_read_info_cb_t) op->cb)
> + (0, 0, 0, 0, op->userdata);
> + else if (op->is_read == TRUE)
> ((ofono_sim_file_read_cb_t) op->cb)
> (0, 0, 0, 0, 0, op->userdata);
> else
Good catch. Patch has been applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-24 14:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-24 12:04 Fix issue in sim_fs_op_error Jeevaka Badrappan
2010-10-24 12:04 ` [PATCH] simfs: Fix issue with sim_fs_op_error Jeevaka Badrappan
2010-10-24 14:13 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.