* -pcidevice broken - fix or remove it?
@ 2010-10-31 15:34 Jan Kiszka
2010-11-02 13:19 ` Markus Armbruster
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2010-10-31 15:34 UTC (permalink / raw)
To: kvm
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
Hi,
looks like the documented way to configure device assignment at qemu-kvm
level is broken in 0.13 and git head:
# qemu-system-x86_64 -pcidevice host=0:1a.0
qemu-system-x86_64: Parameter 'id' expects an identifier
Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
pcidevice argument parse error; please check the help text for usage
"-device pci-assign" works, but only if specify "iommu=0" (otherwise: No
IOMMU found. Unable to assign device "(null)").
Fix that legacy qemu-kvm switch or remove it at this chance? No one
seems to have complained yet.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: -pcidevice broken - fix or remove it?
2010-10-31 15:34 -pcidevice broken - fix or remove it? Jan Kiszka
@ 2010-11-02 13:19 ` Markus Armbruster
2010-11-02 14:31 ` Jan Kiszka
0 siblings, 1 reply; 4+ messages in thread
From: Markus Armbruster @ 2010-11-02 13:19 UTC (permalink / raw)
To: Jan Kiszka; +Cc: kvm, Hao, Xudong, Hidetoshi Seto
Jan Kiszka <jan.kiszka@web.de> writes:
> Hi,
>
> looks like the documented way to configure device assignment at qemu-kvm
> level is broken in 0.13 and git head:
>
> # qemu-system-x86_64 -pcidevice host=0:1a.0
> qemu-system-x86_64: Parameter 'id' expects an identifier
> Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
> pcidevice argument parse error; please check the help text for usage
>
> "-device pci-assign" works, but only if specify "iommu=0" (otherwise: No
> IOMMU found. Unable to assign device "(null)").
>
> Fix that legacy qemu-kvm switch or remove it at this chance? No one
> seems to have complained yet.
>
> Jan
Broken since June. Xudong Hao (cc'ed) reported it then[1], and
Hidetoshi Seto (also cc'ed) attempted to get it patched [2,3].
Removing -pcidevice would be fine with me. For what it's worth, it's
not in upstream qemu.
[1] http://lists.nongnu.org/archive/html/qemu-devel/2010-06/msg02858.html
[2] http://lists.nongnu.org/archive/html/qemu-devel/2010-06/msg03073.html
[3] http://lists.nongnu.org/archive/html/qemu-devel/2010-06/msg02858.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: -pcidevice broken - fix or remove it?
2010-11-02 13:19 ` Markus Armbruster
@ 2010-11-02 14:31 ` Jan Kiszka
2010-11-02 14:35 ` Daniel P. Berrange
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2010-11-02 14:31 UTC (permalink / raw)
To: Markus Armbruster; +Cc: kvm, Hao, Xudong, Hidetoshi Seto, Daniel P. Berrange
Am 02.11.2010 14:19, Markus Armbruster wrote:
> Jan Kiszka <jan.kiszka@web.de> writes:
>
>> Hi,
>>
>> looks like the documented way to configure device assignment at qemu-kvm
>> level is broken in 0.13 and git head:
>>
>> # qemu-system-x86_64 -pcidevice host=0:1a.0
>> qemu-system-x86_64: Parameter 'id' expects an identifier
>> Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
>> pcidevice argument parse error; please check the help text for usage
>>
>> "-device pci-assign" works, but only if specify "iommu=0" (otherwise: No
>> IOMMU found. Unable to assign device "(null)").
>>
>> Fix that legacy qemu-kvm switch or remove it at this chance? No one
>> seems to have complained yet.
>>
>> Jan
>
> Broken since June. Xudong Hao (cc'ed) reported it then[1], and
> Hidetoshi Seto (also cc'ed) attempted to get it patched [2,3].
>
> Removing -pcidevice would be fine with me. For what it's worth, it's
> not in upstream qemu.
>
Patch queued.
While at it, I wondered if we should kill "pci_add ... host" as well.
But it looks like libvirt uses it - and should stumble over this
breakage (it does not specify a device name). I can fix it by removing
the silly auto-naming, or can libvirt live without it?
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: -pcidevice broken - fix or remove it?
2010-11-02 14:31 ` Jan Kiszka
@ 2010-11-02 14:35 ` Daniel P. Berrange
0 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrange @ 2010-11-02 14:35 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Markus Armbruster, kvm, Hao, Xudong, Hidetoshi Seto
On Tue, Nov 02, 2010 at 03:31:31PM +0100, Jan Kiszka wrote:
> Am 02.11.2010 14:19, Markus Armbruster wrote:
> > Jan Kiszka <jan.kiszka@web.de> writes:
> >
> >> Hi,
> >>
> >> looks like the documented way to configure device assignment at qemu-kvm
> >> level is broken in 0.13 and git head:
> >>
> >> # qemu-system-x86_64 -pcidevice host=0:1a.0
> >> qemu-system-x86_64: Parameter 'id' expects an identifier
> >> Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
> >> pcidevice argument parse error; please check the help text for usage
> >>
> >> "-device pci-assign" works, but only if specify "iommu=0" (otherwise: No
> >> IOMMU found. Unable to assign device "(null)").
> >>
> >> Fix that legacy qemu-kvm switch or remove it at this chance? No one
> >> seems to have complained yet.
> >>
> >> Jan
> >
> > Broken since June. Xudong Hao (cc'ed) reported it then[1], and
> > Hidetoshi Seto (also cc'ed) attempted to get it patched [2,3].
> >
> > Removing -pcidevice would be fine with me. For what it's worth, it's
> > not in upstream qemu.
> >
>
> Patch queued.
>
> While at it, I wondered if we should kill "pci_add ... host" as well.
> But it looks like libvirt uses it - and should stumble over this
> breakage (it does not specify a device name). I can fix it by removing
> the silly auto-naming, or can libvirt live without it?
As of libvirt >= 0.8.1 & QEMU >= 0.12.x we use switched to using -device
for everything. Older libvirt versions had rather broken checking for
PCI device topology, so I think it is fine to require libvirt >= 0.8.1
for latest QEMU releases if users want PCI dev assignment. Thus -pcidevice
and pci_add can both be killed from our POV.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-02 14:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-31 15:34 -pcidevice broken - fix or remove it? Jan Kiszka
2010-11-02 13:19 ` Markus Armbruster
2010-11-02 14:31 ` Jan Kiszka
2010-11-02 14:35 ` Daniel P. Berrange
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.